From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 83141941CF0 for ; Tue, 26 Mar 2024 15:52:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jQOPeiYUelHtkvTqHxvjUG9qTI9E1NWtScsklflLPWE=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711468337; v=1; b=BEXTwsWY9a5qLyqf+fgo/Yoleq+t104EXo6p4De7r9k6qXA+LkI8ochcNx0OQybuHOlPOM9f bYIGbMnRl69I7TLH+xHCIV5eY18MQDEr0/N2iHSmgkLl12YgvO8lI5wNz0qx0ul4sSIS/LUkUB+ 6TNlxRXmQPZj39y4isrV1kmgAGSVA6y4tddXgEOZxznfG2r+03JioQIKZkdFSLRZ7EZQ8QIOPZR z3Qu3fmC788NQkJBMgnYMztB3F+teGaSvIxMJRKGL1OrFJ1W0gZGxQ71t0i51hqBEAMWi+RycVY o/wwKrA8IE4fG6fSBPYWsrCQN94GkFaOsDNBgg3LczVPg== X-Received: by 127.0.0.2 with SMTP id FGmXYY7687511xE1Y1apNNH4; Tue, 26 Mar 2024 08:52:17 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mx.groups.io with SMTP id smtpd.web10.1716.1711432311760848307 for ; Mon, 25 Mar 2024 22:51:51 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11024"; a="6401253" X-IronPort-AV: E=Sophos;i="6.07,155,1708416000"; d="scan'208";a="6401253" X-Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2024 22:51:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,155,1708416000"; d="scan'208";a="20534138" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Mar 2024 22:51:52 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Mar 2024 22:51:50 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Mar 2024 22:51:50 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 25 Mar 2024 22:51:50 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 25 Mar 2024 22:51:50 -0700 X-Received: from BN9PR11MB5292.namprd11.prod.outlook.com (2603:10b6:408:119::12) by SJ0PR11MB5071.namprd11.prod.outlook.com (2603:10b6:a03:2d7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar 2024 05:51:42 +0000 X-Received: from BN9PR11MB5292.namprd11.prod.outlook.com ([fe80::2f4a:46b0:8a0d:1ba4]) by BN9PR11MB5292.namprd11.prod.outlook.com ([fe80::2f4a:46b0:8a0d:1ba4%5]) with mapi id 15.20.7409.031; Tue, 26 Mar 2024 05:51:42 +0000 From: "Pethaiyan, Madhan" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Liming Gao , "Liu, Zhiguang" , "Li, Yi1" , GuoX Xu Subject: Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details Thread-Topic: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details Thread-Index: AQHacX3Pfh6JTk/oyU+AqCv+Ja5bw7Ev2qCAgAcRpSCAErPAIA== Date: Tue, 26 Mar 2024 05:51:42 +0000 Message-ID: References: <20240308172556.2473-1-madhan.pethaiyan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5292:EE_|SJ0PR11MB5071:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: mM8mdQHcsHpqNIS0D6iJfAVrmyOl+JFNrs20yc6sTYtsrFNmiS06YQSovs6JOp/DjNjtjJ9iaYEJaPiVrr7vQX/UyXawbL6dRCbggh4b3ctyOHcKpcJlV2/jmSzfYeQWFxO1otgP698CocXvp/A8rPlgQAADKSWwEm1zlnUALD7+3fa8P8ytdlg5C9bZxdLmpLRJlqvXc+Wpk0cbBqMu+XquWo1zGc+DyH4nB1y/goY9t5/y14cPnlRY3yIW/IhHARZ4AEkBtUjipWdQZDLMNmpZTHPkSmSmSOtb7mh77lo4DVW+ChHxCn2BhE9YFVl6rikMyuaCUXs/ACIo/ZwN+km5Q+/aMxtU1Z4MdSB+6W6bcTglZWWzndGdX4ouuCdLr5g7KyjXbFryPOUbX2CbrIbQ2Bwc/b35Vk2qmEtc+Ezr4UncmmDUYGIHdkWHJ3cJdehJK4/yVmL/wN4jwQC0IYxNxeT/CkJ2cLB3JSE2hATwRYr1Fh1dcDhe/jmDARctNiZZcNswgGMFo25tzMq9m1B4rjQgNliptDqT8nL2u7swFwN3sytsbndDbXznfMx7l3YO88B1nM2HL+NWjEZrfXWzEGua768cfjJSTquvPv2LapSwVpA7ZUwg/z7igb+g x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NesZE077d7v4LYrBps6P1zqTTp6zXZzVWcvMoDGs8QuWZgCAHYhIluJ1rZnG?= =?us-ascii?Q?djvzgjeCMzkBEbWIgRtBk+osRf3c2/jpKxbr/Hc/tkohAZVOOCaCn3yLSFDz?= =?us-ascii?Q?PwUohgkPugNuxMaUSE3mY95slTbjZdAYg3910fKisyw32i8knfhmJShEF1xl?= =?us-ascii?Q?I4WJ8CZ5nSGyGbpYUAI73L+hJ6cSPI+6T18CRIKEowPER3f/VzIzzugNZvna?= =?us-ascii?Q?Eh/kDaAyUU4VoSCno/eKBSSi7JLzCEdBMirPyu6fm2Dm219pV6kXH0GFleHV?= =?us-ascii?Q?UfES/MM+GJ9CjMQBVzU3dGpqXyAQf6h0InLq7lWxgq4qYRn2qgyV6O+0bvS2?= =?us-ascii?Q?cvqUQIQnA046wt79OFEt1442hZOIm3qAJMSCZ8KkOydWvLlzsDza8LtDNpqe?= =?us-ascii?Q?rkLqz/xTpp/0Sa468pG1KfDeXK6nGXvpob/C37e0aVPW+aJTY6HER0+xd1e1?= =?us-ascii?Q?/Qii5TgNsDjkmdEbFLiDWVIOklUuosJd6hAXzFXErENd2m4p/zyvEK/Qmbu3?= =?us-ascii?Q?bCbqqV+yJS2uxP02G2OTB2Dz+ArmZy3XtePW7QbwpBNJwad5UrngZS3GiF4A?= =?us-ascii?Q?VpyO6UTfk3+Y3+lcFQvSjdbOlzGAl1ldhaPjZ60tx6jOhDyRkiLFg7NvbnpM?= =?us-ascii?Q?qwa9Mp0v+gx4cZS83M2pL5UHID/LIx2gHZ2rcrFySSciJE2YdhZZwd0NWAPR?= =?us-ascii?Q?IHxO6IzyVzFRYFoBWIWGF3RLN+Mub8Sbr90hNtaY4bflZvAthqtibtbc9G/T?= =?us-ascii?Q?jNJjPiMUzCd7WgTxXbyZTfi7QW45pWcjIvMXjT5CVnID9vRkt/AP4ckkt7St?= =?us-ascii?Q?Rr/sZHY6kpxpAAQnEDezL1SqubnRCi5wOmqjp51NTfhKWPWboeNqJZ5P6xUR?= =?us-ascii?Q?m8iBLW7xWnyvDfV7ao3U1UhhxyBPUY3TmrU3toZas+IehtZxGx3PxGP1QFN9?= =?us-ascii?Q?YIHzqU+KM7hLMwzo9SBxCmtQ3zIFduXM1B7Kvf/080pHtQaS13EQk77lHUiT?= =?us-ascii?Q?Aw6BQrQqnikHowMCrXi04hB8JWNIanJxPslmmYdwykowEv5J6uBAal7ch8Ep?= =?us-ascii?Q?WySPgtwO1YIQJa7lFqW9bkyKH++zzsZEJuysEc3E7KWP+Oky8aHVmoFFN31B?= =?us-ascii?Q?oOg3151zoDGPcOzqCf4V995F7tFFv4jcsnehSt+TOGPQM/e6QkICcdavxkaH?= =?us-ascii?Q?lO2rVXmq8zWXKCCMsa4WbrhRT+y+b73uFYnsBEMZu64DHMdghm8gmRsUdvy9?= =?us-ascii?Q?WG2iti0znb5OukIsXuYgl2BLnKtsvt1Eb8+VeA5Sa/Willis/WCC+OWGQnwd?= =?us-ascii?Q?xpYImu5g0zYOlJa+/sU0I89qjlaIah96aKtP0IJ3lArM1eAtOD9JSyiXtun3?= =?us-ascii?Q?cpUwk3eJT1Tqnnltp3AVdaSoJS9elUyzCA1sBQtiH2pEh3XZ09j273iPP313?= =?us-ascii?Q?1aZPpTcimuT9leAoJdt1QdvTWj1LdMwoOZWg8BJSjNOOSR6f5hLdGAQ0nBMS?= =?us-ascii?Q?H1oNEHx5Rj7s7lGNEFjtApchCdAvwM+EIkuon21twCEU6e0+gKXQHR4wfUgD?= =?us-ascii?Q?N2bsQ2tjW4vc0YZkWtcDfu1QwSuURLJXQmGr2uQSyUXvyz+ogbiJYpjeGmA6?= =?us-ascii?Q?uQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5292.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcbfa0b2-7813-40a3-9670-08dc4d58d035 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2024 05:51:42.4961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pPTvgZZ3rsyHwvCU7+2dd+OdTGav3hEea+DspLn65YXBdcgdtTJUrRzdImSN7ircezj48aMasGAXIii30sJmLOTZUH9Hg5iuR+rQ4Y9HRZY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5071 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 26 Mar 2024 08:52:15 -0700 Reply-To: devel@edk2.groups.io,madhan.pethaiyan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Zny8XXAMFhLxTOeFKUjK52bfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=BEXTwsWY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi All , Remider , request to review and provide feedback , Thanks, P. Madhan -----Original Message----- From: Pethaiyan, Madhan=20 Sent: Thursday, March 14, 2024 1:47 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Liming Gao ; Liu, Zhiguang ; Li, Yi1 ; GuoX Xu Subject: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo= description details Hi Mike , I had raised new code review addressing the coding standard errors and thos= e were not part of my change any way ..=20 Thanks, P. Madhan -----Original Message----- From: Kinney, Michael D Sent: Sunday, March 10, 2024 1:47 AM To: devel@edk2.groups.io; Pethaiyan, Madhan Cc: Liming Gao ; Liu, Zhiguang ; Li, Yi1 ; GuoX Xu ; Kinney, Mi= chael D Subject: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo= description details Hi Madhan, I created a PR with all 3 related patches to run through EDK II CI. https://github.com/tianocore/edk2/pull/5453 There are CI failures. Please resolve and send updated patches. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of=20 > Pethaiyan Madhan > Sent: Friday, March 8, 2024 3:17 PM > To: devel@edk2.groups.io > Cc: Pethaiyan, Madhan ; Kinney, Michael D=20 > ; Liming Gao ;=20 > Liu, Zhiguang ; Li, Yi1 ;=20 > GuoX Xu > Subject: [edk2-devel] [PATCH V1] MdePkg: Update GetImage ,=20 > GetImageInfo description details >=20 > 1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): > Add the following sentence at the end of the Image parameter=20 > description. "May be NULL with a zero ImageSize in order to determine=20 > the size of the buffer needed". >=20 > Modify the description of "EFI_INVALID_PARAMETER" return code as "The=20 > ImageSize is not too small and Image is NULL." >=20 > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo(): > Add the following sentence at the end of the ImageInfo parameter=20 > description."May be NULL with a zero ImageInfoSize in order to=20 > determine the size of the buffer needed". >=20 > Modify the description of "EFI_INVALID_PARAMETER" return code as "The=20 > ImageInfoSize is not too small and Image is NULL." and add new=20 > descriptions for "EFI_INVALID_PARAMETER" return code. >=20 > REF: UEFI spec v2.10 23.1.2 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4660 >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Yi Li > Cc: GuoX Xu > Signed-off-by: Pethaiyan Madhan > --- > MdePkg/Include/Protocol/FirmwareManagement.h | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h > b/MdePkg/Include/Protocol/FirmwareManagement.h > index e535bb697d..90b7d83c8f 100644 > --- a/MdePkg/Include/Protocol/FirmwareManagement.h > +++ b/MdePkg/Include/Protocol/FirmwareManagement.h > @@ -294,6 +294,8 @@ EFI_STATUS > to contain the image(s)=20 > information if the buffer was too small. > @param[in, out] ImageInfo A pointer to the buffer in which > firmware places the current image(s) > information. The information is=20 > an array of EFI_FIRMWARE_IMAGE_DESCRIPTORs. > + May be NULL with a zero > ImageInfoSize in order to determine the size of the > + buffer needed. > @param[out] DescriptorVersion A pointer to the location in > which firmware returns the version number > associated with the=20 > EFI_FIRMWARE_IMAGE_DESCRIPTOR. > @param[out] DescriptorCount A pointer to the location in > which firmware returns the number of > @@ -314,7 +316,12 @@ EFI_STATUS > @retval EFI_SUCCESS The device was successfully > updated with the new image. > @retval EFI_BUFFER_TOO_SMALL The ImageInfo buffer was too > small. The current buffer size > needed to hold the image(s)=20 > information is returned in ImageInfoSize. > - @retval EFI_INVALID_PARAMETER ImageInfoSize is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is not too small > and ImageInfo is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorVersion is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorCount is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorSize is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > PackageVersion is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > PackageVersionName is NULL. > @retval EFI_DEVICE_ERROR Valid information could not be > returned. Possible corrupted image. >=20 > **/ > @@ -341,6 +348,9 @@ EFI_STATUS > @param[in] ImageIndex A unique number identifying the > firmware image(s) within the device. > The number is between 1 and=20 > DescriptorCount. > @param[out] Image Points to the buffer where the > current image is copied to. > + May be NULL with a zero ImageSize in > order to determine the size of the > + buffer needed. > + > @param[in, out] ImageSize On entry, points to the size of the > buffer pointed to by Image, in bytes. > On return, points to the length of=20 > the image, in bytes. >=20 > @@ -348,7 +358,7 @@ EFI_STATUS > @retval EFI_BUFFER_TOO_SMALL The buffer specified by ImageSize is > too small to hold the > image. The current buffer size=20 > needed to hold the image is returned > in ImageSize. > - @retval EFI_INVALID_PARAMETER The Image was NULL. > + @retval EFI_INVALID_PARAMETER The ImageSize is not too small and > Image is NULL. > @retval EFI_NOT_FOUND The current image is not copied to > the buffer. > @retval EFI_UNSUPPORTED The operation is not supported. > @retval EFI_SECURITY_VIOLATION The operation could not be performed=20 > due to an authentication failure. > -- > 2.38.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117135): https://edk2.groups.io/g/devel/message/117135 Mute This Topic: https://groups.io/mt/104819885/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-