Re: [edk2-platforms][PATCH v4 2/2] KabylakeOpenBoardPkg/AspireVn7Dash572G/DxeBoardInitLib: Fix byte shift

["Chiu, Chasel" <chasel.chiu@intel.com>]

Pushed: https://github.com/tianocore/edk2-platforms/commit/057f23a2022c7efb9f99c5c523e09125cb66756b

Thanks,
Chasel


> -----Original Message-----
> From: Benjamin Doron <benjamin.doron00@gmail.com>
> Sent: Monday, September 6, 2021 10:56 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-platforms][PATCH v4 2/2]
> KabylakeOpenBoardPkg/AspireVn7Dash572G/DxeBoardInitLib: Fix byte shift
> 
> Since the time is sent to the EC byte-by-byte, perform shift by a byte multiple of
> bits. Also update some comments.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
> ---
> 
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLi
> b/DxeBoardInitLib.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit
> Lib/DxeBoardInitLib.c
> b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit
> Lib/DxeBoardInitLib.c
> index 906b2d265092..4bce51886e3a 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit
> Lib/DxeBoardInitLib.c
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar
> +++ dInitLib/DxeBoardInitLib.c
> @@ -24,7 +24,7 @@ EcSendTime (
>  {   EFI_STATUS  Status;   EFI_TIME    EfiTime;-  // TODO: Confirm this is really
> INTN and not UINTN+  // Time could be negative (before 2016)   INTN
> EcTime;   UINT8       EcTimeByte;   INTN        Index;@@ -36,7 +36,7 @@
> EcSendTime (
>      return;   } -  // Time since year of release?+  // Time since year of release.
> Note that "century" is ignored.   EcTime = ((EfiTime.Year << 26) +
> (EfiTime.Month << 22) + (EfiTime.Day << 17)          + (EfiTime.Hour << 12) +
> (EfiTime.Minute << 6) + (EfiTime.Second)          /* 16 years */@@ -45,7 +45,8
> @@ EcSendTime (
>    DEBUG ((DEBUG_INFO, "EC: reporting present time 0x%x\n", EcTime));
> SendEcCommand (0xE0);   for (Index = 0; Index < 4; Index++) {-    EcTimeByte =
> EcTime >> Index;+    // Shift bytes+    EcTimeByte = EcTime >> Index*8;     DEBUG
> ((DEBUG_INFO, "EC: Sending 0x%x (iteration %d)\n", EcTimeByte, Index));
> SendEcData (EcTimeByte);   }@@ -61,13 +62,14 @@ EcSendTime (
>   **/ VOID-EcInit (+EcRequestsTime (   VOID   ) {   UINT8           Dat; -  /* Vendor's
> UEFI modules "notify" this protocol in RtKbcDriver */+  /* This is executed as
> protocol notify in vendor's RtKbcDriver when *CommonService+   * protocol is
> installed. Effectively, this code could execute from the entrypoint */
> EcCmd90Read (0x79, &Dat);   if (Dat & BIT0) {     EcSendTime ();@@ -86,7 +88,7
> @@ BoardInitAfterPciEnumeration (
>    VOID   ) {-  EcInit ();+  EcRequestsTime ();   return EFI_SUCCESS; } --
> 2.31.1