From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.1348.1631319865116083401 for ; Fri, 10 Sep 2021 17:24:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ZGJ7EKet; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10103"; a="219342541" X-IronPort-AV: E=Sophos;i="5.85,284,1624345200"; d="scan'208";a="219342541" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2021 17:24:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,284,1624345200"; d="scan'208";a="697355706" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga005.fm.intel.com with ESMTP; 10 Sep 2021 17:24:22 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 10 Sep 2021 17:24:21 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 10 Sep 2021 17:24:21 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 10 Sep 2021 17:24:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aw4iuP9aLdmpggqyPjBn6WgQ+aOwscRPP54tt7m196B8J2MplJyH4oh3CE8xYJUD6tj0Xw2YQ5+FlFyrjDGg+47s1Fjp3NXnfLgFgWftJ4/sFXmkbazE6U0+omtkXchcb1Ii/h24c1yNG3hQNSdaPjfBjokU+6WokdLXmX/HjDmieEzzj3RN55JW/JV3dw9d1+tJ8HrMCst4aY6i5/Wl6Ry/hfu7O5bb7axQBMm7BnKtP8opJ1EUcJkfMSAKIJeSVxVAezKBqP23cyEh9n1fUtp9rQ2jTclzRmEIUQ8nF9rVzZfynYoceDk9rVFNv6oz4IkzowttsJwAg1DLDhT3SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LU6mpPjiTGXsPDutpBG7vimRXhEIxI7WHbeZ9oYmfUU=; b=f8szCvlY/yWHkETowNOmbsfZVa+GaPWku6KKQdiDy8A28qfvJX77l1uJg9uIqP7EfNFUXuuEwerx1FkvVdIo4q07F34YskDgVGH3ZWvSFExXFD2lgUcXbmItW/yXk6+lciEmWObaHfaKi2RHQ5Gj9l+VgpWJLXCwTGxsYoTPSX0+WjpxIG1GKs25eDFB+Ab7ebb2by01ll2nR7/vRfxcZg9F3JKJYz257rnyk8jjmeUvx5XfeKyiCS0pzGhB5Hykn/oltTj9XyIp6SjevNNiTkctS1oYAn9g29oJ/E/OODfpiH+YR3Ai/RLSzzCgnnU4gXIW07iDKMSsXjvf0iTgoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LU6mpPjiTGXsPDutpBG7vimRXhEIxI7WHbeZ9oYmfUU=; b=ZGJ7EKetDOefqk3bE+Pc0Wu0MHkQBzronbOSSW+XeOpN/RX1VzxciTgGQ3maGHijf8swZE+Aw+dCutaKSU1e6JP/11ybIiUldB4ZYLxkVH1+edE4pLgDwuM3PkSj6Zdo4F9YmoejmRK3QB2Oy54rD4EYc7YencdWd0tDBZoCQpU= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN7PR11MB2708.namprd11.prod.outlook.com (2603:10b6:406:a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Sat, 11 Sep 2021 00:24:15 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e%6]) with mapi id 15.20.4500.017; Sat, 11 Sep 2021 00:24:15 +0000 From: "Chiu, Chasel" To: Benjamin Doron , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][PATCH v4 2/2] KabylakeOpenBoardPkg/AspireVn7Dash572G/DxeBoardInitLib: Fix byte shift Thread-Topic: [edk2-platforms][PATCH v4 2/2] KabylakeOpenBoardPkg/AspireVn7Dash572G/DxeBoardInitLib: Fix byte shift Thread-Index: AQHXosrFEuZOyuXUy0G8m2OfSh/J66ueAQdQ Date: Sat, 11 Sep 2021 00:24:15 +0000 Message-ID: References: <20210906025530.279219-1-benjamin.doron00@gmail.com> <20210906025530.279219-2-benjamin.doron00@gmail.com> In-Reply-To: <20210906025530.279219-2-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6c425d67-7877-4252-ba2b-08d974ba7caa x-ms-traffictypediagnostic: BN7PR11MB2708: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PEa+iNyVopzAn1ERDF20vfRKsdB4969cext9zaPCkJ51o01DLeeoRYSXz91MfEXstJ6eo/5V8vzEr7vIGUGoWDDw+j8zvah+ZAmggjVlH73hJwSPTnXV95/o8KcdzN6D8dhF0wyNNw0O0AXhcLzvClnmB3UesAbbX1ykuQCMa0I1VL0Fuyx1THQOqUX6HX/mo5HhOspDK7fT/Y3ki+sM2vkwynF95q6yf8JV584Wcy8Vqr7PP3ao59CjnqSHyVof0WCfRXJa2ed0lkGqY0w7VC+3qzwLhUnWbIZfowLGaetLlF4MVJY1wpPM0dOrGo5nKWjzUH0s5CPSR1OdaQ0OCNX0MSdpKySnKhNjp6EU2tzHlKEBH4fpqquZ17JAEJ3B5Z2zZUpWrliJVnlB8jjjKO27Ys8VzXflM6LCLFyzdp8Q0nabuSRNA/+KeMbF6Tszuvq5hME/J87v6cCgjpZCdvBlTxcmLts/ajSUGdl7yzFHT39GEzhrZAmbTwmSxkb0cK6+Ueed9TVryhFtzOxCVmjvKU648IdJ5EBjyLjELWpXE1acTTJ53xzRF/rx8F+Xr+U5Yryi3xwdoDnkd9foxPg18rQDjo3yqLhF5q2Ei8B2tbsbsRvXmTork0D9zcVOMJ52u62xLG+Dad82TLuS0jztI1CC8NH4G1ojBQL9F6Z+YPFPjPpmgYEPtIOk3tGyYGAvJfL6JbXoly6FWHggEGwHC8ILcCICPKy9KRpxgYS9tykagQ7xQjbGHbLbIMal78+PAm/ZtTxC2/J7/UFvFC8LJq2mw5oaAIp1Q++Xzzo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(346002)(376002)(39860400002)(396003)(86362001)(7696005)(966005)(52536014)(83380400001)(107886003)(55016002)(38100700002)(33656002)(38070700005)(122000001)(9686003)(478600001)(71200400001)(4326008)(5660300002)(26005)(186003)(6506007)(53546011)(8676002)(8936002)(66476007)(66556008)(64756008)(66446008)(66946007)(316002)(110136005)(2906002)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zSopzjlkmNUwhJk/jyRe4PdtXV/aM7W59QsVFIW+j/GH6hTWz0G0G5lghQgW?= =?us-ascii?Q?cpt5JJVkwUQ/TjOYrB2OkONXE3jqwmfpycCl+xPskcir88/T++oSd0P1B0Ab?= =?us-ascii?Q?h9VWE1smw93uKBl0R+1rjx5YUcGyYJoe1IWykpk9D3i3pFyEnKPMFib1kniS?= =?us-ascii?Q?7Hhw3HcwpsstBSyEeHapWxAImP+uEvtPWBBRbipbX7T9RWxL/+g0IvYd9pRb?= =?us-ascii?Q?HG2O5maBcL5wuYkVXx3orC8sRI98UV6Y79YEAP+f26g861399Ab8SvmBT7+Y?= =?us-ascii?Q?KwEHyDkKMUSvrrN4fsLMmLHHD/0QvoquvJvgtPfUFlfQF5017BWhwVLg2xp6?= =?us-ascii?Q?7upMGOFJEgYSgPYPawESX58wZ4THx3SUUW5+BcEUlqJFJxEAAx0XYQxJ/gvL?= =?us-ascii?Q?37T9RlHhiGUUgwUP0tHl1KtBDlyQs7tBwumVXUOD8V7QPJfki7yHRxVLHuWH?= =?us-ascii?Q?I8inL2JbNjHrWqAXCv32bosG4PRiVRfwIa5wM4hEd8AxjAlm8dg7TsgNpV9d?= =?us-ascii?Q?3/Hp8kXwjrt8B1qC9484s6fWXJjNI7+PSwRSZq3kXieNfvEZDvahfR7Vymxn?= =?us-ascii?Q?bYKT8ZE021FiOmqTKHOkk3Kdva6emH+4TRz5PnUQlkt2o2sb+mxpH6kPpQ8O?= =?us-ascii?Q?dFp2Tsobna9A/BR3xkEBZb25NSuK0aAagVSnE0HrqtyHpiQadLO95m8K0QjS?= =?us-ascii?Q?ks/xVVE1my2i4cO+olrK8QiT2gHOjcgmGHW9HNXQZpF4im8KmcnMNJ8Sy06W?= =?us-ascii?Q?vEr+tZWn++2ypt68oCukVJmR73D/mhMBmYzuSnfSeCLopARb62c0fXhIiKcm?= =?us-ascii?Q?/+btgvsvfVy0CC+gReLxOYN6o1Ct6AaEk35UrvAzXQsHd2u8ItbszR1h7a7p?= =?us-ascii?Q?E0zTQAWzKCQUt4peWh3Pz1iUITr04bYq3sHtKL21PpVWsTNPkBIevLIVGGb9?= =?us-ascii?Q?UJmRF2qKMYc9lBv3p6XRSH6wP6f/lxM3t/gQlcTAL8aGYkgN6wfDwNiXmTsw?= =?us-ascii?Q?qoGp/cwx3jHLljZDVASYCnI34hAe4PvRXTI/PQBryLvmZJIQ1j4fH8OKn3eQ?= =?us-ascii?Q?f46VVM0q+DDQxCgAL5/MpX2wYUKKKr2yFqNvulqaK327wFFh7Kw6yRP+PBvH?= =?us-ascii?Q?rLI+tjw0TWK6u1+6MFnwDpNO3zytfgIY76YFqKSO/11Ids75jRGZUXnrgZ/F?= =?us-ascii?Q?5XuNpBTpCKRSWWLzM7M7YB2bcJxYZuEgrrnhUXvdaviCmLmizxOM7x6b9tNH?= =?us-ascii?Q?zhuOBr29GTRn/LtxQB9ysC134zSAJWGhidboo37cWt84vuMbvR29Yw0vRi6F?= =?us-ascii?Q?qTGvV7j4BdWf9ymV52GMEyr6?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c425d67-7877-4252-ba2b-08d974ba7caa X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2021 00:24:15.3191 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HPXG/oWvp9CkB2aYKu3mI9LCpnd9gDkGSQqHgc530N9D9XHxyAtshe4IT3lJdfDxq6Rhktl0ZvyfTtHStrML+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2708 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/057f23a2022c7efb= 9f99c5c523e09125cb66756b Thanks, Chasel > -----Original Message----- > From: Benjamin Doron > Sent: Monday, September 6, 2021 10:56 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 2/2] > KabylakeOpenBoardPkg/AspireVn7Dash572G/DxeBoardInitLib: Fix byte shift >=20 > Since the time is sent to the EC byte-by-byte, perform shift by a byte mu= ltiple of > bits. Also update some comments. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Benjamin Doron > --- >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLi > b/DxeBoardInitLib.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/DxeBoardInitLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/DxeBoardInitLib.c > index 906b2d265092..4bce51886e3a 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/DxeBoardInitLib.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar > +++ dInitLib/DxeBoardInitLib.c > @@ -24,7 +24,7 @@ EcSendTime ( > { EFI_STATUS Status; EFI_TIME EfiTime;- // TODO: Confirm this i= s really > INTN and not UINTN+ // Time could be negative (before 2016) INTN > EcTime; UINT8 EcTimeByte; INTN Index;@@ -36,7 +36,7 @@ > EcSendTime ( > return; } - // Time since year of release?+ // Time since year o= f release. > Note that "century" is ignored. EcTime =3D ((EfiTime.Year << 26) + > (EfiTime.Month << 22) + (EfiTime.Day << 17) + (EfiTime.Hour << 1= 2) + > (EfiTime.Minute << 6) + (EfiTime.Second) /* 16 years */@@ -45,7 = +45,8 > @@ EcSendTime ( > DEBUG ((DEBUG_INFO, "EC: reporting present time 0x%x\n", EcTime)); > SendEcCommand (0xE0); for (Index =3D 0; Index < 4; Index++) {- EcTim= eByte =3D > EcTime >> Index;+ // Shift bytes+ EcTimeByte =3D EcTime >> Index*8;= DEBUG > ((DEBUG_INFO, "EC: Sending 0x%x (iteration %d)\n", EcTimeByte, Index)); > SendEcData (EcTimeByte); }@@ -61,13 +62,14 @@ EcSendTime ( > **/ VOID-EcInit (+EcRequestsTime ( VOID ) { UINT8 Dat; = - /* Vendor's > UEFI modules "notify" this protocol in RtKbcDriver */+ /* This is execut= ed as > protocol notify in vendor's RtKbcDriver when *CommonService+ * protocol= is > installed. Effectively, this code could execute from the entrypoint */ > EcCmd90Read (0x79, &Dat); if (Dat & BIT0) { EcSendTime ();@@ -86,7 = +88,7 > @@ BoardInitAfterPciEnumeration ( > VOID ) {- EcInit ();+ EcRequestsTime (); return EFI_SUCCESS; } -= - > 2.31.1