From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.10021.1683698634173192807 for ; Tue, 09 May 2023 23:03:54 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=lNxp4G3C; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683698634; x=1715234634; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Te3u2vmpQqfbYEJ2IFE3K7f3bU03IDjCXMTLHGZMy3s=; b=lNxp4G3CUAhTtLQanx8H8PsbVCBReN1xKq9pFVhVK4tdVlg6VyEdy8Wz wAvAMxA3Uuu4+BWW6XUXTwazb2EK+gOVhT1P7ct5T9Nd/viGDHuj1uHKM vapBIuyJ5tpqfop67PuVQns32ookhCRvuq9uyKFlvSfViaPTqz6XsPyOw j7zf/UWX1cS0n2hUlvgwiDbezxQZj/RKACX4uWXe7m9vAlpN03HwpoFg2 h0UVKwaFKakxou/B08n7d8s3fnAv8z50mEH3Ic8w5Tv97LN5D/E/vSFuv ffHohW0g77PV684RLw/2bXPSikjM4LbuIbg/bhckSdUip8e5jmvHkfgW0 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="347600378" X-IronPort-AV: E=Sophos;i="5.99,263,1677571200"; d="scan'208";a="347600378" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2023 23:03:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="693275130" X-IronPort-AV: E=Sophos;i="5.99,263,1677571200"; d="scan'208";a="693275130" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 09 May 2023 23:03:53 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 9 May 2023 23:03:53 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 9 May 2023 23:03:53 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 9 May 2023 23:03:53 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 9 May 2023 23:03:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H971cTyN0hMldNUtIKPzSMxIm0+R4V9j2xQ4zWiEqzZlv9i7Ry8ReYE4xCRaj1NNBT43xtYg8+AypAsE0az/AeyNuEdl5Fe8GYqcbejppiI2Pj7QxEzwNIz4UPB1g4mx94GMVx5TjyIr3fG5Y7gZxM59eCEMmDtJsjiAa2oYXlNSJS5qJ3+yvcjl58UNGajVZM2XxcPndP2Y4uwhW/gvX7ykHQr74gMATMwth9ZmYQADrq7AcFm47FVN6RMpPJ8h1yEnyLuLRI0tBnZ+q0bbVg3lz6zWtsMOAgt4JLK3RlmpCcohK3jiAwwECI7TIoYNKTpOIjCAn+RKj1H7tTz4xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qZmeD4fSWtasxu2r+vHMKMYwmqOkcj9vVjYi9wJtlSc=; b=UxLI8w5wH+PNlhWnrvlwHkrhnFYaa+M8BLndpodAyUVT8H+2+ZejGa3hIJmo96osb1+62FILsYaUsOoqXoWWORZx1Mqi/KbkVeb+C/2xO50l8StZMy4bGa83Fw6jbhJ8OySiD7xVQsr6pPsORzvYSyD8L3t5hGTkAu+Z1qjMPBDzA8KBL+0oA0WEMrEgHzx21LRseld7DwJsmJI4I2uLBTIkAq4uvTSSThWTIxq+n3H7BPwCXZ6XfxxQXdMwdQ5bDLZGHKQCoQKJjB18hF3ddBWzuxZDtDU4pd3FqqosSSrzY4Af1Qce2uNEKD3iUDRTBZMOWZ7BZmQ0YDH6rQWlcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DS0PR11MB7631.namprd11.prod.outlook.com (2603:10b6:8:14e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Wed, 10 May 2023 06:03:51 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a%7]) with mapi id 15.20.6363.033; Wed, 10 May 2023 06:03:51 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Chiu, Chasel" , "mikuback@linux.microsoft.com" CC: "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" , "Gudla, Raghava" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 1/1] MinPlatformPkg: Add FspNvsBuffer compression option Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v3 1/1] MinPlatformPkg: Add FspNvsBuffer compression option Thread-Index: AQHZgu6HJat5OZcyakayygd084MM8q9S2FHAgAAo0wA= Date: Wed, 10 May 2023 06:03:50 +0000 Message-ID: References: <20230510032052.1225-1-mikuback@linux.microsoft.com> <175DAA7A0E18189B.14362@groups.io> In-Reply-To: <175DAA7A0E18189B.14362@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DS0PR11MB7631:EE_ x-ms-office365-filtering-correlation-id: 958ec6c5-48be-4e80-6168-08db511c53ab x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jKP5YGktIo/Z3ty8BWez3M6VTRablRtceoBzFuMl8ayKSxJkAeoCrdCXIIuB31yZW48epXO5ojrg2X8iBNfVXZDEnmkJxWqWqAVLvRuhvUk1h1pH9PuU74IdLYnjWSH8ak/KtSBr14cqFP3tf65PsMG+AezsRRWAGiA/JD3KTtokCJ7DGKjUrW4bpLcvkqK3zlzAwB2RIndMr5AwbDqb0pa+YjXr0qw3gxlGuOr3whMf0EBwq/OQXldAM84517LcB/c7u0ENZYqy2wEhGLW7lH3QkaniDC09nlLfIzIcbChWamQsLyT32kiURebMjTuuMu44SXQY0fj4hQT+7KUWlUi65UEceppfZJWPX5TYn7P5Lah2tqUrEo4GlCOA2QEggvTWCe78tIG742BzZphRBYuUE2MHiXHza4Rx2xGFUuZ8q/ZcG6QvAFtUewOuJ2+R3nc/aDc6CzxJoQgVeqhhHN7LAiYhZEZtX4BzUuBUV3JLIDVPM8aAA0omG4NdfACLERIX2Zu6rPEdxxaqaQGxb83pyY9urotpwgep593LNdrWKmloF35mopavRMOjwCet48MWa71K63tKpn0nHXrjpe713PoKcCvpn8eDiZov/shFd5tZWZZ47CxvnVArl+2TtE0RK7UzAZLlgERrOwd3yg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(396003)(346002)(39860400002)(376002)(451199021)(38070700005)(5660300002)(4326008)(26005)(52536014)(316002)(38100700002)(41300700001)(82960400001)(107886003)(64756008)(86362001)(66446008)(66556008)(71200400001)(9686003)(122000001)(53546011)(110136005)(66476007)(66946007)(54906003)(6506007)(2906002)(45080400002)(8936002)(33656002)(8676002)(19627235002)(76116006)(66899021)(186003)(7696005)(478600001)(83380400001)(966005)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?218nthn1I1i/4FRuOdwvdak04u1s3d+L9rNVhFliJ6PQwIe44fnI3Ng6ajlJ?= =?us-ascii?Q?ENW5nkjE0MtILfR1hurgTxrnndcdhcqHCKua4sgGbTfyMvrpgVbdkwYLRaix?= =?us-ascii?Q?P0O7/XbvbxX/L/VBr0maX9EBMuOEWILgrf8khi/mIzJ0GPoRdoQPi7TLk4ns?= =?us-ascii?Q?8L5X+Hf6USRgt1nHlhpvI4MoAb9oxf11+w/ZaFHI0bWjlnrdQGQPDN3XKnJV?= =?us-ascii?Q?zlWpe/7HOuWeA/To8ZahtMuINVvnserm9XEpQQUjSBoQa79yCoRKJoEu9M9i?= =?us-ascii?Q?694A695B1I4tgZyyo3poI75Tf0T40lE4G8Cqsso+Wz0gDzsAy5DnDjuFkpAV?= =?us-ascii?Q?v3WVE8s8ezjLWuIrcqYzblgi/JiNkZLmQ6Dm7tos1YdVKbVp/IUR/w3oYOOB?= =?us-ascii?Q?mPU+Y1NZB4YYcy/5fqnzlfDomUf4ysVohySYlGifDH8Hy+si8QN6D9jJfZjt?= =?us-ascii?Q?Rzn7L9av30IkVi6viEZPbrz1Bz+CfFoJ0uVQEBkf5AADHtWsftFpeM7qRUgd?= =?us-ascii?Q?FcHpLzCYcnc9f9Lmnqo+IkPNlekmsJ1FcPuzW4kF0pziO+TnEjJgH3tsuFHJ?= =?us-ascii?Q?eIwMrClzx8kGiivMG+vrZiCrVKfR6Hdc9kfX3dNR2ij3HZLEzicaYfjZ7m92?= =?us-ascii?Q?bmXSncM2zwyhwGF9488fkjGmvI7Z5wSDjKZaYjw2AkbjlSJELhsiz/yQE5Yj?= =?us-ascii?Q?liXm8mj1TgLppynRtT8QzkSaP3pOnT/IicSotg/Ppxj43qC1LRoOtaL+x7qV?= =?us-ascii?Q?1K3DV3mk+/OaT0gPCWMU+dR8pek9WM4UC9/wgPyW/YQm2Uh9vmKA8wP0CqPe?= =?us-ascii?Q?0ehSTbX8MxoNRmfM1pmQQ7mWWd382NXHvu0HZCuji3ZgWlWvIeDq1ZuF1FRF?= =?us-ascii?Q?OL/ioTndKiVCioiq0fNuzH0cbwBn2IY7LMbg6yaVmz9/p3OmSqA5pDzNXei8?= =?us-ascii?Q?k6/H7JeyKcogs3IqWtb7IOxEbh6URkGsD8OTHLWYaJFnyNQkMpG+yBE9MwSV?= =?us-ascii?Q?EQih8+m6DLw9g2HFauJRsBjYd2kpLHgGv5eJg4ON9CjayWkR/aFCUQQ8FcUA?= =?us-ascii?Q?CylWDd+eavoy9mc0Q1+6XWpYLT07izST0z0FyCFOckVMtQ9hBBePntzuaGd6?= =?us-ascii?Q?/mmXvuJB7mrpgMq4W+nYERHQDghyCXo9wLq4lZxzghgjjxN5T/JqX89BWsT/?= =?us-ascii?Q?1g7quOYk/IM6vfvP4MMYa9cqaGWOGdQZB1IguCHGu5SwZUx1IR2K2Ikz2BFi?= =?us-ascii?Q?oy9AzUQ/HHmPexfN8LrTlDQp/ojX5vf8xiQCug7DKgqnSrOOErHz4C/g/aS2?= =?us-ascii?Q?Rb7XUJQTQXysWd1xCwoDTq29y4s/JPHfgc7RVwOR/i6duupOCzv5b6BnmIY9?= =?us-ascii?Q?sKgzqMrwDYtyUCFs/h9ML35nhExLt5kHg3EVQ4x+DN7mU/qs9UuioV/enZaK?= =?us-ascii?Q?39X5TrGjte60tU5Um5Z+ZtHUKFTsSUJQMkA1qFd04ChURNnrXIUQoTlmiAjI?= =?us-ascii?Q?IE6ZAlYxko6BSc4Oy89r/+2bcxpwiiHByefFTV8eEuL4HF48GCZgAD2j3Q/i?= =?us-ascii?Q?ctsIvzSs/mg9GlL8pqcTXAHPxC9Z2tKk88/ZfyAu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 958ec6c5-48be-4e80-6168-08db511c53ab X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2023 06:03:50.7276 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: klJ7njGl/jvciA0pbs2SP7zjPuDDbI9EnqJ7oe49oDk1QmKBWxyyvNJlVnW9rFsaXFRxIX1a1l/f+i4/eiJAaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7631 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Just found one minor issue but I think it can be fixed during merging. We also need to add below libraryClass in MinPlatform.dsc: CompressLib|MinPlatformPkg/Library/CompressLib/CompressLib.inf Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, Chas= el > Sent: Tuesday, May 9, 2023 8:28 PM > To: devel@edk2.groups.io; mikuback@linux.microsoft.com > Cc: Desimone, Nathaniel L ; Oram, Isaac W > ; Gao, Liming ; Dong, > Eric ; Gudla, Raghava > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 1/1] MinPlatformPkg: = Add > FspNvsBuffer compression option >=20 >=20 > Reviewed-by: Chasel Chiu >=20 > Thanks, > Chasel >=20 >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Michael > > Kubacki > > Sent: Tuesday, May 9, 2023 8:21 PM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Oram, Isaac W > > ; Gao, Liming ; > > Dong, Eric ; Gudla, Raghava > > > > Subject: [edk2-devel] [edk2-platforms][PATCH v3 1/1] MinPlatformPkg: > > Add FspNvsBuffer compression option > > > > From: Michael Kubacki > > > > Adds a PCD called "PcdEnableCompressedFspNvsBuffer" that allows the > > "FspNvsBuffer" UEFI variable data to be saved as compressed data. > > > > Especially due to the nature of the data saved in this variable, it com= presses > well. > > For example, it has been found to reduce ~63KB of data to ~13KB. Boot > > time impact has been found to be negligible. > > > > The default value is FALSE to keep default behavior consistent. > > > > Decompression can be performed on the variable data using the standard > > UefiDecompressLib. > > > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Isaac Oram > > Cc: Liming Gao > > Cc: Eric Dong > > Cc: Raghava Gudla > > Signed-off-by: Michael Kubacki > > --- > > > > Notes: > > v3: > > - Rebase onto 7ac91ec277db > > - Add CompressLib instance to CoreCommonLib.dsc > > v2: Rebase onto 9769bf28d1fc > > > > > > > Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemoryC > > onfig.c | 62 ++++++++++++++++---- > > > > > Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemoryC > > onfig.inf | 4 ++ > > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc = | > > 1 + > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec = | 6 ++ > > 4 files changed, 60 insertions(+), 13 deletions(-) > > > > diff --git > > > a/Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemor > > yConfig.c > > > b/Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemor > > yConfig.c > > index 0215e8eeddfb..95b8cef8b32b 100644 > > --- > > > a/Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemor > > yConfig.c > > +++ > > > b/Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemo > > +++ ryConfig.c > > @@ -3,6 +3,7 @@ > > exists, and saves the data to nvRAM. > > > > Copyright (c) 2017 - 2022, Intel Corporation. All rights > > reserved.
> > +Copyright (c) Microsoft Corporation.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -10,6 +11,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include #include #include > > +#include > > #include > > #include > > #include > > @@ -19,6 +21,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include #include > > #include > > > > +#include > > #include #include > > > > > > @@ -38,20 +41,26 @@ SaveMemoryConfigEntryPoint ( > > IN EFI_SYSTEM_TABLE *SystemTable > > ) > > { > > - EFI_STATUS Status; > > - EFI_HOB_GUID_TYPE *GuidHob; > > - VOID *HobData; > > - VOID *VariableData; > > - UINTN DataSize; > > - UINTN BufferSize; > > - BOOLEAN DataIsIdentical; > > + EFI_STATUS Status; > > + EFI_HOB_GUID_TYPE *GuidHob; > > + VOID *HobData; > > + VOID *VariableData; > > + UINTN DataSize; > > + UINTN BufferSize; > > + BOOLEAN DataIsIdentical; > > + VOID *CompressedData; > > + UINT64 CompressedSize; > > + UINTN CompressedAllocationPages; > > > > - DataSize =3D 0; > > - BufferSize =3D 0; > > - VariableData =3D NULL; > > - GuidHob =3D NULL; > > - HobData =3D NULL; > > - DataIsIdentical =3D FALSE; > > + DataSize =3D 0; > > + BufferSize =3D 0; > > + VariableData =3D NULL; > > + GuidHob =3D NULL; > > + HobData =3D NULL; > > + DataIsIdentical =3D FALSE; > > + CompressedData =3D NULL; > > + CompressedSize =3D 0; > > + CompressedAllocationPages =3D 0; > > > > // > > // Search for the Memory Configuration GUID HOB. If it is not > > present, then @@ -73,6 +82,29 @@ SaveMemoryConfigEntryPoint ( > > } > > } > > > > + if (PcdGetBool (PcdEnableCompressedFspNvsBuffer)) { > > + if (DataSize > 0) { > > + CompressedAllocationPages =3D EFI_SIZE_TO_PAGES (DataSize); > > + CompressedData =3D AllocatePages (CompressedAllocatio= nPages); > > + if (CompressedData =3D=3D NULL) { > > + DEBUG ((DEBUG_ERROR, "[%a] - Failed to allocate compressed > > + data > > buffer.\n", __FUNCTION__)); > > + ASSERT_EFI_ERROR (EFI_OUT_OF_RESOURCES); > > + return EFI_OUT_OF_RESOURCES; > > + } > > + > > + CompressedSize =3D EFI_PAGES_TO_SIZE (CompressedAllocationPages)= ; > > + Status =3D Compress (HobData, DataSize, CompressedData, > > &CompressedSize); > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "[%a] - failed to compress data. Status > > + =3D %r\n", > > __FUNCTION__, Status)); > > + ASSERT_EFI_ERROR (Status); > > + return Status; > > + } > > + } > > + > > + HobData =3D CompressedData; > > + DataSize =3D (UINTN)CompressedSize; } > > + > > if (HobData !=3D NULL) { > > DEBUG ((DEBUG_INFO, "FspNvsHob.NvsDataLength:%d\n", DataSize)); > > DEBUG ((DEBUG_INFO, "FspNvsHob.NvsDataPtr : 0x%x\n", HobData)); > > @@ -136,6 +168,10 @@ SaveMemoryConfigEntryPoint ( > > DEBUG((DEBUG_ERROR, "Memory S3 Data HOB was not found\n")); > > } > > > > + if (CompressedData !=3D NULL) { > > + FreePages (CompressedData, CompressedAllocationPages); } > > + > > // > > // This driver does not produce any protocol services, so always unl= oad it. > > // > > diff --git > > > a/Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemor > > yConfig.inf > > > b/Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemor > > yConfig.inf > > index 61e85a658693..0f12deb131ca 100644 > > --- > > > a/Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemor > > yConfig.inf > > +++ > > > b/Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemo > > +++ ryConfig.inf > > @@ -26,6 +26,7 @@ [LibraryClasses] > > LargeVariableReadLib > > LargeVariableWriteLib > > BaseLib > > + CompressLib > > > > [Packages] > > MdePkg/MdePkg.dec > > @@ -45,6 +46,9 @@ [Guids] > > gFspNonVolatileStorageHob2Guid ## CONSUMES > > gFspNvsBufferVariableGuid ## PRODUCES > > > > +[Pcd] > > + gMinPlatformPkgTokenSpaceGuid.PcdEnableCompressedFspNvsBuffer > > + > > [Depex] > > gEfiVariableArchProtocolGuid AND > > gEfiVariableWriteArchProtocolGuid > > \ No newline at end of file > > diff --git > > a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > index 5ce21cf31e17..dfe7d836d32a 100644 > > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > @@ -147,6 +147,7 @@ [LibraryClasses.common] > > > > > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLi > > b.inf > > > > LargeVariableReadLib|MinPlatformPkg/Library/BaseLargeVariableLib/BaseL > > LargeVariableReadLib|arg > > eVariableReadLib.inf > > > > LargeVariableWriteLib|MinPlatformPkg/Library/BaseLargeVariableLib/Base > > LargeVariableWriteLib|Larg > > eVariableWriteLib.inf > > + CompressLib|MinPlatformPkg/Library/CompressLib/CompressLib.inf > > > > # > > # CryptLib > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > index 784abb828e76..45c75f8ec2c9 100644 > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > @@ -311,6 +311,12 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, > > PcdsDynamic, PcdsDynamicEx] > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPlatformMemoryCheckLevel|0|UINT32|0 > > x30000009 > > > > + ## Controls whether the FSP NVS buffer is saved as compressed data. > > + # Data compression can significantly reduce variable storage usage > > + for FSP > > NVS buffer data. > > + # Platforms that choose to compress the data will need to > > + decompress the variable data upon # extraction. > > + > > + > > > gMinPlatformPkgTokenSpaceGuid.PcdEnableCompressedFspNvsBuffer|FALSE|B > > O > > + OLEAN|0x30000010 > > + > > ## This PCD is to control which device is the potential trusted > > console input device.

> > # For example:
> > # USB Short Form: UsbHID(0xFFFF,0xFFFF,0x1,0x1)
> > -- > > 2.40.1.windows.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#104478): > > https://edk2.groups.io/g/devel/message/104478 > > Mute This Topic: https://groups.io/mt/98799191/1777047 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [chasel.chiu@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D > > >=20 >=20 >=20 >=20 >=20