From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web08.3701.1662521846027021418 for ; Tue, 06 Sep 2022 20:37:26 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=fUgrAxIU; spf=permerror, err=too many SPF records (domain: intel.com, ip: 134.134.136.100, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662521846; x=1694057846; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xSTm67NyPUZ1Q6mK5j7Yabf7X57K9hI2HjIliDdNLkM=; b=fUgrAxIUbDrQT1HfWEDg9vUN7iGqOWkWMx0rqjfo8tR8qDB7ty9kxiAE lOnPOstUVuZ3moW5ISEoCax8e8JCO8v6iWtiGqszgdUAVWiAuvgKsYxSG /pErCdkRSqE8aK2aLhIZfNxDxO83En91iprjepG8eWDr1TV2uNS3R2LXb qeTeDJNCbPEBM8p4C5OxbhStw3qfn7C9cHovptIVwu6KB4rSCUBsQnkSu E3SXfZwv679mfQmacSkYvnkbE3Iq9y7Xnk5LeLarLgfGmRHBBfcq9sMoL QGYK3sv+RqfrAjYzi4P2btJUKmoAXU2Q2avJqIY/YV4lkGRwBPTiQsrZB A==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="360716037" X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="360716037" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 20:37:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="565347292" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 06 Sep 2022 20:37:18 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Sep 2022 20:37:18 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Sep 2022 20:37:17 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 6 Sep 2022 20:37:17 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 6 Sep 2022 20:37:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lK4SlGnoe2K8uEelKJ3qiM0YLVlRiHY/wU4IAt+cMPe/d9WJqtX4QgKENAzuIOY6Tti/qkjdrMCsaZQV444r88c6ARPHtAjDIPUwN+xRqPP58a9tbYVtqZ+Wqmt1zAOql6sGyAPJVN21+1yQmfoHLYuKjNl37oIN21e3NoGvEc1ZzAZnLpEtVQCKkk6W2mjM6l2wgBgjezz7DVacnFM6q3ZJhMYu5O84pos+kbfjPmqJhUi7+BOWnI767zmlyrGZrY/S8prAra5YVfTA7YZgVRhvKp7V3JcItI79RrjSKDCCsTiZPvQ/OxXnoNiRl4eEkb48PLwdYaeDsnIl2JLzMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lXMoEGTbl4O44zbdbQHw5htaJAi4JVidxM9B9ksDmx0=; b=eN3dyVixCvZhqyIfoSWIz3y1CX8D7ppFjLvn1jyPrkm2JwANdAtnL3eu5r9eA58iC8uJHM1u+yDgX6UCvlEdKYJPQ6QBuR8BFFbiZEnLBicPHHzxsEoysZYU9uPqQzgW1icuhhUr27zYWhnizFaiCFBk+RHPEmZwRGkDIicIEZiHoxNEMfJkOPGh4M4G4oPvbYAyHIWiZ/6bnk35uhDiYv/ZFHbFRyy10ioXt9UaOhDERvLsCWx+uHLaqRQiGQJH4XGbZodyL3pTPzvVkt0HL0GxFYZmvYG28BEL/t7MFG7AtY2syJNpCAYf9WTO/Cj2EpzXiAdgiztEvS0aJcRrjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by MWHPR11MB1584.namprd11.prod.outlook.com (2603:10b6:301:e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 03:36:57 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::613a:668:ad30:2cb6]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::613a:668:ad30:2cb6%3]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 03:36:57 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors Thread-Topic: [edk2-devel] [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors Thread-Index: AQHYwmiwzFdatPYmBE64GKzgVodMd63TUUkg Date: Wed, 7 Sep 2022 03:36:57 +0000 Message-ID: References: <20220907031914.397-1-mikuback@linux.microsoft.com> <20220907031914.397-2-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-2-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2c687cc-661d-45a1-685d-08da90823731 x-ms-traffictypediagnostic: MWHPR11MB1584:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kJ/Ipyh4FuYPRBi7fpX5a/6siIrkgtDVaba6/0b80rhnRzJAwkK/UvzQ4vAEZi79U0FtHJM70hM3ZhieqhRMuUPIgDslSv/Pm1gJaBXiPyrkCoaiRZUsl0WP/VZC/y/HitKPcIemcDqwDSJKyIA6ONsg4rt8wc/nSGTgvhxY5orpen+PyeUv3mt5XDYI7R8X1eemSN1O4xvo9/XMy4dkZZhJhqS18r4PinwrUgGRL/hzZCNie8+ar2KcXBZunQpeoUOPucTTDagP+GDCocG0eet0HWmy/45KZAkbNqVI+lHHSs3dWDjHCZy5/aRAFYipNeBg2gxHj4Zw3xS6xafWFeFqddoZw9tCi4aolf8PkwnazTaZ9KswK28nn8g2jx8MPLCqRyjp5Ns5ecx69WFW+ztknxf1tfibh1FAVHFD2lgCi8tgjHrrGLcb2owpO2Ae9n2FBeg7NT32W/J+0QKQxxgIZNM+R6yMqs59dvrXTNtY/v3zMFeWNnt91DXXXoZ4L4iSx3WSe9j50Dps+iEQthubMRnQNB9AJAGSiOomr2riHbfqJBbeQ+I/7wnYyH3ZxBqTAA+dr/LSFAdtVg8Ew1nJ4/VrAYXD5wjQiV0IgFS0tXvTJhydnVGI9cvjFZrJlVaZR4OAEeTdz1LyL2SAY2zS3pOKn3KqAzNaSpC6kMprQr27jfxwlF7wyQY7VAn8JSdSgmn5ZVMxPCpfv2NdDPNS05qiBA0mPbYqEBAj+HAXa+e1ChHXacqEL75oCtadFDFgpLzCGvLyCpPJcdqhTLavc0lzSD06rNXZK9ldtIQVU+pxgLTnkS0sx4ZiPwbxwVN3bQP1e52Abm9INIM51g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(39860400002)(346002)(366004)(136003)(38100700002)(122000001)(186003)(54906003)(316002)(71200400001)(110136005)(19627235002)(55016003)(8676002)(66946007)(76116006)(66556008)(41300700001)(83380400001)(52536014)(64756008)(66446008)(9686003)(26005)(38070700005)(107886003)(4326008)(2906002)(86362001)(66476007)(53546011)(5660300002)(966005)(7696005)(478600001)(33656002)(8936002)(82960400001)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?il7Vovxbc4b/9z+aI1YT+HkMOK89Lq3Bqm9BojLo2FM/DvZTVMIscVaOZEBf?= =?us-ascii?Q?1uCdNOF9cyXZQHOCdpk/3dkuBRkdDIQDPbSyyNMAYgY5AnIcymw8fKoUPjCu?= =?us-ascii?Q?LETb1nk67erAHDDvdrLrB/yb/NUjqS9UW2Q+N1HJImpFCrIOPXOpIIOUJ3Vp?= =?us-ascii?Q?aolnmgEgLIJs2SsyezMv4ofX4W6MHaDmRS3yPz46q1ss3ZXq/ugEnP0PjPs8?= =?us-ascii?Q?BNFf0k6CzO8ji3/i+k8jGKDsXsSrBhaWxI9JZ52qxr9/ihwqq9FvillnhUzE?= =?us-ascii?Q?qOdAT4lLuIZagTR5rbZ4+4tNKbUEq2KfdB6xtJ3aDznxpLgmASfkQAAjpo6e?= =?us-ascii?Q?9ydJ+bPIvKXc6MpWo2FPG93w3SS/SxEikO9deIjYid7AfxVUV27bpZoBpWmm?= =?us-ascii?Q?DNhCDMxVlEocJtatY6aJZhirFUlt+/jvkrhgCLHLu5GaNuF0Yu5CJU3daBEN?= =?us-ascii?Q?xJD4s47HvrIJp264Ga68vzV+2WhYzbZO4AIZbV7uic4Z9Yox1Hp1/H7oUfXa?= =?us-ascii?Q?DOG47f+nINsqjxprmIBdVx3eng+gncL0swR3GF0N9UYQh3RA9NP6/VyNUQLZ?= =?us-ascii?Q?Cu4VjnXQbP7XAYyni3dd14wrV6PwiwpbleM1ZoCiL23tyJ28rNsjIRo2EHrg?= =?us-ascii?Q?WtduWr1OIjdpOElam9gB5kjiJYS2IpolZWKbcqW/gN71j1ub1LrGNKwrfmYG?= =?us-ascii?Q?mvWZQ8kkUfPgZurFTE4WclODdjaNwRgdzYMNXkOGVLuf4H0W+0PDSjJOTNZ+?= =?us-ascii?Q?ymS0xFA6/ZrMDbe7mm5zfTXrpCf46+v30nIEzko7ibl/Pe+OZPXyQzQjqsTt?= =?us-ascii?Q?fmbHVx8s2ddorEVV3NN/uHZHVlBaSg2Tjr2G4NFEj9qWNHEmDd6G+F+KSyE6?= =?us-ascii?Q?/KaVbGJg3d+OnT3Dtvj/AmIMebXGA6QpAchB5hb/SiXi3nnYjyzjUrnJ9G8t?= =?us-ascii?Q?vq1JMwOJz3O1f5DxwZjP/q6byj03GFc8Nkhd2Apgh5Z9dq9PhGkTgkYxkCzF?= =?us-ascii?Q?zoPAFy8d0D5CnkwHzrnTnJAYRWN0YMpBiREKRWvDhYR45KT1QF7++zJPjwlw?= =?us-ascii?Q?aATXJi8XXjiXq0Ni3/fLd/66CIUolh2+XsYChQ1SGNsl2EQFOIpKQGObcuxM?= =?us-ascii?Q?TNciFIz1QEOr0qPdn8uWagBF9QNGuEirBFQmAsJWxB4KRVyMfYV6af2lNBql?= =?us-ascii?Q?o5m1wYpKm9mI10cCMj9sDRsRB6g1I5vg1zeR5blg/WKeJPv+eVRuXC+BLj9l?= =?us-ascii?Q?yz9HZV6s/SRpj9ZuIsP9eBxK3h74c/wro9DnWx0lMPXnD32d7YhePdDdjGqw?= =?us-ascii?Q?bUNR/49vGdAuICbz6Itl4gk3ZCVGk2kxv6FrdzmJt1bcN0Il4QVcpcuFEunG?= =?us-ascii?Q?efpm5bSpfOVCm6EnWG+6cf2DPnw6LD94NUU/sQ/HdU810cGsX8t1Hah3vOzk?= =?us-ascii?Q?WWkNphOMUc5SaWtJPMLGzem1d+KoCxhKdMc0kFzrf34FQeOmHALf2wxdn4Zf?= =?us-ascii?Q?4/2/WX9UmO3IUozAJhI8GofhMzPvyYGHH6L6UWG8B9Igy/R5vMrwvlRQ8mYt?= =?us-ascii?Q?mCWN17N7pUaTGBhc+NPJR3at7WTY4gWjDa/1f+C/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2c687cc-661d-45a1-685d-08da90823731 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 03:36:57.2318 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FLGIVXbUL7TT+fw9Pe4jJkVWex2ovQUKpAfkbMb+8XXYF2ZFBkdY5ax1EAWnR7KRNg3PCGzBrEvFj3oCVI5k8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1584 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, September 6, 2022 8:19 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting er= rors >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 >=20 > This package did not have CI enabled so code changes were merged that fai= l > uncrustify formatting. This change updates those files to include uncusti= fy > formatting. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Michael Kubacki > --- > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c | 9 +++++= ---- > IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c | 2 +- > IntelFsp2Pkg/Include/Ppi/Variable.h | 8 ++++-= --- > 3 files changed, 10 insertions(+), 9 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > index cb2317bfb240..8e24b946cd88 100644 > --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > @@ -193,8 +193,8 @@ DebugBPrint ( > **/ > VOID > FillHex ( > - UINTN Value, > - CHAR8 *Buffer > + UINTN Value, > + CHAR8 *Buffer > ) > { > INTN Idx; > @@ -227,8 +227,8 @@ DebugAssertInternal ( > VOID > ) > { > - CHAR8 Buffer[MAX_DEBUG_MESSAGE_LENGTH]; > - UINTN *Frame; > + CHAR8 Buffer[MAX_DEBUG_MESSAGE_LENGTH]; UINTN *Frame; >=20 > Frame =3D (UINTN *)GetStackFramePointer (); >=20 > @@ -250,6 +250,7 @@ DebugAssertInternal ( > sizeof (Buffer) / sizeof (CHAR8) - 1 > ); > } > + > SerialPortWrite ((UINT8 *)"ASSERT DUMP:\n", 13); > while (Frame !=3D NULL) { > FillHex ((UINTN)Frame, Buffer + 9); diff --git > a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c > b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c > index 69a021f42b39..a0b2193bdeab 100644 > --- a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c > +++ b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c > @@ -31,6 +31,6 @@ SwapStack ( >=20 > FspData =3D GetFspGlobalDataPointer (); > OldStack =3D FspData->CoreStack; > - FspData->CoreStack =3D (UINTN) NewStack; > + FspData->CoreStack =3D (UINTN)NewStack; > return OldStack; > } > diff --git a/IntelFsp2Pkg/Include/Ppi/Variable.h > b/IntelFsp2Pkg/Include/Ppi/Variable.h > index 3e1f4b98a999..581f14880813 100644 > --- a/IntelFsp2Pkg/Include/Ppi/Variable.h > +++ b/IntelFsp2Pkg/Include/Ppi/Variable.h > @@ -184,10 +184,10 @@ EFI_STATUS > /// to store data in the PEI environment. > /// > struct _EDKII_PEI_VARIABLE_PPI { > - EDKII_PEI_GET_VARIABLE GetVariable; > - EDKII_PEI_GET_NEXT_VARIABLE_NAME GetNextVariableName; > - EDKII_PEI_SET_VARIABLE SetVariable; > - EDKII_PEI_QUERY_VARIABLE_INFO QueryVariableInfo; > + EDKII_PEI_GET_VARIABLE GetVariable; > + EDKII_PEI_GET_NEXT_VARIABLE_NAME GetNextVariableName; > + EDKII_PEI_SET_VARIABLE SetVariable; > + EDKII_PEI_QUERY_VARIABLE_INFO QueryVariableInfo; > }; >=20 > extern EFI_GUID gEdkiiPeiVariablePpiGuid; > -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#93315): https://edk2.groups.io/g/devel/message/93315 > Mute This Topic: https://groups.io/mt/93518036/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20