From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.4596.1685676988604046510 for ; Thu, 01 Jun 2023 20:36:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RqJpChM5; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685676988; x=1717212988; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Y+1RiVV8q+jB2NoJKil2F8NoBJkx7iaV2XDUP6a6DRA=; b=RqJpChM5NOkBBzxI/oz/xRt+Y/FC8Zr+1fUQQkDH7KwO4rZzh3H+rqcy uci2YZ6emHHYEY01apKchHrZSWQApgdfAAGtpXZo3OCvmVMX17A/mW9u3 hx1H7TOX6RynT0sbsEMR5HvI2jtviMhTvAm75NN8qBbyyG98Zs1Oxj5rh fg/8WZXQSqpjYfdXpvH5Cbos8edf7FpugDEozTIGimtgL0GlEG84a7k27 hUWTGK97IkL5lUnKbe2xV+LOG/04O1m6ERjI364hYggS8EPj4j8/rYhxC +Wch/auzE14lxYeqcMSePFk8NoItYbTnSWzmqVaiWKeR4jdTIe1d8N8bz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="336121728" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="336121728" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 20:36:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="1037749292" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="1037749292" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 01 Jun 2023 20:36:17 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 20:36:16 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Jun 2023 20:36:16 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 1 Jun 2023 20:36:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QRdmjI+xzDNucA5ZfXv+ymp6+ec/qWWrsKbVUbXiNyfYHEmpiR7WUR/3OcWPB5AKf+bM8qZPd9hyB2c5nA+nFzHR2kPiIhl5MX5pXb8GNpg5+l2sdu59Y9bnQnCHv+awzPfmBDfNKGv093fYDmUoyewyRA4fIGMJMW0fQKVbpVGnBRdHGGxbzK1AcxweeuEBKF8cf2Bb53ExA3I6rOCc5Rf++eAs3eItyF9T1aKFEP8a+mSud4FcRreR0fHkuhHjL3M7zP3OsWQBUt3FbtKQjaQ0+4Zp2dmSfcVvIs30wDOjfE5J9MAjy1RXFi6hYnOysNO8d0KN4XsvCnHxW7Vvww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xKVxgE5ZTOCZGM5J3lbCOcvMnecvhWWYPkPcjdvDe4E=; b=QmA2YAYjJf415Mhl9zbl2353FlumGEylcmLTCqNAwH7ZJHwR1M2FAsAt6BqJcaHCDagNIe9Bq2G3vCUagIYOR/b7IrAvPPvF4leLLsBb9U4U6jnqrVKLbUeNoWParywt7J4i7DrLvgSm0ZL0JTOJuzKDbYE0YpNYJCcnAdQWpuqU0NUsoGX8VxqEpyNjslrzVegD/eVtpT1Znk+Ztiho5PnMituFkg66G91dcgbb87p0Fo8aEOclRL8Ls4km2cNbCne/v5sQuDq21lveSg7LwfzosAPVrRINE1ooWfbedaYegD1F5+Extfhx7lnTQr8nH7PVwt2I5BWVYPU1b9Ji2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by IA1PR11MB7679.namprd11.prod.outlook.com (2603:10b6:208:3f1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.24; Fri, 2 Jun 2023 03:36:14 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3023:34d3:bd4e:7901]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3023:34d3:bd4e:7901%3]) with mapi id 15.20.6455.024; Fri, 2 Jun 2023 03:36:14 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V4 09/15] UefiCpuPkg: Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h Thread-Topic: [edk2-devel] [Patch V4 09/15] UefiCpuPkg: Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h Thread-Index: AQHZlQCuypEOpPwX5Uu+p0C/7xj0GK922PAA Date: Fri, 2 Jun 2023 03:36:14 +0000 Message-ID: References: <20230516095932.1525-1-dun.tan@intel.com> <20230516095932.1525-10-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|IA1PR11MB7679:EE_ x-ms-office365-filtering-correlation-id: 6af24efd-efec-454c-3989-08db631a8456 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aoo5CaoZvz2uGlRkaoaDFkdEG2cBi1p7vM3fV7EwpBmrzWK9ybGxTqTOXRGktgb62OdCj9fPqqHhjg6CL3u1zAg0VeB0n/2V5531I1T0R451aJjazUucAN3K/gsp4ZcDpvN7dvNyA+vAVuLPZ6HsogQ2jQkAUBhnALUrQdotMotPPv7aSyqp1idKVTAfXEeaIfWc/FHwT82AfjplR/6yZbXPHpk5s1zh+BE2Eeq7yW3nL/EOrCwjkZdPejGNwvLnIlixODLryglSRAlT4GZTZZH7beCBl1/zQ34ErJErNHmDoXbcF7tqiOQCO9g2rn5hIGTKqvXCidtoBYTkEy//j81EG5XjajeNC4TKZ1UjhHG8+eDmgRnP/PDrt1bHwU0neTNfrOF+AQsSN6L+wYODdx7YsUHpEyH/njdk8JVlG73kfyvdW7/AQ+FAJdlJZoA9wCIGth4Kgzy8O3UrVFromrpjDnGi0CUuxz/MSE/OHp64URAfY5uu4GpRks52LPI+554aeoUp0hdFYyyxaAMIXOyBI7RXB7w1aQXP/RRcmG6hufLReVb+Vi1vLwv+zgvFx6elTqaU16h7vk2xY4Eac/raDEOU2GWpKlTCqPdk9atyMOrxWuW5q6aBwKPUmWySzLSf0QeZiIROPPWOeOYdT71Iimqv9llgNXvPjmN6vBI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(39860400002)(136003)(346002)(366004)(396003)(376002)(451199021)(86362001)(33656002)(82960400001)(122000001)(38100700002)(38070700005)(478600001)(71200400001)(19627235002)(110136005)(54906003)(66476007)(7696005)(8936002)(5660300002)(966005)(64756008)(66446008)(2906002)(52536014)(66946007)(66556008)(316002)(76116006)(41300700001)(4326008)(8676002)(66899021)(6506007)(53546011)(55016003)(186003)(83380400001)(9686003)(26005)(145543001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dHh7RPulctcjuIxafdRUINApqTA1xBLV6zJXEmW8lasdwwveNS1U2ihCJNvj?= =?us-ascii?Q?P0DKgLQkARrUHrA0cZd56/WpkfU9DRCPiaz/fCY1ZKDKRKlKO4nTjI2MFotx?= =?us-ascii?Q?APc4P0dXgXVISmYxvUI1Jfp5fNEmVDpFeyhZ9QtsEIC+M2xXaMgen2MPyMXM?= =?us-ascii?Q?o0FF2/YnSFdYI40MZ0UYWW+cugpg3ssH1cS11S9GQHTIUP2GelWXHTIUZNQx?= =?us-ascii?Q?MS+MI6ypox4AxGBmk7n4HV5hu+ur+BYAKU1gznWK/iyXjQZDsbjbUXKw6pfa?= =?us-ascii?Q?FB4Z48Zg2TkgnMDNwCZ/TemHtnHbensspm22Cfe9GxoWMjBBAgndenIYwIG0?= =?us-ascii?Q?ke6dnofssstX1M2Mn/VaP1Bb5GsiGsLfkPbRHJL90niAIwzogsjSN+PsFIUO?= =?us-ascii?Q?8csIosltsZMT/fPtPe0HJ83yEb18qM/vmycxMlMnMd00L5M42c2cMjlpPj1k?= =?us-ascii?Q?VufU61Rr6gGoo4pjuBcC9FkzX2k9TYe8YL3SaAXWjiXXgHcJ2to7vKdfO64O?= =?us-ascii?Q?QHb8WczETsBiDM8nhmnesSTsPOASXYRJExUCIfK8ELgLXi48vCGgapNyZoaP?= =?us-ascii?Q?eIrJ3dVVUL67UX+x2OUK2hHjSsF13q4U0sA1sQuo+8dWNherkW18dXiOtLxt?= =?us-ascii?Q?kS64TnHkUe8dRHl9BrOhA3XHCCZJocv0dL6lC8xr01A1+z5jDXew3tnbW4ce?= =?us-ascii?Q?rHfLsago/hG8B+l4UvdIMpywL0ldj6pX/bVNm9JndpRUChwCume70v5K55fD?= =?us-ascii?Q?vXFzxKr/tj8CWAzCf1iCpTdlkqtosji2rskAFlvkSV8DLZ8EMeQ5wYb80o7y?= =?us-ascii?Q?gRF5Rb6XM4MIBmlnnjQ40LW22IvmuHM00CJ+STW4Q9A0xDA7pgnygx680lie?= =?us-ascii?Q?gP6w+/wltsM4kQumcHmq+8dxiSRuetREWND+h4emfAQukNDKo6fnGcXTXBQK?= =?us-ascii?Q?R/H3H8XNik+b0PYZoWP88zkJVP9Ca9PqJtdDUTq3zVOocA4wDhzHmVTwdiLH?= =?us-ascii?Q?0iHX5DIihKbQjSUAUGbsBxNol0qBHrH91XAZWN+J2ZLWxfoe7Kq72seBrGa3?= =?us-ascii?Q?BpzBAl3LfskzIIuSufamoXlWz4lUPhMC7IxzpFxl42gLKWHjQI3flRjQ9Y/w?= =?us-ascii?Q?rqLkZXz331Z7sP4kbRnpcyhhWs6b5oKgz7yOfik4aHG4Zc0qsjCKqPfcRttl?= =?us-ascii?Q?V6W3FEgXNtvz9yTMtUniGq4SS+9rEkpGUH+41LggfVGWkxH5dPOAIS8ckn6x?= =?us-ascii?Q?XzRT9cO5qshD+J1+HyfMFA87qi1+jqL7caF0JTR0FPuHtzZuNCnGFVRpN1BH?= =?us-ascii?Q?QA5vneAH93G+ugl+bLEaRD4TlUWDOrMl4ZREevGlgAQgFaL5Pag51qmJdCPw?= =?us-ascii?Q?ERNtWFJbvQfyrzkp59OplImOLyI7aP+57Y3/EwoqiKrmg1I7jvkGHkPYdmv7?= =?us-ascii?Q?xefErwCuDoiMCL6QCkGwvkLFca9L0o+OuWtQj8EfeSuSd6pdEyH5lN3WRnGC?= =?us-ascii?Q?IUn4sNNsqJrv81KHDxeR4bjwb+cbILSgNhGQ8ydkdC84CURg896D0OyLRc33?= =?us-ascii?Q?uD36mfBlgiqVD4drnlM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6af24efd-efec-454c-3989-08db631a8456 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 03:36:14.3163 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5pLk7SbbpPR9H05FY47LvyxJGQfakp7jPUrc5n8d3BXQToJL1jhY62YzKzmJQPgFPnkOeCJUmoppVq6gnvMTDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7679 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray,=20 The definition for mSmmShadowStackSize is in PiSmmCpuDxeSmm.c I have tested the build process in my local and CI and both works. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Friday, June 2, 2023 11:17 AM To: devel@edk2.groups.io; Tan, Dun Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [edk2-devel] [Patch V4 09/15] UefiCpuPkg: Extern mSmmShadowSta= ckSize in PiSmmCpuDxeSmm.h You removed all "extern" and added one "extern" in PiSmmCpuDxeSmm.h. But, where is the mSmmShadowStackSize defined? No link error? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Tuesday, May 16, 2023 5:59 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ;=20 > Kumar, Rahul R ; Gerd Hoffmann=20 > > Subject: [edk2-devel] [Patch V4 09/15] UefiCpuPkg: Extern=20 > mSmmShadowStackSize in PiSmmCpuDxeSmm.h >=20 > Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h and remove extern for=20 > mSmmShadowStackSize in c files to simplify code. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 3 +-- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 -- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 1 + > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 2 -- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 3 +-- > 5 files changed, 3 insertions(+), 8 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c > index 6c48a53f67..636dc8d92f 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c > @@ -1,7 +1,7 @@ > /** @file > SMM CPU misc functions for Ia32 arch specific. >=20 > -Copyright (c) 2015 - 2019, Intel Corporation. All rights=20 > reserved.
> +Copyright (c) 2015 - 2023, Intel Corporation. All rights=20 > +reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -14,7 +14,6 @@ EFI_PHYSICAL_ADDRESS mGdtBuffer; > UINTN mGdtBufferSize; >=20 > extern BOOLEAN mCetSupported; > -extern UINTN mSmmShadowStackSize; >=20 > X86_ASSEMBLY_PATCH_LABEL mPatchCetPl0Ssp; X86_ASSEMBLY_PATCH_LABEL =20 > mPatchCetInterruptSsp; diff --git=20 > a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index baf827cf9d..1878252eac 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -29,8 +29,6 @@ MM_COMPLETION mSmmStartupThisApToken; > // > UINT32 *mPackageFirstThreadIndex =3D NULL; >=20 > -extern UINTN mSmmShadowStackSize; > - > /** > Performs an atomic compare exchange operation to get semaphore. > The compare exchange operation must be performed using diff --git=20 > a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index e0c4ca76dc..a7da9673a5 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -262,6 +262,7 @@ extern EFI_SMM_CPU_PROTOCOL mSmmCpu; > extern EFI_MM_MP_PROTOCOL mSmmMp; > extern BOOLEAN m5LevelPagingNeeded; > extern PAGING_MODE mPagingMode; > +extern UINTN mSmmShadowStackSize; >=20 > /// > /// The mode of the CPU at the time an SMI occurs diff --git=20 > a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > index a25a96f68c..25ced50955 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > @@ -13,8 +13,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent =20 > #define PAGE_TABLE_PAGES 8 > #define ACC_MAX_BIT BIT3 >=20 > -extern UINTN mSmmShadowStackSize; > - > LIST_ENTRY mPagePool =3D INITIALIZE_LIST_HEAD_V= ARIABLE > (mPagePool); > BOOLEAN m1GPageTableSupport =3D FALSE; > BOOLEAN mCpuSmmRestrictedMemoryAccess; > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c > index 00a284c369..c4f21e2155 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c > @@ -1,7 +1,7 @@ > /** @file > SMM CPU misc functions for x64 arch specific. >=20 > -Copyright (c) 2015 - 2019, Intel Corporation. All rights=20 > reserved.
> +Copyright (c) 2015 - 2023, Intel Corporation. All rights=20 > +reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -12,7 +12,6 @@ EFI_PHYSICAL_ADDRESS mGdtBuffer; > UINTN mGdtBufferSize; >=20 > extern BOOLEAN mCetSupported; > -extern UINTN mSmmShadowStackSize; >=20 > X86_ASSEMBLY_PATCH_LABEL mPatchCetPl0Ssp; X86_ASSEMBLY_PATCH_LABEL =20 > mPatchCetInterruptSsp; > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20