From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Chiu, Chasel" <chasel.chiu@intel.com>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.
Date: Mon, 26 Sep 2022 20:24:19 +0000 [thread overview]
Message-ID: <BN9PR11MB54830C25D16280B92C55770EE6529@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <171279939D8A2496.24814@groups.io>
Patch 4 Fspw to adopt FSP 2.4 MultiPhase has been merged:
https://github.com/tianocore/edk2/commit/96f3efbd991db83c608909c1c861a77fe26982f1
Thanks,
Chasel
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, Chasel
> Sent: Tuesday, September 6, 2022 9:28 PM
> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP
> 2.4 MultiPhase.
>
>
> patch3 Fsp24SecCore modules have been merged:
> https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee9
> 6f462676e7
>
> Thanks,
> Chasel
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu,
> > Chasel
> > Sent: Wednesday, August 31, 2022 11:13 AM
> > To: devel@edk2.groups.io
> > Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> > <star.zeng@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg:
> > Support FSP
> > 2.4 MultiPhase.
> >
> >
> > Patch1 and patch2 have been merged:
> >
> https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee
> > 9
> > 6f462676e7
> >
> https://github.com/tianocore/edk2/commit/31a94f7fba2a2c1244fc35b6f631e
> > 2
> > 35e267715b
> >
> > Rest of the patches will be merged later.
> >
> > Thanks,
> > Chasel
> >
> >
> > > -----Original Message-----
> > > From: Chiu, Chasel <chasel.chiu@intel.com>
> > > Sent: Tuesday, August 9, 2022 5:48 PM
> > > To: devel@edk2.groups.io
> > > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > > <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> > > Subject: [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
> > >
> > > Add FSP 2.4 MultiPhase interfaces and implementation.
> > >
> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > > Cc: Star Zeng <star.zeng@intel.com>
> > > Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> > >
> > > V2:
> > > . Add FspMultiPhasePlatformGetNumberOfPhases() and
> > > FspWrapperPlatformMultiPhaseHandler() to support platform porting.
> > >
> > > . Add FSP reset support in FspWrapperVariableRequestHandler()
> > >
> > > . Fix bug that wrong parameter given when calling
> > > FspWrapperVariableRequestHandler()
> > >
> > > . Corrected code comments.
> > >
> > > Chasel Chiu (4):
> > > IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
> > > IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface.
> > > IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions.
> > > IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers.
> > >
> > > IntelFsp2Pkg/FspSecCore/SecFsp.c
> > > | 4 ++++
> > > IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
> > > | 9 +++++++++
> > > IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c
> > > | 184
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c
> > > | 30 ++++++++++++++++++++++++++++++
> > > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> > > | 33 +++++++++++++++++++++++++--------
> > > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > > | 27 +++++++++++++++++++++------
> > >
> > >
> > IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/
> > Fs
> > > pWrapperPlatformMultiPhaseLibSample.c | 49
> > > +++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> > >
> > IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapp
> > er
> > > MultiPhaseProcessLib.c | 355
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > ++++++++++++++++++++++++++++++
> > > IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> > > | 75
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > ++++++++++
> > > IntelFsp2Pkg/FspSecCore/Fsp24SecCoreS.inf
> > > | 59
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> > > | 304
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > ++++++++++++++++++++++++++++++++++++++++++++
> > > IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryS.nasm
> > > | 101
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > ++++++++++++++++++++++++++++++++++++
> > > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm
> > > | 3 +++
> > > IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> > > | 303
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > +++++++++++++++++++++++++++++++++++++++++++
> > > IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryS.nasm
> > > | 108
> > >
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > +++++++++++++++++++++++++++++++++++++++++++
> > > IntelFsp2Pkg/FspSecCore/X64/FspApiEntryCommon.nasm
> > > | 3 +++
> > > IntelFsp2Pkg/Include/FspEas/FspApi.h
> > > | 62
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > > -
> > > IntelFsp2Pkg/Include/FspGlobalData.h
> > > | 5 ++++-
> > > IntelFsp2Pkg/Include/Library/FspMultiPhaseLib.h
> > > | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h
> > > | 19 +++++++++++++++++++
> > > IntelFsp2Pkg/IntelFsp2Pkg.dec
> > |
> > > 12 ++++++++++--
> > > IntelFsp2Pkg/IntelFsp2Pkg.dsc
> > |
> > > 4 ++++
> > > IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
> > > | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > > IntelFsp2Pkg/Tools/SplitFspBin.py
> > > | 48 +++++++++++++++++++++++++-----------------------
> > > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf
> > > | 1 +
> > > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf
> > > | 3 ++-
> > >
> > > IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h
> > > | 62
> > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> > > | 10 +++++++++-
> > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
> > > | 6 +++++-
> > >
> > > IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSampl
> > > e/ Ba seFspWrapperPlatformMultiPhaseLibSample.inf | 37
> > > +++++++++++++++++++++++++++++++++++++
> > >
> > >
> >
> IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperM
> > u
> > > ltiPhaseProcessLib.inf | 48
> > > ++++++++++++++++++++++++++++++++++++++++++++++++
> > > 31 files changed, 2023 insertions(+), 45 deletions(-) create mode
> > > 100644 IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c
> > > create mode 100644
> > > IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSampl
> > > e/
> > > Fs
> > > pWrapperPlatformMultiPhaseLibSample.c
> > > create mode 100644
> > > IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWra
> > > pp
> > > er
> > > MultiPhaseProcessLib.c
> > > create mode 100644 IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> > > create mode 100644 IntelFsp2Pkg/FspSecCore/Fsp24SecCoreS.inf
> > > create mode 100644 IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> > > create mode 100644 IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryS.nasm
> > > create mode 100644 IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> > > create mode 100644 IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryS.nasm
> > > create mode 100644 IntelFsp2Pkg/Include/Library/FspMultiPhaseLib.h
> > > create mode 100644
> > > IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
> > > create mode 100644
> > > IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h
> > > create mode 100644
> > > IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSampl
> > > e/ Ba seFspWrapperPlatformMultiPhaseLibSample.inf
> > > create mode 100644
> > >
> >
> IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/FspWrapperM
> > > u
> > > ltiPhaseProcessLib.inf
> > >
> > > --
> > > 2.35.0.windows.1
> >
> >
> >
> >
> >
>
>
>
>
>
prev parent reply other threads:[~2022-09-26 20:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 0:48 [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase Chiu, Chasel
2022-08-10 0:48 ` [PATCH v2 1/4] IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface Chiu, Chasel
2022-08-31 0:11 ` Nate DeSimone
2022-08-10 0:48 ` [PATCH v2 2/4] IntelFsp2WrapperPkg: " Chiu, Chasel
2022-08-31 0:11 ` Nate DeSimone
2022-08-10 0:48 ` [PATCH v2 3/4] IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions Chiu, Chasel
2022-08-31 0:11 ` Nate DeSimone
2022-08-10 0:48 ` [PATCH v2 4/4] IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers Chiu, Chasel
2022-08-31 0:11 ` Nate DeSimone
2022-08-31 0:11 ` [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase Nate DeSimone
2022-08-31 18:13 ` Chiu, Chasel
[not found] ` <1710808E80FE5771.19509@groups.io>
2022-09-07 4:27 ` [edk2-devel] " Chiu, Chasel
[not found] ` <171279939D8A2496.24814@groups.io>
2022-09-26 20:24 ` Chiu, Chasel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB54830C25D16280B92C55770EE6529@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox