From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.3859.1662522681533568915 for ; Tue, 06 Sep 2022 20:51:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Y1XmBumL; spf=permerror, err=too many SPF records (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662522681; x=1694058681; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vZWy/iTsOtw4CwYjjX8QiZSf8yFw+cVBAJl3/MD50ow=; b=Y1XmBumLHe1BRrer5Qadw1re4/GX8Ztct1AN6eh66qF1tLCVUFEVUtXV VzhA6Oo8WLBF1zgkyB/obd8+iELqfxWKX4FEMZxDJcpPafiUfPxHBvcTa hNM/jZxcvNZlKDDO5DUXtXRx1LjKUp3mRmALvvvDoa9Xf75QJEdb9t4wt 2TxwxPh9Jmr5OCfXBb/Nugwq5JlE2RZZaff0C7QWbu2OwwAfcwZmUP+ST KNcwwyIxhyCMhnkLZRX8zRgg+izmhlbLPluPf+Sj2DLqOlPW4trBAuKN4 Rxs0vJwU1G6yn7JzZdn/Cq2m+4W8Fc2fE/GF8RrdW3EjwdJleC14VcVIN Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="294355867" X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="294355867" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 20:50:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="610179223" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 06 Sep 2022 20:50:00 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Sep 2022 20:50:00 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 6 Sep 2022 20:50:00 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 6 Sep 2022 20:49:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+qwrKuEtGp6QQpXUqoGCmIcFT97rRG51LHstOHFPOA+yBZ9cyVmyNv8r80ruZwIPUG1OHygLano+NaVoLqgtLYsgPHZbiJUw0haYYYpbnOph7j2se4n782W9/lxwPB0NpVgYqjsRW4SsCoaNjZFqU7hjbLa2u4nXSpxxPz0iQetzTfFdconULutepCzM/L5CJzIAQGM19tXuCz2niCm7U1BusZPoU92qNRLC2LzayLxYE2xOJDyKXMNY4MYlhGZlwwqNmNpSkNRvEs46rhYbJ2P2Tc/nrhGVOPY7jYJVY5pEkfzRGtafrbezh877h8+5w6mexYBMIKck2qsIXf6Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ggwcUni8/SvdHxtcS0yDTCVbcZ/eVxS7DuRqQoMKeYI=; b=iW4SmwqPZK+u+culxwnrUeWM2BfRXC6OGUP42a0xh8Of6/Z6HgLdGJTYT5NmGGtyXYJ+mtSSjk39X63al61/Mrm7nZyW5DchHyDu6sKIS7H0nahPeONxlUO0wHoWmbrfkf+0yEUsQ0pTNhfLKnVzna1rsbFQVUEj5i1Y4N1xZylE+e6czxKAvdkdosMGp2JudI7g+3I1To4gwuPXYEnpvOfe3WdHcKUu2RnMh5PlLisyOEhL11Glc5Rd/3Dh0OUiV4FJ5tKjDgfvaa3DzkqArJeYrz2KYGtui2eGYBSiPxcCLlOtzZVstmvLkn6MY+ydhRy2udolKeeWJ8Gl60QF9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SN6PR11MB3023.namprd11.prod.outlook.com (2603:10b6:805:d3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.19; Wed, 7 Sep 2022 03:49:58 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::613a:668:ad30:2cb6]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::613a:668:ad30:2cb6%3]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 03:49:58 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry Thread-Topic: [edk2-devel] [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry Thread-Index: AQHYwmi5C1ZaZvS7QkyYNmCr11inca3TUiKg Date: Wed, 7 Sep 2022 03:49:58 +0000 Message-ID: References: <20220907031914.397-1-mikuback@linux.microsoft.com> <20220907031914.397-6-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-6-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35079ee1-f0df-4bff-6d73-08da9084089f x-ms-traffictypediagnostic: SN6PR11MB3023:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YleBnqM/YvqPaMjtq6V9Y19gnr9ONLgu+UWZNybF7ijxnMrcrJSi9H4wSLDVo3iZtN9wn1sXISS7k5OIJ032nhXNLbuScQVuazzV3ansoyX96/FGupVNyZidP3Sq0WZQgHJHWsdwhdyraSt05jOeQpUXNUOLIoSImLMEffOU1p6QL9S5eQLXK/V7up5/jmjUh1/ATJK/f/8S/sSOPN/abJ9wnrKvSfcyiLl0YSWwgwdSUR9lYDgBN3ZPiBCm0iyMmEtUY7KeTesgD3XJKBpbh/xQnWDR63W+nR1HOeOFLMVlgiYp7dfyimOeKWSc3qsoLS06Upa55YTUT5g5R0WO1oaIfPFFp7QbciEIxEWQ8IlJdSAPVfVwkSBBdD/0mkBTknP4JwSVC5g7FdTLmwt8M1/DqUiVK5RSDJ/WtlaaVWaQIBYL+sZTFrG8fdCUbNn+ybNFYVGQ0H3Byxnwzj9q5ZaW8PfNGyxYFgeUUGl6y1AAFZILTg0mOd3xtVOTYUXzdacXu+EdNOJ/SZnU3LKiYzbl4no0VgG7FFTK+YyCGcZV3otgL+wDRmI7yKFQlQPFNcm0QHaBVU2vQE5ow/vqbe6KoV/pLcF43sj46ITYpNrYJ1TJPHCfyjlnSxlamcQ6plJ6vGuMoNtlcaEGwSYichDLZSzveaMM+m7qeKI4RR5TQ8xA6M2egQrghLTe8iGzsvB7WUdIFsJPMnCOGqW9KMjVz8h1VMMTift6YZ1YEbH8Zr2V3WQ0ySk0OEoPhumKAzpq9ptsqS24RqxEUweQti82UaKcKE0B4bGs5i6pVMeQI9SNc1XKqDHjsvtqKC9LG606Uth9pR6fF8f18s6y5Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(39860400002)(346002)(366004)(136003)(76116006)(478600001)(41300700001)(110136005)(966005)(8936002)(316002)(19627235002)(107886003)(6506007)(7696005)(53546011)(5660300002)(2906002)(9686003)(26005)(54906003)(38070700005)(86362001)(33656002)(82960400001)(186003)(83380400001)(71200400001)(66946007)(52536014)(66556008)(66476007)(66446008)(64756008)(8676002)(4326008)(122000001)(38100700002)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?geKy0g1n0+8op06LhowRPpFxx/aZ/USuQHDrGmVq8BBYTqGJRj+MbqeDowqE?= =?us-ascii?Q?sfbpK87VOkaNM0L3dTH1svuTu4fRlUPnq8gQd+zoZauZsLE9gXiyXJ4AV5Th?= =?us-ascii?Q?BmOuVxS2LtTrpez9fBN1gA1SCwAm1aF5V5LfoD5+zFJlI5lY+jdAsyBIHwh1?= =?us-ascii?Q?Cx9a80jHDJQzWgf5hb7Lr4SLqAi3g5BSns0pXCho4/UiBAQR2koI4P5uJ+1R?= =?us-ascii?Q?faZhUplFP5Hlld26lvUYRrqdHO+cuuB4odfozS7veEBfqfzqn68JVFgNstOc?= =?us-ascii?Q?+o/AkziGSj76m4a4h0qKS7pn5/ENoHDPPMrPefro3f02fFN/86mKnrhZl9s9?= =?us-ascii?Q?tJaBV/SdjNGP0EXrfP+VGen90P8H1i2HY3Amwi/9631egRe5pwHw/oZI0MLs?= =?us-ascii?Q?IbmF80r9ACMEocdtZPHO07PjMuoGKbxUiC/RSWc5mQcxcszBSRDR17DGHC0y?= =?us-ascii?Q?bcSHAcW4ZJxORLHhrimR5Yxxap6p8lh2R6rPZ44QeUXpubTGcRSBbeYdf155?= =?us-ascii?Q?GRzmGaPKHRFnblJSXTu+R2JgDpTRYTcGN0/ZKClEjJkhaapbbI3IpvzZgHZ1?= =?us-ascii?Q?ogQRMt++G4RAvtbk4/oYQvANlOCo6ADQVYPqLLyQPDQhyRX9rnOdhZqhvs64?= =?us-ascii?Q?kbIF/5OBJugtWf8bgbDzxSRj8sbhNkAC63tYlXKZEu1jlGimtUmy2HYbGUyt?= =?us-ascii?Q?fkH9YKyzI8hvIyssFy+UxtiL76WdBGdvHQDhNmD6STpU6qghBt8WF6kVtmU/?= =?us-ascii?Q?EU/hYCohl88Nd1079jMVrdXP3wwXVhbCCXGnDhTayXX3FJ9hFxl9pkfDSe7x?= =?us-ascii?Q?sTDEnrxPBAKtY/KABcAjNOXyEHZX71aOIG9euc/HqrrEQYqUpA4hLIPHTpzV?= =?us-ascii?Q?xULsU8F7YJ4whaZNyVL9PK3arupWKpSLWmagCm4F9/z9oK8Af2o3a4vQstHg?= =?us-ascii?Q?4xAj8VDR2d2hMG7GHASbJOgDaWr3BtcKK2+M6rBSfZ3qNGqLJ01TTF2KJDMX?= =?us-ascii?Q?dA0GQRJZ78qcF54MRh7F96zjV4E6Yot76eiFNl7H7pgRgHsavvHmwbJXBE7x?= =?us-ascii?Q?WNxP4AQbEpuqge3hAoakd7BYJ3npydYR7AzDCF4dOXS2/3NZKKaqTszrGf5y?= =?us-ascii?Q?vbQRoWVIyaRCnni/sOdkaK7k84Zewhwi5LYiVcYzm/tz27MIWOHduZKZPPQT?= =?us-ascii?Q?sHemabCIsyu6LDR1m/l5OhEgqDN2tzKsK64uutflDemlMJz5jeWSInaEtmKM?= =?us-ascii?Q?PvSOlTL2d+7DuqOgS4TfQC9O8/OpSDg7sgjWRy7hNiT+jarOSa8Cp+fQfhYU?= =?us-ascii?Q?xxr2Z+lybbuvUjOoblbCbSgZlpAgUpBN9bmvGt9DJxOCqMSqrQPFRlVuLQot?= =?us-ascii?Q?mxq/JL4B+G+lKq2QPRM4iMZ6HzPFCLy0teOmY7SqdBodv4LM5oTx/mg6Pr9Y?= =?us-ascii?Q?ocuObiHjfv/DeWSn9zivLBEW8j8PSsV2rPNc9nlHxhqbM4ZzW1wqe40TQOR+?= =?us-ascii?Q?w0d5VZVvmgAR/ThB7g/MT7vtBKkSRjXNwGAJMe6hhiBAE+9Wkn/dLT2rpJ+e?= =?us-ascii?Q?n/2PK6XHtiaTIY/wotP/dLf+OSLaAmLQJpfViCoi?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35079ee1-f0df-4bff-6d73-08da9084089f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 03:49:58.0626 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8Xw3O77Xw55ya1k5cdVwg2Eci0dLKFZQY16A2uwVYiukp0JjcMdc4ZoAr4hle5ZSfjJks0B5irg4q62xpNXzQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3023 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, In this case we intended to provide a single-small function in separate lib= rary for platform customization so platforms do not have to override the wh= ole main library instance, and I think it is not valuable to create another= H file to hold this single small library function. Is it possible to suppo= rt such scenario in CI? Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, September 6, 2022 8:19 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove > duplicate LibraryClasses entry >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 >=20 > The last [LibraryClasses] entry for FspWrapperPlatformMultiPhaseLib point= s to > the same entry as FspWrapperMultiPhaseProcessLib. >=20 > FspWrapperPlatformMultiPhaseHandler() is the only function implemented in > FspWrapperPlatformMultiPhaseLibNull.c and it is only called (not implemen= ted) > in PeiFspWrapperMultiPhaseProcessLib.c, > so I'd assume: >=20 > - Producing library: FspWrapperPlatformMultiPhaseLib > - Consuming library: FspWrapperMultiPhaseProcessLib >=20 > But, the API descriptions do not provide any descriptive information: >=20 > FspWrapperPlatformMultiPhaseHandler(): >=20 > ``` > /** > FSP Wrapper Platform MultiPhase Handler >=20 > @param[in] FspHobListPtr - Pointer to FSP HobList (valid > after FSP-M completed) > @param[in] ComponentIndex - FSP Component which executing > MultiPhase initialization. > @param[in] PhaseIndex - Indicates current execution phase > of FSP MultiPhase initialization. >=20 > @retval EFI_STATUS Always return EFI_SUCCESS >=20 > **/ > ``` >=20 > In any case, this removes the redundant header file entry so the Library = Class > Check CI test can pass on the package. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Michael Kubacki > --- > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > index 95ada0f7a151..c3bbc5c45517 100644 > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > @@ -32,10 +32,6 @@ [LibraryClasses] > ## @libraryclass Provide MultiPhase handling related functions. >=20 > FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProce > ssLib.h >=20 > - ## @libraryclass Provide MultiPhase platform actions related functio= ns. > - > FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhaseProc > essLib.h > - > - > [Guids] > # > # GUID defined in package > -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#93319): https://edk2.groups.io/g/devel/message/93319 > Mute This Topic: https://groups.io/mt/93518040/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20