public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Pu, Yu" <yu.pu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v2 02/14] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib
Date: Wed, 13 Apr 2022 00:13:24 +0000	[thread overview]
Message-ID: <BN9PR11MB5483126501E8844D77FD80E7E6EC9@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220412145144.3521-3-yu.pu@intel.com>


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel


> -----Original Message-----
> From: Pu, Yu <yu.pu@intel.com>
> Sent: Tuesday, April 12, 2022 10:52 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu <yu.pu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH v2 02/14] IntelFsp2Pkg: Add CpuLib to module INFs that
> depend on UefiCpuLib
> 
> There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib and
> UefiCpuPkg/UefiCpuLib will be merged to MdePkg/CpuLib. To avoid build
> failure, add CpuLib dependency to all modules that depend on UefiCpuLib.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Yu Pu <yu.pu@intel.com>
> ---
>  IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 +
>  IntelFsp2Pkg/FspSecCore/SecMain.h       | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> index 7b05cae64130..830471adcf2f 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> @@ -51,6 +51,7 @@
>    FspSwitchStackLib   FspCommonLib   FspSecPlatformLib+  CpuLib
> UefiCpuLib  [Pcd]diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.h
> b/IntelFsp2Pkg/FspSecCore/SecMain.h
> index 7794255af13d..edb7447d9eff 100644
> --- a/IntelFsp2Pkg/FspSecCore/SecMain.h
> +++ b/IntelFsp2Pkg/FspSecCore/SecMain.h
> @@ -20,6 +20,7 @@
>  #include <Library/SerialPortLib.h> #include <Library/FspSwitchStackLib.h>
> #include <Library/FspCommonLib.h>+#include <Library/CpuLib.h> #include
> <Library/UefiCpuLib.h> #include <FspEas.h> --
> 2.30.0.windows.2


  reply	other threads:[~2022-04-13  0:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 14:51 [PATCH v2 00/14] merge UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib Yu Pu
2022-04-12 14:51 ` [PATCH v2 01/14] MdePkg: Add CpuLib to module INFs that depend on UefiCpuLib Yu Pu
2022-04-28  6:35   ` [edk2-devel] " Ni, Ray
2022-04-12 14:51 ` [PATCH v2 02/14] IntelFsp2Pkg: " Yu Pu
2022-04-13  0:13   ` Chiu, Chasel [this message]
2022-04-28  6:35   ` [edk2-devel] " Ni, Ray
2022-04-12 14:51 ` [PATCH v2 03/14] IntelFsp2WrapperPkg: " Yu Pu
2022-04-13  0:13   ` Chiu, Chasel
2022-04-12 14:51 ` [PATCH v2 04/14] OvmfPkg: " Yu Pu
2022-04-13  8:13   ` Gerd Hoffmann
2022-04-20  9:12     ` Ard Biesheuvel
2022-04-12 14:51 ` [PATCH v2 05/14] UefiCpuPkg: " Yu Pu
2022-04-28  6:30   ` [edk2-devel] " Ni, Ray
2022-04-12 14:51 ` [PATCH v2 06/14] UefiPayloadPkg: " Yu Pu
2022-04-28  6:32   ` [edk2-devel] " Ni, Ray
2022-04-12 14:51 ` [PATCH v2 07/14] MdePkg: Move API and implementation from UefiCpuLib to CpuLib Yu Pu
2022-04-12 14:51 ` [PATCH v2 08/14] IntelFsp2Pkg: Remove UefiCpuLib from module INFs Yu Pu
2022-04-13  0:15   ` Chiu, Chasel
2022-04-12 14:51 ` [PATCH v2 09/14] OvmfPkg: " Yu Pu
2022-04-13  8:14   ` Gerd Hoffmann
2022-04-20  9:13     ` [edk2-devel] " Ard Biesheuvel
2022-04-12 14:51 ` [PATCH v2 10/14] PcAtChipsetPkg: " Yu Pu
2022-04-28  6:33   ` [edk2-devel] " Ni, Ray
2022-04-12 14:51 ` [PATCH v2 11/14] SourceLevelDebugPkg: " Yu Pu
2022-04-28  6:33   ` [edk2-devel] " Ni, Ray
2022-04-28  7:30   ` Wu, Hao A
2022-04-12 14:51 ` [PATCH v2 12/14] UefiCpuPkg: " Yu Pu
2022-04-28  6:33   ` [edk2-devel] " Ni, Ray
2022-04-12 14:51 ` [PATCH v2 13/14] UefiPayloadPkg: " Yu Pu
2022-04-28  6:33   ` [edk2-devel] " Ni, Ray
2022-04-12 14:51 ` [PATCH v2 14/14] UefiCpuLib: Remove UefiCpuLib Yu Pu
2022-04-28  6:34   ` [edk2-devel] " Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB5483126501E8844D77FD80E7E6EC9@BN9PR11MB5483.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox