Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg : Remove EFIAPI from local functions.

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg : Remove EFIAPI from local functions.

[Zeng, Star]

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, Chasel
Sent: Tuesday, December 21, 2021 8:40 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; Ni, Ray <ray.ni@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
Subject: [edk2-devel] [PATCH] IntelFsp2WrapperPkg : Remove EFIAPI from local functions.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642

Local functions do not need EFIAPI.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 1 -
 IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
index 49fbb27eca..b0c6b2f8a6 100644
--- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
@@ -45,7 +45,6 @@ extern EFI_GUID  gFspHobGuid;
 **/

 

 UINTN

-EFIAPI

 GetFspmUpdDataAddress (

   VOID

   )

diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index ddee9cd029..fadadd40e6 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -188,7 +188,6 @@ FspSiliconInitDoneGetFspHobList (
 **/

 

 UINTN

-EFIAPI

 GetFspsUpdDataAddress (

   VOID

   )

-- 
2.28.0.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85113): https://edk2.groups.io/g/devel/message/85113
Mute This Topic: https://groups.io/mt/87869015/1779220
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [star.zeng@intel.com]
-=-=-=-=-=-=

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg : Remove EFIAPI from local functions.

[Chiu, Chasel]

Patch pushed: https://github.com/tianocore/edk2/commit/9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9

Thanks,
Chasel


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, Chasel
> Sent: Tuesday, December 21, 2021 8:40 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; Ni, Ray
> <ray.ni@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> Subject: [edk2-devel] [PATCH] IntelFsp2WrapperPkg : Remove EFIAPI from local
> functions.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642
> 
> Local functions do not need EFIAPI.
> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 1 -
> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> index 49fbb27eca..b0c6b2f8a6 100644
> --- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> @@ -45,7 +45,6 @@ extern EFI_GUID  gFspHobGuid;
>  **/  UINTN-EFIAPI GetFspmUpdDataAddress (   VOID   )diff --git
> a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index ddee9cd029..fadadd40e6 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -188,7 +188,6 @@ FspSiliconInitDoneGetFspHobList (
>  **/  UINTN-EFIAPI GetFspsUpdDataAddress (   VOID   )--
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#85113): https://edk2.groups.io/g/devel/message/85113
> Mute This Topic: https://groups.io/mt/87869015/1777047
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] -=-
> =-=-=-=-=
>