From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v1 4/7] IntelFsp2WrapperPkg: Fix code formatting errors
Date: Wed, 7 Sep 2022 03:34:51 +0000 [thread overview]
Message-ID: <BN9PR11MB54831D34D0C8BDE7A336AE66E6419@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220907031914.397-5-mikuback@linux.microsoft.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
Thanks,
Chasel
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Tuesday, September 6, 2022 8:19 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v1 4/7] IntelFsp2WrapperPkg: Fix code formatting errors
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048
>
> This package did not have CI enabled so code changes were merged that fail
> uncrustify formatting. This change updates those files to include uncustify
> formatting.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c
> | 4 ++++
> IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c
> | 1 -
>
> IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamInit
> Data.c | 8 ++++----
> 3 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c
> index 5b5beb5c6557..2e82a0c1b59a 100644
> --- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c
> +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.
> +++ c
> @@ -115,6 +115,7 @@ CallFspNotifyPhase (
> } else {
> Status = Execute64BitCode ((UINTN)NotifyPhaseApi,
> (UINTN)NotifyPhaseParams, (UINTN)NULL);
> }
> +
> SetInterruptState (InterruptState);
>
> return Status;
> @@ -152,6 +153,7 @@ CallFspMemoryInit (
> } else {
> Status = Execute64BitCode ((UINTN)FspMemoryInitApi,
> (UINTN)FspmUpdDataPtr, (UINTN)HobListPtr);
> }
> +
> SetInterruptState (InterruptState);
>
> return Status;
> @@ -187,6 +189,7 @@ CallTempRamExit (
> } else {
> Status = Execute64BitCode ((UINTN)TempRamExitApi,
> (UINTN)TempRamExitParam, (UINTN)NULL);
> }
> +
> SetInterruptState (InterruptState);
>
> return Status;
> @@ -222,6 +225,7 @@ CallFspSiliconInit (
> } else {
> Status = Execute64BitCode ((UINTN)FspSiliconInitApi,
> (UINTN)FspsUpdDataPtr, (UINTN)NULL);
> }
> +
> SetInterruptState (InterruptState);
>
> return Status;
> diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c
> index a17ca7dcabe8..c8248eb88851 100644
> ---
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c
> +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExec
> +++ ute.c
> @@ -69,4 +69,3 @@ Execute64BitCode (
> {
> return EFI_UNSUPPORTED;
> }
> -
> diff --git
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI
> nitData.c
> b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI
> nitData.c
> index d2acb2fd46cd..fb0d9a8683a9 100644
> ---
> a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI
> nitData.c
> +++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecR
> +++ amInitData.c
> @@ -10,10 +10,10 @@
> #include <FspEas.h>
>
> typedef struct {
> - EFI_PHYSICAL_ADDRESS MicrocodeRegionBase;
> - UINT64 MicrocodeRegionSize;
> - EFI_PHYSICAL_ADDRESS CodeRegionBase;
> - UINT64 CodeRegionSize;
> + EFI_PHYSICAL_ADDRESS MicrocodeRegionBase;
> + UINT64 MicrocodeRegionSize;
> + EFI_PHYSICAL_ADDRESS CodeRegionBase;
> + UINT64 CodeRegionSize;
> } FSPT_CORE_UPD;
>
> typedef struct {
> --
> 2.28.0.windows.1
next prev parent reply other threads:[~2022-09-07 3:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 3:19 [PATCH v1 0/7] Enable CI in Intel FSP Packages Michael Kubacki
2022-09-07 3:19 ` [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors Michael Kubacki
2022-09-07 3:36 ` [edk2-devel] " Chiu, Chasel
2022-09-07 3:19 ` [PATCH v1 2/7] IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate GUID Michael Kubacki
2022-09-07 3:33 ` Chiu, Chasel
2022-09-07 3:19 ` [PATCH v1 3/7] IntelFsp2Pkg: Add CI YAML file Michael Kubacki
2022-09-07 3:19 ` [PATCH v1 4/7] IntelFsp2WrapperPkg: Fix code formatting errors Michael Kubacki
2022-09-07 3:34 ` Chiu, Chasel [this message]
2022-09-07 3:19 ` [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry Michael Kubacki
2022-09-07 3:49 ` [edk2-devel] " Chiu, Chasel
2022-09-07 4:34 ` Michael Kubacki
2022-09-07 4:47 ` Chiu, Chasel
2022-09-07 3:19 ` [PATCH v1 6/7] IntelFsp2WrapperPkg: Add CI YAML file Michael Kubacki
2022-09-07 3:19 ` [PATCH v1 7/7] .azurepipelines: Add IntelFsp2Pkg and IntelFsp2WrapperPkg to CI Michael Kubacki
2022-09-09 1:35 ` [edk2-devel] " Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB54831D34D0C8BDE7A336AE66E6419@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox