From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.3684.1662521709675513536 for ; Tue, 06 Sep 2022 20:35:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=K/hr/RZz; spf=permerror, err=too many SPF records (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662521709; x=1694057709; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=a0JCdLhqGU8MWvO5AcJ3gtJFVCnw98LiXGDmF8JGkJ8=; b=K/hr/RZzzCHUw2bxS+9HwGH+zYXl3oPf8eVAjar/WywhhoXa3u5OXylG PwNtvg4Vh6+x1EfEViYgw0tCuKhyafd9g3wAHpGIQQeuvMPWWDnfcmgfG sSNWJY7zWMrg0q0Lk8nUe6mZF+TZ3tfXcqcunliBW6S0XHqeJzeQNSI/F ZrKxkMKtzTNzv5kmREfbF35b9fX3D4S2o/D+rfn8+/PUPe8BR69tXXuGK uq272AQuKOr44oMImmBSwM2P/SWhRBahGx+Rw2LPM4DJwHX17xa7w6Byy NVfN3rXAfkuPIuU1+bTvbvpRMx90wGnzPicQdGGAjb4cYZTugQxksbkXr A==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="296768707" X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="296768707" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 20:35:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="565346792" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 06 Sep 2022 20:35:08 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Sep 2022 20:35:08 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 6 Sep 2022 20:35:08 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 6 Sep 2022 20:35:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMTDzdYKqeW1t/+zt+Yv0Mt1td7b/aTo/Q536g/38C3PPHdP7L0Mag0tQAn9VGb9eMJuLkGyqnM9IAj5UkLz8TdOwbHtKV1raKm19b04MwAvyY9cTmtN56IXlrXcL1CfDZZf5GDY2Z/b2lfiwOCh+oveascGQDTgx5rrWRR71n5Lvi4vZusuPTNoy77fNniCev4S221vqBxfnUYc01ZaYF6t6KPIs4hQ7Pszv+m3nCmb5jPEn9ZDLN3QrpGWhk/Vh9w8gOSWOZGtK25E9fc67kAKEWpSyV7AjMuBrgyGpJHzPiitY0LokCdBWuUdsw12j/Czp4UoANL82gS6Zok29Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V/fMMmHG7PoelfGBkaeKcTrsuqXzdA8F+/jASW1bETg=; b=GrVbFrtYjPMZmDY9uU4S10tpMdx8h6qWcVwFKAMQ23hPSY2qCqtnTUC4UsDo9L+UDu63lgPUEKIpPztNZzg7dzB4+/kZ6/dfXoe/BplJmXvbIkFWVffPYxCkORZLPIFNAPncX2IWl0IclbDoQGc9cLpuPbCC3to2dnUDv3kOf6WGPxU8QOy2Fhj8vcGhR6mXH9G8JTdDBc8Ot9JdGD1rRUz93VYcJ6ITghGL4ok0HGERcdAA2qVR3bVNb3QBNr+bayjGvxGWWIh7p7pu8oz40Mhn/fbT1RLUyb6L04s5AmvWv9tXM3uTlqb2QhjAWXSCJCUC7tFoFgauA0d72EQR1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by MWHPR11MB1584.namprd11.prod.outlook.com (2603:10b6:301:e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 03:34:52 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::613a:668:ad30:2cb6]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::613a:668:ad30:2cb6%3]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 03:34:51 +0000 From: "Chiu, Chasel" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH v1 4/7] IntelFsp2WrapperPkg: Fix code formatting errors Thread-Topic: [PATCH v1 4/7] IntelFsp2WrapperPkg: Fix code formatting errors Thread-Index: AQHYwmi3hP9c7ADihEWz8OjDmV/Moa3TUKNg Date: Wed, 7 Sep 2022 03:34:51 +0000 Message-ID: References: <20220907031914.397-1-mikuback@linux.microsoft.com> <20220907031914.397-5-mikuback@linux.microsoft.com> In-Reply-To: <20220907031914.397-5-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc039ab1-d335-4574-d52c-08da9081ec7c x-ms-traffictypediagnostic: MWHPR11MB1584:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zn15liCWJ9Z32VtPGV8Lkx0zH4zo79ntP34D0zL+v15Q851hbKSeiQzOV8WEDnSIsjV/5BMdfnOuASwRBnbz2IMjnq1kxcV7eBvuk/1rXSckUNEBtMk2W3zj7lxNbQKGMhlnXGLCxis6QTvkp+L3fiDPVcYY2P2Bzsm3SGgtd1JaV9xIJeQxx3Npln4d+GHLJ2+xSSEpPwaBnr2Xkpvjer2F3VHPfzNm6Vqg30GMMd6XMzK9HMlW7B8XwqQO4mQSwNX5h4dAwOyyT3xDw9vJky9PIXC3/p4XDZvWRsDGkWL/R42Fp44D5eelYgNfuI7BpaNvZVHuYQqGT3/218g/9KKM8DuGLu6/LMB2Us/3PtK79RTH3szP0N/QgKn3wAJ2XvgjIoUuy60so4tmz/iUZDTXckL3gkyhohADwXAxAb5mHe4uAG0/bHZeDTdJFzg7LhSKczqTDsgKtb2AwkZifYyKHwEuXhsaMdyPO7kNhTXp/OIyFOobKVch9dCibIKbnArbzOA1qlilfMxrim8rTQerMkZGVr2bTz2PzhbiBW0dIKiRGz4VLqxtIuJVQdozxh7Reqvfv8WiIyHNAT6SCPjMRc+8JLLRYzhonrfL+ddMnsymUQFAeocv+Uhvs+XO8HXsTohHuocVhBfUEPIt9jR3l458feQ699iR8SRYS+fKMCm20ROsnJS5+i8mvs9+KoZgnuz5PqrWS9bEsfZ0vL6rO/jB6J/nk1fvN9YRcdFy+Cr4ruM4qZcKRnWsGuKJdshhNvdcS00wVElrzOU+hDhdSHBO8Cur85auCIy69BQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(39860400002)(346002)(366004)(136003)(38100700002)(122000001)(186003)(54906003)(316002)(71200400001)(110136005)(55016003)(8676002)(66946007)(76116006)(66556008)(41300700001)(83380400001)(52536014)(64756008)(66446008)(9686003)(26005)(38070700005)(107886003)(4326008)(2906002)(86362001)(66476007)(53546011)(5660300002)(7696005)(478600001)(33656002)(8936002)(82960400001)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h716F5swygoIYPYW6PhdLTKFXzRIIpHInUHnljxVsmo1WnyrtsHMCN4xM+Sb?= =?us-ascii?Q?lNx6Iwzh7oujjXAjGjvBBjXgBi5f7glkQDHHkn14RMAClIkqQAI4rZNzt+9u?= =?us-ascii?Q?5NAYg1ZqFipkEWVodg7eO9onHWY7tMtWzAIgR3IITZZ2g2DtWkeMZ76FKmpx?= =?us-ascii?Q?Hr4TVFu32IAcUdAwVN0YUImq1yD5rH6YA/Cyp/vDQU5JI7W7cO2gp7IqmRGp?= =?us-ascii?Q?9TmwFI2ObNPMTlcHOsJJh9jsY01c6eaeF70shOs4K/wOwObC2V0UgDeE9zTW?= =?us-ascii?Q?/Poia0aSkEY1vczp1XpesQqqTUVwfS16eQlG7O3sHDPbIrgxneJUzrn0FKCN?= =?us-ascii?Q?OuEgIRStmKXWjmNnbG+3s+6jNzF5zq5t6veVz6voZ5g+AdfUBQyAVf7YOtKr?= =?us-ascii?Q?G8LOU5lyArknjy2+VFMBLnAPQRQ7d2xb7kSP8g21Khe73198DCCfO1CoXV25?= =?us-ascii?Q?fXXjwjz6iFRW2AvggY98rEQWM8MAfZ+RmFrsjahttfQ5vREeL23L9tlqHTM7?= =?us-ascii?Q?hzbCl2iIQ6Hq89JnjSe+37SE3PGUZ6psDto/lWO+1X+ea4uUnmrjmMou1efZ?= =?us-ascii?Q?E+crQ8Nnn7vC+iIg3jeaEPlRLK2AfPAmf+ygnX+Y77FveGEdUuVJJqcQrRbm?= =?us-ascii?Q?tQcq+a+5V/JKTf0YwO76FiUv2FaK8Cvz1fVZ9j0lXrteZbNj1gJiPf7lVJ7v?= =?us-ascii?Q?fYRjyrTBr/6zvLjcaJ8sIUyn78xHifpTdtdhr1+n/SEYmb6WRxa9AjFNS04m?= =?us-ascii?Q?RPc5jd7Y0zyeNWc7OJBpuIbXyXHX+jN9jCRjfkMQj01oNZdIdi6FPFCfFj8Y?= =?us-ascii?Q?WCAPmMSTG5BrdhgXDpMgM13+brh/CK/oO9Diy1dlCSIoOGmbjeV3vng9Cf+O?= =?us-ascii?Q?iryKp7biDun9o27ImhP1h5itya7EaeWaO0WkJbbJdv1qG0ujSlYzN74q/UsS?= =?us-ascii?Q?TtU9EG0F+lgJHHCtQzOZvIrTOPKgSL07DWhohYc4Cwh+O+GpLYiG2TiheV5E?= =?us-ascii?Q?B18QheYWrmT9NyQjbP6Lmu/eXPf1D9H76t/y/J9AK4TZ0KM8DrgskRHT603F?= =?us-ascii?Q?uFj9b824jiMGvTlsHCo7HX3/rfmjNp4JxnaZFuvlEQfHYOk9AcUgPueMjbX/?= =?us-ascii?Q?WGHDhGfteAhtDZ4McbnRBht73t5DeETjewjYPGf9DO8cy6yTvchlLArRkvZg?= =?us-ascii?Q?ngOEvNj3YWIHxVyw3POqzuiOPR7jlO42unvvAIbN52pcddyA9BxtAtl2cBLb?= =?us-ascii?Q?oA/zyKNNObjo/AKgw1Dp4eAeuWYlhOXkHlQ2sZgXWlRXTX4z1BsYRhFR+jyK?= =?us-ascii?Q?eS4GctexB9jkdVFFYprUdJtalENN6gdI35Xbav/6SY9IL0bnq805Gnpbtp69?= =?us-ascii?Q?njOd5yz/+8dOQHu4JXBO+n31Y8QsQZk584eEOYF6GAoAEQc3eK9R9D5F6jJp?= =?us-ascii?Q?F04jchpU7RGCIR6R475zcvXxksoNyRKtferiL8I0ZJ5GYBSPzb70IPTYyXkI?= =?us-ascii?Q?c8JtJdH+JBamMFb5TimgSWwRCXXxI/pl014i8RBB8epXfjEmBSPcodD8ZiyY?= =?us-ascii?Q?hOGvmR5aAEpmoT7ufeWiyx+VJiwVQ6z8JEQO83rB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc039ab1-d335-4574-d52c-08da9081ec7c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 03:34:51.8974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eWzlba0u3fvd8xg+kXU+sjZJTvCY2s2NCYLJIQlxwegfuWzKcAPNlis//Dl9LxcSMWu/ZGKm7gByfXgO7GtEUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1584 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Tuesday, September 6, 2022 8:19 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v1 4/7] IntelFsp2WrapperPkg: Fix code formatting errors >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 >=20 > This package did not have CI enabled so code changes were merged that fai= l > uncrustify formatting. This change updates those files to include uncusti= fy > formatting. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Michael Kubacki > --- > IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c > | 4 ++++ > IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c > | 1 - >=20 > IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamInit > Data.c | 8 ++++---- > 3 files changed, 8 insertions(+), 5 deletions(-) >=20 > diff --git > a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c > b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c > index 5b5beb5c6557..2e82a0c1b59a 100644 > --- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c > +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib. > +++ c > @@ -115,6 +115,7 @@ CallFspNotifyPhase ( > } else { > Status =3D Execute64BitCode ((UINTN)NotifyPhaseApi, > (UINTN)NotifyPhaseParams, (UINTN)NULL); > } > + > SetInterruptState (InterruptState); >=20 > return Status; > @@ -152,6 +153,7 @@ CallFspMemoryInit ( > } else { > Status =3D Execute64BitCode ((UINTN)FspMemoryInitApi, > (UINTN)FspmUpdDataPtr, (UINTN)HobListPtr); > } > + > SetInterruptState (InterruptState); >=20 > return Status; > @@ -187,6 +189,7 @@ CallTempRamExit ( > } else { > Status =3D Execute64BitCode ((UINTN)TempRamExitApi, > (UINTN)TempRamExitParam, (UINTN)NULL); > } > + > SetInterruptState (InterruptState); >=20 > return Status; > @@ -222,6 +225,7 @@ CallFspSiliconInit ( > } else { > Status =3D Execute64BitCode ((UINTN)FspSiliconInitApi, > (UINTN)FspsUpdDataPtr, (UINTN)NULL); > } > + > SetInterruptState (InterruptState); >=20 > return Status; > diff --git > a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c > b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c > index a17ca7dcabe8..c8248eb88851 100644 > --- > a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c > +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExec > +++ ute.c > @@ -69,4 +69,3 @@ Execute64BitCode ( > { > return EFI_UNSUPPORTED; > } > - > diff --git > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI > nitData.c > b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI > nitData.c > index d2acb2fd46cd..fb0d9a8683a9 100644 > --- > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI > nitData.c > +++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecR > +++ amInitData.c > @@ -10,10 +10,10 @@ > #include >=20 > typedef struct { > - EFI_PHYSICAL_ADDRESS MicrocodeRegionBase; > - UINT64 MicrocodeRegionSize; > - EFI_PHYSICAL_ADDRESS CodeRegionBase; > - UINT64 CodeRegionSize; > + EFI_PHYSICAL_ADDRESS MicrocodeRegionBase; > + UINT64 MicrocodeRegionSize; > + EFI_PHYSICAL_ADDRESS CodeRegionBase; > + UINT64 CodeRegionSize; > } FSPT_CORE_UPD; >=20 > typedef struct { > -- > 2.28.0.windows.1