From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.241.1652838079602929034 for ; Tue, 17 May 2022 18:41:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Eb6LHOyP; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652838079; x=1684374079; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gGtzxAkznS64b3iS+WmZHzrlXXzGcDtx53CELErxXKM=; b=Eb6LHOyPdnAQXxUvDxjdbjaQkx1V9e2M1JZyIgnQASSVaWWasZcgtR+T 0LYSDAGGe8nhr0whr0eYSiVYw3LOiZuajAjX+wUNAizi2RVNVAQgAE+Yy UKSz5AkTfvkWAtCqF0fPFyGPnkLojnRZB42pRkHS/ox/Opa4VGWwQXyKE nypwxVVWs+EnKylU/LoLCxWCYRANl1zQQWqQhYFCQi90BY9kQo4duBp1F /dwG+UHHn8n61/F/KjAcV4xSqhskx2ln6qB7vRuYLzwtdgPEoJcwiQUOj a8FTum2/3OBB8l5IRChJHlaBhkgTEu1cQAvEAp6635aP3O9O2vyMg08bj w==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="251936132" X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="251936132" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 18:41:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="569186810" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga007.jf.intel.com with ESMTP; 17 May 2022 18:41:18 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 18:41:18 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 18:41:18 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 18:41:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nlLwdcN+jz5geCHFaYSc2HMu2E2tIvNsxqjsMtZWoZj6SCtmGa33mL+qR/bJrKbhllBYjMulK6Kz9b/22cdq6hVWq6Bb7sClEUOaWIinrC+D3s7y/xnAorxG1pOvezqytGjB6p9M8cVRWL/P4Yefd7KXXe7LAXEHbnemOWaZurfuZ456fH7hCROnhh0UScN+xC25W68o/PJAar2Jm8fOiVOalhYZ0VSA2sBkk8SWtQFn9mr0Jv86VN5Va2gDZsHy7n6U+6ZWN832YhIQyff7oLLETg7IYdrOyQGKHHIfhtgEpCb+nNaXe+VZWEqHJ4oEiCH3hez1YGEYpdfwSY5ZNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LNTbxDKQyazoO9MtZW7ESeoVCROUUUq8/AMJpbn+nZs=; b=jW8opk//x+tiipI+JMNJ2ylT5XAc6vQjU+sKACbDdS7YyM1S5Rkgd3LV7G9FwY9GI9uZZ/CZS3haM5Gu7GWw/FPd00apET0EjvGGHy/tjRh/078g49iE/q7DdsjhMke2ShR6M3vg3uLYoAOLkIUEitzwgAK20+iUyfEdASbeLJkUwVT7466PMDqUudm8/STcJVt68nLb0oGIzcaRQ4l7TdfsR0l2Aac79dJthPcpDSuAqABPwlpoAjW6a32YxL/qs3YgtR3BCuXN9jtQ0m2DcdxPm+SESB9bg5AUv2ZeVo9k9IbNVlikOPQW33B8Ff38PffdLr8c+/4hg2Evwy7HkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by MN2PR11MB4189.namprd11.prod.outlook.com (2603:10b6:208:139::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.15; Wed, 18 May 2022 01:41:14 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c076:6436:db8e:ee22]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c076:6436:db8e:ee22%8]) with mapi id 15.20.5250.018; Wed, 18 May 2022 01:41:14 +0000 From: "Chiu, Chasel" To: "Duggapu, Chinni B" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "S, Ashraf Ali" Subject: Re: [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention Thread-Topic: [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call must follow X64 Calling Convention Thread-Index: AQHYacpUjxV6uzGesUq8ZApqXJwbYK0j3Qig Date: Wed, 18 May 2022 01:41:14 +0000 Message-ID: References: <20220517084401.1805-1-chinni.b.duggapu@intel.com> <20220517084401.1805-3-chinni.b.duggapu@intel.com> In-Reply-To: <20220517084401.1805-3-chinni.b.duggapu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e40d761a-1d50-4525-9812-08da386f7ec3 x-ms-traffictypediagnostic: MN2PR11MB4189:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lgk+uo9WykVIuy3qMb6X8l3Ng4RlozSs1Ik9vqPLLc/l9m5qRO1WwpLPF3xfSiwIz3MH0giWn/bJgGABynLvmLTGYRp00SK38/YHAP/MnZkcK/7GMbsHEdX9oYLynWol14QCt1VserMSwqHG/y4FchtOaq5Fywh/ECN9hSl1BU6YqMGxB5ZnGqJrgXnSDJmLNPoeXW7fCe0R7OQJfog0+Y6sH/2+gJCWOp7J1zW2v0kBCg+D3KNjdIJbq2hBdy8ZRin1BNjYNFafX+UbJeJB4oaGaddnXqtx4vO/9197dchw+XAYsMMvtqViZ3fmJ3YQerk9cMMouDRWoCMFFKiMB7VZfO06HUbRVowTo24FaBcDBYce1zlxFqP8R8uAYEU2pcQlax7lT3kHa89yaOoNxDnd/dxsEmfDtkNQm44rSywacydnYEcwPRWSI0dLTMV54DtV9dR690LnWoxmNb7+8Yww3ntlVM7QaI8RG+vYNbxh/A/tnKCS4XGjcX3wo18Fy7j2XUg++5eOxD9L920Gb/LVskGJanNQn5cRRfmCCrGsDi06/eoZOdqCUWzxiVW6kfxMgOz7Zv/UnaDXtIHyk7okAtt/p/9QSi766dT4aaNytZvqJjsiIjzUsDiCPPFzI5f8dvcK1PDjub5kphgzm5daV5AOnvEn+jY9aZnG16pzjcGl7h16mZC35EGA4IjI9fk1AHQ+xXDe6rNeAEbWPm8L+PaV1xmPStUxANrD7YDs0to2n+YbIpTKUm7Yta+KAt56+NIWkG+3FXHoBskkSaSCXExqPJnDaeCh7CD4XpA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(122000001)(83380400001)(107886003)(316002)(9686003)(55016003)(6506007)(66556008)(66476007)(66946007)(66446008)(2906002)(71200400001)(508600001)(53546011)(52536014)(8936002)(38070700005)(26005)(76116006)(64756008)(4326008)(86362001)(82960400001)(7696005)(186003)(54906003)(110136005)(33656002)(38100700002)(5660300002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1fJ/8vj9whibZlOAP8W+/p+pUuRztSUKDvK+tjhnes/6mYHhBVQT7jhsuRNP?= =?us-ascii?Q?Ktw5z9TOi3b1oRsZTGZV1vZNtyG1G9yFhxqQ0foY/dIR7LNM3VvYQMS4yPbS?= =?us-ascii?Q?822bNUoskKBny+oKVDFuGhgw0M97wwicM8KnVCH3Rp8979kOZFnA3SbD09Xo?= =?us-ascii?Q?4F+F+RgEF1pia3ms3tOSf7Q5rkd4e8VeMdmqiTtFO3pXgG0J3bOFEFglVbDC?= =?us-ascii?Q?QSGxS6ITxTmaJsh6DReOFXggZDGl84kiCqQ10MGAeamMoEnOGXgHAA7eB1Ft?= =?us-ascii?Q?UH8pSzMzt9dkucemB3ezd6yxFcMZ4Via89CM8wYfh7neuxLJ0OWN/ExzYHou?= =?us-ascii?Q?+cLdh2nMrfI7pV3WZ4pDusSm6pW1hfGbemw/KV5HMkNl+sjmIVYNinPNS172?= =?us-ascii?Q?cCd4Oc9ahMCJPCj31L6EzonjgyjBcNsb0rV2RzLS9cmXnruWxg+6wh71LDJF?= =?us-ascii?Q?TREkhqENXGwseGj/t0ppObmAKcSFkNpwDGf+vszXBKBpeo7uTdyyzZgb73hP?= =?us-ascii?Q?Udf3WWYaIEZLwku7C6SDSNFJwpkolAvQkmqNjeWSOdeHaTD1l/xn0LANSsJ2?= =?us-ascii?Q?8zJPC6mSFyfQn3BgzqEHLx9kQxHG6L/lbfJVRrKH2PHGx6MH72qZwrSR3YFn?= =?us-ascii?Q?e4s7s6SmwFkx1Hwp8ETCkx5N0/HuR9Q+Jw0eDd8mA9Pq3qlsIYTJG8W5fNJV?= =?us-ascii?Q?juNkmQT7WWwzUASJbUSf7QV3nB29f+U2O2b70B6CzKwZlAlIppK4CAA5OpW9?= =?us-ascii?Q?HOrgfAEEfyCyg96o1c+I+BGRV2vPpGVvPLxB4uW7LTiQQ7txPpUF9yIPziL/?= =?us-ascii?Q?AVEtwZ36stIVn1C/9/DyFwrGABBNSzZYjv9KDV6oHZaCfNwbR2kZ4W8PAy8E?= =?us-ascii?Q?JhI0E4+MN5BWXFKu+yyuaujR3SPbLKO023l9n4MOmLWkODCfLJFghPHlPgWP?= =?us-ascii?Q?u3sP4yhKyoS8IFTQ03ZdNH9+egpTlvc5DDH8TySoUElL13ggbGVPHY1WsCvR?= =?us-ascii?Q?DGuNf6OFevPtv8AE7qXwteqrX8o637VDUPgOXZTcgSXEai/6o86Owc/r0zAc?= =?us-ascii?Q?TB+2R188tH0TjbTCYIBAy5txMSwZwaxW5/7ygaLiq7q8BielsDvPEWlaysbS?= =?us-ascii?Q?RNDR9BkAilWpKGBrG4yhCDNGWyhdLOkTHIh7+l5f9ggLQ/jLKTkURYsuNfrD?= =?us-ascii?Q?tyiuAXkf9Y+x0hJbQWvbl2vLhD5v3BGQlXvWkX/fumPjM/4HTlE4LAqHk4aH?= =?us-ascii?Q?rGxqUHJgtJXPFoPBXn8VjM7ExQfLLpp45fHW3983u729QW7wpSnU3hzGtDF7?= =?us-ascii?Q?vJD58ntrPcVw3C8Yp5X2bqVVPx50bDEOL8v6k3JS5t4Xu96Socwtu6DtS7dK?= =?us-ascii?Q?xz2sdqZRKmrUeL6/mWJfsgGp2tva72HJiDR3NzOwEOcpm0HWHOohLFSFitXM?= =?us-ascii?Q?CzlQKrt/xOnj9rtgQyg8fTV/Ylk4zxLejKmrrh2e724WSpKIXnfahpJ9L5er?= =?us-ascii?Q?7MFrb1dZ9dOxKoicochY5eGJMXtVk9FeVZKpA4Aso1kdJ2udPcLFD0+MPrt5?= =?us-ascii?Q?0Gbx4YKBGVBZfaxCO5UJtcr639Da0ZXntsAOKL8InzwbFfcmf4WMM8v3ssPZ?= =?us-ascii?Q?HWNTSCnHBabsxXHxYbwiiCE+7aMhvEZtFdSjFzfvF0Ygb5JF+9AUC/bDNgwm?= =?us-ascii?Q?GDB3x+ZRiDxIXLgk3/Z+HcfwBDxk+90pnqbt6SCksG7Bf9+MMr6BawqUmFML?= =?us-ascii?Q?cVMmKsf0XQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e40d761a-1d50-4525-9812-08da386f7ec3 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 01:41:14.5463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ph+8M/8UtItUJiBU+LTkwOGeCUQRVdNPd4iKPIIGglu9/Fiml1tsvMr18idpMwn4I9Nkb47zfxpw0guv6znwsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4189 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Chinni! Reviewed-by: Chasel Chiu > -----Original Message----- > From: Duggapu, Chinni B > Sent: Tuesday, May 17, 2022 4:44 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, > Ashraf Ali > Subject: [PATCH v5 2/2] IntelFsp2WrapperPkg: FSP_TEMP_RAM_INIT call > must follow X64 Calling Convention >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3926 > Pass Input parameters using RCX. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Ashraf Ali S > Signed-off-by: cbduggap > --- > .../SecFspWrapperPlatformSecLibSample/X64/SecEntry.nasm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64 > /SecEntry.nasm > b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64 > /SecEntry.nasm > index dbbf63336e..065d80d0e2 100644 > --- > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64 > /SecEntry.nasm > +++ > b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/X64 > /SecEntry.nasm > @@ -130,6 +130,9 @@ FspHeaderFound: > mov eax, dword [edi + FSP_HEADER_IMAGEBASE_OFFSET] >=20 > add eax, dword [edi + FSP_HEADER_TEMPRAMINIT_OFFSET] >=20 >=20 >=20 > + ; Pass Fsp T Udp pointer as Input parameter >=20 > + mov rcx, ASM_PFX(FsptUpdDataPtr) >=20 > + >=20 > ; Setup the hardcode stack >=20 > mov rsp, TempRamInitStack >=20 >=20 >=20 > @@ -167,5 +170,4 @@ FspApiFailed: > align 10h >=20 > TempRamInitStack: >=20 > DQ TempRamInitDone >=20 > - DQ ASM_PFX(FsptUpdDataPtr) ; TempRamInitParams >=20 >=20 >=20 > -- > 2.36.0.windows.1