From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.2474.1626235429579927884 for ; Tue, 13 Jul 2021 21:03:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=mqmfhI43; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10044"; a="210099270" X-IronPort-AV: E=Sophos;i="5.84,238,1620716400"; d="scan'208";a="210099270" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 21:03:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,238,1620716400"; d="scan'208";a="412661259" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 13 Jul 2021 21:03:48 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 13 Jul 2021 21:03:48 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 13 Jul 2021 21:03:48 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 13 Jul 2021 21:03:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ErFqxHZDd7RbBFs/eH9T92axe7KTh1Xe8LpUV8G7p4xStpGjpqKdj7uj8r4RhGRIQHL5u0+Zn35OFn4XguQnnhdNy1E+z2kc4sL8/gqfmJDTHdwkakkuviXeNk7GUXvbYVy4/2OfVa6eDcgQhgj8nizMTOPzd+Gy8/K3TMK8aSBcsRVmy5CARJu0676TVDOEYCX4B2qvsc0A7hrKbqvroe+9QLldqMw38zaC9k2lmwYFgu0IymN33eX02fiqBvYLP4+k6mk/oglOA9QX2fYmrJ+h7JxFCU0rlB+4BWabw6uxzbRg/tdXmGw1C18wpCQtVLJj+ObClJZgqTclvTj2LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EY1MupjWK5/5NH9z4wQaPHFI96v9SUXLqDPqJAY33y8=; b=SocFEvzvA+UxY7VU3zqWwGM1uGM0Rwzec5l9GGvnJppGkl8uGxRdEczriZ+i9b4nbslOakQDAW/Nf0CXYgPqfXZW6e0up3psFBtYAJC1UGFY8havoBBkcCqc3CbG/jj7cLAe+dcxOT7HRZEB/1RcyzQZHkyCNAntBV4UG9u93KPz9RqBEFGTUu/xfyZn+lyQ6d/wU+db6dpz444Q0w9TeJzjISkVkIe38H2kuPz70kOmufvA3VgeCEOft7JNhbQDm4Dc5cpAIuP6uPyIC3JVGEUgliFN9PztgpBOIlWXVauw5D8UM66URzSrLSPpXzgRWEe7zkvOv9wmucw8Cgbd8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EY1MupjWK5/5NH9z4wQaPHFI96v9SUXLqDPqJAY33y8=; b=mqmfhI43dx9wFCuoqe08OxVahS5tgCf9lzKinM2IBRc2+JrjNmBc/7nj9B2THG5Fc59lqNZh6ctVGPalQXemGnYbOrqW9zbZWU92BMDUcNgPxOn2Exu4OLQKBbvwj9uRfHFqumVU2yF+eazhn1OiP8Hxv4VOC2Z3xXzJXaIHuVs= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB1860.namprd11.prod.outlook.com (2603:10b6:404:102::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.24; Wed, 14 Jul 2021 04:03:47 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2%7]) with mapi id 15.20.4308.027; Wed, 14 Jul 2021 04:03:47 +0000 From: "Chiu, Chasel" To: "S, Ashraf Ali" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Desimone, Nathaniel L" , "Zeng, Star" , "Solanki, Digant H" , "V, Sangeetha" Subject: Re: [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber Should be UINT32 Thread-Topic: [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber Should be UINT32 Thread-Index: AQHXdJTBk39I94MTukWmjbGA3a5a0KtB4STg Date: Wed, 14 Jul 2021 04:03:46 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 960b4edf-52f7-4955-aed6-08d9467c612f x-ms-traffictypediagnostic: BN6PR11MB1860: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:901; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UTMSe3DClQ7ssAB1SaszgtnWLqWZOCscHSS3cy4mKZNElf6jj/jj5YsB/QQ1lw/FsRhK1DPpe4DVlcD8iwVnrXTOMLD69CB+in697aGSjLDbNf3qqlmTcLDYrgQCiszzLUTYpZB0xS5JSgWkImvBpMT+FaRv19nrEPyhd+N0l3s1U6hUEGtz0dtRZ09RLsFJN6kGcaITf/KqHjmQANwJuaVq/xTlkICh3irDnKEjT1fK7Ev0e2QzeBLVc+G0eGRVm/z+SDtasTUkoAm9v1jJvtdNec3XPRvIn4WVzjYxerTY4brUhBFf+rlQ9MOhpfZ5NJa84pajSm4bPIEd0ES6FIvY2gchL0UXwVTk7wHTPrc9Bh140DFH6gn9PPl6/Usr6n/mzD1joFP/ke0gyhIhrlcgoB+ne6RxNpqbaFjCsy1eOKk3wq7W08BgAxGNEsooCPEystYItQBJf/Y7V7nxbBVgBnrcqjythrdKNLEeXLd0SVGYat0AH58wTAaTpKupmGF6Wl+8a8QwF0EPB28uK6mk8xngURKJU21BMKxgh3Uk1Lj0qYCAGchz87IjRG+reD+IF0ZjaTBsPkJSe/NVhFOKkFsUehrP3GiiID/bPDxe041E+VxxIzth/P8zEGbLFdRU9u/uDIKn8P316e69bqzUSVKL8GMob3E1XgRZr2SU9Wy/6xEzbK/dhlkbnKWtEf5Stu+mw0CgBnRkEDl3gckKGLFDtBpduOiJKcwMED6oSVWXwQe5B1Fb695DLizDymUsbMx9WZfv9nrCpwHy9XFf67wAJ+KnY88ANJPwKxV8ByB7grOqT1lo35E//4vw x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(39860400002)(136003)(396003)(376002)(19627235002)(5660300002)(86362001)(66446008)(107886003)(71200400001)(2906002)(478600001)(8936002)(4326008)(83380400001)(8676002)(7696005)(66946007)(26005)(53546011)(33656002)(66556008)(316002)(76116006)(66476007)(122000001)(38100700002)(64756008)(186003)(9686003)(52536014)(54906003)(55016002)(110136005)(6506007)(11716005)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LNTRp+FZRY7WlO6WlLCzmBQT3keX6k3VTwHvi8Ts8S+T17hWFmhAeqX1kwYS?= =?us-ascii?Q?nX1V461tG5vJVlY+1mHvyHeigqJ3GabmieeG1iPkiXG71zpd1LNzf+uFShIA?= =?us-ascii?Q?1mAQD0N9nXKs4RJJRW6luOE5bFPSRzc67CoO9tqGxN1Bu6Ppd8mi/80jZa05?= =?us-ascii?Q?asrz2bJU7qoRLVcLNC19b7VY1TjlJxgT+3HQwFza7EXpZqJmySrO13En47H3?= =?us-ascii?Q?zPZgUm/Bxyd3kbmQjj5zxNP0hvRj/Vg+SPeAUjl/064CpWwZWD20F5Y/uPjU?= =?us-ascii?Q?GzkYr6Lmgx9hM4x1R/2jOgwJkZi0tyo1L/BQwoQMiwu4FpDBxyQUS0TEs/pf?= =?us-ascii?Q?66tRQ2ECMbSAOYDa6K196eha4uxnj3E4fQs5R/Mj7ww5HnrgElcurIzr0U8n?= =?us-ascii?Q?upTeP1bL/X07bfyusaTzUN5YG7sIuWLwNP+wtxz31czNivznlzknqHOxniyx?= =?us-ascii?Q?fKZ0VDeWboAbmYtPSCLochJy1RRdeUbR4lhXthmxoR4FMUBNLSJPiDSmc2oc?= =?us-ascii?Q?64ZwkJ0JDsn7pTf+jMySdaxjK3Iyc4BVEnTmhOoSeli2zwY3yb2LgKmK6YUo?= =?us-ascii?Q?nRYtlDJ+l1g6JjMaG9iV8Z0ySNyOvt95mu2ql7uwckm7yYdR4wrSGnak3ruM?= =?us-ascii?Q?npXTw6MglUUUUvjJQIUF0e+HjGouGNuxUhCh5sAkHJDFUTvXQKVfH6Wudvgn?= =?us-ascii?Q?j7GJ5zXRS0cxomYxRq6QLHuNb8zVHm1ENX0PjaAJwjOrdZcFzx5EHfquaOAH?= =?us-ascii?Q?kzXQTGFLyWYZ3pe0gui0m5pTDYL7LGlGjC8qF7OOHzVaNE6lsGxKaZR6tfXm?= =?us-ascii?Q?VZ8SR9PkC3TeyK2pvVrbBFP8/0PD036jN1TntRqDNIkeJsNk5gYRS7RCqLji?= =?us-ascii?Q?KTPFhU3oiRQl4DUkwqD+esKfnGSzRob/4ntQkBqrD5VFkmtlaqA3v50pG/uu?= =?us-ascii?Q?BslIRUxK6SYynCFMLaTvgZir8mwIDHJMFOpeMz6GAXlyIpGmvJ++RYhyBQtX?= =?us-ascii?Q?5YxdGkg+ztP1/9Al27N0EtrTn1fgBLRjaNOl6a18PWcWitVNemRC5SlJoM72?= =?us-ascii?Q?kz5QmvXihVRUBXopEO969W77wLrXX1wQcBUA5ts2PwxQUQKCbD7AGHuefQOU?= =?us-ascii?Q?d1PWTYp2zayXuOw84OC5u48046xXmkZy3mAN3OmVmIKVHJr4D77LvR4L/wnk?= =?us-ascii?Q?GwAD/S9EdRVeqWpCvKO7IE0eaBSo5UOJ1EQReXSdqMsBnUZVOms4+5oLHqpd?= =?us-ascii?Q?guKtuZ54xBOSw/hOapc/Hw55f2sMmr4b8QSzwpKA4fpOgLG8EjMQR1xCp8+U?= =?us-ascii?Q?qCX+5boQrdE6MFuK5VenOXZD?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 960b4edf-52f7-4955-aed6-08d9467c612f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 04:03:46.8456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q2GCA5Izr6rgxXXtkiTuvCjv4fp712wMqsiseYT9EbbrQA6dvH6J2GOdwuBd0+qqB6GShxS/XW8c2uWxZS0UqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1860 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch pushed: 91f5d3b41043b8a0c8a5ed00e1c88bca4a777067 Thanks, Chasel > -----Original Message----- > From: S, Ashraf Ali > Sent: Friday, July 9, 2021 3:33 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; C= hiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Solan= ki, > Digant H ; V, Sangeetha > Subject: [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber > Should be UINT32 >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3485 >=20 > CacheLib EfiProgramMtrr Function takes MTRR number as a input parameter, = in > the function the parameter is defined as UINTN were as the caller calling= MTTR > number in UINT32. >=20 > Signed-off-by: Ashraf Ali S > Cc: Ray Ni > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Digant H Solanki > Cc: Sangeetha V > --- > IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf | 4 ++-- > IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf > b/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf > index d9034bcbaf..9a513fb6df 100644 > --- a/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf > +++ b/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Instance of BaseCache. > # > -# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2014 - 2021, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -15,7 +15,7 @@ > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D CacheLib >=20 > -[Sources.IA32] > +[Sources] > CacheLib.c > CacheLibInternal.h >=20 > diff --git a/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c > b/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c > index 17e895c345..2365f7514e 100644 > --- a/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c > +++ b/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2021, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -164,7 +164,7 @@ EfiRecoverCacheMtrr ( **/ VOID EfiProgramMtrr ( > - IN UINTN MtrrNumber, > + IN UINT32 MtrrNumber, > IN EFI_PHYSICAL_ADDRESS MemoryAddress, > IN UINT64 MemoryLength, > IN EFI_MEMORY_CACHE_TYPE MemoryCacheType, > -- > 2.30.2.windows.1