From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.38140.1681289941285766164 for ; Wed, 12 Apr 2023 01:59:01 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=h2qNbm1X; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681289941; x=1712825941; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=6qDzqI7eunZCGyZTZyoDvQYxTai8+ikA274sNCyxSBE=; b=h2qNbm1Xs8wqNEXFQTOymu0+RDAXk8CB/CjteZ9M6iL/05Zq09wDypDg fT8VCoFhgUAXnnBA6UXGaOufTdJOaO9vqcBGp0hKienxT8KeQSyYJhD8y E7cnm2GI2oK0hCl6+g7MB3rKcii8g37ql/7NmQSpZfj3WGz40yinfGrdM 3fbWdaSp0cfzEXG0KRHrG1kJWaVAk5svS3sh2Kqlb3IbzAKQ9R94OXx8l rbEajyJT+mtqi+2V7Ad3wireCcZbVPcg9r/amnEkLBu9zDqeUCA8gl3SX GCXyvwQwF+1L4dQN+deZmmyqNzcyDlgnG359OloMm2fAFPtb7JLxuClGE A==; X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="342598148" X-IronPort-AV: E=Sophos;i="5.98,338,1673942400"; d="scan'208";a="342598148" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2023 01:59:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="1018672105" X-IronPort-AV: E=Sophos;i="5.98,338,1673942400"; d="scan'208";a="1018672105" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 12 Apr 2023 01:58:59 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Apr 2023 01:58:59 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 12 Apr 2023 01:58:59 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 12 Apr 2023 01:58:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XG4rhhSL7yXOuwAr8YJ4AycI+qCMLjTz9h11/iuGwA0RY4ZeqFjBvj6zx3DNtAF7iMCOe6Pve1xkCvFTVv2h8l9uo6qte9xsUUnNIXiYKhG4prubCaLPfsszrssqe+T7QI9WkPsz59ktQF5BGcLSXeO0rd4oDrHpWKWAsXV+3Uc9vVf+UOy1gBdrWH1BLJAJUI2RV+BwZkD9CyFLBdUWHpbg0piZD15rbkZAC38oT4U7/qEV+uznBE05qaQDEVtz16m/ebOlO/s7d6g/ouQaW4H6J5f1yNMW6ffLoEq1jeI89BKaWgViIpseVwXqv3YXjiuent++pwEA37AKZ/HkWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=swgdXLJUQ2cRtHFcTxmnMqHGV1tz7M7+8EyI2SEgLrI=; b=NJdp7q7TamO/2P2u9lbzeobhKWdYatklDNHFYi/tjEdn/evtHzITu/YFKhvOWkdFhO/0jw8NQ3uZ1lqfRbw+k1C5Im/Fg5LKZaoJasEpkhXpHIeeSxIwXckXJSWn43AYP5Pw607SJo2rEgyj8xWngN3aEUw5aeOexF9IU2Wl4jY/RTdwa7G7eAZzGF1rzrw+Wi9gJIChFFnRS7Be7H8dh3O1jrN2sOhNsk7bWTsYFDfYgA7GvJIM4m8Xe/V/EHioRuczzKSrq9SUcJYDZI6+iCK48Co7+p8Zw3o5Z+m+KkScdxQPy7Q9FhwB7K8Qcsgcj+bOphX/oRVHI1ICww56oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by LV2PR11MB5976.namprd11.prod.outlook.com (2603:10b6:408:17c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Wed, 12 Apr 2023 08:58:57 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a%6]) with mapi id 15.20.6277.038; Wed, 12 Apr 2023 08:58:57 +0000 From: "duntan" To: "devel@edk2.groups.io" , Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table Thread-Topic: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table Thread-Index: AQHZbRyoGhev/k0Lh0ak5MT8foi7/q8nXyQw Date: Wed, 12 Apr 2023 08:58:57 +0000 Message-ID: References: <1755241E6695EAE7.1885@groups.io> In-Reply-To: <1755241E6695EAE7.1885@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|LV2PR11MB5976:EE_ x-ms-office365-filtering-correlation-id: ccaaf927-6d3b-47d8-f52d-08db3b34265f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CUrP3Fl77mYbgDyU6OvmKv+VzK221UnSrBSteG70jHQez/JbiXAqXv3ixXtiPDww19jo7xhVlPWBpMrhGdqWKl3Hjg35pYt2h0t8Yw1l5/xLXAn7tmXes9Q2LpJHi3EfjD+7zfUYhVcHff6vU0QrComc6t7wIbepVsuritu0/4/lH5mkzlsQxJDrCfuPo8CovyJvN6Fbwgw2zURL6dgMR8YgYTjTO1r2R9bNl4KzFm2T2VwJxuunX9qNZIEkxtyVzDDcf9BTBsLcjsMLrkj7wezYK/ASyBXXK5u0jhR33MUkt0WvksI5zcKsgSSpiRkYBxhC+NRbkJqOcv+nrxXaaORYZhg0+bQPHZAm/b7fAdiLycoNAPKsHdqEzRjUi0oNFnY66V872fitvzv+I0z9RcZbJkVtg9QCV5NZE6ywruK7hMmEqVlYAPXvXYCbY1Zd4PiUSmXMcvshX4ffWKolfyMQ3p9hP9zmhucnfM1NAvmbVcYMAm3h3yufnGqof0TxFtJPyKZE/qWyS3WkpsL+SlBXqlfs0PkpEcK57S0nawVB7Ecj0uk8nh33dvuYEh6CX9ZuIxbN24VqkfkW1+WJhwjpGy9b/5SJV50GSAzs3nymdHTVtYHPFm8ssPwUi+sBM8l/eyGeYodaKSg8MK0JGw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(396003)(366004)(346002)(376002)(451199021)(71200400001)(478600001)(33656002)(966005)(26005)(7696005)(9686003)(6506007)(122000001)(41300700001)(82960400001)(66556008)(316002)(66446008)(19627235002)(76116006)(64756008)(66476007)(53546011)(186003)(83380400001)(66946007)(52536014)(2906002)(5660300002)(110136005)(15650500001)(38070700005)(86362001)(66899021)(8676002)(38100700002)(55016003)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/B5W8VqpRCdmpZQN8gnzmRzsP1EpMRJKUaKO9Sj5vN8E5pEp2z5IMgwNnXZa?= =?us-ascii?Q?/5Eey5RNjwU6aDAghwB8sofAU+f6vuHhpQVknW/tUfMQ1aH66JHA+5iAH5Rf?= =?us-ascii?Q?zh/En8OyGaEVQ91ZxfTnGxgUOClgzAFe1F4LR8ElXQadY/VJa4YSZfVIWuKe?= =?us-ascii?Q?QDcPNLc4kdxiL6Pc38PfU9ug1B5LRB1Kh9sBF/aDr6edITwfa9E0TqsqrAWE?= =?us-ascii?Q?Xfet3XHMXHpHWX245YG5vk2806pEm1E7hInHiVLJ1b3tjM8gYcL3zbLSKObh?= =?us-ascii?Q?waaET1xjVvJ7R7Nsjxid4qL6fuVKUasamB2iTdfmgxbg5d88h/1l8rFBE+KQ?= =?us-ascii?Q?LPCRgnG95RJvTI44D/8O6ANFlhnm7mdEuU53h+MXPXumF3N2kKGkvJJ/Sovf?= =?us-ascii?Q?oN80l6tprM+aOCFvQ/lGIHXMnZlO3h54133SIlRoxnXarX9wdICILG+y5d78?= =?us-ascii?Q?mSmTHNLc9QZ6jhtccHK4JtSfcoPzYq+Ybdise5F0YoyC2LYfW3M4/2FXjbda?= =?us-ascii?Q?zKgF8oE2Qli7QV9dgmhZJrO3aw7OkTWHYAQdu5lG30JWp+6au1gTCYm6IZmJ?= =?us-ascii?Q?8fI87d60Vqpzmv5OFY0p5SVJygsmypXE5K/nhWAg/NO7GZeTjq2uVUzSJ8xC?= =?us-ascii?Q?eXuCbtHsVLPekRNkxqY1ZQNly1UsFhcH49udw+kGAZiDILeKInwupDK9SCuh?= =?us-ascii?Q?vW+Hq2nRxB0w9cCpEyT4xQjLRYKYsMFVv75XCJeZ9mpoD2m3RGu7g31tIQiT?= =?us-ascii?Q?4vpZO76JfktLspozIka6XGVCdlaigcbP5brmWqwjatVmVJrKB0QkX7wVtug8?= =?us-ascii?Q?WUPnnrUnT6/zTLWHqMl9ly3QWy5ara6L2ZrZgohlUO9wmxu6k2N21DMnrBBR?= =?us-ascii?Q?zQOFqpzofHwoowv7lWFAK/eaa3QD4z2cx/pk1X/fys8DAX3QdjaRfJJvrXTZ?= =?us-ascii?Q?XT3DT+UpkORH8ExZ64BO60RegwKifsIhF3TJBLC04KF5R6srZFNUqhiPVnqY?= =?us-ascii?Q?LCLmZVLM6oF9SU0EsUnnA7Ibt9eL8GDyjXz8bgkoJUAY1j1ZQYkP661wEyF1?= =?us-ascii?Q?i9KN3RSzHhysNWqchHYTNEGykb8sYCyVR1ILs9EY7dAbxaErxEFDeC+VmSDO?= =?us-ascii?Q?rYt+8l9PxM1+/KlAr8RumSQSpSQAoSEGEz7LazyYOIucClzvQOjU9QUZWmRn?= =?us-ascii?Q?59JNPQtYUd7eL3VFD9Y3svhLx8i8pADw9BnZlwUzm21lloJlU189g/pxSHk+?= =?us-ascii?Q?FBLoqXmEBofqczHDgIpI4LefbWQwO2JLRbqbVXds2rh5mNU4+T+PHrhXIfp/?= =?us-ascii?Q?IRMBTnkwgZQ2OfTRk/Kana3vqIdSiYRMsqjvac6KDIC0SxbQ/7tBhIYaA+/c?= =?us-ascii?Q?lAwTMPa5hbG6r1yWLLzS//lkRpCs7UklcGy0xXKCB7m6XcKPeNXQ2VBOxXX1?= =?us-ascii?Q?gYU+o8UMtWMA9RRCcE6dahN24C+WOOn044/Ep2BuGA0mGT62PMc5ok7+2dij?= =?us-ascii?Q?xg7DpmraBYkpn2I4E4a2aTZ5dxWRWVB138hRd+HnAIcj36Rb7YuUyf1EkKmK?= =?us-ascii?Q?SeTDJ+UGkRTdeUcniyE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccaaf927-6d3b-47d8-f52d-08db3b34265f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2023 08:58:57.0747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Rrwe9h+RSuW1fVi0CG/zkdDVG8BzfMg6eEyByICZw8UPki+pNoLH1xJ7r99MC1vBmaRaRKMGDHi+X5fuLqydw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB5976 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gerd, OvmfPkg/OvmfPkgIa32X64.dsc fails to build with first version patch set is b= ecause that CpuPageTableLib is not in OvmfPkg DSC files. The reason why I d= idn't add CpuPageTableLib into OvmfPkg DSC files is because a previous patc= h I sent before '[Patch V2 4/8] OvmfPkg: Add CpuPageTableLib required by Dx= eIpl in DSC file' contains the changes to do this. In the V2 patch, I add a temp patch 'OvmfPkg: Add CpuPageTableLib required = by PiSmmCpuDxe' to add CpuPageTableLib into OvmfPkg DSC files. This temp pa= tch will be removed after DxeIpl page table related code is merged. You can= directly test the V2 patch set. Thanks for helping to test. Thanks, Dun -----Original Message----- From: devel@edk2.groups.io On Behalf Of duntan Sent: Wednesday, April 12, 2023 4:54 PM To: devel@edk2.groups.io Subject: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and upda= te smm page table In V2 patch set: 1.In 'Refinement to code about updating smm page table', use QuickSort() in= BaseLib instead or PerformQuickSort() in BaseSortLib. 2.Remove the patch to add BaseSortLib in DSC file. 3.Add a new patch to add CpuPageTableLib in UefiCpuPkg.dsc. 4.Add a temp patch to add CpuPageTableLib in OvmfPkg dsc files for test(A p= revious patch I sent before '[Patch V2 4/8] OvmfPkg: Add CpuPageTableLib re= quired by DxeIpl in DSC file' contains all the changes in this patch) Dun Tan (8): OvmfPkg: Add CpuPageTableLib required by PiSmmCpuDxe UefiPayloadPkg: Add CpuPageTableLib required by PiSmmCpuDxe UefiCpuPkg: Use CpuPageTableLib to convert SMM paging attribute. UefiCpuPkg/PiSmmCpuDxeSmm: Avoid setting non-present range to RO/NX UefiCpuPkg: Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h UefiCpuPkg: Refinement to current smm page table generation code UefiCpuPkg: Refinement to code about updating smm page table UefiCpuPkg/PiSmmCpuDxeSmm: Remove unnecessary function OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- OvmfPkg/OvmfPkgIa32.dsc | 3 ++- OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- OvmfPkg/OvmfPkgX64.dsc | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 5 +++-- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 3 +-- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmProfileArch.c | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 132 -----------------= ---------------------------------------------------------------------------= ---------------------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 8 ++++++-- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 97 +++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++--------------------------------= ----- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 1 + UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 629 +++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++-------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ------------ UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 348 +++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ------------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 229 +++++++++++++++++= +++++++++++++--------------------------------------------------------------= ---------------------------------------------------------------------------= -------------------------------------------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 3 +-- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmProfileArch.c | 19 ++---------------= -- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +- 17 files changed, 510 insertions(+), 977 deletions(-) --=20 2.39.1.windows.1