From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.14099.1681487805154064736 for ; Fri, 14 Apr 2023 08:56:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Os2vjsHG; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681487805; x=1713023805; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WEHQtAVB3drdK+RCA+1H+oLmy4aEL/wV37Z1j4jXkM0=; b=Os2vjsHGkFpnEmzfkkUKOjVUWCOTUgEt+1Xj1lSjxLjbqFqMv0MGSO1z jsoS2nMO4mbsfSHqNgCqkCe1Kmj5712ZJw4/S4OEV31jGni1S4krHnYaD 21c18WecInCUJWZXxxbbWlL+7MNjZG6hrYGzMy6d2SXqkyPwIbnK7YvuV kFLjpOxiT61eqbubxpPv1EkFGEleUSjeLuBQSFd1scdT8i8cPgTr8Rpat LZiNW6hUUmwCzXAPjPmr49z/FzjqKxbRo+8iSj5NFu1UkCFseJARSV2hZ DZ0tuclZEyYfm/hHBhYs6WyKLHd59bwLR7/Vn9T3zVEQnfH1X0yPlcuot A==; X-IronPort-AV: E=McAfee;i="6600,9927,10680"; a="341990723" X-IronPort-AV: E=Sophos;i="5.99,197,1677571200"; d="scan'208";a="341990723" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2023 08:56:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10680"; a="759145630" X-IronPort-AV: E=Sophos;i="5.99,197,1677571200"; d="scan'208";a="759145630" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 14 Apr 2023 08:56:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 14 Apr 2023 08:56:43 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 14 Apr 2023 08:56:43 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 14 Apr 2023 08:56:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X7CGWyeVELvcVcYmboNUsjytmJ7Ml6U+WEjbjKGMJN0lg+fQwwJQwKc6wSoPpwGaH7MbYxBsjLFzw0f5h++aO9AQNr4O4FWebvMXZPE9hLfa2cyxrQg/90ySUUczk9Ihvc/gp9shvokS/LdD0shdGYjGj3vxRdSSlnEVKrfSS19uT7OiKF5Ah3HddxgG74BpBfurnhJ3GCAim1IAIlj4mMkoPCRl+N/iMrzHyMij74XUARuCHPPH+mLDtcPT6XtUDgj5Wv3i62mXDhdj3lc8f1y3MSxipR9S251NhhBuGO90aTYMouJ0Y18YkG+LHNKxsK1zPsyCdYYYAS205Arf7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ykg7C7a/M8qNbO5nBhnkKSIp3kQbXqAI7kYalSAhHEA=; b=eT2Vstf5Akj/BLmJpg0+rOdXgsVklyapv1q9IhUK5flPm3KvWD+3QzcailVhFDu7igGZA/0FGqMo5OT0M84D4N9U7N69WrYKavN00I+xlAJvjTOiIYXgSgzXUrhBQEPAADlgZzktWaT3bLaVJWvNrBL1TZOFiuBBrXnq195A1eS6QPX+damFJmqX701VJQn4K7rC1WtrR5XDpQtZaxq53XeD1cXztYkPv0t2L18x7RgOSnP6sHgOeUey8w4R+py+TRDXHFfHOyMBVqswf0l2ZIepewuviCsgIz3kav1uS0GVCH5pzw1t+XGpR8bYvME1lAGjHaTq2dR16VbBH9yU6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DS0PR11MB6325.namprd11.prod.outlook.com (2603:10b6:8:cf::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Fri, 14 Apr 2023 15:56:40 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 15:56:40 +0000 From: "Chiu, Chasel" To: "Chen, Aryeh" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package. Thread-Topic: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package. Thread-Index: AQHZbVud9LTNbmX90kqVlXzhQysZrK8q+J/A Date: Fri, 14 Apr 2023 15:56:40 +0000 Message-ID: References: <20230412162648.308-1-aryeh.chen@intel.com> In-Reply-To: <20230412162648.308-1-aryeh.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DS0PR11MB6325:EE_ x-ms-office365-filtering-correlation-id: 5b7add1f-cfd0-4f22-b838-08db3d00d61b x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zYuuS9utCqQk74LgRikw6ki1ki2kC1XsZ+6EagD40YapTG/3czWF+UKeC+1g1mR+w0vnGc19rYfXxBc5oHN1dnWkPjeXytbMmt2+vJSAU4FtGDSiW0PEWHkxbP1+pPDaxZ4u4/wvbu5szvbU0V7mkTWqBK9tuSXJMKcXl1WieBAThPW6J10QW0T8xb1F7fF+O+4OKuxOkqOKgyDZHJGmpJ77kNfb8/6wsScwt8LARe76eAYlIUHg8rDrScTUzAbMNJIDHUJdiD63mcDLcqDXIyr3WA3Ms6uenpoc/HgX/FJ1TDc8U8H3ipQ/pNDHbWAjSaN0XT6PvVnegeEsaCG2t2KwE+MjblLTJ/ahGQMg5XXqc+mQvEUD39UcTwyfJMGIytWS76HNLsJsM18qXryyH4+0fmby4pGb/k/yZzjhr1emAtOH+rrYVlhYdwEW9nWekUfgIbSraP4tRk63FKTO7wpomkZxGz81oBY0gUlWYU85U9MGtQF/xa7sd/ji5vqqFooq9vm0uOj7fD8wP+kmL3PPkVTaHEFgVdjxD7Kmu19z2Hin7sOKxfv0YAVxLG9MwuMNVOkaef54SI/4pOC58RnZCsQhK0KF844JU/wrEZ/2y2PcWCl22HWiMiZhQ5EOiuxwMJJOUQpQsPSWhIo6QA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(396003)(376002)(366004)(346002)(451199021)(82960400001)(316002)(15650500001)(2906002)(38070700005)(122000001)(8676002)(52536014)(8936002)(5660300002)(38100700002)(55016003)(86362001)(478600001)(7696005)(33656002)(71200400001)(966005)(107886003)(110136005)(26005)(54906003)(83380400001)(6506007)(9686003)(53546011)(186003)(66476007)(4326008)(66446008)(66946007)(64756008)(41300700001)(66556008)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lbry+yGXyuY5zxJgx3XV0yQd5c8LHcs/XWAiITjI2yoa6kuJfXGW2GniwQG0?= =?us-ascii?Q?DgRRohZOYyYtX/3zMOlPD7iADGRcm0MfYql8w1wKkLtWOl/8z3sRQ+7cqtEw?= =?us-ascii?Q?m/JtGDCaD6wfv79VW48xH5y9vV12ujpcptqvJf58lHtsWG8H6es5KAQ9pUlI?= =?us-ascii?Q?/LYc2VPCaZU+DUbFMdL4Z/NihtUp4oNDlIHMqBHjyraZzf0+nA9lGbSIIfOR?= =?us-ascii?Q?ex8cfXliN9N/4l8fc8cASI3XgmseC2axwbgMOHysO/U4JDn7ie7Gqkfo4w6P?= =?us-ascii?Q?nbTzlFRbSaTpCNhe+sIIaneoTDbFqtWAbyYkcgk+FpfVO+t8YHLgt06Rru5b?= =?us-ascii?Q?RLJNcoLG4PGj1PGWknFVcz/Qac3sGqxsCHXOf/gWxcJGyqfK62qJG45nsVw5?= =?us-ascii?Q?iUDPeKM9CvaeWeCXIJGcfViHcX5Ava92ROIpc1VpP1Ly7MguaYYbRtcW2iW/?= =?us-ascii?Q?MqYpEwAAGhjUwxq1Cy+344BzvjubovnibPAwu+CJ0QEjVS1PSgEe6f4pbwQs?= =?us-ascii?Q?htXMIIqhXi7LITjmHSNXilpXoJ8+IXRgqqOlnI2tiJO5i39AEz5JFJj6oySR?= =?us-ascii?Q?7sGjvtvx9CaUv4wX6nUrC0I6EmkVImMxKgu8+c6EDF+Zm9Q5BtxZNugAFKrV?= =?us-ascii?Q?eYC0+reBO5XfnOBr5u9IGmkMsPquyyiocmvBP+mUwTTCf76nLMmFB46fgt4i?= =?us-ascii?Q?O+vURgAgz/r8noZcWdhC5WmRPVmokBFOCQ7yKnPopAMDHjzJSL4UcJTusJ8c?= =?us-ascii?Q?kRooiE9UKInakNL7uo9WxDU2V5Y7BLqKvPebGIMG/tO7zFevlLGe9I9bgftd?= =?us-ascii?Q?zbV34m1gYOFNUvRUs15AbNc1b9ARR4lNL+IjqorgrxvbLLIV5vLgAv5p5yW9?= =?us-ascii?Q?Ld596SeUdJMt+SG3N6BF+a0+L6wWVZuBqZebPb5cpY08HC/p1DEIOpophhw8?= =?us-ascii?Q?UBKHZYl3yWM3TjEF60g/aqKnLjKM3CKxa0OagOCGfyOjXNDxEs1FyPWJowNe?= =?us-ascii?Q?gR8vjBWmpouEkKBbFPn8W52sZZ6cqCUH6zGEhkbPl+AYfGE6UyJHElmRAAdh?= =?us-ascii?Q?UiBZKlpoAAd6q3WvmOgApF6GKdRToriO2zoTmFUpou+ZMLEH04dnrq5BqDH8?= =?us-ascii?Q?iAaMtqXu7U71IsJR2jgTCYlCZv52sdkT8BAem5HwW7kSESEIyj5FN0427Iql?= =?us-ascii?Q?gKVW2PBzIEpUwueMTg73O1LEbUAiJkzD01LRmX/qPpLVIEozv4HbQ3gTrICY?= =?us-ascii?Q?U5xLqNa6w6hc/frq+Lsaw/P7wY4HE9cieUm0fZ3898DpWN7vS1YmVK87IjjV?= =?us-ascii?Q?pJUifWq/XukDsoh3vKSzsWJjn2jQaKAP2o2b3TjQJmMxWlVswmAQl9GXZ8ml?= =?us-ascii?Q?N46OSQ+mXhQSpY+aHQtz4fSxiHGOSHghWWqDBACCEvjdfyrrlKR8W8BHs8yc?= =?us-ascii?Q?YjM30+9Xu+QycA2kbxeqNxCKps6cxtRgflkv3nj2VzpHD1mPhcGzzl6zrIhL?= =?us-ascii?Q?0u2+PJsqhXWXobCScg0/vLmgvDiZwt184y9sCWUY1Xs6f4eaterYTAKhv579?= =?us-ascii?Q?DCptWu13Xb2gV8Lpz5vQBUvWvlp0zTXPgnNlhJ8z?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b7add1f-cfd0-4f22-b838-08db3d00d61b X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2023 15:56:40.4334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TyoeQ3RnNK4GDxl4jF6ftZLLHWqiUC4KqrZhNxvnlX/KSG5hGS3YvghKCDUzNeZV616oYBq9cigiTs4TvjaOGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6325 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch merged: https://github.com/tianocore/edk2-platforms/commit/3b7f82b61b552f5bdd415f1b= f4ba2866a09ceac0 Thanks, Chasel > -----Original Message----- > From: Chen, Aryeh > Sent: Wednesday, April 12, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric > Subject: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR > REVISION to update FADT entries from board package. >=20 > From: Aryeh Chen >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4409 >=20 > Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from > board package. >=20 > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 ++ > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++ > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 2 ++ > 3 files changed, 6 insertions(+) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 6e57b638e0..e967031a3b 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -1096,6 +1096,7 @@ PlatformUpdateTables ( > case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE: > FadtHeader =3D (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) Table; + > FadtHeader->Header.Revision =3D PcdGet8 (PcdFadtMajorVe= rsion); > FadtHeader->PreferredPmProfile =3D PcdGet8 > (PcdFadtPreferredPmProfile); FadtHeader->IaPcBootArch = =3D > PcdGet16 (PcdFadtIaPcBootArch); FadtHeader->Flags = =3D > PcdGet32 (PcdFadtFlags);@@ -1113,6 +1114,7 @@ PlatformUpdateTables ( > FadtHeader->Gpe1Blk =3D PcdGet16 (PcdAcpiG= pe1BlockAddress); > FadtHeader->Gpe1BlkLen =3D PcdGet8 (PcdAcpiGpe1Blo= ckLength); > FadtHeader->Gpe1Base =3D PcdGet8 (PcdAcpiGpe1Bas= e);+ > FadtHeader->MinorVersion =3D PcdGet8 (PcdFadtMinorVe= rsion); > FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > (PcdAcpiPm1AEventBlockAddress); FadtHeader->XPm1bEvtBlk.Address > =3D PcdGet16 (PcdAcpiPm1BEventBlockAddress);diff --git > a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > index 451034fb8a..694492112b 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > @@ -67,6 +67,8 @@ > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags > gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset > gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion > gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddressdiff --git > a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index e6f714b181..784abb828e 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -346,6 +346,8 @@ >=20 > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9 > 0000025 > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x900 > 00026 > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000 > 027+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion|0x06|UINT8|0x900000 > 30+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion|0x03|UINT8|0x900000 > 31 [PcdsFixedAtBuild] -- > 2.26.2.windows.1