From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.3083.1628652296386976528 for ; Tue, 10 Aug 2021 20:24:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ERhfp75z; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="214775697" X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="214775697" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 20:24:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="675852023" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 10 Aug 2021 20:24:55 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 10 Aug 2021 20:24:54 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 10 Aug 2021 20:24:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 10 Aug 2021 20:24:54 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 10 Aug 2021 20:24:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m4vumx1QfDYjKJfGDVkxnzRfFdLnjNvHOxrqH6VYb8GzvzK+uCRkgbZGqJsnrQmeIX0MQcBzwBhSPacvfmR0r4uYsl33MYf0T0zgJWEcfQBH4nPUltxZMjViR7csWHDXv1QYvj6/N61GWyjs71GufyDVMcNwfWILfRRFeFopT2FYeyUwvDQwK6lsWI/uhP4Q75OYxGUUhz/AAEWuBSk3B//A/ygj1ctGwriFZeyrZaYaCYUOvpPGUefyO8ZRevwGaosijDE/3/li89optPqjbpBXvdRDWsSa5Apn6FfWeEuyYKD6ZPBS01VgZrIADk5cAzhF7zGrvSSGV8FgVpbXcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qdbc2+gpV0NfvfSOukIT+9iiFTSwlEdW/khyUes/fXc=; b=jpGAZFmgCOGZJv5BetMpYMhfn3D3YpZloy5BcTCm33eafZJOGhMVxOleyaSULzwAK5aw65dIITqm6Oyaqa8laqfqj60bklVP8cpxfXFtFuvjvE9IAGNpPxNDhqXg4PeDjKCnQRqguOg+gwtswNzMGSE7nDjjWDfEtdBpoaXPt48Lh3KwuNZbGbu0RB5W/k5pDXetZ450VfZwYQipHqNiIdtV6APZJDspnvAxKEth2L42hXrSuIBySK8tztWdOYO8Xk4lDgFoBk+Staz2ARRubqKyihTpcwI99UOdemUwJdKQmF/K1opebM6Zm9I8iRA5iWbH5LaepJ7quWMYSk9PDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qdbc2+gpV0NfvfSOukIT+9iiFTSwlEdW/khyUes/fXc=; b=ERhfp75zMS+nyqjed3+Odo3K1k6OhA7nO2P5nGlIZGMf/u9xqyQXhjBi+5v2zYJwXnLtJH6Mz00ixt6cbageGGiNO9NfzxDNzTgWEJPS/BT2UOV4V3hWm7zK+MML0Lkpe6Dll5KQl3xLLo04/6EjnHJ98qfE9MZbfoEcOwqkSsE= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN7PR11MB2609.namprd11.prod.outlook.com (2603:10b6:406:b1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Wed, 11 Aug 2021 03:24:50 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6413:4198:3c40:777f]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6413:4198:3c40:777f%3]) with mapi id 15.20.4415.014; Wed, 11 Aug 2021 03:24:50 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Chiu, Chasel" , "Desimone, Nathaniel L" CC: Michael Kubacki , Benjamin Doron Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS Thread-Index: AQHXjjqCAnkwC+4xxkyYDQJRxrTXEqtti6PwgAALU6A= Date: Wed, 11 Aug 2021 03:24:50 +0000 Message-ID: References: <20210810225309.27112-1-nathaniel.l.desimone@intel.com> <169A1DCEF9C635BF.17558@groups.io> In-Reply-To: <169A1DCEF9C635BF.17558@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a81c312-976f-4d47-b1a6-08d95c779420 x-ms-traffictypediagnostic: BN7PR11MB2609: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Dpx9xwWYBxrFjgUOPJiSh4uPPc6Ndf+NNbN21GsV1ZbZXxwun1j5Vei7cSmO9nduTXoN0beGa9Q1cB77oirhGpOLMy31cw6GU1LxMXkB2LUJomWd9O61nUUXDjM1n13g060AEhJ9YmIcWK0dw8KtCmbeUPjGYSF9Bl72jwpdFAj9FjZpzp4C6jkHL8/wEB5kz7oV6QgmEaDu10/M3d2LAUO2MlWc2AUY35Z+qIFr3/E9Fs19HSBeUqUoKPr5XcVqa5Lffzu0jmDFewv7q0nezNcTClcWykfnptiqJ6r3cTesqkOGGaXsS+NELOrPesoPqesiHye4o3NDR5eTOWw/lyN2N4PiDZv0gKa3HfWwWrJfKA3SIt9vpaeZJaeohbIthGax0qoA7kDtdeWxOovdZ56xbRl/Sey1GRP8rJUjIsRm/XJ50dtxFWgH9K9mx+CsSFTV5vqwtmZsqSTXR3MC4edxu7+2LnW65/hft4Sr0Vl+Mp/IBFmwSPNlQCwUskuOwTaq1zHq3O9IyULGOriYYT04YdAoEWlsQVBXgjP6j3uLb6POJHjEVQwPw1dOptLrnEMaNBIAiG1hbw7hErjVttVLH4aT7IFjXM0gChUMbutaQHuZj21DOyxr3ki2HqJSNcmSEnimH3yM0B5dnuuo18mV8F1iT2I4IQTguzzjdHiqcAdzitxChiOh3TmpoK4oVjXMtfgci8SpJcB93g9WPFGPBEOX6imYgVR1SFlbLnTa7OK8rn7meHlWOYh5DLNLMJ2WFAWeZQM5H2yf/kTJDV69BhkQ9Sg37GO7TawA7JCoyObQqFbKrws5cJijxwGqxK1t3rPlAzfuDewK+K2E6w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(66946007)(66476007)(83380400001)(186003)(64756008)(66446008)(76116006)(26005)(2906002)(38070700005)(122000001)(38100700002)(86362001)(6506007)(316002)(19627235002)(508600001)(52536014)(5660300002)(33656002)(966005)(7696005)(8676002)(71200400001)(4326008)(53546011)(9686003)(110136005)(54906003)(6636002)(8936002)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?chGtEUbxt29WdfuoUV36+hc4/AaB8bJzSPWfqwo2UZ20/bN5Ebn8n1HIQmaU?= =?us-ascii?Q?LlpSJfEMTfqbQ/ctgw02FFyxd5j3c72FJfgLBOpSj09VAaKY2Zj8CwhIdLhP?= =?us-ascii?Q?O/Jk1+UBHjCuxBxGZR1x1a9fg1RuSRja8ZI/x8/xBTM7RH+SOXkZLxRTuEkA?= =?us-ascii?Q?z/1TTA/fgKKwKs82GHVVQzFfQ6AUG69uVmfJwT4vPUDUcPHLo0b9gbBL/I0M?= =?us-ascii?Q?lFwz6m4lFHweE1VBrWkqpn1K3PW3Qq0mA+RNVyUeYNTV73KiOGq/HfRnt7gP?= =?us-ascii?Q?tmJZQPjPaa5nGIflWG41WKzo1wEmrx8yy8aTGb3S4prXd0aXeb2+lmgjxudz?= =?us-ascii?Q?zbHGggI6hI/2IpAqMi2wOahqdH2K+3Y4STZZTRoDDs9KfiH5wsqaru5fqXaP?= =?us-ascii?Q?KVvDfEddlHKLsBvNT3nHr14jx60qBs6BhtB5lS8CYWcMdMRWvbNhVfL1FOn0?= =?us-ascii?Q?DT+LuXgHhuQ3Po86Bp9+XJVTQfIcwa+efDJ2tJefpmpe7i3N/ZQyz+igluO2?= =?us-ascii?Q?LxTTpj1Vbc9DXjsZjNBxRu/Nd4M+MR1IqCdoeiHPKweBpRGTGudvQlvquH+q?= =?us-ascii?Q?0EqxkpL7o32inQbp3+ivyI16AbxjDjU+HVBkekdlIRIfbRQ5Yz1uHGWc4Njr?= =?us-ascii?Q?L/AFxEBg16VH4C8jJQyRqQm1MZltfpcVkUct9wmPYz/WLLucfx5qmVzZidG8?= =?us-ascii?Q?g+wgRi1T23DSLdsN3to4u9tfLxvtFZ3EB2VOwmEaW9wewPGuwVekqrW0YJRu?= =?us-ascii?Q?3AlS8u0JyEJz+cQnLdzTwr2Q20zoIjTSXwvNrpmoRxof8AeKE8Z9E6pXoLKA?= =?us-ascii?Q?8zi3ue7wsGnlpo8Ple7zL7d/16VdkIYXvznhTj+FgAdPMPVBbI0wVC0/rbW5?= =?us-ascii?Q?41GSth14ax3pShd849496NLO2Yq1rJeUHAWMl/UE3Xw2gqcduNnmWSdwOoVu?= =?us-ascii?Q?IgJcf9lR25Kpsjc/IAznhrvPD1VktlJJOiCUq8R4NnXBnBYe/7Sl/YZLsxJS?= =?us-ascii?Q?KvBCsWmkojtsfK1Gpw5T/ITMkIN+KqkLxDOnEmQttHJnXfFmE0sGTbjrIERC?= =?us-ascii?Q?UA22fUfa3jQxt8k36XcRlh7B6wp8ZaJdjPFOwEA3FhEiZAJzv7KXa2yXOp4w?= =?us-ascii?Q?rHqEOI14L0VBDxHkjIUw+vftwn+rIpypKQkoduIzMbp0IPwLVwl6s3AhD2Be?= =?us-ascii?Q?c9R3g0g6mWo7hW5ECgirvcyG7pznYOveUaH0vgs6cHVPoEHq3eWeKURk7/O2?= =?us-ascii?Q?nDglHboWH8xRfOC2ZOf9NGXr/HsQIkfhjyM/qotaj0Sf6Fy8xV6FGXTPR3h3?= =?us-ascii?Q?kvhXuOE60xSL0IQShcFLKEZE?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a81c312-976f-4d47-b1a6-08d95c779420 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2021 03:24:50.4286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: keBvjU/3ql3iQtfOuKRRImpDq5ToEsPAZstur0GBjGwQyrBToud+Cgm77fiNc2HV79+mfB9zdPPLwr7FjWKEMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2609 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Nate, Internal test case failed, please see below inline for comments. Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Wednesday, August 11, 2021 9:56 AM > To: Desimone, Nathaniel L ; > devel@edk2.groups.io > Cc: Michael Kubacki ; Benjamin Doron > > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] > KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS >=20 >=20 > Reviewed-by: Chasel Chiu >=20 > > -----Original Message----- > > From: Desimone, Nathaniel L > > Sent: Wednesday, August 11, 2021 6:53 AM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Michael Kubacki > > ; Benjamin Doron > > > > Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO > > Base/Length to SA GNVS > > > > The SA GNVS Area contains fields for the MMIO region base address and > > length. This implements code to populate those fields. The MMIO > > Base/Length are used by ASL at runtime and must be populated for > > normal system operation. > > > > Cc: Chasel Chiu > > Cc: Michael Kubacki > > Cc: Benjamin Doron > > Signed-off-by: Nate DeSimone > > --- > > .../Acpi/BoardAcpiDxe/AcpiGnvsInit.c | 57 ++++++++++++++++++- > > .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 12 +++- > > 2 files changed, 63 insertions(+), 6 deletions(-) > > > > diff --git > > > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit.c > > > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit. > > c > > index 0d9d217e38..b09b92f2e6 100644 > > --- > > > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit.c > > +++ > > > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit > > +++ .c > > @@ -1,7 +1,7 @@ > > /** @file > > Acpi Gnvs Init Library. > > > > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> > +Copyright (c) 2017 - 2021, Intel Corporation. All rights > > +reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -11,11 +11,51 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include #include #include > > > > +#include > > #include > > > > #include > > #include > > #include > > +#include > > + > > +/** > > + A protocol callback which updates MMIO Base and Length in SA GNVS > > +area > > + > > + @param[in] Event - The triggered event. > > + @param[in] Context - Context for this event. > > + > > +**/ > > +VOID > > +UpdateSaGnvsForMmioResourceBaseLength ( > > + IN EFI_EVENT Event, > > + IN VOID *Context > > + ) Should we add EFIAPI to this function? > > +{ > > + EFI_STATUS Status; > > + SYSTEM_AGENT_GLOBAL_NVS_AREA_PROTOCOL > > *SaGlobalNvsAreaProtocol; > > + > > + Status =3D gBS->LocateProtocol (&gSaGlobalNvsAreaProtocolGuid, NULL, > > + (VOID **) &SaGlobalNvsAreaProtocol); if (Status !=3D EFI_SUCCESS) { > > + return; > > + } > > + gBS->CloseEvent (Event); > > + > > + // > > + // Configure MMIO Base/Length. This logic is only valid for > > + platforms that > > use PciHostBridgeLibSimple. > > + // > > + DEBUG ((DEBUG_INFO, "[BoardAcpiDxe] Update SA GNVS Area.\n")); > > + SaGlobalNvsAreaProtocol->Area->Mmio32Base =3D PcdGet32 > > +(PcdPciReservedMemBase); > > + if (PcdGet32 (PcdPciReservedMemLimit) !=3D 0) { > > + SaGlobalNvsAreaProtocol->Area->Mmio32Length =3D PcdGet32 > > +(PcdPciReservedMemLimit) - PcdGet32 (PcdPciReservedMemBase) + 1; > > + } else { > > + SaGlobalNvsAreaProtocol->Area->Mmio32Length =3D ((UINT32) PcdGet64 > > +(PcdPciExpressBaseAddress)) - PcdGet32 (PcdPciReservedMemBase); > > + } > > + if (PcdGet64 (PcdPciReservedMemAbove4GBLimit) > PcdGet64 > > (PcdPciReservedMemAbove4GBBase)) { > > + SaGlobalNvsAreaProtocol->Area->Mmio64Base =3D PcdGet64 > > (PcdPciReservedMemAbove4GBBase); > > + SaGlobalNvsAreaProtocol->Area->Mmio64Length =3D PcdGet64 > > +(PcdPciReservedMemAbove4GBLimit) - PcdGet64 > > +(PcdPciReservedMemAbove4GBBase) + 1; > > + } > > +} > > > > /** > > @brief > > @@ -39,6 +79,7 @@ AcpiGnvsInit ( > > EFI_MP_SERVICES_PROTOCOL *MpService; > > UINTN NumberOfCPUs; > > UINTN NumberOfEnabledCPUs; > > + VOID *SaGlobalNvsRegistration; > > > > Pages =3D EFI_SIZE_TO_PAGES (sizeof (EFI_GLOBAL_NVS_AREA)); > > Address =3D 0xffffffff; // allocate address below 4G. > > @@ -53,7 +94,7 @@ AcpiGnvsInit ( > > if (EFI_ERROR(Status)) { > > return Status; > > } > > - > > + > > // > > // Locate the MP services protocol > > // Find the MP Protocol. This is an MP platform, so MP protocol > > must be there. > > @@ -90,6 +131,16 @@ AcpiGnvsInit ( > > GNVS->Area->PL1LimitCS =3D 0; > > GNVS->Area->PL1LimitCSValue =3D 4500; > > > > + // > > + // Update SA GNVS with MMIO Base/Length // > > + EfiCreateProtocolNotifyEvent ( > > + &gSaGlobalNvsAreaProtocolGuid, > > + TPL_CALLBACK, > > + UpdateSaGnvsForMmioResourceBaseLength, > > + NULL, > > + &SaGlobalNvsRegistration > > + ); The build failure is here, please help to fix it: /edk2-platforms/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiG= nvsInit.c:140:5: error: passing argument 3 of 'EfiCreateProtocolNotifyEvent= ' from incompatible pointer type [-Werror=3Dincompatible-pointer-types]/edk= 2-platforms/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsI= nit.c:14:0: /edk2/MdePkg/Include/Library/UefiLib.h:168:1: note: expected 'EFI_EVENT_NOT= IFY' but argument is of type 'void (*)(void *, void *)' EfiCreateProtocolNotifyEvent( > > + > > return EFI_SUCCESS; > > } > > - > > diff --git > > > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > > .inf > > > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > > .inf > > index 7d2e105e54..5d3d4c3a2b 100644 > > --- > > > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > > .inf > > +++ > > > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > > +++ .inf > > @@ -1,7 +1,7 @@ > > ### @file > > # Component information file for AcpiPlatform module # -# Copyright > > (c) > > 2017 - 2019, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2017 - 2021, Intel Corporation. All rights > > +reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -38,6 +38,7 @@ > > PcdLib > > UefiBootServicesTableLib > > UefiRuntimeServicesTableLib > > + UefiLib > > BaseMemoryLib > > HobLib > > AslUpdateLib > > @@ -48,8 +49,15 @@ > > gEfiFirmwareVolume2ProtocolGuid ## CONSUMES > > gEfiMpServiceProtocolGuid ## CONSUMES > > gEfiGlobalNvsAreaProtocolGuid > > + gSaGlobalNvsAreaProtocolGuid ## CONSUMES > > > > [Pcd] > > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit > > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemAbove4GBBase > > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemAbove4GBLimit > > + > > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiGnvsAddress > > > > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiSleepState > > @@ -65,5 +73,3 @@ > > gEfiPciRootBridgeIoProtocolGuid AND > > gEfiVariableArchProtocolGuid AND > > gEfiVariableWriteArchProtocolGuid > > - > > - > > -- > > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20