From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.13003.1663261731004878710 for ; Thu, 15 Sep 2022 10:08:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=OyQaYxD9; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663261731; x=1694797731; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xaFSCM5qdJn0pnvDIK/+OAUnhWOo3TsUfqLqEA9q8rU=; b=OyQaYxD9By1ND7Wn2BUtojXx1M9qYuV+7ZPuQ7Y6lOVDpTpgyS0SUxVC 3ei6K346lSalPS1WL7BefkwfBjhszEyONs71eKLJI4FUsMyXPbbGQhqJS ixEy1Dvron68kIo6S/Y28Q0xtqLop5aWFqElI32w6Z5vOCNmcxp48MfGd evU8aAot4cGQQT2bG+i9H0FuRNQbZDb851u5hkqqQHcGHzsZV/P02yd9L miS+vWm/6k3MYLyKam5+cPg8nl8tWiC+M55DVYnHsq3UeCeuTSaB375uB BzZBIwNOQK11RVXHVWRZZGharud6WZnLXsa/98TAYgVyAPngEOAeefwIv A==; X-IronPort-AV: E=McAfee;i="6500,9779,10471"; a="285819294" X-IronPort-AV: E=Sophos;i="5.93,318,1654585200"; d="scan'208";a="285819294" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 10:04:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,318,1654585200"; d="scan'208";a="650556486" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 15 Sep 2022 10:04:49 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 10:04:45 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 15 Sep 2022 10:04:45 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 15 Sep 2022 10:04:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kyFEdhaPSvLtZJuU+BXrkKShXm6SjzNXMJu55hWU+DmCBJB4ilVxAKqFYLzU4yKKUh6F3oq4ixvzN3gKmoPtCve9s4wShx0ldkOAmoUX+/+BuwgLIUH6uc3InmWPXAFAcZ4pdBTfAxLFjAT1Qj1FVL/9cz7XewQAi7a0NRHV0oGUMeiTRY/OcMi7osTDnfdFcYa6zWHsXHYfXN+3fjtY+k5ypTKBIp2E9OFpaR4itnnHNk1TYqvMMeLeh3RAr86CxkQFPe3qowTlqhhcgnbwxwmm5l3Nnska2n9Ed3uSgzd4kRRw9fDMsfMxZXp1aWfxh/SM+uDXfWDCYcaUwPw9tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WWOGb5Cp1aXZtleYJg1DS7aEvua4RuK9cfkzsQfA4H0=; b=N+QxfAo7QrK58l3ITyx07XDTIzRBXTsId1lFtDmFXUnZFgiUJKTJJHKFUEUYz8dJZe7Ry2sE7Mxrh8VmYK7bsgJvLD8MtGO+VnJ10EXM2xlaqcLnAPPL8zsl5luwL19iWdr1Lan//tD6u8aidi0fuEwN3oAJKs5dsN45xgxC7zF9qRg320pwNF8ibSqKQYdM8ZeuCDpXwwL0QQNsCCIRPwc1QYzMdP0e96BsMGFA8lWEuz1v27H6c75CRChucQ0AbbgAJQ/qXqfy9CY1Jfv9/0jyB2b0Gg0dWSZJ6Hf16MHEYgpUXhM/jSkAVCLFwJoe+u6wkzgz44fNwp0WKVVTiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BL3PR11MB6433.namprd11.prod.outlook.com (2603:10b6:208:3b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15; Thu, 15 Sep 2022 17:04:43 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2c62:61b:4030:8a3]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2c62:61b:4030:8a3%3]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 17:04:43 +0000 From: "Chiu, Chasel" To: "Kuo, Ted" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "S, Ashraf Ali" , "Duggapu, Chinni B" Subject: Re: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm Thread-Topic: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm Thread-Index: AQHYyQimP1QjWq0Wh0+GCpl5f6Xxta3guFZA Date: Thu, 15 Sep 2022 17:04:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|BL3PR11MB6433:EE_ x-ms-office365-filtering-correlation-id: fd99d0ac-e2ec-409a-f776-08da973c6282 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Mk2xoCyXxdPyiKD3V2dJUbRykJGc2VDfKdWorLU95S+1PWCAt84kM7RNE/P5nWzEMyKGLKZ6Ysp715DAE3Sr0OUoZwMuvWZSJ934H1NdZk2KktLIKSpMFhupeGSXruOyU2rsLwGXF0fD8gX2MHE/pIAkVmL2XT0XkJ9/AF5oDxnFjfiLs/bDX6OsHtUFOGAgqm9p4GwMOraIXTZJhVqLSx4lAnmFVI2r1ZdrCnjY/zx17kM1JoY8faeUxeRBOmEkzaCXD+H+53imLE6UPXC+geEmVeDYs4kjqVs+pH0xX6F3qrlNwyQF0A+gUoTkqwtd3HPlqVhwUFJnuf8KYDJVHacjkswGO5UBZx1W7Kb4VqY8n2FxZtGlGupdb7RM/zQ7AesTScHkjIKGRWALoq5nkEZnhkIA4QeeRASSTuNKUBYpIPGKVU12eGYrgQ42UD4r5f2r2UBgZaigzMCR6WXnTX+i8b0ZQQ1h2v1uK1yCsinUUk9b0t5+JJLK+3+ucvX02RyryP52fCigthDvQ5Vzv58Ku6rdye4h/4VtZzd692vTmkcuf872IYz4STHZUtu43IGxy0otZYPmXL12EMSxa7zAUGmLq1G6c76H3gfRcXZm+Kq+73+XBghpC7qIu1pjZylXMTaopwT3LfFv8mcFwnppdg7FsxZ6z3gb4oLlbkIh2EB1BGIXaUJ1satCWNYprjlJCLARkGdW8RNR/5cTC+1o6ktm/zbRHV8Ip0hm8Upbl1sNTAFIeEfNZzmDZOmd9pta+g4k+hwh8oB0om8IvdtNOXu9i1QT+HzoROd9ih8It2e0t24NurYOfeo41YjQYWknn0wzjm1dwnhXTfo/AA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(39860400002)(366004)(346002)(136003)(451199015)(86362001)(38070700005)(316002)(82960400001)(122000001)(66946007)(4326008)(66476007)(66556008)(76116006)(52536014)(64756008)(54906003)(110136005)(8676002)(66446008)(55016003)(19627235002)(8936002)(5660300002)(2906002)(33656002)(478600001)(83380400001)(966005)(186003)(71200400001)(53546011)(9686003)(7696005)(6506007)(26005)(107886003)(41300700001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qrykVdYH/YSiumiX5Papo4GjH+BAP2YjUDitj2UzVWyLgHnSLn5gP4SZ203w?= =?us-ascii?Q?ptutiqxK4lYqt1+zyTQSwQsuY1TpjXIKW8clhKVbvSO22VEKz0HlNYjJJPWL?= =?us-ascii?Q?nBeWS0LurSE7NzImydGR8aHnQwy+pJWatB+4Rafr7PIcFK8L61sML3TYtaOh?= =?us-ascii?Q?l5uR07DJrjdb9ZD8pIcJDWc4GSt8hgoIH2kxH20Yn88wJkOzGql2u6IXx5s4?= =?us-ascii?Q?CpzVU+xuvMJ+LJ4Aw5YMD060QXgBC090sqZuQgnN32UTdTWvB3OEln5ptPGv?= =?us-ascii?Q?Tq1T/O97ivlkxRMq4EROJ9lyIJpAvOfM3BUIvGWbV9VMK6rU+X8Tow2+Y9+Y?= =?us-ascii?Q?9/N8bZ5M5hAczLiQw40qzdOpet7rmK7BhScBislqEuMpcH3XTYUQs0PCIN7X?= =?us-ascii?Q?cf//z4dqXJmKjdAuLYPLaYhz+qVoQMHcp2PXWnF0d+Dtz7T8a64mihB7HEzu?= =?us-ascii?Q?KAVniheVXX9bZv7YlBkH+ATvQK+Ylnyvk1Fc/KYfDrUr2uhyp6qHR0UDZx69?= =?us-ascii?Q?VrW3eKxjLOsRRknCfKG21jmBA5E8MgziGLWH7byqmQmBD6UGMhwnpoN6cUSy?= =?us-ascii?Q?QM4FBOqo1Io3S2MtW0wIcb3qqIPsDEedZY79ohncE9rMd75a5+Ye3+i99KF4?= =?us-ascii?Q?S8kN/Np+b8K9POrvWCfkgko8+AwjezJ0mTrKnBsE9HqcR7ATSDnmQAvo9gL/?= =?us-ascii?Q?a95WPXBbT/78YQqzdCvmY8ltguP8zJA8ejkwZ+cHpc5J7GnVgsL7KcAOa6F/?= =?us-ascii?Q?rZjB1uDL10nrIqGwKpk5KiQ+ON1k0I29EHcJ7KXHFr/FWlvwVBz/uckbkJAr?= =?us-ascii?Q?ZzGRIq0nBRZE7Idyy8SS+GyTFHOso2qjByFXdo/zPHGTVEmTMcU7Rj5+IXFt?= =?us-ascii?Q?GnagfqmNjt4r43KwL8KA91JDItvokAajxZZ8M1wyTv2oruRDC6wQRTT5FC7g?= =?us-ascii?Q?fN0V7JkpT+4lqPRx7rC9NaHiyaiQjywVk/Wr4IU2RwF+xYZj5J0DGphMyCkU?= =?us-ascii?Q?ibYDNl3Gxg96sIn1mo/3QiUoq1gccV48rq5lvM9pziU0b4EZo5FOzBolZ7x9?= =?us-ascii?Q?G0UV0m2er2XNv4z5/x2hlcCssgbTA8Dr6Q0QERXGGGCbPL+E3LwtQf79mViu?= =?us-ascii?Q?WJXDxS0Ssyb/s4Ct1n6qpOA+UFw4ueX/lgWOVblOBOQuMYfBa30cvv9tA3fI?= =?us-ascii?Q?NKbFqqUS226ANwJQ4O1QtQdqsGbW9jRkF+mz66btR/ZHO407P0L8PFY3W1CL?= =?us-ascii?Q?5FSIpuwe41+SSTP1P2p7SDTw48s3dNaAQE6zeGtI2RP6YRWw1ci2J0/2lpSv?= =?us-ascii?Q?l5ciFqL6m2c3aYm73+ByAkukPZ2ZyF2/yJ/JoE519kJEuoowOFUjEL9p4X4Q?= =?us-ascii?Q?PHX7UIVZRn+axia1Ttx1oD7MMr1mTPTkv07PvN1IiY8vj1z7CCVW5ZS7ddw4?= =?us-ascii?Q?UtGoCssp0T7Q/uVW1Xp57JwcrFvAh8TvYEX2AKzIwF5ace/d4I9FBLENnSla?= =?us-ascii?Q?6svcYmncDjYmKyKE9bzNnqE782mlyoq6G/Ns2q3aFDzcklYJCAqXVujrIo4Q?= =?us-ascii?Q?wYyG1b4WNQWMNAg28qZ3AmM/IbrZ3QS5QbrSQ0o7?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd99d0ac-e2ec-409a-f776-08da973c6282 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2022 17:04:43.2303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9jcP9EZPwnqYpb9qBWSBA/4+VrUp+S4UKmDiMszW55hIOs0/gRD4EHDbhGS4pHzY8+eAXh8FoSNRz7yKLT0iKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6433 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch merged: https://github.com/tianocore/edk2/commit/981bf66d5a7b1a31be5ffccc15fe13b973= 00e124 Thanks, Chasel > -----Original Message----- > From: Kuo, Ted > Sent: Thursday, September 15, 2022 6:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, As= hraf > Ali ; Duggapu, Chinni B > Subject: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in > Fsp24ApiEntryM.nasm >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4063 > Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm > to align with FSP 2.4 SPEC. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Ashraf Ali S > Cc: Chinni B Duggapu > Signed-off-by: Ted Kuo > --- > IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++- > IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > index 997b9c0bff..15f8ecea83 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > @@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24 > .Revision: resb 1 .Reserved: = resb 3 .Length > resd 1+ .NvsBufferPtr resq 1 .StackBase: = resq > 1 .StackSize: resq 1 .BootLoaderTolumSize: = resd > 1 .BootMode: resd 1 .FspEventHandler = resq 1- .Reserved1: > resb 24+ .Reserved1: resb 16 ; } .size: endstr= ucdiff --git > a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > index 8880721f29..a3b38e4585 100644 > --- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > @@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24 > .Revision: resb 1 .Reserved: = resb 3 .Length > resd 1+ .NvsBufferPtr resq 1 .StackBase: = resq > 1 .StackSize: resq 1 .BootLoaderTolumSize: = resd > 1 .BootMode: resd 1 .FspEventHandler = resq 1- .Reserved1: > resb 24+ .Reserved1: resb 16 ; } .size: endstr= uc-- > 2.35.3.windows.1