* [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm
@ 2022-09-15 13:39 Kuo, Ted
2022-09-15 16:31 ` Chiu, Chasel
2022-09-15 17:04 ` Chiu, Chasel
0 siblings, 2 replies; 3+ messages in thread
From: Kuo, Ted @ 2022-09-15 13:39 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone, Star Zeng, Ashraf Ali S,
Chinni B Duggapu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4063
Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm to
align with FSP 2.4 SPEC.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Chinni B Duggapu <chinni.b.duggapu@intel.com>
Signed-off-by: Ted Kuo <ted.kuo@intel.com>
---
IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++-
IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
index 997b9c0bff..15f8ecea83 100644
--- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
+++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
@@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24
.Revision: resb 1
.Reserved: resb 3
.Length resd 1
+ .NvsBufferPtr resq 1
.StackBase: resq 1
.StackSize: resq 1
.BootLoaderTolumSize: resd 1
.BootMode: resd 1
.FspEventHandler resq 1
- .Reserved1: resb 24
+ .Reserved1: resb 16
; }
.size:
endstruc
diff --git a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
index 8880721f29..a3b38e4585 100644
--- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
+++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
@@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24
.Revision: resb 1
.Reserved: resb 3
.Length resd 1
+ .NvsBufferPtr resq 1
.StackBase: resq 1
.StackSize: resq 1
.BootLoaderTolumSize: resd 1
.BootMode: resd 1
.FspEventHandler resq 1
- .Reserved1: resb 24
+ .Reserved1: resb 16
; }
.size:
endstruc
--
2.35.3.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm
2022-09-15 13:39 [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm Kuo, Ted
@ 2022-09-15 16:31 ` Chiu, Chasel
2022-09-15 17:04 ` Chiu, Chasel
1 sibling, 0 replies; 3+ messages in thread
From: Chiu, Chasel @ 2022-09-15 16:31 UTC (permalink / raw)
To: Kuo, Ted, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Zeng, Star, S, Ashraf Ali,
Duggapu, Chinni B
Thanks Ted!
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Kuo, Ted <ted.kuo@intel.com>
> Sent: Thursday, September 15, 2022 6:40 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; S, Ashraf
> Ali <ashraf.ali.s@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com>
> Subject: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in
> Fsp24ApiEntryM.nasm
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4063
> Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm
> to align with FSP 2.4 SPEC.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Chinni B Duggapu <chinni.b.duggapu@intel.com>
> Signed-off-by: Ted Kuo <ted.kuo@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++-
> IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> index 997b9c0bff..15f8ecea83 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> @@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24
> .Revision: resb 1 .Reserved: resb 3 .Length
> resd 1+ .NvsBufferPtr resq 1 .StackBase: resq
> 1 .StackSize: resq 1 .BootLoaderTolumSize: resd
> 1 .BootMode: resd 1 .FspEventHandler resq 1- .Reserved1:
> resb 24+ .Reserved1: resb 16 ; } .size: endstrucdiff --git
> a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> index 8880721f29..a3b38e4585 100644
> --- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> @@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24
> .Revision: resb 1 .Reserved: resb 3 .Length
> resd 1+ .NvsBufferPtr resq 1 .StackBase: resq
> 1 .StackSize: resq 1 .BootLoaderTolumSize: resd
> 1 .BootMode: resd 1 .FspEventHandler resq 1- .Reserved1:
> resb 24+ .Reserved1: resb 16 ; } .size: endstruc--
> 2.35.3.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm
2022-09-15 13:39 [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm Kuo, Ted
2022-09-15 16:31 ` Chiu, Chasel
@ 2022-09-15 17:04 ` Chiu, Chasel
1 sibling, 0 replies; 3+ messages in thread
From: Chiu, Chasel @ 2022-09-15 17:04 UTC (permalink / raw)
To: Kuo, Ted, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Zeng, Star, S, Ashraf Ali,
Duggapu, Chinni B
Patch merged:
https://github.com/tianocore/edk2/commit/981bf66d5a7b1a31be5ffccc15fe13b97300e124
Thanks,
Chasel
> -----Original Message-----
> From: Kuo, Ted <ted.kuo@intel.com>
> Sent: Thursday, September 15, 2022 6:40 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; S, Ashraf
> Ali <ashraf.ali.s@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com>
> Subject: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in
> Fsp24ApiEntryM.nasm
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4063
> Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm
> to align with FSP 2.4 SPEC.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Chinni B Duggapu <chinni.b.duggapu@intel.com>
> Signed-off-by: Ted Kuo <ted.kuo@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++-
> IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> index 997b9c0bff..15f8ecea83 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> @@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24
> .Revision: resb 1 .Reserved: resb 3 .Length
> resd 1+ .NvsBufferPtr resq 1 .StackBase: resq
> 1 .StackSize: resq 1 .BootLoaderTolumSize: resd
> 1 .BootMode: resd 1 .FspEventHandler resq 1- .Reserved1:
> resb 24+ .Reserved1: resb 16 ; } .size: endstrucdiff --git
> a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> index 8880721f29..a3b38e4585 100644
> --- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> @@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24
> .Revision: resb 1 .Reserved: resb 3 .Length
> resd 1+ .NvsBufferPtr resq 1 .StackBase: resq
> 1 .StackSize: resq 1 .BootLoaderTolumSize: resd
> 1 .BootMode: resd 1 .FspEventHandler resq 1- .Reserved1:
> resb 24+ .Reserved1: resb 16 ; } .size: endstruc--
> 2.35.3.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-15 17:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-15 13:39 [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm Kuo, Ted
2022-09-15 16:31 ` Chiu, Chasel
2022-09-15 17:04 ` Chiu, Chasel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox