Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

["duntan" <dun.tan@intel.com>]

Hi Liming,

Sorry I didn't get what the code needs to be compatible with. Could you please explain more?
The MpService2Ppi field was added in " MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE"( b1955cddb2) last year by me. Previously It was added to simplify the code logic to wakeup AP in S3 boot related code of CPU SMM driver when code execution modes for PEI and DXE are the same. In this patch set, all the related code logic was removed.

Thanks,
Dun

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Tuesday, May 28, 2024 5:17 PM
To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
Cc: Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
Subject: 回复: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

Dun:
  To be compatible, I suggest to keep the same layout of SMM_S3_RESUME_STATE. MpService2Ppi field can be kept, but it is not used any more. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> 发送时间: 2024年5月28日 14:35
> 收件人: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>; Liming Gao 
> <gaoliming@byosoft.com.cn>
> 抄送: Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> 主题: Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove 
> MpService2Ppi field in SMM_S3_RESUME_STATE
> 
> Hi Liming,
> 
> Could you please help to review this patch?
> This patch set is to simplify the X86 CPU SMM driver by removing most 
> of
S3
> related logics and we want to merge it as soon as possible.
> 
> Thanks,
> Dun
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of duntan
> Sent: Friday, May 17, 2024 5:46 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
Liming
> Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove 
> MpService2Ppi field in SMM_S3_RESUME_STATE
> 
> This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP 
> to do the CPU initialization during smm s3 boot when the execution 
> mode of PEI
and
> DXE are the same.
> Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup AP 
> anymore. The initialization for AP will be done in S3Resume.c before
transfer to
> CpuS3.c of smm cpu driver.
> So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> index 72d173c4fd..6c7237727e 100644
> --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> @@ -1,7 +1,7 @@
>  /** @file
>    Definitions for data structures used in S3 resume.
> 
> -Copyright (c) 2011 - 2023, Intel Corporation. All rights 
> reserved.<BR>
> +Copyright (c) 2011 - 2024, Intel Corporation. All rights 
> +reserved.<BR>
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -30,7 +30,6 @@ typedef struct {
>    EFI_PHYSICAL_ADDRESS    ReturnContext1;
>    EFI_PHYSICAL_ADDRESS    ReturnContext2;
>    EFI_PHYSICAL_ADDRESS    ReturnStackPointer;
> -  EFI_PHYSICAL_ADDRESS    MpService2Ppi;
>    EFI_PHYSICAL_ADDRESS    Smst;
>  } SMM_S3_RESUME_STATE;
> 
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119296): https://edk2.groups.io/g/devel/message/119296
Mute This Topic: https://groups.io/mt/106345552/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-