From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.2365.1628646988879707917 for ; Tue, 10 Aug 2021 18:56:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=n/0aAaJF; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="278782170" X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="278782170" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 18:56:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="516267149" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 10 Aug 2021 18:56:21 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 10 Aug 2021 18:56:21 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 10 Aug 2021 18:56:20 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 10 Aug 2021 18:56:20 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 10 Aug 2021 18:56:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MlQWnS+GzkfijJcavTr5purAPbHg3ALGEpjSC+wgG1akO9TKBpapLRCC11f8Lkmzhzp2PgQaljSDpa9inh7Hi6rTHJScb5UWE+MgE6sfWXb/iY3fHdzU7yNEJ3Y0LJfgJ//AOmFmlHAtQonWc6/W6gneMDiomG7i2c+QRVnIy80f/Z7OOmvUTF5u5UG6j5DMBHfIATdB9qJKX1MzYqAuWaCRGSn6DT+WcUo3J/q7avLu5xKjPK1b7+05OTWoxp6yXw9/M1Of7ZJHuOMDphfAebBy0qA88CzCQX7XQ8HL8/LOx9ax1MmgTHiuwOPaBghwT6ostaa7tJs8CQOIfh/VNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KiAYYLtoJcZ0ef1TKBd9mkMzCibQRMQn8O1pGk/WpTA=; b=PwOap81/qp9H+1HUyEXMxvsz5rau3/OgEj1fjs7cNbcTyewQKBL6NF//gjNM1zGaUQTd9jUVWbrEHuXDdBEf+nR04TfTOg+MW8cxgE8Azs18BCMI2GHu9qLTIxR+Wz+EAP8vOk1OATy0gC7MPMB3aJ7oGplssJCqaKYXrbYgCcqa4h2p9U4v8Rj2qHHg2vB3GJVszyI6zvA2GlaPhQ7KGSVEZXGOKHDoEvITvTUYQx1Zz1do/pBfPic4yQSeb+/6sQetrp0V6fa/v2QQyBRLILomyCXNs40GHIqfXensve+4BobcoUMxR6MDW0UOUB2znD9ALHFM8yTZ2WzF159RsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KiAYYLtoJcZ0ef1TKBd9mkMzCibQRMQn8O1pGk/WpTA=; b=n/0aAaJFVjN/D+3xRT3iNGmwZaJ1CP7lAqlisCjCtpA37PNTmJ2T8O2eZ/7OEr25oOikKaGNgVxvkjIr7+vhVc6NJfJ1J+ScBSWP/Xay7ltvWwKewGEEh+EBRZIDdlMYEdpNMXX0eEShI6xseFHs0kkYIcW+hQzB3LiFtKcVam8= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN8PR11MB3569.namprd11.prod.outlook.com (2603:10b6:408:85::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Wed, 11 Aug 2021 01:56:12 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6413:4198:3c40:777f]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6413:4198:3c40:777f%3]) with mapi id 15.20.4415.014; Wed, 11 Aug 2021 01:56:12 +0000 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: Michael Kubacki , Benjamin Doron Subject: Re: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS Thread-Topic: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO Base/Length to SA GNVS Thread-Index: AQHXjjqCAnkwC+4xxkyYDQJRxrTXEqtti6Pw Date: Wed, 11 Aug 2021 01:56:12 +0000 Message-ID: References: <20210810225309.27112-1-nathaniel.l.desimone@intel.com> In-Reply-To: <20210810225309.27112-1-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6477c9fc-b3ea-4c60-722e-08d95c6b3239 x-ms-traffictypediagnostic: BN8PR11MB3569: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lJjCCOde1xyd7K/Cw93oLnoe071EOo9BMLI2JmTFu1fssJOeFG8MpF2GnY2EruLpuOuLjoftU1Twyf9AK6FUCsNjVK2mgIYOpA4KDd5un0yK3ZYnZuX5p8LN1dR1wyRa+LJbBEW+JJ72rIgKVXEasFC1jZQvg/hkL+lXK6ePBjtMZ4R4lC1+I9Sinjbsr4kwrmfuroIC1Jer8Fnx+Gu48GecOzb0Z/7zDl/kNatFIHZxVlZJfLPwrWf35k7svxKRY45dLonLYshfUPNfuRCv8g3xFtCo1jwC/scR29AogU8iYCX2kfG5LD2uk0i+N/d/jQiOwqD/WCA4Cy2m+UhUuZNWSLSBDFf775aKyAiFBrrIJEpoKMOqlMq6//WntTYZEdQDD15DYNzGEtVyeKVjK04mJAMu/Osv2a8JSuITjX6UvrrbFPIR0qytJ5vrMdwAchaRF9SfITfZhQ8LiErCfBhJl56tmXjRW+002Qgg57bePbOYjImBiJ2wHsnp5+NVTubMyHnUifj5q++1pKsd8hEDfR5uQS2DVNWieLFbAYurZBHYhHQ+54ZHwS0bOsmKdI9AE8sAegCounaJ6+iG/Wa6/tQSgjXSKPIUO4p2X7cC924zDRXTWEIRwSJxd4W4ErBsZfoWwbcYuM0PE9ASBHX3hRauYPuMnxEuMEAmGlvuGCVy8Np+AYpglHgp6RQ2kXu59u4ttOoc1MBx/A5mbg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(136003)(396003)(366004)(33656002)(8936002)(71200400001)(186003)(9686003)(8676002)(86362001)(54906003)(83380400001)(76116006)(53546011)(19627235002)(6506007)(26005)(478600001)(55016002)(110136005)(316002)(2906002)(66476007)(38100700002)(66556008)(52536014)(64756008)(7696005)(4326008)(5660300002)(38070700005)(66446008)(66946007)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?auNZATg4TeMXDBj1lYHkJHieeronI1ZGTiPOQWvFAnHqwiW4f2j0TjmtvEiR?= =?us-ascii?Q?ViJsChXQ87JjoxdUvgOkXL+sI3t4doIPN1xHvVlY3Q/kW9CasVRpKUNMkcfV?= =?us-ascii?Q?rbgQFSAWCKAbGaZvUu8C2ypx81yTbT2+KZw+yRixiX+i6+ngs+RbWNIuwCJT?= =?us-ascii?Q?TByyq63cOjgh3hOc00nnN4SgrGtFFM+zPFPXYaEcS0C37wOr46ozp36WHGmQ?= =?us-ascii?Q?fjLjCGC2CDv1nZswI0zufbfXyrbx/mSBefmlpmYK1Z3mYoAlvjD2jLMZzWKz?= =?us-ascii?Q?YbVb27Umega5QhSLlq+wLzHMUKPcj/1quq/uJG3slePtqn3419s1IiEwiLuQ?= =?us-ascii?Q?cmjqmkdu3Mh5Io5OxCKu6nk+0RmCEU0bucbzWz5YaJ2T9bJZJnG085FZtLcF?= =?us-ascii?Q?MCkxYlGEXrXLEZKSwVGk6bFmjc/jbwU7XEI3FFbSNL+mbTXi53g2sJETj4Ig?= =?us-ascii?Q?Bq6PH8vZLGu9A8UPMbmQuz5a9H6GnHqMdcDChCsZrhgcINW+vj44BLaFo6g9?= =?us-ascii?Q?+n76maNcV4kHax3la6G+Hcdd4Ie8NdSDOE+UIKO6uNgGV0jvRSi4NSPCkB3Z?= =?us-ascii?Q?LErGgYFF9FE2l1ozDrlJ2sjzNl6hKcVyfLrgVT64Fbq7kiC+M+m3+9Us8836?= =?us-ascii?Q?mPgGg6fdsT/mgAJ9fb+7v/Mp0hUehh/eFJjvg4qDeRebThhvfJfmIt/S6pM8?= =?us-ascii?Q?RCi8dBU4k6ZXwA3PA6H1usEKDRLmur7yhfYvJBT7Z0vTqxiq53Q9dPqMTQai?= =?us-ascii?Q?jOxSFzapGZ0f4k2ah49846yAIF/gmEnrv2JNKuOeWVVM0syJZw1a6VaKbxXp?= =?us-ascii?Q?VvkA6wdNiVbE4slQIAnf0KVmJ5K6Jm53014if5hw/lv2UOTYx8X4YJ4Sci1f?= =?us-ascii?Q?IHJdhfBDxLD+LkcmIjgN7/eQ3Q7r3W9hiEtDh4Efg6Gv+l4SCxdXZxeqcvi8?= =?us-ascii?Q?CifSBguMvhYxNYfMRQ9PU9vOwDlBeKob/bPOkuyhPpO+bGZVGt3vVb9CSiP+?= =?us-ascii?Q?EYBPzKqfNbq+CFvMWIw66jwHBISznjpNgJCSnzpBWt65pbEBqAgJITMTswVI?= =?us-ascii?Q?yWOk3okYlC2UWPWE48RHsVmrrIv+qYDBArkHHiISqIvSYRnr4OnO8kdoBvrq?= =?us-ascii?Q?BqGYxe8TDzCftmRF1kUpwlIt4IvbAQ+1TA5cC5HGOQ87kmHq7EqTZaLoNywT?= =?us-ascii?Q?C1/Z1fbUUf3qTW+lQI5ufvvkgwZGbqOx0Uz2wKXwTxu6pK6dLifvZQXE3e2K?= =?us-ascii?Q?k2ih/bYM9dVZAaHC9bZBJa2hdOkfRIAswT1fXMzO/roSNw/wAU/lNTLEUp7Q?= =?us-ascii?Q?rpLDJW2ZhEy1KFvFzTvhW+vl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6477c9fc-b3ea-4c60-722e-08d95c6b3239 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2021 01:56:12.2631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ICqdbjsRhT7AZ69zCThYz77l6mj6YngOypPOSfCDTRRE8DntVV+7bCnoTtSy9vxH11WBC7BGAENlXCfXeO9fQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3569 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, August 11, 2021 6:53 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Michael Kubacki > ; Benjamin Doron > > Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Add MMIO > Base/Length to SA GNVS >=20 > The SA GNVS Area contains fields for the MMIO region base address and > length. This implements code to populate those fields. The MMIO > Base/Length are used by ASL at runtime and must be populated for normal > system operation. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Benjamin Doron > Signed-off-by: Nate DeSimone > --- > .../Acpi/BoardAcpiDxe/AcpiGnvsInit.c | 57 ++++++++++++++++++- > .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 12 +++- > 2 files changed, 63 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit.c > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit. > c > index 0d9d217e38..b09b92f2e6 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/AcpiGnvsInit > +++ .c > @@ -1,7 +1,7 @@ > /** @file > Acpi Gnvs Init Library. >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -11,11 +11,51 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include #include #include > > +#include > #include >=20 > #include > #include > #include > +#include > + > +/** > + A protocol callback which updates MMIO Base and Length in SA GNVS > +area > + > + @param[in] Event - The triggered event. > + @param[in] Context - Context for this event. > + > +**/ > +VOID > +UpdateSaGnvsForMmioResourceBaseLength ( > + IN EFI_EVENT Event, > + IN VOID *Context > + ) > +{ > + EFI_STATUS Status; > + SYSTEM_AGENT_GLOBAL_NVS_AREA_PROTOCOL > *SaGlobalNvsAreaProtocol; > + > + Status =3D gBS->LocateProtocol (&gSaGlobalNvsAreaProtocolGuid, NULL, > + (VOID **) &SaGlobalNvsAreaProtocol); if (Status !=3D EFI_SUCCESS) { > + return; > + } > + gBS->CloseEvent (Event); > + > + // > + // Configure MMIO Base/Length. This logic is only valid for platforms = that > use PciHostBridgeLibSimple. > + // > + DEBUG ((DEBUG_INFO, "[BoardAcpiDxe] Update SA GNVS Area.\n")); > + SaGlobalNvsAreaProtocol->Area->Mmio32Base =3D PcdGet32 > +(PcdPciReservedMemBase); > + if (PcdGet32 (PcdPciReservedMemLimit) !=3D 0) { > + SaGlobalNvsAreaProtocol->Area->Mmio32Length =3D PcdGet32 > +(PcdPciReservedMemLimit) - PcdGet32 (PcdPciReservedMemBase) + 1; > + } else { > + SaGlobalNvsAreaProtocol->Area->Mmio32Length =3D ((UINT32) PcdGet64 > +(PcdPciExpressBaseAddress)) - PcdGet32 (PcdPciReservedMemBase); > + } > + if (PcdGet64 (PcdPciReservedMemAbove4GBLimit) > PcdGet64 > (PcdPciReservedMemAbove4GBBase)) { > + SaGlobalNvsAreaProtocol->Area->Mmio64Base =3D PcdGet64 > (PcdPciReservedMemAbove4GBBase); > + SaGlobalNvsAreaProtocol->Area->Mmio64Length =3D PcdGet64 > +(PcdPciReservedMemAbove4GBLimit) - PcdGet64 > +(PcdPciReservedMemAbove4GBBase) + 1; > + } > +} >=20 > /** > @brief > @@ -39,6 +79,7 @@ AcpiGnvsInit ( > EFI_MP_SERVICES_PROTOCOL *MpService; > UINTN NumberOfCPUs; > UINTN NumberOfEnabledCPUs; > + VOID *SaGlobalNvsRegistration; >=20 > Pages =3D EFI_SIZE_TO_PAGES (sizeof (EFI_GLOBAL_NVS_AREA)); > Address =3D 0xffffffff; // allocate address below 4G. > @@ -53,7 +94,7 @@ AcpiGnvsInit ( > if (EFI_ERROR(Status)) { > return Status; > } > - > + > // > // Locate the MP services protocol > // Find the MP Protocol. This is an MP platform, so MP protocol must b= e > there. > @@ -90,6 +131,16 @@ AcpiGnvsInit ( > GNVS->Area->PL1LimitCS =3D 0; > GNVS->Area->PL1LimitCSValue =3D 4500; >=20 > + // > + // Update SA GNVS with MMIO Base/Length // > + EfiCreateProtocolNotifyEvent ( > + &gSaGlobalNvsAreaProtocolGuid, > + TPL_CALLBACK, > + UpdateSaGnvsForMmioResourceBaseLength, > + NULL, > + &SaGlobalNvsRegistration > + ); > + > return EFI_SUCCESS; > } > - > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > .inf > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > .inf > index 7d2e105e54..5d3d4c3a2b 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > .inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe > +++ .inf > @@ -1,7 +1,7 @@ > ### @file > # Component information file for AcpiPlatform module # -# Copyright (c= ) > 2017 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -38,6 +38,7 @@ > PcdLib > UefiBootServicesTableLib > UefiRuntimeServicesTableLib > + UefiLib > BaseMemoryLib > HobLib > AslUpdateLib > @@ -48,8 +49,15 @@ > gEfiFirmwareVolume2ProtocolGuid ## CONSUMES > gEfiMpServiceProtocolGuid ## CONSUMES > gEfiGlobalNvsAreaProtocolGuid > + gSaGlobalNvsAreaProtocolGuid ## CONSUMES >=20 > [Pcd] > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemAbove4GBBase > + gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemAbove4GBLimit > + > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiGnvsAddress >=20 > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiSleepState > @@ -65,5 +73,3 @@ > gEfiPciRootBridgeIoProtocolGuid AND > gEfiVariableArchProtocolGuid AND > gEfiVariableWriteArchProtocolGuid > - > - > -- > 2.27.0.windows.1