From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.3913.1650426589674756327 for ; Tue, 19 Apr 2022 20:49:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=giwCubg8; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650426589; x=1681962589; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=nim82w64MyeuhaI9QcKVwr3iRoiQB19OX61bFv/v8B0=; b=giwCubg8WvtVhi0sGsqVdlEAx5TifEvcrA10rVuY8/fxLw514G5b0AtV oewGF+rULuaX4M2w0AtImdvPnzthX7jaREPp/46i8DC2AwC+QJmOJ5Ben 77SjShgwcUzGIa3w6DxmmUassg0S1p8gnKXNzrVHzBrypRygPJoxBQvlv 26mugCo7w3Pc3PxmYRJLmV0PoUMEsLWDbCZ89hqRziulGdAwABAVxDV8v h8ghJSULPkH3fZfgiLLK0b+VwmQL2x+pjCR34dlx9sAYNrc8qjI2OdUii jZliz9bBB9ds4RhqsqMHM4pmt1k9QwzfXnyiOJBo84M7wHFzswiLlyLBQ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="264102660" X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="264102660" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 20:49:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="529576290" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 19 Apr 2022 20:49:48 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 19 Apr 2022 20:49:48 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 19 Apr 2022 20:49:48 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Apr 2022 20:49:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDvaf/GhUzjOe18teHLS731a1Z4uUiKex2qn6EMT3geW6u9HpHnDtZUTaZTLfbPpj5JT0fA/KUNIwdbFuzxOVMbdVcUbwc6Whvk53zTpJzquwode6fDk2qzo1k9peJDRTsqROD+NKkwWn8vIbr9GiILFt79tAtH6q3cXIzFxEr5g3/+OF8ezmX276dCFEITWNsrdHuGSCgJ5tXowj9GBPqM5PCv2e5JAdEvk1Tg77G07nkhxFApS+kp4FeV2v4xYctrNwMiTcw02vKTfVnmR6T0vawNYuvyrOhygAW5pACoffG81q5qUGJbXqcXIyvTu7sJvC9l8YWmpnXg3z/5Juw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lZDV7IYwHVQS+hy9IaQdf91rxa54vzWzWMoxAHK7cMo=; b=G2MZPZjvzE3Y1HdetYsaMEkYqtP0NwS9oGtK8ep0yxEt6Z5wPZv/+ZhXH0Rkcir7u+tleqEJXNNIOB/E8TYKAAtbOQb2tXPL+3qKnN8Q6Ka5rtMU1z6LGY/8wByJbkSf3UuWdIwTUTDtnpd+TcTJOemqQ7tmS4Eb5Fc1osuzPC6SHYijQssmTpu/S9+P1RIAtESLN9OueVvQz84qyDWhimv0jPtLJsLTyCc/4pfjfbtvuKH6HICbLFiTKhvZK+BoWzVU52MOOdihMuxcFpx+FdWUbTLTlg8TUbbx4NeiBtMk41xJcAn+XABa2S3Qt74xj0Z7bEUvWCFVbEinLHERww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by CY4PR1101MB2232.namprd11.prod.outlook.com (2603:10b6:910:21::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr 2022 03:49:46 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c076:6436:db8e:ee22]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c076:6436:db8e:ee22%9]) with mapi id 15.20.5186.013; Wed, 20 Apr 2022 03:49:46 +0000 From: "duntan" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [PATCH] CryptoPkg: Fix the build failure in CryptoPkg Thread-Topic: [PATCH] CryptoPkg: Fix the build failure in CryptoPkg Thread-Index: AQHYVGfWhyNrULlc9kOtD+q8pJmWSqz4J6FAgAABFGA= Date: Wed, 20 Apr 2022 03:49:46 +0000 Message-ID: References: <20220420033527.752-1-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f550db92-f87d-48d8-0077-08da2280cfe1 x-ms-traffictypediagnostic: CY4PR1101MB2232:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7vZZJ9dKTZrHkv1zjfwiXwi11qgM0iEl2T/o/hfYaHhpJVSV6MFjUZy9WBPPI6OOc2qiSWm3AnPGTU1dxpWfgdxHB4fbw0uNAs0DCch6jZNQKspBJTALSU6M+qG69ZMzZR8MPGxP7PomiPTQhinWZA48nj9K/dWzvrbRTCPlA3RMeXXybYJL6La5VtNo63JFNVp5ouzOpXQmbx1RZ8Ifw5/hEIw0DSxYWj/+zCERMcvCdShRersGtLsHvEawiVXROuerTINWt2Q1PiDXIErdETMCLW7eanRjSNzE+Ez2pDxc2vPw1S7xkGawikCy42qBCeqhkBWcN16qvAoD5US5zhI8x0wxpICyqiXbB1dUui0c2ofVd+FlL6+BzWk+lj96bwYSBgmjaD3wLQh99AYvaDvGcRRnJljjfOvBlLBXM/ExWvWK7W90wtWbcfdpmRixZZ0ovPxKF3My8n+b32OQZ8pBzyRSsSWYENS2oafvYqM9hOQPY6WhavbRhVcZbKiuwemRkWB9mQHZ3MfB9I6AojDbILd/whBMgB6c+zeC2nFA5QPDx6iu7uY6gDVm2CI8RnibOM8PnIzC3S9ZRy6IsPoARcsZH89Fh9suR1bBTjtSASGM0wM5cfY3ljkBKO5Xx9PQvkIY8UGO7B/fRMdbvvCtaPRhO82cGw7SvtqZwK/cjtvb/tTNCb0PLaQcDxig1Ib6t/wPpP4iK+ra33DOL6VRphJfnl7wddzsYP9YwSw+sHO9aaQNa4y1OyFkOaNSA3KveOhtDV9jHRywXzmF3sjdmZdpM5KyJ16s3Gk7mt2wgq4mrI3WAgLoi4MMKddL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(122000001)(38100700002)(53546011)(107886003)(9686003)(26005)(186003)(83380400001)(54906003)(33656002)(110136005)(7696005)(64756008)(66946007)(4326008)(66476007)(71200400001)(82960400001)(316002)(508600001)(2906002)(86362001)(55016003)(5660300002)(8936002)(8676002)(76116006)(66446008)(38070700005)(52536014)(966005)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Py2apJytLhWQtvJsX1BCglHmRIbkNeCA+IDigUoBtiCMPpKqhVX4nIjg7kwl?= =?us-ascii?Q?4lNc5lryfzyEHHxtAwTzEQyxOex+O93jlPfpsP+Kkjf6SsqDrEDcx0LXFNbm?= =?us-ascii?Q?UFbxFzK3ZFf0IZdnvOzAt5wADPXSyjBsL79rt2njFkcozWsABoYSDXbJYnBe?= =?us-ascii?Q?nooHV8LyLwH8VZxUNQNWu0fldvmL8eoU4foplx0g59eEVmAS6NTbH4C0lO1/?= =?us-ascii?Q?hCGqOOv04Vo+nkv4mE07/cGkLGa+PDQI4Rt1qBy8VWNOi8C0QhotOJS2o+hE?= =?us-ascii?Q?prgrAGiG7kReF86a0Icskeu1ikVShprjtorJITWOVu2Iq+JDwxKiHgYpL2tm?= =?us-ascii?Q?Z9nq2fG6eaOYYnV1sd0PD1m9AfyrQmDp1av63Kp7tthZgJAc6VkXSn0paUt7?= =?us-ascii?Q?a5MmjINzvDTaFS0z7Rjd4oiReV+bnoW21OWC2j7C22AFLpX1ql79Z2Qv6UGj?= =?us-ascii?Q?vLthL8wq0jTYM8TIJBTG5Z6chabip0f9CHQ7WKBCMSOK8kGoboGQ1mjg2RCZ?= =?us-ascii?Q?8SJHs1GBAML3BZXmjR2F6RGwBFEKiFQmMTkrljYPY6GFh1warqjYmX9aW1RH?= =?us-ascii?Q?PUYvyBiAmxhJgXLl0lgVWX6peoU+/qR+ux1pdhZzVmmRd4SmZPGrrPd0RyJI?= =?us-ascii?Q?kxSnE9v3SbJJkwN9QtDWR3pgPW28fxSRn/3zn80E4Eqwj3TZbECF7G7rlL4k?= =?us-ascii?Q?UygJnATIkX8u6dW9bnQYDMabA9Z7Y7wwJDYdSpON9u2XSKTBjHiZgyiFfDZZ?= =?us-ascii?Q?KE+gD0UuDSmHmBff0LD70ONV8lGk3UlfHMmzOK3Ls4Ish87PZLrBZGizxfjm?= =?us-ascii?Q?BsCtZ6lhz5IhB9xa9Lroirl9GEhyrVe7zENDUZ3IkmwCAcoT6qcKRhnBlcJ2?= =?us-ascii?Q?q+xNqslX44S2o7zxp2hQ3GyiQ9Z8kLo0N0eO5/+5Tps8pD3jb0seru0mxsdr?= =?us-ascii?Q?f0O9TBpDaMoU76IIn6DzvZhNh+VCGkHuUHbQtpDZJfv5MLgczdI0AG+kUlt0?= =?us-ascii?Q?xj45/4rpBl8yL3LChehPDfOAidWrXbEwDWiMDbWXYVES8IzLOXU0ZT6+dyBR?= =?us-ascii?Q?2/nYVHJzbjAkplQQM/SsWPpFQUC10XM7+dlg9GxxfqJtq3H6WLih7ze7/sEW?= =?us-ascii?Q?2MZ1Rc4o2oiH777Gtv+C337DTvvtWKBxlQVZaT6ayILanvdbwO7VnlyrET5P?= =?us-ascii?Q?QbwWrQO9vlaXnjA4kGA/0AXr7kt9fh6u/2xayXvo15draqH2Vj8ODng5W4Ca?= =?us-ascii?Q?DJSRlVrxXby0/f8dP7M6Yen0p+jsaaYcTrRh2fYOU7G1nDWQ3L4qC2f6FDqF?= =?us-ascii?Q?no4bzMfSvqEQ0QUatvgPskCpZipK/Z6jS1t91Nn994ZL+ZYvzPae6LnuAXcX?= =?us-ascii?Q?zLOD69UsBxOoZBq2ntaLKDSTJ3Mg9RwsA52crDIdodpRdJtlU+9rxDbZno1I?= =?us-ascii?Q?3Ilj8AAGUtJ2A3tTFE2WQvIbQ9jOrt32VM28Wyin/pD34VMf9CF3poklo4vC?= =?us-ascii?Q?yXxyj1gYVOQJfGiXuitiTV0/rMs8vVdqLJH0iNkx5MASNG81b+kRIrrr/L4G?= =?us-ascii?Q?iabPY7Dv2cbqUZLLun2CQIt3AqEfRObLaFMupv836/Z8HJIRSiKKOmEQ9tZl?= =?us-ascii?Q?Z0Mx6vymS777fvklTu2UVfgaUtKMulKRiFVk2qIqcorQMBmXggGACdKY5Wlf?= =?us-ascii?Q?f6Jr/HppPpDpwqueGCbF6w5FahHyfVfLWxh7YhDieNUMSf9U9RkTaC55LpSG?= =?us-ascii?Q?+38iM/KOeA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f550db92-f87d-48d8-0077-08da2280cfe1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 03:49:46.4977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3Ygvb8Sx1WWdVbRfcoRT6YFJ+XV+LQwXsXrzz+hmw0tqNXg2EHmH9VlRO9oR7iaVXsl64OzTgdF2qjs5dmJrIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2232 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, I tested it locally. I just created a PR. Here is the link https://github.com/tianocore/edk2/pull/2800 Thanks, Dun -----Original Message----- From: Yao, Jiewen =20 Sent: Wednesday, April 20, 2022 11:40 AM To: Tan, Dun ; devel@edk2.groups.io Cc: Wang, Jian J ; Lu, Xiaoyu1 ; Jiang, Guomin Subject: RE: [PATCH] CryptoPkg: Fix the build failure in CryptoPkg Hi May I know if you have run EDKII CI for this patch?=20 > -----Original Message----- > From: Tan, Dun > Sent: Wednesday, April 20, 2022 11:35 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J=20 > ; Lu, Xiaoyu1 ; Jiang,=20 > Guomin > Subject: [PATCH] CryptoPkg: Fix the build failure in CryptoPkg >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3908 >=20 > Fix the build failure in CryptoPkg caused by this commit: > fab6285a73("CryptoPkg/CrtLibSupport: fix strcpy") Remove the=20 > 'restrict' keyword which starts in VS2019. >=20 > Signed-off-by: Dun Tan > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > --- > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 2 +- > CryptoPkg/Library/Include/CrtLibSupport.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > index 6fcbe5885e..68e21e8fb6 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > @@ -267,7 +267,7 @@ strcspn ( >=20 > char * > strcpy ( > - char *restrict strDest, > + char *strDest, > const char *strSource > ) > { > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h > b/CryptoPkg/Library/Include/CrtLibSupport.h > index bdc2654b6e..bce38eaa1a 100644 > --- a/CryptoPkg/Library/Include/CrtLibSupport.h > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h > @@ -397,7 +397,7 @@ inet_pton ( >=20 > char * > strcpy ( > - char *restrict strDest, > + char *strDest, > const char *strSource > ); >=20 > -- > 2.31.1.windows.1