From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.9108.1645504383566825355 for ; Mon, 21 Feb 2022 20:33:03 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Ne9ihtgv; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645504383; x=1677040383; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CK+YET6NvrZo5zyc96d3Pu2NYojARCPvGY2HdR61xuY=; b=Ne9ihtgv1ngZKbkhuhf51zNmtLITGe/E3eCM/ByF2jIWGscunjraW48p r0c+b86WUzx7XVSvVNrIfyLyTHMwvmaLo/sA6Br9qqxNqohNknFg5+ZQd A5T1Eu3pOxKtWq4ZLMDJwTIXQJUxDecfKMQhtIK2zkFDmzCjwKThZEcOb rRfQqVXfrRC+e093GnRInYgcoSg238ZZ60atjVYvFq+Y7BgCfinp63UXS ab2tQKpSzVHglpkCd9g8S193QNLkjnHji6IrNpoHHa/lTxn8uNXHQz9a+ QVnFEl/xBn4LQmc8Q99fXBheeOPSHSBKQPQ1hf0juXgbeg3Q54xM66wC8 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="232229040" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="232229040" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2022 20:33:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="591166091" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 21 Feb 2022 20:33:02 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 21 Feb 2022 20:33:02 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 21 Feb 2022 20:33:02 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 21 Feb 2022 20:33:02 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 21 Feb 2022 20:33:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kvosOO+hfSgKVTxmefsXIfQexmpS+/arGGyPDe6c05n2nSbhp6kpg+VUYVm9C9xBVY27U0OWJWdjMnC0utJFra14vHpPk4KY3fUib3NRzxtj0qBlLYam7538745h45nhkRpY+be3EP/a2kVFh4QRKZVwuDP9H/tpYuTlLN7OKPoxp1jrmn3sy5xRPxFWeyCL9XzXzVQJZuNcbyF/EBbxHLtCp9vOYQpnJ/pLVGQKUV4B8T2EtoqYd9SoVlb4XTO/2hjTUlOULyT7GJYjJJKCle08qJFP2f7OAfkw1LgyDFqTyTq6sQETCyRRYvfGWS9Ljy1vQrApn/LsBHHKySg1HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X3EaWp+Ag4U4Ra68MYonn/dkh9T6cVCmIEdW/oiM6O0=; b=QdQH939V3l2uwHa6pGclhsSobMWLWh/OwqRt1F729jtoHw9ZvPkMZcw3ox4CS7iz+8TMsHSro7JuqpstPt7sBEcA6oCRLYcYvIRqLXblUnqczU/+CWLZPQAE+vc0qMYxFr1jMPJUiE6s06p0Fxv2IgGj+G+FBkuFs/AxtA1jCa+ZASnXtvfnfNxDu5XI9wl7roa8jds78tTiy7jgkhTMj2S9h/jxGnp9eUFq3JK5iU0sK2K7srbyXVKV1HzBXAQNeHgQl8MdkbfOB3N/BL67FjNGWsc7Ve4Uo7iXChi8xZIVQQ9cSjSGPbr9RJEEohEGrj1NnHudOrNA/4szhDNd6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by MWHPR11MB1678.namprd11.prod.outlook.com (2603:10b6:301:e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb 2022 04:33:00 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::8c4b:e24c:c69f:7809]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::8c4b:e24c:c69f:7809%5]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022 04:33:00 +0000 From: "Chiu, Chasel" To: "Ni, Ray" , "devel@edk2.groups.io" , "S, Ashraf Ali" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "Kuo, Ted" , "Duggapu, Chinni B" , "Chaganty, Rangasai V" , "Solanki, Digant H" , "V, Sangeetha" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support for X64 Build Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support for X64 Build Thread-Index: AQHYIPaRcdaLmzpRO0GKDPuFn4BM7aySt2IAgAxQfyA= Date: Tue, 22 Feb 2022 04:33:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-Mentions: ashraf.ali.s@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1eb0f499-b99c-4e2a-d7f6-08d9f5bc6850 x-ms-traffictypediagnostic: MWHPR11MB1678:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ikf7cq4Zfb/Jd5NSSsDXWJD/LC2P0dkY7nOzrq1hedRtWXrOHPt4LRS88p7LL7VX+s1MY6ISx5Nst7seHCyjtR3fWoJ7Ph17ISUU82MBqyn0JXeisxNm8VDKTLYp0SxlWTtxnzAKPMapxBMMwisl6oZxrRdjG4SJVD8lujHv/IeWParj8eJdg5GXo4+7Yzky2rp/4UklcYg31/5jryIlA3Jld6fJhDksFnZNdTxIqPh77Vktau7Vq3Gb5HcMLcz6OzUaWbUfywVFEd3DxS6PRZ5/Rps1M5K6eQ4SJpj7vc/EXNK1iCn7hA8f41ZKR8OQdAGmvZLA6H5TD05wIwC326RToDdrNh6O5+ePm6bcMW9pEYjH3p8nF68jvmvmd5+wG0Lth29IR552Egfo+Jx18abVIj4tGmGJU8GfcrToGnbsTKHzCEjzLsiKydmsbbykoB/BCYrp+NYWcpUFiFH64QXFoHvke5VrB66Pg678GocR4PoVu7/t873a+7XjZzS1SdImiGQqM3WQz7jjD8tZvmSHZO039ATH0CmRjbk/F2HnGx79LX0pQE3hVB0zeAHCh7JKWdFaz6Yvow5twWXZvNastjPIDYC7OM+TwPCfdwlBN05z2hS3LocgmJHCecTjeOOELGKlV0eyMuUpFJdIPtmhoFnHkD0ua5QVFcWpiVJi9P36IILmaNfFpuYZH49+KXCySq6MZ1zFJ9N4H+K2hAFKe74xoc4HgdHt7ZP0bD16naT3xxzzzoqpRaMXhUkaEzppI/etqUQ5SB4fleX453MfO9KRy76JCNvogo//IKX/uJKr7kt3I/WUQTxU6ga2YMcLSfC16pGOP60aJyC42tOZgyw+qOw8N2c3IbMsAqqAxoLcAMXGYNpqDLY81Oll x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(6506007)(7696005)(186003)(26005)(2906002)(53546011)(71200400001)(122000001)(107886003)(82960400001)(38070700005)(38100700002)(66556008)(64756008)(83380400001)(110136005)(66476007)(76116006)(66946007)(316002)(508600001)(54906003)(6636002)(52536014)(966005)(8676002)(4326008)(66446008)(9686003)(8936002)(5660300002)(19627235002)(55016003)(33656002)(11716005)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TPEGKRhyWmNtSeVHfQ3+/c7PoXRqHNgaSnTuqvIYLM69h9cPZwRGLIfziDrA?= =?us-ascii?Q?Sp57eP3TxH3Oey7M8/DjW0R9W6ypcjQPjKYm/JcIFxiaI54EOJ6K3eT1Oy6o?= =?us-ascii?Q?9noxKht45p2H9w//s2HLd3erTV7fOi3Tf21UAnC9BAUG0wiTbxzKOlmmbW/M?= =?us-ascii?Q?qq8Y4UbZWv3BSphlm661qnKNLXt6NPwmF+3H/wmc9yjJ7P6h/DOUUtEH1ggT?= =?us-ascii?Q?R2aEEk9pwYmGZYAIoKzs9szyWV4mKPAYa0jS6cj8U2KGYWAnY3AqTGJo9+K/?= =?us-ascii?Q?S0/lW9IWU6SAo+icJHqvd3BTx2X1pVY9jnMPuPyCSZQv7x5OSHOkj7UDPm7P?= =?us-ascii?Q?14rpecfUiab3jKNz99XgzFrGIn/OVoAdR4ZpUJgpKzFsPl3/wV9ORPzEJTyB?= =?us-ascii?Q?22tEn/1ZtY3yTcurTz/CYUpAJjSr3b+0QjzBukRlimdutxxcSaOqNwmCsqLL?= =?us-ascii?Q?SrY9uZMZr2ka/fbD4iOCK7qFnPN2kCRY6iffqPxGTqAefo+kFlfduSDIgTPC?= =?us-ascii?Q?AlQtzxJnx4dNAb6CY+2E3+lf7n6OWex2TiYGMLfhBvnZHNNuQggOtlci9OU4?= =?us-ascii?Q?UJWp9jaGThVF6lDBfQm4cks/OfxCqy2ESjx5eh/WdpYeIMrANUCvcYAcpdTL?= =?us-ascii?Q?fGH0E06O4dpvapbE46mxfOeVlG9ZYfzCstssVk+K2N9ujPOVHlfB3Pcm+uCn?= =?us-ascii?Q?hZvLE1cYiC+AIYkMx3flHbvo752t7puIbfncc1F/BMF9D4+PMOpQNndkvhFO?= =?us-ascii?Q?Tfz5tlMCYlmz9MaYQ9LnjlBqzi+uRW70ZCwcVRTy+a+Vav6i9N7hZMTjUiWX?= =?us-ascii?Q?oaUv7poTyVTPBhqaxxRtcTx4ci0mzNab5YG5RJi9Jx9FtikJCdO33VxzAsTt?= =?us-ascii?Q?rpUj1b6zvHeqCSHY4OfNNY2X8TksOa7wu3ZTJUHF1VsSeOjH6KGNTP1ROZKE?= =?us-ascii?Q?ZjDipSTwoWd7uEZROdW9UPmNCP3duusQs809BE7HNax/p2zBI2LhJG4TdgHD?= =?us-ascii?Q?Xc8wbNN4muGmfuneBftYcdVPPDw2mVjhYHv5L2mViuy/fkb+rKUNaGPu4QQL?= =?us-ascii?Q?sP+LyRF14kIAS5Zvv39YNtSd8oVeXLaJGFkoSgT02BqagSCFssfenLxmoh8V?= =?us-ascii?Q?F5mrwX1W8OrGhv0TdWaLLnXGioQMcuIrJHaUpZnZ3x4Z56jR8zVhRYuiy4I6?= =?us-ascii?Q?qOvtu+k1yLokgbC0RtrtltGzNywt8yvGHygHzJSH9LFXuYfVSQSuMypI2fhp?= =?us-ascii?Q?+tRpCkULdUM3bdYKX2A1meH3n6jJDcxI7veJznpfQpJG8+Qsv9QaRMzPy5Gj?= =?us-ascii?Q?y6+Yku+i9imTLIdzHJxqIJ4AqBzuTKf3mNRSpdVCv/JqO23m0vV8jge8jPL1?= =?us-ascii?Q?iYWJV3NzxdK1ch24DzRw+uuTXWwpzXvkjfOai/5BO3h5dt4FMS2vAmSQ6kod?= =?us-ascii?Q?1H6vsdW298s+UBEBObWtfi75NDwEreom974Duofw361KfqFwZBwbUqsFWszx?= =?us-ascii?Q?FyJARApHeKmpBYO7bFcGTY2/XzYWZ7R2ZRoPkp6sE68E+sozV9ncRqBKpIOM?= =?us-ascii?Q?yzThro/9dxbh+TlkSoY8ONhHkK/qx50uTdQVPK6Mltjd/WtTuCtVGZ1V9WMh?= =?us-ascii?Q?Zw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1eb0f499-b99c-4e2a-d7f6-08d9f5bc6850 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 04:33:00.1327 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oE27OwZ4mwNGTGlkejGZp+QITt+9amSPs7k4yplX6BGsU+fOBEt/EO++I43zb2c3P0JA2wKhSPXjcH5xMLtXkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1678 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Ray! @S, Ashraf Ali I think we need to return 64bit pointer in 64bit build, plea= se help to verify and confirm. Thanks, Chasel > -----Original Message----- > From: Ni, Ray > Sent: Monday, February 14, 2022 4:27 PM > To: devel@edk2.groups.io; S, Ashraf Ali > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Kuo, = Ted > ; Duggapu, Chinni B ; > Chaganty, Rangasai V ; Solanki, Digant H > ; V, Sangeetha > Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort > Support for X64 Build >=20 > Ashraf, > GetStackFramePointer() only returns the lower 32 bits of RBP. Is that exp= ected? >=20 >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ashraf Ali= S > Sent: Monday, February 14, 2022 12:27 AM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Kuo, Ted ; Duggapu, Chinni B > ; Chaganty, Rangasai V > ; Solanki, Digant H > ; V, Sangeetha > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Sup= port > for X64 Build >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3833 >=20 > Move FspDebug to the root of BaseFspDebugLibSerialPort since the current > nasm support for both IA32 and X64 Build, remove IA32 from INF file. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Kuo Ted > Cc: Duggapu Chinni B > Cc: Rangasai V Chaganty > Cc: Digant H Solanki > Cc: Sangeetha V >=20 > Signed-off-by: Ashraf Ali S > --- > .../BaseFspDebugLibSerialPort.inf | 8 ++- > .../{Ia32 =3D> }/FspDebug.nasm | 50 +++++++++---------- > 2 files changed, 28 insertions(+), 30 deletions(-) rename > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/{Ia32 =3D> }/FspDebug.nasm > (86%) >=20 > diff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPor= t.i > nf > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPor= t.i > nf > index 14b1899e6c..0024edf2dc 100644 > --- > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPor= t.i > nf > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSeri > +++ alPort.inf > @@ -1,7 +1,7 @@ > ## @file > # Instance of BaseFspDebugLib > # > -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved. > +# Copyright (c) 2014 - 2022, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -16,14 +16,12 @@ > LIBRARY_CLASS =3D DebugLib >=20 > # > -# VALID_ARCHITECTURES =3D IA32 > +# VALID_ARCHITECTURES =3D IA32 X64 > # >=20 > [Sources] > DebugLib.c > - > -[Sources.Ia32] > - Ia32/FspDebug.nasm > + FspDebug.nasm >=20 > [Packages] > MdePkg/MdePkg.dec > diff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.nasm > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/FspDebug.nasm > similarity index 86% > rename from > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.nasm > rename to IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/FspDebug.nasm > index 997e375c8c..ffacaa239d 100644 > --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.nasm > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/FspDebug.nasm > @@ -1,25 +1,25 @@ > -;-----------------------------------------------------------------------= ------- > -; > -; Copyright (c) 2016, Intel Corporation. All rights reserved.
-; SPD= X-License- > Identifier: BSD-2-Clause-Patent -; -; Abstract: > -; > -; FSP Debug functions > -; > -;-----------------------------------------------------------------------= ------- > - > - SECTION .text > - > -;-----------------------------------------------------------------------= ------- > -; UINT32 * > -; EFIAPI > -; GetStackFramePointer ( > -; VOID > -; ); > -;-----------------------------------------------------------------------= ------- > -global ASM_PFX(GetStackFramePointer) > -ASM_PFX(GetStackFramePointer): > - mov eax, ebp > - ret > - > +;---------------------------------------------------------------------- > +-------- > +; > +; Copyright (c) 2016 - 2022, Intel Corporation. All rights > +reserved.
; SPDX-License-Identifier: BSD-2-Clause-Patent ; ; > +Abstract: > +; > +; FSP Debug functions > +; > +;---------------------------------------------------------------------- > +-------- > + > + SECTION .text > + > +;---------------------------------------------------------------------- > +-------- > +; UINT32 * > +; EFIAPI > +; GetStackFramePointer ( > +; VOID > +; ); > +;---------------------------------------------------------------------- > +-------- > +global ASM_PFX(GetStackFramePointer) > +ASM_PFX(GetStackFramePointer): > + mov eax, ebp > + ret > + > -- > 2.30.2.windows.1 >=20 >=20 >=20 >=20 >=20