public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Jeremy Soller <jeremy@system76.com>,
	Michael Kubacki <Michael.Kubacki@microsoft.com>,
	Benjamin Doron <benjamin.doron00@gmail.com>
Subject: Re: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix GalagoPro3 Build
Date: Thu, 12 Aug 2021 02:16:26 +0000	[thread overview]
Message-ID: <BN9PR11MB548333A2EFB892AFE3CA8A0EE6F99@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210812015147.28476-1-nathaniel.l.desimone@intel.com>


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Thursday, August 12, 2021 9:52 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Jeremy Soller
> <jeremy@system76.com>; Michael Kubacki
> <Michael.Kubacki@microsoft.com>; Benjamin Doron
> <benjamin.doron00@gmail.com>
> Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix
> GalagoPro3 Build
> 
> This resolves a build error introduced by 891b355.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
> Cc: Benjamin Doron <benjamin.doron00@gmail.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Library/BoardInitLib/PeiGalagoPro3InitPreMemLib.c          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P
> eiGalagoPro3InitPreMemLib.c
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P
> eiGalagoPro3InitPreMemLib.c
> index 6bf77a2af0..f4833149f3 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P
> eiGalagoPro3InitPreMemLib.c
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLi
> +++ b/PeiGalagoPro3InitPreMemLib.c
> @@ -29,6 +29,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include
> <SioRegs.h>  #include <Library/PchPcrLib.h>  #include
> <Library/SiliconInitLib.h>
> +#include <Library/PchResetLib.h>
> 
>  #include "PeiGalagoPro3InitLib.h"
> 
> @@ -192,6 +193,8 @@ GalagoPro3BoardInitBeforeMemoryInit (
>    VOID
>    )
>  {
> +  EFI_STATUS    Status;
> +
>    GalagoPro3InitPreMem ();
> 
>    //
> --
> 2.27.0.windows.1


      reply	other threads:[~2021-08-12  2:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  1:51 [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix GalagoPro3 Build Nate DeSimone
2021-08-12  2:16 ` Chiu, Chasel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB548333A2EFB892AFE3CA8A0EE6F99@BN9PR11MB5483.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox