Re: [edk2-devel] [PATCH] MinPlatformPkg/DxePhatLib: Add to CoreCommon dsc

["Chiu, Chasel" <chasel.chiu@intel.com>]

Hi Zack,

Usually we would like the LIBRARY_CLASS to be "phase agnostic" so we can share the same API cross different phase implementation.
Please see if we only need to update DxePhatAcpiLib.inf LIBRARY_CLASS and add INF to CoreCommon.dsc

Thanks,
Chasel



> -----Original Message-----
> From: Clark-williams, Zachary <zachary.clark-williams@intel.com>
> Sent: Tuesday, February 20, 2024 1:42 PM
> To: devel@edk2.groups.io
> Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH] MinPlatformPkg/DxePhatLib: Add to CoreCommon dsc
> 
> From: Zachary Clark-Williams <zachary.clark-williams@intel.com>
> 
> PhatAcpiLib update to match all file names to DxePhatAcpiLib and add the library
> to CoreCommonPkg for use.
> 
> Change-Id: I6e18ecf5acfdbc2053cf60b9a151b891e4e0fdfe
> Hsd-es-id: 22019504949
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Zachary Clark-Williams <zachary.clark-williams@intel.com>
> ---
>  .../Library/{PhatAcpiLib => DxePhatAcpiLib}/DxePhatAcpiLib.c    | 2 +-
>  .../Library/{PhatAcpiLib => DxePhatAcpiLib}/DxePhatAcpiLib.inf  | 0
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc     | 1 +
>  .../Include/Library/{PhatAcpiLib.h => DxePhatAcpiLib.h}         | 0
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                | 2 +-
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc                | 2 +-
>  6 files changed, 4 insertions(+), 3 deletions(-)  rename
> Platform/Intel/MinPlatformPkg/Acpi/Library/{PhatAcpiLib =>
> DxePhatAcpiLib}/DxePhatAcpiLib.c (96%)  rename
> Platform/Intel/MinPlatformPkg/Acpi/Library/{PhatAcpiLib =>
> DxePhatAcpiLib}/DxePhatAcpiLib.inf (100%)  rename
> Platform/Intel/MinPlatformPkg/Include/Library/{PhatAcpiLib.h =>
> DxePhatAcpiLib.h} (100%)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/PhatAcpiLib/DxePhatAcpiLib.c
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiLib.c
> similarity index 96%
> rename from
> Platform/Intel/MinPlatformPkg/Acpi/Library/PhatAcpiLib/DxePhatAcpiLib.c
> rename to
> Platform/Intel/MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiLib.c
> index e0e502cf0..ebfc542a3 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/Library/PhatAcpiLib/DxePhatAcpiLib.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatA
> +++ cpiLib.c
> @@ -6,7 +6,7 @@
>    SPDX-License-Identifier: BSD-2-Clause-Patent  **/
> 
> -#include <Library/PhatAcpiLib.h>
> +#include <Library/DxePhatAcpiLib.h>
> 
>  #include <PiDxe.h>
>  #include <Base.h>
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/PhatAcpiLib/DxePhatAcpiLib.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiLib.in
> f
> similarity index 100%
> rename from
> Platform/Intel/MinPlatformPkg/Acpi/Library/PhatAcpiLib/DxePhatAcpiLib.inf
> rename to
> Platform/Intel/MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiLib.inf
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> index 790fccf40..657a9decc 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> @@ -150,6 +150,7 @@
> 
> LargeVariableReadLib|MinPlatformPkg/Library/BaseLargeVariableLib/BaseLarge
> VariableReadLib.inf
> 
> LargeVariableWriteLib|MinPlatformPkg/Library/BaseLargeVariableLib/BaseLarge
> VariableWriteLib.inf
>    CompressLib|MinPlatformPkg/Library/CompressLib/CompressLib.inf
> +
> + DxePhatAcpiLib|MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiL
> + ib.inf
> 
>    #
>    # CryptLib
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Library/PhatAcpiLib.h
> b/Platform/Intel/MinPlatformPkg/Include/Library/DxePhatAcpiLib.h
> similarity index 100%
> rename from Platform/Intel/MinPlatformPkg/Include/Library/PhatAcpiLib.h
> rename to Platform/Intel/MinPlatformPkg/Include/Library/DxePhatAcpiLib.h
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> index 09312d329..d006d7117 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> @@ -88,7 +88,7 @@
>    LargeVariableReadLib|Include/Library/LargeVariableReadLib.h
>    LargeVariableWriteLib|Include/Library/LargeVariableWriteLib.h
> 
> -  PhatAcpiLib|Include/Library/PhatAcpiLib.h
> +  DxePhatAcpiLib|Include/Library/DxePhatAcpiLib.h
> 
>  [PcdsFixedAtBuild, PcdsPatchableInModule]
> 
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> index 4b295babf..f9227e014 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> @@ -64,7 +64,7 @@
> 
> PciSegmentInfoLib|MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSeg
> mentInfoLibSimple.inf
> 
> PlatformBootManagerLib|MinPlatformPkg/Bds/Library/DxePlatformBootManager
> Lib/DxePlatformBootManagerLib.inf
> 
> AslUpdateLib|MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.in
> f
> -  PhatAcpiLib|MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiLib.inf
> +
> + DxePhatAcpiLib|MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiL
> + ib.inf
> 
>    #
>    # Misc
> --
> 2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115682): https://edk2.groups.io/g/devel/message/115682
Mute This Topic: https://groups.io/mt/104476855/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-