From: "duntan" <dun.tan@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [Patch V4 11/15] UefiCpuPkg: Use GenSmmPageTable() to create Smm S3 page table
Date: Fri, 2 Jun 2023 03:37:27 +0000 [thread overview]
Message-ID: <BN9PR11MB54833A2A7182D385EA4371A2E54EA@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN6PR11MB8244C378AB692C4F43D045548C4EA@MN6PR11MB8244.namprd11.prod.outlook.com>
Sure, it's to align with the old behavior. Will add comments to explain it.
Thanks,
Dun
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Friday, June 2, 2023 11:31 AM
To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
Subject: RE: [edk2-devel] [Patch V4 11/15] UefiCpuPkg: Use GenSmmPageTable() to create Smm S3 page table
> - mSmmS3ResumeState->SmmS3Cr3 = (UINT32)(UINTN)PTEntry;
> + mSmmS3ResumeState->SmmS3Cr3 = (UINT32)GenSmmPageTable
> (Paging4Level, 32);
Why is "Paging4Level" used for S3 page table?
The S3 page table is used by S3Resume module:
if (SmmS3ResumeState->Signature == SMM_S3_RESUME_SMM_64) {
//
// Switch to long mode to complete resume.
//
......
AsmWriteCr3 ((UINTN)SmmS3ResumeState->SmmS3Cr3);
......
AsmEnablePaging64 (
0x38,
SmmS3ResumeState->SmmS3ResumeEntryPoint,
(UINT64)(UINTN)AcpiS3Context,
0,
SmmS3ResumeState->SmmS3StackBase + SmmS3ResumeState->SmmS3StackSize
);
The S3 page table is only used when PEI runs in 32bit mode, which revolves my concern that CPU in 64bit mode cannot switch from 5-l paging to 4-l paging.
And I guess your code just aligns to the old behavior.
Can you add comments to above to explain the SmmS3Cr3 is only used by S3Resume PEIM to switch CPU from 32bit to 64bit?
With that, Reviewed-by: Ray Ni <ray.ni@intel.com>
next prev parent reply other threads:[~2023-06-02 3:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 9:59 [Patch V4 00/15] Use CpuPageTableLib to create and update smm page table duntan
2023-05-16 9:59 ` [Patch V4 01/15] OvmfPkg: Add CpuPageTableLib required by PiSmmCpuDxe duntan
2023-05-16 9:59 ` [Patch V4 02/15] UefiPayloadPkg: " duntan
2023-05-16 10:01 ` Guo, Gua
2023-05-16 9:59 ` [Patch V4 03/15] OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry duntan
2023-05-16 9:59 ` [Patch V4 04/15] MdeModulePkg: Remove RO and NX protection when unset guard page duntan
2023-05-16 19:04 ` [edk2-devel] " Kun Qin
2023-05-17 10:16 ` duntan
2023-05-16 9:59 ` [Patch V4 05/15] UefiCpuPkg: Use CpuPageTableLib to convert SMM paging attribute duntan
2023-06-01 1:09 ` Ni, Ray
2023-05-16 9:59 ` [Patch V4 06/15] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid setting non-present range to RO/NX duntan
2023-05-16 9:59 ` [Patch V4 07/15] UefiCpuPkg/PiSmmCpuDxeSmm: Add 2 function to disable/enable CR0.WP duntan
2023-05-20 2:00 ` [edk2-devel] " Kun Qin
2023-05-23 9:14 ` duntan
2023-05-24 18:39 ` Kun Qin
2023-05-25 0:46 ` Ni, Ray
2023-05-26 2:48 ` Kun Qin
2023-06-02 3:09 ` Ni, Ray
2023-05-16 9:59 ` [Patch V4 08/15] UefiCpuPkg/PiSmmCpuDxeSmm: Clear CR0.WP before modify page table duntan
2023-06-02 3:12 ` [edk2-devel] " Ni, Ray
2023-05-16 9:59 ` [Patch V4 09/15] UefiCpuPkg: Extern mSmmShadowStackSize in PiSmmCpuDxeSmm.h duntan
2023-06-02 3:16 ` [edk2-devel] " Ni, Ray
2023-06-02 3:36 ` duntan
2023-05-16 9:59 ` [Patch V4 10/15] UefiCpuPkg: Add GenSmmPageTable() to create smm page table duntan
2023-06-02 3:23 ` [edk2-devel] " Ni, Ray
2023-06-02 3:36 ` duntan
2023-06-02 3:46 ` duntan
2023-06-02 5:08 ` Ni, Ray
2023-06-02 7:33 ` duntan
2023-05-16 9:59 ` [Patch V4 11/15] UefiCpuPkg: Use GenSmmPageTable() to create Smm S3 " duntan
2023-06-02 3:31 ` [edk2-devel] " Ni, Ray
2023-06-02 3:37 ` duntan [this message]
2023-05-16 9:59 ` [Patch V4 12/15] UefiCpuPkg: Sort mSmmCpuSmramRanges in FindSmramInfo duntan
2023-06-02 3:33 ` [edk2-devel] " Ni, Ray
2023-06-02 3:43 ` duntan
2023-05-16 9:59 ` [Patch V4 13/15] UefiCpuPkg: Sort mProtectionMemRange when ReadyToLock duntan
2023-06-02 3:34 ` Ni, Ray
2023-06-02 3:35 ` Ni, Ray
2023-06-02 3:55 ` duntan
2023-05-16 9:59 ` [Patch V4 14/15] UefiCpuPkg: Refinement to smm runtime InitPaging() code duntan
2023-06-02 3:54 ` [edk2-devel] " Ni, Ray
2023-06-02 3:59 ` duntan
2023-05-16 9:59 ` [Patch V4 15/15] UefiCpuPkg/PiSmmCpuDxeSmm: Remove unnecessary function duntan
2023-06-02 3:55 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB54833A2A7182D385EA4371A2E54EA@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox