public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python Interpreter Name
Date: Tue, 28 Nov 2023 03:19:42 +0000	[thread overview]
Message-ID: <BN9PR11MB54833CD435D5AC61C2E6128BE6BCA@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231118063629.1397-3-nathaniel.l.desimone@intel.com>


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel


> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Friday, November 17, 2023 10:36 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python
> Interpreter Name
> 
> Removes the assumption that the python interpreter will have the name python.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com
> ---
>  Platform/Intel/WhitleyOpenBoardPkg/Aowanda/build_board.py     | 4 ++--
>  .../Intel/WhitleyOpenBoardPkg/JunctionCity/build_board.py     | 4 ++--
>  .../Intel/WhitleyOpenBoardPkg/WilsonCityRvp/build_board.py    | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/build_board.py
> b/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/build_board.py
> index af6985019b..70ef4c2201 100644
> --- a/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/build_board.py
> +++ b/Platform/Intel/WhitleyOpenBoardPkg/Aowanda/build_board.py
> @@ -2,7 +2,7 @@
>  # Extensions for building Aowanda using build_bios.py  #  # -# Copyright (c) 2021,
> Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2021 - 2023, Intel Corporation. All rights
> +reserved.<BR>
>  # Copyright (c) 2022, American Megatrends International LLC. <BR>  # SPDX-
> License-Identifier: BSD-2-Clause-Patent  # @@ -107,7 +107,7 @@ def
> pre_build_ex(config, functions):
>      if not os.path.exists(out_file_dir):
>          os.mkdir(out_file_dir)
> 
> -    command = ["python",
> +    command = [sys.executable,
>                 os.path.join(config["MIN_PACKAGE_TOOLS"], "AmlGenOffset",
> "AmlGenOffset.py"),
>                 "-d", "--aml_filter", config["AML_FILTER"],
>                 "-o", out_file_path,
> diff --git a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/build_board.py
> b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/build_board.py
> index ccf7a8c55a..61b893686c 100644
> --- a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/build_board.py
> +++ b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/build_board.py
> @@ -2,7 +2,7 @@
>  # Extensions for building JunctionCity using build_bios.py  #  # -# Copyright (c)
> 2021, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2021 - 2023, Intel Corporation. All rights
> +reserved.<BR>
>  # Copyright (c) 2021, American Megatrends International LLC. <BR>  # SPDX-
> License-Identifier: BSD-2-Clause-Patent  # @@ -107,7 +107,7 @@ def
> pre_build_ex(config, functions):
>      if not os.path.exists(out_file_dir):
>          os.mkdir(out_file_dir)
> 
> -    command = ["python",
> +    command = [sys.executable,
>                 os.path.join(config["MIN_PACKAGE_TOOLS"], "AmlGenOffset",
> "AmlGenOffset.py"),
>                 "-d", "--aml_filter", config["AML_FILTER"],
>                 "-o", out_file_path,
> diff --git a/Platform/Intel/WhitleyOpenBoardPkg/WilsonCityRvp/build_board.py
> b/Platform/Intel/WhitleyOpenBoardPkg/WilsonCityRvp/build_board.py
> index e2d32d3e13..8d62dd43b8 100644
> --- a/Platform/Intel/WhitleyOpenBoardPkg/WilsonCityRvp/build_board.py
> +++ b/Platform/Intel/WhitleyOpenBoardPkg/WilsonCityRvp/build_board.py
> @@ -1,7 +1,7 @@
>  # @ build_board.py
>  # Extensions for building WilsonCityRvp using build_bios.py  # -# Copyright (c)
> 2021, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2021 - 2023, Intel Corporation. All rights
> +reserved.<BR>
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  #
> 
> @@ -105,7 +105,7 @@ def pre_build_ex(config, functions):
>      if not os.path.exists(out_file_dir):
>          os.mkdir(out_file_dir)
> 
> -    command = ["python",
> +    command = [sys.executable,
>                 os.path.join(config["MIN_PACKAGE_TOOLS"], "AmlGenOffset",
> "AmlGenOffset.py"),
>                 "-d", "--aml_filter", config["AML_FILTER"],
>                 "-o", out_file_path,
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111784): https://edk2.groups.io/g/devel/message/111784
Mute This Topic: https://groups.io/mt/102667306/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-11-28  3:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-18  6:36 [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of PYTHON_HOME Nate DeSimone
2023-11-18  6:36 ` [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python Interpreter Name Nate DeSimone
2023-11-28  3:20   ` Chiu, Chasel
2023-11-18  6:36 ` [edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: " Nate DeSimone
2023-11-28  3:19   ` Chiu, Chasel [this message]
2023-11-28  3:17 ` [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of PYTHON_HOME Chiu, Chasel
     [not found] ` <1798A438690A80D8.26894@groups.io>
2023-11-29  0:03   ` [edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python Interpreter Name Nate DeSimone
     [not found] ` <1798A43863B4D009.26894@groups.io>
2023-11-29  0:03   ` [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: " Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB54833CD435D5AC61C2E6128BE6BCA@BN9PR11MB5483.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox