* [edk2-devel] [PATCH] UefiPayloadPkg/Crypto: Support external Crypto drivers. @ 2024-02-01 6:09 marsx.lin 2024-02-01 6:11 ` Guo, Gua 0 siblings, 1 reply; 3+ messages in thread From: marsx.lin @ 2024-02-01 6:09 UTC (permalink / raw) To: devel; +Cc: MarsX Lin, Chasel Chiu, Guo Dong, Sean Rhodes, James Lu, Gua Guo From: MarsX Lin <marsx.lin@intel.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4661 There is potential build problem when CRYPTO_PROTOCOL_SUPPORT is set to TRUE and CRYPTO_DRIVER_EXTERNAL_SUPPORT is set to TRUE Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Guo Dong <guo.dong@intel.com> Cc: Sean Rhodes <sean@starlabs.systems> Cc: James Lu <james.lu@intel.com> Cc: Gua Guo <gua.guo@intel.com> Signed-off-by: MarsX Lin <marsx.lin@intel.com> --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 2c4013bd9d..0e142bb7c2 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -480,6 +480,7 @@ gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000 !if $(CRYPTO_PROTOCOL_SUPPORT) == TRUE +!if $(CRYPTO_DRIVER_EXTERNAL_SUPPORT) == FALSE gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Md5.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY @@ -501,6 +502,7 @@ gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsSet.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsGet.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY !endif +!endif [PcdsPatchableInModule.X64] !if $(NETWORK_DRIVER_ENABLE) == TRUE -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114976): https://edk2.groups.io/g/devel/message/114976 Mute This Topic: https://groups.io/mt/104091974/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg/Crypto: Support external Crypto drivers. 2024-02-01 6:09 [edk2-devel] [PATCH] UefiPayloadPkg/Crypto: Support external Crypto drivers marsx.lin @ 2024-02-01 6:11 ` Guo, Gua 2024-02-01 6:30 ` Lu, James 0 siblings, 1 reply; 3+ messages in thread From: Guo, Gua @ 2024-02-01 6:11 UTC (permalink / raw) To: Lin, MarsX, devel@edk2.groups.io Cc: Chiu, Chasel, Dong, Guo, Rhodes, Sean, Lu, James Thanks this patch Mars, it's good catch. Reviewed-by: Gua Guo <gua.guo@intel.com> -----Original Message----- From: Lin, MarsX <marsx.lin@intel.com> Sent: Thursday, February 1, 2024 2:10 PM To: devel@edk2.groups.io Cc: Lin, MarsX <marsx.lin@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Guo <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> Subject: [PATCH] UefiPayloadPkg/Crypto: Support external Crypto drivers. From: MarsX Lin <marsx.lin@intel.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4661 There is potential build problem when CRYPTO_PROTOCOL_SUPPORT is set to TRUE and CRYPTO_DRIVER_EXTERNAL_SUPPORT is set to TRUE Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Guo Dong <guo.dong@intel.com> Cc: Sean Rhodes <sean@starlabs.systems> Cc: James Lu <james.lu@intel.com> Cc: Gua Guo <gua.guo@intel.com> Signed-off-by: MarsX Lin <marsx.lin@intel.com> --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 2c4013bd9d..0e142bb7c2 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -480,6 +480,7 @@ gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000 !if $(CRYPTO_PROTOCOL_SUPPORT) == TRUE+!if $(CRYPTO_DRIVER_EXTERNAL_SUPPORT) == FALSE gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Md5.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY@@ -501,6 +502,7 @@ gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsSet.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsGet.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY !endif+!endif [PcdsPatchableInModule.X64] !if $(NETWORK_DRIVER_ENABLE) == TRUE-- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114932): https://edk2.groups.io/g/devel/message/114932 Mute This Topic: https://groups.io/mt/104091974/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg/Crypto: Support external Crypto drivers. 2024-02-01 6:11 ` Guo, Gua @ 2024-02-01 6:30 ` Lu, James 0 siblings, 0 replies; 3+ messages in thread From: Lu, James @ 2024-02-01 6:30 UTC (permalink / raw) To: Guo, Gua, Lin, MarsX, devel@edk2.groups.io Cc: Chiu, Chasel, Dong, Guo, Rhodes, Sean Reviewed-by: James Lu <james.lu@intel.com> Thanks, James -----Original Message----- From: Guo, Gua <gua.guo@intel.com> Sent: Thursday, February 1, 2024 2:11 PM To: Lin, MarsX <marsx.lin@intel.com>; devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com>; Dong, Guo <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com> Subject: RE: [PATCH] UefiPayloadPkg/Crypto: Support external Crypto drivers. Thanks this patch Mars, it's good catch. Reviewed-by: Gua Guo <gua.guo@intel.com> -----Original Message----- From: Lin, MarsX <marsx.lin@intel.com> Sent: Thursday, February 1, 2024 2:10 PM To: devel@edk2.groups.io Cc: Lin, MarsX <marsx.lin@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Guo <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com> Subject: [PATCH] UefiPayloadPkg/Crypto: Support external Crypto drivers. From: MarsX Lin <marsx.lin@intel.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4661 There is potential build problem when CRYPTO_PROTOCOL_SUPPORT is set to TRUE and CRYPTO_DRIVER_EXTERNAL_SUPPORT is set to TRUE Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Guo Dong <guo.dong@intel.com> Cc: Sean Rhodes <sean@starlabs.systems> Cc: James Lu <james.lu@intel.com> Cc: Gua Guo <gua.guo@intel.com> Signed-off-by: MarsX Lin <marsx.lin@intel.com> --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 2c4013bd9d..0e142bb7c2 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -480,6 +480,7 @@ gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000 !if $(CRYPTO_PROTOCOL_SUPPORT) == TRUE+!if $(CRYPTO_DRIVER_EXTERNAL_SUPPORT) == FALSE gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Md5.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY@@ -501,6 +502,7 @@ gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsSet.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.TlsGet.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY !endif+!endif [PcdsPatchableInModule.X64] !if $(NETWORK_DRIVER_ENABLE) == TRUE-- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114933): https://edk2.groups.io/g/devel/message/114933 Mute This Topic: https://groups.io/mt/104091974/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-01 23:04 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-02-01 6:09 [edk2-devel] [PATCH] UefiPayloadPkg/Crypto: Support external Crypto drivers marsx.lin 2024-02-01 6:11 ` Guo, Gua 2024-02-01 6:30 ` Lu, James
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox