From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.1970.1666745232080967325 for ; Tue, 25 Oct 2022 17:47:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=abIFYBif; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666745232; x=1698281232; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=HiHJlw/OClZLRVwPGgzPZLOVyxLhu45/VcxbFrXek+U=; b=abIFYBifkhY6UU17MDXKJFdsEusVW3Vv2gBhtQ9KiZdzzgqZFQKi+RfY z1QzleiH19lEetjyiip7+SWip8291X4k1iK0RLb70OtX+l81f/+WieHmq /tQHlWY8y/poFekNmQsaxpzXkqdE65MT/89+Dp5xctJreNxjH7bRgkSn0 N+5Ntnu4vw9Ak+/iXvlOZxeK2Gqtbskteq0pGku6QJ/I3X4vYrOd9DxJk NYsTsO+RIhQvWybp9W/Ud7jmMCrDVjBehsav89G5dQPmGbx5cv7GTuCiL N10znVI4lQKqyaAOVSDUsA71m0+chXUyVv54Bh1pvZFSG1YqZcAf3gnyq g==; X-IronPort-AV: E=McAfee;i="6500,9779,10511"; a="308920647" X-IronPort-AV: E=Sophos;i="5.95,213,1661842800"; d="scan'208";a="308920647" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2022 17:45:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10511"; a="774398599" X-IronPort-AV: E=Sophos;i="5.95,213,1661842800"; d="scan'208";a="774398599" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 25 Oct 2022 17:45:55 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct 2022 17:45:54 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct 2022 17:45:54 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 25 Oct 2022 17:45:54 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 25 Oct 2022 17:45:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZQ1ydGTjIl9tAFRASfPXcCPEBlv+42+qL83AWYOGVi9NPg8dWlr3TghrmNCHcoNlbND3hWEtFTH2UBQNseTqpaJqEC+oI2FAeFPLrA7ty7xlmnNlYZAPCrJAdRylLyns906Q9KeFLb4BHbJPlArbKj7iMajjm6is52bGtQ6CTxddWAZPFAHvUqBSdcLu4OVQ66nIcsFE/1tNXTK3IPudVu0Wp2DMMph3r9h7t05QwaoAPzGTXIyJk5nC1SsBFY8v75PRUnitpmor6LZ18O0EUoTT9nCU6W23hXlPN19Kx14NFdmw8+aMR/EDP+st1NFG5zb53pHy842Obubd35KOoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gZMFFA5/0PbgPteOWeZfmRjJaRYF5dZxVPNWROF1fXI=; b=hqX/X5cio3uPXHdiFH1adc3oia964+IBNF+6lnII+oPVRJ5vGuY/6ulnXG5GFkbAKKKwvumRHcvvmJrXJdjZiTxaz6aMTLafpO81lrroXFFnJKihS+Z2Aq8W9syP7bioaiAPG76d5gREW/r5FUwlXZs0VKzZJiguubXdFP1RPt+05yB+tVQ8e0t/1kmNE+/QFV8qSVnhWHEk7j3j/Z0g/JRvsoE6+s8WEl+HXQjJbWZziVakStfH7aOzKlS6D/iq3n5dDf58m4WgN0YYcf0VH5UIS7yYciCt/6qv2hVLEcgYQUkaIJZOO7RwIYg/xGq5w0DbX0JSGhrcZM4k2GFnBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by CH0PR11MB5395.namprd11.prod.outlook.com (2603:10b6:610:ba::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.25; Wed, 26 Oct 2022 00:45:50 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::74ca:2692:fcb:1664]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::74ca:2692:fcb:1664%6]) with mapi id 15.20.5723.035; Wed, 26 Oct 2022 00:45:50 +0000 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Zeng, Star" Subject: Re: [PATCH] IntelFsp2WrapprPkg: Check header revision for MultiPhase support. Thread-Topic: [PATCH] IntelFsp2WrapprPkg: Check header revision for MultiPhase support. Thread-Index: AQHY6LQpA3I91AfReUSrKW1nrwmRzK4frkYAgAAo0iA= Date: Wed, 26 Oct 2022 00:45:50 +0000 Message-ID: References: <20221025205532.2247-1-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|CH0PR11MB5395:EE_ x-ms-office365-filtering-correlation-id: 8dc84b47-37e1-42e6-91db-08dab6eb6e08 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xLZSZ/EjHaVOl2IDRSo22LzD4D/UB+HGo+QR2tMcrZ7171lBUw4PE7kbkEXioOQNaJ0vkK7HO76/KbHrX+WDfd5KMix87oi8vxEodp1YJFmysTX+rGKO9kbiGUBQYBNDVZZSBRMqmkojeV7YMC4+Qk8AWe6f6uO6/W189J/uy+W0Sa53Def2W+J//8sZ/V4uzAPdPKPPfLg5bTo6LHG+G5/q2zY2rdh3ADVXBgRPzGupQo8TnDIJu1uIAC9ybR96q1BY4OO3AG1ff56D3ih91SXhnmhYnidDJHz8Q083TBC/QJIs8v/is0+w4w17dq63nLAZ8mkv0nqWe3TKslDJ59uGtKavb9pftvxm5xg5RdKhFxtKJngqhkM8zIgHXQaVjwFQDkU//3TPYw22JMguJ6o+PjxKZSHP5uIq/CNg7bith9XtSFyazJqzG3VIDbfi3WdVCttPGKcN1smAl3nWKldem+JQZlbcL6chDIVgsv6euif2KSaDGcLoKrQFeD70LhKS6M6faIq7o+luL7nhTZiOy0giJSCqtWLogjd8h47osHjoKQL0IXlCJ1VzCNALb4o+lKT5H9/el/mXEouVtxinIlvK/J7dQGHPxBmGRNtZPIIcQmowUGhzxsv58BK7eQJKckOsVQmLUli9JtnMGMMbwYlET1t5V4PKwsRSioIT8HmbjM2rIp2Uznfcg4TKHP0e6GFTFV8Zqli2YG1rp8LewyCt0wwUu5Q0GV7ISq7XMY4kVmMsfvkE91DLyUXfs5xLxk1Lr/wQ/fwAssAt5pHNF9X34ka3jmlFMfRt4dTFY5E+pyOFf8wcXVyTJgCrPIdvSQQoDgIhux9n1L3resmQDAtdzn04Fex7zD6rTSY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(39860400002)(376002)(136003)(396003)(451199015)(76116006)(83380400001)(33656002)(82960400001)(86362001)(5660300002)(38070700005)(186003)(38100700002)(122000001)(8936002)(2906002)(41300700001)(66946007)(66476007)(66446008)(52536014)(107886003)(66556008)(64756008)(6506007)(7696005)(55016003)(478600001)(316002)(110136005)(8676002)(53546011)(9686003)(966005)(26005)(4326008)(71200400001)(19627235002)(44824005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bx0pDeROCREHwCBNDcztP8aUSABH8LyPNHe86ou1q2ffpQSy0Ps4iHNUSBGL?= =?us-ascii?Q?BwiQyXojt9bN7/EL8hcDQyTs4KsINxOyp0kH2Ap0iAxZl3VXI6J+4jm7jo3J?= =?us-ascii?Q?jeKy3VO5ymD130SG/ySPZeU8WjCba1lQZGybOyzOIZROH89lDhwigalQd8Gk?= =?us-ascii?Q?EpOYxrxTOOSk7rXCGoH24l/+vBrYA0bbVfNVAeb6/hXHTxMtMrt5tBeTDqmZ?= =?us-ascii?Q?3qQBOc1Z45rIqvwyNK1HMgtl3XCAAOGtQSXxzMO6sGM0vEHJUZnlBqlavazM?= =?us-ascii?Q?1zKrdbWLTI7qpwd8sSvlovAfgpKdC7J4KvaVbzdMjJ0TNarZdxuqNMBzcEOK?= =?us-ascii?Q?Wl4dZUof91knSmyfN9uNiXTUB+3Acr5d3HbiSWk8nfesU1d3M42pi/6JlSi3?= =?us-ascii?Q?DQS/k90VI2jHU8Z/yhv5S8S4/NNQ/QP15qcOEc/Croh0/dxpeR698eEIbYPn?= =?us-ascii?Q?qkuFlBVdUfFkZIYLQchdBbgxHqMTLSDrcqIFIvwwtY2z/Fp0nJe2niGo7bCf?= =?us-ascii?Q?V2Qkwowzvx8VkatdBYgEeJT+CNdzgl9tDdTIJh2Utp1qUlcRVPKYmSNneZV3?= =?us-ascii?Q?hsHk/P3I05DRuLQTQ9hNkAJ5blzIBoAg9t8BFnoxEIXb9JfLA39pd+3YFvrD?= =?us-ascii?Q?G+FRQ04v3ulXQuLjMwQlOMNAUEi9AE3D5V6CmNkWRI3thimZhLL6L7qeSY8S?= =?us-ascii?Q?lm4IbXmeLyomtb5N2JtOI6u1Dvj9jKZpakkSuFt0jP7Hm/awZIYK/ciwSa6i?= =?us-ascii?Q?3yLPGxKHfCMGFm8d4Xypju6CTGbM4udbjevg5eJarPX+OxJ7cYd+qdMgxDR3?= =?us-ascii?Q?pDJ8F6+b0QjytrPA9UXP01zmlk1lJ0mQ2RNLsNMfi+/JFqjC0pL83zVTezng?= =?us-ascii?Q?7OCLyDFbn6iyG1oydWebVzzJvS5NztP+FTk5049u1fByG7aaCpnU9wOjxz2F?= =?us-ascii?Q?4VnnJXiybz0OuDcVpgLIGvB2iD+V1PIk3jxtqoMR6HaODOBLEwyNeoqinJeU?= =?us-ascii?Q?RGq8HhmOTiP5Pk5k7QJHUSE5SfeKWWbjOfpvt+eoARknwgRXDj0wxQ7KPdeF?= =?us-ascii?Q?1Xz/wvhxUaixpfQqhOthQEoyMmVl8OdSJnQxfGLdbHiKsYq1NdMtSU1/pF+P?= =?us-ascii?Q?i+c3qFNfzTETHqCp2OqGZM+bc461linZw54U6yx+IA7YBekx3qtiZ4/U46mW?= =?us-ascii?Q?wH4hOY0jWhSbekkOUuVSi4SC0/UsBuEhDxHC7gIWxaQlQqWvKXNxO4teg2AF?= =?us-ascii?Q?PADbJ8GxN5xMpxKVJ00rvKMOWqeRyuUwToIOuBXTzEPEYHXC/+ww8wKbgDWL?= =?us-ascii?Q?2/hggzeqDosOG9RWNXnRqIUIRuoXAu0oXOJwzfJpUqxzmGRkNF6F/jtIJ9Jf?= =?us-ascii?Q?ltN34OD/C2kWrsvFGBxhB4O7eX/BZkFSC/0bHi2BUBxrZSKr0js7IXv2Gj3E?= =?us-ascii?Q?M7CleKgAbBSHGf6GMuqx/z2/SHRIOFBfFBeHA15Q1noOk5tw5HDjHW/by46d?= =?us-ascii?Q?KFh1pIUuWmyFw5ixqgyR54aLKmtaSroam5pnPr2UdTDcloTTb4+ucCgbvrmi?= =?us-ascii?Q?Kn9Fyo078cSLfy05ia8t2lDcNjfkFgKGoWvPJNB8?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8dc84b47-37e1-42e6-91db-08dab6eb6e08 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 00:45:50.5497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /2P5Ge9w61i9KWDV26uIcjgHlnknzk3bg9ml+93q+HOe5T+v5jfks+6d7Ucaf8BvLUWsuso/xYGO8Z6n66aUaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5395 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch merged: https://github.com/tianocore/edk2/commit/26638d2aa399e436f47d= 629f877e581ed402020a Thanks, Chasel > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Tuesday, October 25, 2022 3:19 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Zeng, Star > Subject: RE: [PATCH] IntelFsp2WrapprPkg: Check header revision for > MultiPhase support. >=20 > Hi Chasel, >=20 > There is a spelling error in your commit message. IntelFsp2WrapprPkg > should be IntelFsp2WrapperPkg. Please fix this during the push. No need t= o > send a 2nd review. >=20 > With that change... >=20 > Reviewed-by: Nate DeSimone >=20 > > -----Original Message----- > > From: Chiu, Chasel > > Sent: Tuesday, October 25, 2022 1:56 PM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Zeng, Star > > Subject: [PATCH] IntelFsp2WrapprPkg: Check header revision for > > MultiPhase support. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4119 > > > > Earlier version of FSP header may not have MultiPhase fields present > > in the FspInfoHeader so the handler should verify header revision > > before accessing the MultiPhase fields from the header. > > > > Cc: Nate DeSimone > > Cc: Star Zeng > > Signed-off-by: Chasel Chiu > > --- > > > > > IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWr > app > > erMultiPhaseProcessLib.c | 30 ++++++++++++++++++++++++------ > > 1 file changed, 24 insertions(+), 6 deletions(-) > > > > diff --git > > > a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFsp > Wra > > pperMultiPhaseProcessLib.c > > > b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFsp > Wra > > pperMultiPhaseProcessLib.c > > index 1248accf87..0f524910d5 100644 > > --- > > > a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFsp > Wra > > pperMultiPhaseProcessLib.c > > +++ > b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFs > > +++ pWrapperMultiPhaseProcessLib.c > > @@ -73,15 +73,27 @@ CallFspMultiPhaseEntry ( > > // > > // FSP_MULTI_PHASE_INIT and FSP_MULTI_PHASE_SI_INIT API > functions having same prototype. > > // > > - UINTN FspMultiPhaseApiEntry; > > - UINTN FspMultiPhaseApiOffset; > > - EFI_STATUS Status; > > - BOOLEAN InterruptState; > > + UINTN FspMultiPhaseApiEntry; > > + UINTN FspMultiPhaseApiOffset; > > + EFI_STATUS Status; > > + BOOLEAN InterruptState; > > + BOOLEAN IsVariableServiceRequest; > > + FSP_MULTI_PHASE_PARAMS *FspMultiPhaseParamsPtr; > > + > > + FspMultiPhaseParamsPtr =3D (FSP_MULTI_PHASE_PARAMS > *)FspMultiPhaseParams; > > + IsVariableServiceRequest =3D FALSE; > > + if ((FspMultiPhaseParamsPtr->MultiPhaseAction =3D=3D > EnumMultiPhaseGetVariableRequestInfo) || > > + (FspMultiPhaseParamsPtr->MultiPhaseAction =3D=3D > > + EnumMultiPhaseCompleteVariableRequest)) > > + { > > + IsVariableServiceRequest =3D TRUE; > > + } > > > > if (ComponentIndex =3D=3D FspMultiPhaseMemInitApiIndex) { > > FspHeader =3D (FSP_INFO_HEADER *)FspFindFspHeader (PcdGet32 > (PcdFspmBaseAddress)); > > if (FspHeader =3D=3D NULL) { > > return EFI_DEVICE_ERROR; > > + } else if (FspHeader->SpecVersion < 0x24) { > > + return EFI_UNSUPPORTED; > > } > > > > FspMultiPhaseApiOffset =3D > > FspHeader->FspMultiPhaseMemInitEntryOffset; > > @@ -89,6 +101,10 @@ CallFspMultiPhaseEntry ( > > FspHeader =3D (FSP_INFO_HEADER *)FspFindFspHeader (PcdGet32 > (PcdFspsBaseAddress)); > > if (FspHeader =3D=3D NULL) { > > return EFI_DEVICE_ERROR; > > + } else if (FspHeader->SpecVersion < 0x22) { > > + return EFI_UNSUPPORTED; > > + } else if ((FspHeader->SpecVersion < 0x24) && > (IsVariableServiceRequest =3D=3D TRUE)) { > > + return EFI_UNSUPPORTED; > > } > > > > FspMultiPhaseApiOffset =3D > > FspHeader->FspMultiPhaseSiInitEntryOffset; > > @@ -120,7 +136,8 @@ CallFspMultiPhaseEntry ( > > @param[in] FspHobListPtr - Pointer to FSP HobList (valid afte= r FSP- > M completed) > > @param[in] ComponentIndex - FSP Component which executing > MultiPhase initialization. > > > > - @retval EFI_UNSUPPORTED FSP Wrapper cannot support the specific > variable request > > + @retval EFI_UNSUPPORTED FSP Wrapper cannot support the specific > variable request, > > + or FSP does not support VariableService > > @retval EFI_STATUS Return FSP returned status > > > > **/ > > @@ -287,7 +304,8 @@ FspWrapperVariableRequestHandler ( > > @param[in] FspHobListPtr - Pointer to FSP HobList (valid afte= r FSP- > M completed) > > @param[in] ComponentIndex - FSP Component which executing > MultiPhase initialization. > > > > - @retval EFI_STATUS Always return EFI_SUCCESS > > + @retval EFI_UNSUPPORTED Specific MultiPhase action was not > supported. > > + @retval EFI_SUCCESS MultiPhase action were completed > successfully. > > > > **/ > > EFI_STATUS > > -- > > 2.35.0.windows.1