Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE

["duntan" <dun.tan@intel.com>]

Thanks for the comments. I'll put the new fields together with other Return*** fields in next version patch.

Thanks,
Dun
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Friday, July 28, 2023 2:26 PM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: RE: [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE

SmmS3ResumeState is a structure which contains two kinds of fields:
* that are initialized in previous boot. E.g.: Signature, Smm***, Smst
* that are initialized in S3 boot: e.g.: Return***

Your patch adds a new field that is initialized in S3 boot path.
Can you put the fields together with other Return*** fields as they are a group of fields initialized in S3 boot path?

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Thursday, July 27, 2023 10:21 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; 
> Gao, Liming <gaoliming@byosoft.com.cn>
> Subject: [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in 
> SMM_S3_RESUME_STATE
> 
> Add MpService2Ppi field in SMM_S3_RESUME_STATE of AcpiS3Context.h. It 
> will be used to wakeup AP to do the CPU initialization during smm s3 
> boot flow in following patches.
> With this field, we can avoid sending InitSipiSipi to wakeup AP.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> index 645496d191..b1c177e072 100644
> --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> @@ -1,7 +1,7 @@
>  /** @file
>    Definitions for data structures used in S3 resume.
> 
> -Copyright (c) 2011 - 2018, Intel Corporation. All rights 
> reserved.<BR>
> +Copyright (c) 2011 - 2023, Intel Corporation. All rights 
> +reserved.<BR>
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -20,6 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  
> typedef struct {
>    UINT64                  Signature;
>    EFI_PHYSICAL_ADDRESS    SmmS3ResumeEntryPoint;
> +  EFI_PHYSICAL_ADDRESS    MpService2Ppi;
>    EFI_PHYSICAL_ADDRESS    SmmS3StackBase;
>    UINT64                  SmmS3StackSize;
>    UINT64                  SmmS3Cr0;
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107371): https://edk2.groups.io/g/devel/message/107371
Mute This Topic: https://groups.io/mt/100383957/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-