From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1018CAC10B4 for ; Fri, 28 Jul 2023 07:18:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qFVT0OkSXYuJ71Nhg4z8uSbCtqUhbl7y6sSMtTBmLHg=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ld-processed:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-Cro ssTenantHeadersStamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690528701; v=1; b=r6W38om9DA3E65OcTzS3FRSplDdb27pQJ89zLGObGHok8rtvGC+yxNztD1snJyt0nmo7yho+ LP/CsaCSaoz+rIUgGu9InjMB96/3PllxqpochdfTgf27F1o+LEfGSvvXDf8KyQZjRg7f2ocyk+R tKjBhY82LzYXC8Q0Pl9lIXfU= X-Received: by 127.0.0.2 with SMTP id 9E5YYY7687511xQibkxZ85d4; Fri, 28 Jul 2023 00:18:21 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.27436.1690528700773401165 for ; Fri, 28 Jul 2023 00:18:21 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="358554293" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="358554293" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2023 00:18:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="727360941" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="727360941" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 28 Jul 2023 00:18:20 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 28 Jul 2023 00:18:20 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 28 Jul 2023 00:18:20 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 28 Jul 2023 00:18:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H+Sb+C6crflBYSnYLRQpwRskdkA0IUOchJrZzf8W3ftAunW3ErMsCXhJNDSg+EQYnkT+ur1LoOXcOiQ962sPrunfHJloVG3f+UbTjkGIGlmJyN8pp/SJIos/9x/yekXer8Vej8RLE1orHiPypITWXB10iXhYxwxVneVOkpqp6Ozebe3n5xw+V/o+hcXeSaV7hyRLBSw3npK0VKn3wGlJfLLbZRUY3+HGfVlVZ57tmnldfe0j7B6ZuxoEpEtrBhQQFF7B0rc+efLgfZXz14dGONR0+GIaLC5lFtoCdURsvj2tqmF+AjIwpipiha1wUWq3PO0wxt2knqPAerPtDYj4kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CxVK3J6w0rq6kjoIi3WleolfI1ErcfdgpymzrjTN6H8=; b=HseR02jnPiX+ife7Nm23diZp4eThnOi1/sZJ0dQ05Lz5DI0kasY+zOOJKU/n4uZfoenmQLMRSGSV2qWJN8M4Ut1MqaMHoMIX/bNTMJzG7ZayKS5J9EE+jz1E0JraiCVwzusfXcLUex/yoP9S5beNe6wTgPz7/qJxGRwlp/JRvbaOAaDQFrci4jHTWceNEiEGKMTnu+zlN/Mh8MyRlnLFIkn+7Wr4xjczk46wXa39Pnl8wpKofN4zwCLUYA8erh6O3UCObgEZqoJFcVCgAzuBhUfOaxnCvQiWoZ1bv+HwPTe6ZbyyCn0L2/OlTb8x+2cEB3pa1x1W9tit4RCcq4CCqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SA2PR11MB5163.namprd11.prod.outlook.com (2603:10b6:806:113::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Fri, 28 Jul 2023 07:18:17 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::380d:dcf6:c4b:d48b]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::380d:dcf6:c4b:d48b%4]) with mapi id 15.20.6631.026; Fri, 28 Jul 2023 07:18:17 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Topic: [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Index: AQHZwDD/XsZyAZt8fUaBm07XwCVoDK/Ot5QwgAAL6uA= Date: Fri, 28 Jul 2023 07:18:16 +0000 Message-ID: References: <20230727022040.1910-1-dun.tan@intel.com> <20230727022040.1910-2-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SA2PR11MB5163:EE_ x-ms-office365-filtering-correlation-id: 68d145b4-5be1-48fc-69de-08db8f3ad051 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: evzpyh3YTlDteA0Z6aCsXepj3m1Mbz4Md+P5p+PGd8Wn5ciFyBUhxN0ppYf3ZtEhVpVil03uEl8lGmihXnjFay5v9pFOcdSBodbXUYePBETbHUTNsy0wK7Z0Be+7oU3MpyZ2x6k7o7ZCDRS6Xji0vwFuAG6FWtwGanctuuKF03mSET02qFR5gN2pnN/8m5LHgYNf13eDmaY0yVklr9IKK0El6GSn1IRiZefENXQ8Hgc2AMgHlA+X9K+KkrqIekwIzQCcR9LLg7q8sTSR/jDIv1mvXvapPzFRKxbo/hRFGjEwccJx1ebIa+ZxczhZGNTCk0cEFM6sbU1gkD248velBu2UK26Hiz+n4SCGoAoFOO90/Hymfg8rIfyBx9Pw/wOlWLG3IPp3x8c6dl4VN3h0rTQ2D0GcluXF8EYU0owihpb5bS9DcIDQOLu3HDRI6NNoof8PcPmv42Pq7967q1TI7otUOyPdj1/VAA544AAMH4eWeVgeMSQk2navk42CjkwR8u+kI0WLZw/ctE5EizflAnZ6Oi0m3NxieUK4VKinfWStITSCkBMznPnnMro6LR8+LiDgqefroID+P/+QUgEAgmN8L0UXRFXGvQkNb5c3TXFCQ4csQkN+iQ5OQkJ5CJfK x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vhtcG4X7hGzvFpSR8QLmFjWCjFZkipLmgQ34FNvfysaP4DaWQdfcsCHiLk74?= =?us-ascii?Q?snVyk+cY1U/h8IjDJKiYAv3c1h5a6m9piPOg0BNzZuC/PbOB01aI4WcEG0ok?= =?us-ascii?Q?n5YiFu1hBmbL60O8PfqmCCS5FJpq810chxDoaiEMrSxqVH0/ZnuIfOT7R2z8?= =?us-ascii?Q?YNHndeQW6JjYVW2DlzpeTqZxDlxaNrAtgV9zQRW/W6XNOnJhHu3ESmHkf0e/?= =?us-ascii?Q?HqMxJyEe6mqPcEYCS8zGZypR18dalXuD238M+bwKG77MqX0w1ot/bmk6Hjwd?= =?us-ascii?Q?EJd32VqQ1neMpXLB0cCfjlNrgQVt+TcI8TNuvtNZeeZMY2VMNAAZ/9C5tQu9?= =?us-ascii?Q?oKcu/J3yzvLKDVPBj8aeIjnDeCuJnYTabknBMDb9QUCqZpEQeYcXgGUBWxZ6?= =?us-ascii?Q?1n2ypt+TDhbbeP6vJMFw8EzG30+U+FGNqkTC6+4v1ST2o41YkgcS+3UA59Ss?= =?us-ascii?Q?v+Yrkik9noHGWwwc11FWyTduh46O+o0zhd4T8CeAW3ta+zfIujWNr/qoV07D?= =?us-ascii?Q?VHba/c56z9Bjcoo90JNZlP9C282fGjgo/fRJi9dEkjvjzVzbbkzDzOcvVnOP?= =?us-ascii?Q?V30ahFpVHrKMr+ShpvKRFC/aXHmPIgO7We6IXcUxTRBx3jeG/tbfIFaSLdvh?= =?us-ascii?Q?/cSk6QIxWkFk5GufZkGW4526hPeNy1v9VHlDaqLWdnKIR7QjdhEOclnemmDO?= =?us-ascii?Q?he37EhLHNXip5bJHRoW5E/lG9LqQ+v3vCHSjkbUG4goxUQ5ZCD+YGOIWBvup?= =?us-ascii?Q?0rhEeDpNS8sMRh2S5i5k1j39eYl1dRFL0ks1bjBp36vUEn+DffcoUAFH6Mm/?= =?us-ascii?Q?lQayUfVrJrjZ7itt60u7nQXwEM0eqspxn+9TXat1j4/YVmflOuOF52ASAtRa?= =?us-ascii?Q?hzEzlbPkP/hjw89/0u5qqHtqlkOj4UrxifmLGHsGnjA8uizRbzFJ3oZA4m+e?= =?us-ascii?Q?o/gGylqPI8q5IKmUoC1YyO3Rfm1X3QHtEbOz2NavU9w+AjxOhyqkIJ5xlQsE?= =?us-ascii?Q?yGxRluGMwYadHb/Feu4Bo2V6hoRYO+tTTEdmgTHdLOOeWhLrmqIA6xsEEWBm?= =?us-ascii?Q?JmxziByqlcGi07kayIyIHPiV0vA0Y9DQ4Nkh4Omzj2xyA3nJ+YUl+i7AX+Z0?= =?us-ascii?Q?mn0pVkwZLMz+qrOKsFi9D8r0NS74YrGER3+/v4zgJym3BO6l4HJtnu7JxilW?= =?us-ascii?Q?DUS+h3WVlFbfs7amkVOmYoIPyr39wf5Nvdi3KUVm4CDwTuhY/nawEC8sKqTz?= =?us-ascii?Q?ishf4y2FJvJwkzsh9xPoO0utPxFjFbSEgao6uL3S4aiz3QNNdPNUKx9yOf/O?= =?us-ascii?Q?w2FD30Fu3BwyI4tpgCypx7QRDPfsGDzVQ8IngLga/oVNH1Rrp3iKWvvx8WAY?= =?us-ascii?Q?5bPF9hAa106ii8Cjy9btWOP0D6EGGkleLA2Xsb09Kqn+9w1uwQ4YQRBuauDI?= =?us-ascii?Q?xqr36HALZIZVVwP9/j7NajckFTrphT2RoUTjXucVwMichJvGOIp36qgN7cPG?= =?us-ascii?Q?ecj14NUWbC/M/TzV1sYJr16v+WkasVJC56eJAfjLXvdmxg4H+FLb6ab7XVGd?= =?us-ascii?Q?0WeRmaQOqSezbXjdkWE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68d145b4-5be1-48fc-69de-08db8f3ad051 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 07:18:16.8374 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JR4mX4ha87hH2cEsiL01NqN8YwxuniH2LLovGpGxCljr46V9039LzIwTGITfgGOSAidQcYniuZ1QqSEUDp0/pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5163 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FKKfvKe6q9AILXUa7bnMbcnWx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=r6W38om9; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for the comments. I'll put the new fields together with other Return= *** fields in next version patch. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Friday, July 28, 2023 2:26 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Wang, Jian J ; Gao, Liming Subject: RE: [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RE= SUME_STATE SmmS3ResumeState is a structure which contains two kinds of fields: * that are initialized in previous boot. E.g.: Signature, Smm***, Smst * that are initialized in S3 boot: e.g.: Return*** Your patch adds a new field that is initialized in S3 boot path. Can you put the fields together with other Return*** fields as they are a g= roup of fields initialized in S3 boot path? > -----Original Message----- > From: Tan, Dun > Sent: Thursday, July 27, 2023 10:21 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ;=20 > Gao, Liming > Subject: [PATCH 1/5] MdeModulePkg: add MpService2Ppi field in=20 > SMM_S3_RESUME_STATE >=20 > Add MpService2Ppi field in SMM_S3_RESUME_STATE of AcpiS3Context.h. It=20 > will be used to wakeup AP to do the CPU initialization during smm s3=20 > boot flow in following patches. > With this field, we can avoid sending InitSipiSipi to wakeup AP. >=20 > Signed-off-by: Dun Tan > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > --- > MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h > b/MdeModulePkg/Include/Guid/AcpiS3Context.h > index 645496d191..b1c177e072 100644 > --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h > +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h > @@ -1,7 +1,7 @@ > /** @file > Definitions for data structures used in S3 resume. >=20 > -Copyright (c) 2011 - 2018, Intel Corporation. All rights=20 > reserved.
> +Copyright (c) 2011 - 2023, Intel Corporation. All rights=20 > +reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -20,6 +20,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent =20 > typedef struct { > UINT64 Signature; > EFI_PHYSICAL_ADDRESS SmmS3ResumeEntryPoint; > + EFI_PHYSICAL_ADDRESS MpService2Ppi; > EFI_PHYSICAL_ADDRESS SmmS3StackBase; > UINT64 SmmS3StackSize; > UINT64 SmmS3Cr0; > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107371): https://edk2.groups.io/g/devel/message/107371 Mute This Topic: https://groups.io/mt/100383957/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-