From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.5961.1651050253665100662 for ; Wed, 27 Apr 2022 02:04:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=noF7Kaf8; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651050253; x=1682586253; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/gEQD0p+BXkPZ25piJBzFabybL+hRGNhz8HcTs7iJvw=; b=noF7Kaf82NP76qGONn6EawnPvLa+S7zdr+U3gXoR86dl4sI+A2yqULwh mSRddZOTrXAT6DBGN7HEoqpwsGWuUS8+0OSEUIoLP47l3fuE1IEH55KnX d1hVsRDNW1wJHiuXOY6pZ3MrbX3REkrygnonf6Mmd9BKJqDmK+BuIZVri COqlcOwf7OtLsZLKmlbWZ621sYc2/YlIw5YPA5wSLy4ewbDj8U6LWWdtc lVr2mgMTRKnRZTlLhR/OJ4VHabg/oR7/8rvduA2rePN3HJ9dPO6CaxPVL c3644fbW9xWxOu28ep5KNTjJXsXDepynUV7i+k1J2pALnZKW9gs/KLlEZ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="246432441" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="246432441" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 02:04:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="558824222" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 27 Apr 2022 02:04:12 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr 2022 02:04:11 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 27 Apr 2022 02:04:11 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 27 Apr 2022 02:04:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7sjF8i7BifjJdIrOzqIfvWGwBgZ+sTPDbj3nPtR+IeHr1dKgNicoTxrFzG6CDCjmwQf3pdbbUPJeCqvN9yc4BECpWpH5V7/Lcc5ELnc33/kY2igxLVcbj9q1dUVY4jzJX4ztdsW0LEMXUtnYQ88wwRAMlfDCvLn1aU39+Cls5ofWL8M7kUTCT5SOFgmJ/AjegNQPYK5xw6x4d02F0fDUV/YprTKZFz76Y0cPS5/BxK4xp7iJcCrhc//Thnk9YbsGboHQt4SEKdB4qrKOWRRvUzyg3GzLKwYbGnC0BgIJ9QhvnAVs4+2iIbEfYjX9S2oCeinZAtKHw9Xd4iYaRKJpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tMBFfDlSEaX5H0G8/ThtFQo8+Vik4nGVRwglbV67YWY=; b=CMBSgoQcdusCdtIQzypNiIKjwK2DTIqqPmr8sx0sXz4netOmW01Wl3rNvgWu/4QYaJaYV6HeHi5gV6Fdo0LwM0xd2j0qCUSPf54s1DhCc+uzJK/ceB6fAYrLBjWtt+p40qE/X3V9S8iMNuK8BOUPqNl59FA76JCis4II+PzBAHz/AergUlUgRTFxy1g8dEUXDu7GQzXkpkEp5In1HPjgbC87veRIywY1FC89UnEp3Lpq2XKXFrPhG+pSs6uxCn8CQDShByVu6vyHWydoYcH0RPoyIvtn58KwZRELNuR3fOrYBRchSD1cbcYgGCCBTp2LQQxO9/p7i543W4rG4mNvOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SN6PR11MB2622.namprd11.prod.outlook.com (2603:10b6:805:57::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 27 Apr 2022 09:04:08 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c076:6436:db8e:ee22]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c076:6436:db8e:ee22%9]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022 09:04:08 +0000 From: "duntan" To: "Dong, Guo" , "devel@edk2.groups.io" CC: "Ni, Ray" , "You, Benjamin" , "Rhodes, Sean" , "Liu, Zhiguang" Subject: Re: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Thread-Topic: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Thread-Index: AQHYVgcCP0SvLbSGgUils6lZfwCf6qz7cpxQgAdEswCAAMRm0A== Date: Wed, 27 Apr 2022 09:04:08 +0000 Message-ID: References: <20220422035047.1130-1-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 799af334-9ee9-4c58-4828-08da282ce389 x-ms-traffictypediagnostic: SN6PR11MB2622:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3VpXN1c0IcJR4oRC5StADrgKqb3OgVx8LMywVuqv9CSN7R1Iirb0JzMHTlkhxVg8tgHHgWCLTFnXsUy9iX0DR37gBVCH/5zOi88E3TFHN2xMZjPHwYYM16ZuHakWuy93AiriWTJu3zbPbO3zRiA9UwP5FzAOl9+xRvFGFqCWPjs2MoLuQAtMG3wWOj+quKI0oRDMhzsbPjJPfPApuHvOU0wu9RL8y7oSl/Jk/SVpE7ufPjb9sD2VcI7d5kXfxoc5QxgkKg4d9nP7mYSuQcGQ6K8R0d+KU57CzVYb+KXdkmM5PNPJe53NaTVYKU0eAYwmv49Mhg99iVDgotcRuwTbQHKsRMOq3T5rVxFQ+U99gKW+ZCA5qsCmUyTcBp8RRBdtDTuNE39Yya8QOImm7CVOU5JJYTWa2cXd4WjJtJlNeiaj9nRlxelosXZwdCFtFfy42fPOC0Pe7HkR46UleftP74D6I7YEX3CicUvmHmcN1ChviIAp2FjU+oj7VW7POWcgNVeE15dn2p+uUpYzlW6TsZzAI0v/ZS3IJlaTVOPKit9ecbVzQ4uOclgRGKidIYHUMkn9MbB4jZnKDd+w9gR/tOiniJmt77jqUeU0ChUC2wMkt0FjfQQKwl2kqhnaGehgJicjKVKXuTOf4noPnThsTu8ECFBHWUb6fIOsQuKNgpKr2iQLmQCKHo5nx+K/pQb157gcOrOiAgs47I2ku5v6YA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(33656002)(110136005)(54906003)(122000001)(76116006)(86362001)(8936002)(71200400001)(508600001)(52536014)(2906002)(107886003)(55016003)(83380400001)(82960400001)(66946007)(4326008)(5660300002)(8676002)(186003)(66556008)(66446008)(66476007)(64756008)(26005)(6506007)(316002)(53546011)(9686003)(7696005)(38100700002)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HYkFmN3RFVBOPZMLSTUUZndXjm2FTgqFml3mxfB7WNc4SUlP2ANzhbk6uM1N?= =?us-ascii?Q?tFQEwj0IHwBSS38/gycUFh2omVQbNg1aU5IL95Paq3oLa035RZLa1vALVcSy?= =?us-ascii?Q?8nXbWJ50ttiT/YA++mzIEceLMt5nDsTiTJyH2SW7ufoJMYprmODhZDRk9tN7?= =?us-ascii?Q?2F8ZzH34Y7mfSKC1TIhboImc5MpgmNpE02RCX+FM/Jhh451qv3VwlSyj/MYP?= =?us-ascii?Q?OtDGeeZlE1SmR+xKesg3n8X7getykW+STkD4O4Lyh3HZFPoRere7FlPDSdG4?= =?us-ascii?Q?72A5JZ/dM5uYrvwjkWVLBPAT3hWAk6UXWEFE7nMCqoMA1AKpU60Hu15WFP0y?= =?us-ascii?Q?ANTsaaftl7RfZ93QQSoyjhMNHPsE5d6owU45w/EOoF2mRA7syXFtYbXZ8iLb?= =?us-ascii?Q?iCKY+loYdfbPfkEUgW+4TVIAdXmoYMw4jSptuUbAvM2mjFFuByzHoceSEP7v?= =?us-ascii?Q?QQ02w5O7iQ1XZ4RMhTw8uUVI8fuy05vXOGIMmXKFsfa4D18TDJPiclZWXdg6?= =?us-ascii?Q?nJV0RK/6QewxF0fZDDpy0cZkkB82Iux/r6tmenT2luHX0IxeVKFGfxeK6cNs?= =?us-ascii?Q?wIgExrjeNKvWEegOy8nURUFOSy8GtrLMsOGkUnzC5D1zT+PLqcQhFLiCahio?= =?us-ascii?Q?Tu4hHhuok8FW6DeOm8ppXJ8JiRjjhLtNG415lsb8RQiZbEe0SPypzGeVryrb?= =?us-ascii?Q?Q0OgE78+ZZZFurF/QqH08261msxcrHrywjL/h9NzKcNsRV5iTIzBiVByFcct?= =?us-ascii?Q?9D5AdoguFY1NpNYSSKPn92GWoRGpjBTQk6RWUfimsMNiVi0sXFVQ7Pz88MlH?= =?us-ascii?Q?DQw+o8TfTJnR5wCyH3W5IC6XAfc/O1haMKwIhX8MtrK8xiR+CAZ3WO/6FoRa?= =?us-ascii?Q?PZtQRKMDgPxdWrz3BudrqXcHtUM9e7HnAfDCdNq8HqlVo2kHrFtD0Sm7tUhI?= =?us-ascii?Q?n6+uIPBMvuK7vQj8gPf8r04l5zu/KjWAF8LyfO10VEApw9+R4pJQR3WwNYjZ?= =?us-ascii?Q?tTER9RpnH3w7vQBcGl3KGxO+xYM8n2hzG/JpkI1kF54E4fHBcSTtc0l2SB48?= =?us-ascii?Q?Jg7gqbLNTncZmZs9JlhpTTHZ0fb/QcR8xmGYMaY+UJX0WKmKPx0F/41lPmnj?= =?us-ascii?Q?QPgfotx8wT59zcxG3X/Nsbapd20TznKR14gYljiRXSeSJReG1F2mRYl2Hupa?= =?us-ascii?Q?MGG/Z2bb0SxQ9KikZtClYZIoItfHs0optIl/+yLFUu5X1GwosESNndlzT5SW?= =?us-ascii?Q?HGE/hNOOfq31pszbkfi748Zi2CqOyOSDBJ5kVy3KYxzbwpxVPTcdp9B+kH4D?= =?us-ascii?Q?amPWRHNN3ie8C2aWnQtpdjDOpgE0aczIQ3l1+QXV3f/6qEMjP9xbZnKdyGaD?= =?us-ascii?Q?b6K2f6T5BO9zWsLczQlMctJPvRcZ9TFPDYiY9BmLIgcmDVCjk/yMuWCA2aDE?= =?us-ascii?Q?VyjeEb0ehVRRfKDT6NbKbVb9C6avchv9gbDlEEPdAMsGocqJwACade9VFOSv?= =?us-ascii?Q?qscXdYJR+G9m8q66leKdTUdqfweSVbUUBePLBi2FNkBLVcOKSLM3GVkastzP?= =?us-ascii?Q?j+m/qiIlrInhxwKdiwYV3VyoYixyad0ko4vs/zjnFwHeWupGqGNXUEBFKcp/?= =?us-ascii?Q?Av0GX4oDBvW3LShMTkVqze3loXI/h2nLUkX2aMa7GCumGV1nFAyx3iajbNMj?= =?us-ascii?Q?PnIvFLtLDNALykmr6XNhfsZaXkeQL4kwQKEV7CfW28j+nbgTagvwlrwArmP0?= =?us-ascii?Q?OQPxEzi+1w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 799af334-9ee9-4c58-4828-08da282ce389 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 09:04:08.6974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Dao7gSoPtcrB8tRv+fpsnzXjjuQjTwcl5CvBcgin0za+T9+w+qNG7SmGy/HZ/8wHULchfEUWv9kbbeac3OVsqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2622 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Guo, We may plan to have a LinuxPayloadEntry in Edk2 to launch LinuxPayload inst= ead of UEFI payload entry.=20 UEFI payload does not need to be aware of this HOB. Thanks, Dun -----Original Message----- From: Dong, Guo =20 Sent: Wednesday, April 27, 2022 5:08 AM To: Tan, Dun ; devel@edk2.groups.io Cc: Ni, Ray ; You, Benjamin ; Rho= des, Sean ; Liu, Zhiguang Subject: RE: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HO= B Hi Dun, This patch adds an interface (passing command line HOB) between bootloader = and UEFI payload. Do you mean the use case is that bootloader passes this HOB to UEFI payloa= d, then UEFI payload would launch LinuxPayload with this command line? If so, how the UEFI payload knows it is LinuxPayload so it would pass this = command line? Thanks, Guo -----Original Message----- From: Tan, Dun =20 Sent: Thursday, April 21, 2022 11:59 PM To: Dong, Guo ; devel@edk2.groups.io Cc: Ni, Ray ; You, Benjamin ; Rho= des, Sean ; Liu, Zhiguang Subject: RE: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HO= B Hi Guo, Thanks for the comments!=20 This Hob is used to pass Linux command line to LinuxPayload instead of OSes= . For LinuxPayload, it only needs the Linux Command Line. Thanks, Dun -----Original Message----- From: Dong, Guo =20 Sent: Friday, April 22, 2022 1:09 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Ni, Ray ; You, Benjamin ; Rho= des, Sean ; Liu, Zhiguang Subject: RE: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HO= B Minor comments: It would be great if adding some descriptions to the fields to make its usa= ge more clear. Maybe we need give this header file and structure a more generic name by us= ing "OS" instead of "LINUX" so that bootloader could pass command line to A= ndroid and other OSes using same structure. With current definition it looks bootloader could only pass 1 command line = to payload. I am not sure if there is a case that bootloader need pass mult= iple command line so that payload could pick up one of them for OS. +typedef struct { + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; + UINT32 Count; + CHAR8 CommandLine[0]; +} UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE; Thanks, Guo -----Original Message----- From: Tan, Dun Sent: Thursday, April 21, 2022 8:51 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Dong, Guo ; You, Benjam= in ; Rhodes, Sean ; Liu, Zhi= guang Subject: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Add definition for UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE Hob. This Hob is used to pass Linux Kernel command Line to Payload Signed-off-by: Dun Tan Cc: Ray Ni Cc: Guo Dong Cc: Benjamin You Cc: Sean Rhodes Cc: Zhiguang Liu Signed-off-by: Dun Tan --- UefiPayloadPkg/Include/Guid/LinuxCommandLine.h | 28 ++++++++++++++++++++++= ++++++ UefiPayloadPkg/UefiPayloadPkg.dec | 1 + 2 files changed, 29 insertions(+) diff --git a/UefiPayloadPkg/Include/Guid/LinuxCommandLine.h b/UefiPayloadPk= g/Include/Guid/LinuxCommandLine.h new file mode 100644 index 0000000000..0bb75238e7 --- /dev/null +++ b/UefiPayloadPkg/Include/Guid/LinuxCommandLine.h @@ -0,0 +1,28 @@ +/** @file + Define the structure for the Linux command line Hob. + +Copyright (c) 2022, Intel Corporation. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef LINUX_COMMAND_LINE_GUID_H_ +#define LINUX_COMMAND_LINE_GUID_H_ + +#include +#include + +#pragma pack (1) + +typedef struct { + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; + UINT32 Count; + CHAR8 CommandLine[0]; +} UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE; + +#pragma pack() + +#define UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE_REVISION 1 + +extern GUID gEdkiiLinuxCommandLineGuid; #endif diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec b/UefiPayloadPkg/UefiPayload= Pkg.dec index 5c1aeb8235..494ef94932 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dec +++ b/UefiPayloadPkg/UefiPayloadPkg.dec @@ -35,6 +35,7 @@ gUefiAcpiBoardInfoGuid =3D {0xad3d31b, 0xb3d8, 0x4506, {0xae, 0x71, 0x= 2e, 0xf1, 0x10, 0x6, 0xd9, 0xf}} gUefiSerialPortInfoGuid =3D { 0x6c6872fe, 0x56a9, 0x4403, { 0xbb, 0x98,= 0x95, 0x8d, 0x62, 0xde, 0x87, 0xf1 } } gLoaderMemoryMapInfoGuid =3D { 0xa1ff7424, 0x7a1a, 0x478e, { 0xa9, 0xe4,= 0x92, 0xf3, 0x57, 0xd1, 0x28, 0x32 } } + gEdkiiLinuxCommandLineGuid =3D {0xb5aeb34f, 0x3047, 0x4955, {0xb8,=20 + 0x80, 0xad, 0xd3, 0x6d, 0x86, 0xdc, 0x0f}} =20 # SMM variable support gNvVariableInfoGuid =3D { 0x7a345dca, 0xc26, 0x4f2a, { 0xa8, 0x9a,= 0x57, 0xc0, 0x8d, 0xdd, 0x22, 0xee } } -- 2.31.1.windows.1