From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.2131.1623371553958982524 for ; Thu, 10 Jun 2021 17:32:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=sOWy8KIR; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) IronPort-SDR: dJ8rInnh61A67xr2rt203pIRMeULGARm3TMOiCQRDmhphK/lRy40OhQrygK7t81JpXh9kBh8ug uaws/L4FCg6Q== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="266587935" X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="266587935" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 17:32:30 -0700 IronPort-SDR: H7r2Z/HShdJMGKlovuOxf8a8kAaQ/ZAheXH54Xvk8erT9V+qpl1r18SxHWVyl9WEipYBTwsE6t fobGYCe4YDsA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="486396286" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga002.fm.intel.com with ESMTP; 10 Jun 2021 17:32:29 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 10 Jun 2021 17:32:28 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 10 Jun 2021 17:32:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 10 Jun 2021 17:32:28 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 10 Jun 2021 17:32:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iKnrA7j+AteIoZcv9GTWxvfQxVKYKw6W9s4RpThCw2Sx0gMuhaSUJ0u2cfwhWd1a1OvkJvt2Dp3uWneTgbhxA1Lnt7+MUucwGy3BVHC0EnKV6fa787vcs7S1aGj+HyyN22j4Lkeqae6bE7ajjWLSaIeNGsOl+YLHPeQuJJfCuQA6Mu7M3khSXVGfHIWYAmXAFCmvSTvI1uhFg2CAP0dUKZiNRkU7sNpgbxziMz8wkqWeIsXsg0KJRH3qNMikc6W8qmHMQte8BdDw1fRFP7U3Mzm9oBWZv8fd6jIk21dizwG2dyA+psOwSZAZVjZrl7KDImBhSAS5vXfPSsrXDO7+uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nf1FlxOQrohxHIyGQ/eTB/mCLNAwQAa+EPPCW9Qb7QY=; b=fvLDXHqJ/CTXZm4O4MaFpb1iyI+MpUlT6lSEpQHffBU2HmUATTtH7hgkb/iL3xSGldM771V23/jz5SW/1677jYMsr3KDyYjuq+J444Wcm4Ab73BGPxXrkPRHdZpaW/VzrnthKrIwJxu3Xf3xUoJOH1ZlcnSGFkWMp9iOZFLLUFBy1/VcOavXUF4rnmNyaStATDp/gNltNCzACv2IPgypA1ZroJoKXqQy1LC2N+mJ99afUmovMt4p3FxfaY5FWM4vngLrWOHJXBrRACVpPIEy7OvFihTWVBGFfqyyW90oJxxwTsAXvotRdpn7f0yKwWAzIgiwYTSMRuLdbTLhwhtHFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nf1FlxOQrohxHIyGQ/eTB/mCLNAwQAa+EPPCW9Qb7QY=; b=sOWy8KIRW6cmBPEhaP2StrtKrXH2Ejxq3Mit6FvJIN2CE4QEXYIMfxxS7IgLEWNLgZkLsjjPvcuAVRPTLvua7S71HtcYUFJyjjVaf1pwWm1xuY9+bPC8miJOOPJXDQEO33vyAOQ+9UmQ1xbiwazdfOUCuAclVq/MS97FTkJ6xfQ= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB1393.namprd11.prod.outlook.com (2603:10b6:404:3c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 00:32:23 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2162:be61:a479:4168]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2162:be61:a479:4168%9]) with mapi id 15.20.4219.023; Fri, 11 Jun 2021 00:32:23 +0000 From: "Chiu, Chasel" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-platforms][Patch 1/3] CoffeelakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value Thread-Topic: [edk2-platforms][Patch 1/3] CoffeelakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value Thread-Index: AQHXXkps09tnOemFUUyE442BsFdDuasN9cwQ Date: Fri, 11 Jun 2021 00:32:23 +0000 Message-ID: References: <20210610224550.855-1-michael.d.kinney@intel.com> <20210610224550.855-2-michael.d.kinney@intel.com> In-Reply-To: <20210610224550.855-2-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [111.240.64.175] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a859a0a3-0a17-4c1c-cc94-08d92c7061aa x-ms-traffictypediagnostic: BN6PR11MB1393: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K1w0F+GpYE0+1gjqABiujwb5BEXEmWWBkMJuo4RZSzRXvttpPVIz8WQtEmYOITrk8DxFmMIWGXGjmBZUiRWYzFGBOClLhRT7tsA4RzdQjbvwX0aYC/YTaftsFTEBgcMeFhFb6guDK4S3cL+HByiu1OV1fIQN9lH3w2ZNKreO5eKZGBQD0AK0TLKqIoZGIIBTJF+fDCO+I4MC+Q8aGPpiqngU9vsasuCwTZ5Tz8rABM0qTlNlZS1WOWRBW4HRI1q/9px8r8nxpFGUqH30GsrBa7eYcynz85TkAyxUQjOb0CrljczaiDZK01/U2DNL7DTHl8D+QidWAe3Zs9j4+PXFWC0X3KWWNRNYhuy4YCKuc4AIcTfTkBFZL9ImufPTp8RUylus2uK1NTiDGmUO8Cs4l12JZ3bfQBqrlRFydg6jQ9jwVihK32Bw61NxddFtV7JsMKrTeRbatL2AFki/46+kjnI87bMrfVX57UdaxqTOv81qb7yb4X3yKP2IVoHXG7ojZmPP2XYBbPcdAX0KoxM3yMl4OVj4F+Lz1+G8lcKCw6cDZE5Qv8I50iwSyOa+SVivewUyaby5/CaQ/gJyR4JJKcBN/6nP3d9T/yqLyr51Ijjx8q68xIRmlBByigD3NGvTqPJkLgJsVfjIi/7NQ6jiPs5O7ED5vJFCRTXyp55NtWlTEga/MQgTnIZfEQbcXE17vPYByA4tdqWBeKHpqghYrw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(346002)(39860400002)(376002)(136003)(396003)(366004)(53546011)(8676002)(478600001)(316002)(86362001)(9686003)(66476007)(66556008)(8936002)(76116006)(966005)(5660300002)(186003)(66446008)(66946007)(64756008)(7696005)(38100700002)(52536014)(122000001)(71200400001)(83380400001)(55016002)(107886003)(2906002)(26005)(110136005)(6506007)(4326008)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qRny9IgXCTVuREdl8Ysc3D+KqmfM9yG4Au4wpDdIiBTv6ce0RGthGxK8HhOn?= =?us-ascii?Q?D9ka3W4c9y5X45bEBHXrsX4hsK7nrQmbPEq14reslOTBfKexFk9ESmFP0AIg?= =?us-ascii?Q?NlZHlpgz+GZf1Ngl7NbrjGhVmRTwEMeyOpU6eHGq1UA3K7yu08ReIoW5oIcJ?= =?us-ascii?Q?xhqWbv1cXK/icVUyhAFo0F2zX6I6t4TxCQtmKQHMkq/2172VSA5UymE67NpF?= =?us-ascii?Q?a6SqPZPFzck2dyelqgstnZEa6c/v5k+KlGYqJucw3cel+fvsDUpelp9nD/34?= =?us-ascii?Q?eLj9Q5pNfdTArBaxhwYtHgLl6RGJvQGftdtsBW+wr7twUw5mQfPxQxG8KtfH?= =?us-ascii?Q?/SX6m5zFvTh9Fbo6+9DYwvYKjc4WMeYNwwAq/m6PiJBhhAqa3c3DkZHjTfXQ?= =?us-ascii?Q?B5pgHkKzDOsvjkXcY7YyIGd9HKypRauRqcSLspOV71KbD1Aks6L5csvbcdV9?= =?us-ascii?Q?BqLqe29FIpxNV9SIPSNoECFykD42HsBA41pDO9XmyX8Xc5wam7YszJXZVWCU?= =?us-ascii?Q?AkOikCc7yQ9LHIJvmQqicUvzQEAPzGkc3pnTuH+KRUr1hNmsuYcFhBc8Bp18?= =?us-ascii?Q?E/PR4NqSwtmDGpNYye2CB60rJCMjN2jG7hSqqyasFlR7ZAYXOkZnjh2zzPOL?= =?us-ascii?Q?IqQtUPViDQF1eWiYzjxyB1uK/u1iHZ70O4WsljntJ416agWXc9aY5sbSihtY?= =?us-ascii?Q?nTKF/WOAZBq5s3nJd4KSruhkBK1T9j2Oo41dh/IC1dquVkR2fslTiILda3p4?= =?us-ascii?Q?mp3o4bW5P5Tjr24XGxn2ekeLruRa5jkl021k9TDQDXNSy9G4dY685euPIS8J?= =?us-ascii?Q?wFNyuSTazNSg9+qstQvJKtpYQU3XUxETMS4SaVRoVklWkRv7uBJcsWwhQyi6?= =?us-ascii?Q?u7PxFmOTESM8QruL7u8hyGH7Y7NJzb1dk25yjwHionMHSt2ik6eP526xkRe0?= =?us-ascii?Q?LpPhqJoEU+hye95+02Fp3R7FvTSTGt59uSzKO0iiuDEJGHltgpeOHuE2PV+Z?= =?us-ascii?Q?ZEOdkSMIz7M84hsufEnv4EVgG/JYmrQZEHXzdxcQj7yGzjrZzSHZ+PcGJ8kZ?= =?us-ascii?Q?O0PXX47lJ+w65X4mR2o4djIV24sgjSZp9wQq0WsLZP3vbnJHR9D9KlT9nWGc?= =?us-ascii?Q?7dXLob+iSSYQ8gluNoCUWGCqzeWVaVzDNx/flZSmQwx1JvtHmd7SIIgVnM2W?= =?us-ascii?Q?1uIgyUcZYF7BVubjznAJbUed2ln3JoT3TrXGrspXZzbcoEUWrZDsIyFrCnaq?= =?us-ascii?Q?+rZ/LETJ9k8+/tXxJMX2PnUExbmkpTTKlvD9uIWV5wjj+WQWuYS90J93D4m9?= =?us-ascii?Q?s7AfpbYSrjhW3kDKMCG0Qgjw?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a859a0a3-0a17-4c1c-cc94-08d92c7061aa X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2021 00:32:23.4476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7tvoeIuCXdyXsrff1kcwZvKkF87zL2zgbkIS4UllXuixnkMDnYUjE0VXZMO59QDqMjyl89V2gvYzLuBjiPSowg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1393 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, June 11, 2021 6:46 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][Patch 1/3] CoffeelakeSiliconPkg/BaseSmbusLib: F= ix > SmBusSendByte value >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3450 >=20 > Update SmBusSendByte() to write value to Command Register instead of Host > Data registers. >=20 > Cc: Chasel Chiu > Cc: Sai Chaganty > Signed-off-by: Michael D Kinney > --- > .../Pch/Library/BaseSmbusLib/BaseSmbusLib.c | 24 +++++++++++++------ > 1 file changed, 17 insertions(+), 7 deletions(-) >=20 > diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSmbusLi= b.c > b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSmbusLi= b.c > index 3d6386d433..dacf9d03b2 100644 > --- > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSmbusLi= b.c > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSm > +++ busLib.c > @@ -203,14 +203,24 @@ InternalSmBusNonBlock ( > AuxiliaryControl |=3D B_SMBUS_IO_AAC; > } > // > - // Set Host Commond Register. > + // We do not need Data Register for SendByte Command > // > - IoWrite8 (IoPortBaseAddress + R_SMBUS_IO_HCMD, (UINT8) > SMBUS_LIB_COMMAND (SmBusAddress)); > - // > - // Write value to Host Data 0 and Host Data 1 Registers. > - // > - IoWrite8 (IoPortBaseAddress + R_SMBUS_IO_HD0, (UINT8) Value); > - IoWrite8 (IoPortBaseAddress + R_SMBUS_IO_HD1, (UINT8) (Value >> 8)); > + if ((HostControl =3D=3D V_SMBUS_IO_SMB_CMD_BYTE) && ((SmBusAddress & > BIT0) =3D=3D B_SMBUS_IO_WRITE)) { > + // > + // Set Host Command Register. > + // > + IoWrite8 (IoPortBaseAddress + R_SMBUS_IO_HCMD, (UINT8)Value); } > + else { > + // > + // Set Host Command Register. > + // > + IoWrite8 (IoPortBaseAddress + R_SMBUS_IO_HCMD, (UINT8) > SMBUS_LIB_COMMAND (SmBusAddress)); > + // > + // Write value to Host Data 0 and Host Data 1 Registers. > + // > + IoWrite8 (IoPortBaseAddress + R_SMBUS_IO_HD0, (UINT8) Value); > + IoWrite8 (IoPortBaseAddress + R_SMBUS_IO_HD1, (UINT8) (Value >> > + 8)); } > // > // Set Auxiliary Control Regiester. > // > -- > 2.31.1.windows.1