From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.98107.1682472492043890911 for ; Tue, 25 Apr 2023 18:28:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=C0DkYDoA; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682472491; x=1714008491; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QO03SvRJ5YVd/FRd0EpN8wA7ydblgM5KMCTL3OurIRI=; b=C0DkYDoADLUXOmiD1//DUDecsTXM47GkHOT8EKTTUS8G/uyj9FsjZPJn yHmvBRTRHMC8l0KR3Xn9zuU+v7rdkNEDYQeu+c/5X7OqeUffE2zC9aSrm WfSHJXxHN0NUlsPIts4nFIOXb4Vfbizvnuh0GSmfPhlN0Kfo13+eul6WK WEVEhmaW9oRBDBshaejlLoDcDVfJBLSH3R83leDnOwhU73qHfxjYUGRLr QbFp3TV9ySR1ZTfv8MmiQ2Up4mIS+zYFC2jFR36httwFOMYfrLDDDTrAX prIUtJEYualf1Kc4fDgfr5JwFNjrAww3LjKfNnAEYhLY/+jxayrls5VfN g==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="327275319" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="327275319" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 18:28:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="696420587" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="696420587" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 25 Apr 2023 18:28:11 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 18:28:11 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 18:28:11 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 25 Apr 2023 18:28:11 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 18:28:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PHPA1rEsKeBn005uWBI/NhMOG/oSBgRpPp71wQYuy04JLk8bjckiLT97NjKaQd0zHReJt5gbpQldk1k2X+jpTIwwJYxy5ok0D8SSp6S2B/kTUBSb8QCAwLFHUNCpNJFbmDDiqzvlNGXaKCmQTnUFQhmv46+u1tjOIb3kz9ZMxJWejgReGssKbcR+0U49nSbcPZP31kXPp9u+BxGtjxd8TfgVcD2onH3Fiev04UiNWQqy1YKW1HBv4J1astmpYzsMCiAYULcQ27KzbI1VHP7IySQW6mtx+OSsobJFb8MzLPalW+j8CzDRo+Np0k/CMSGJGjTbpoBktIHCOLx20Tz7XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P81Dm59gPCQXKM5c6VqVv0xZ9JptHFVXP7rsMGwfeXQ=; b=kEIrW6GqjomEJUP1yHWw7L0qFQRkZbPVybuduwoysK+NDz2QyR25KJ/ePPq534W4GWjDHSTzPWSBNJhyy8Die8I9/oRXeHSzkja9QeHYkeILGAGqlfnS5FV+kjnz4CRmVBsFngEjJHNmhPcjzKumzuZYnO9JyxciE+cpQeo8W+pWt8H71QC5diUeZj3a/gTKLnM9B4K7kBIcZ4qM1zHJCKNf83PMsNth5eS8bIDgV5iU94zKRWm/2CQnwRB/v39SJtIHiffVoSciOcifrsK1Z0gjWWtDcET8y+N8Xd3Fp+NNZUncXtE6vM4TERgHiWtS+BlASwfDDRDEdgkseB8feA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by IA0PR11MB7403.namprd11.prod.outlook.com (2603:10b6:208:431::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.20; Wed, 26 Apr 2023 01:28:09 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a%7]) with mapi id 15.20.6340.020; Wed, 26 Apr 2023 01:28:09 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , "Chen, Xiao X" Subject: Re: [edk2-devel] [Patch V2 1/2] UefiCpuPkg: Update code to support enable ProcTrace only on BSP Thread-Topic: [edk2-devel] [Patch V2 1/2] UefiCpuPkg: Update code to support enable ProcTrace only on BSP Thread-Index: AQHZd3+XljfMYhTN10io1DHFML+Sha88zPGA Date: Wed, 26 Apr 2023 01:28:09 +0000 Message-ID: References: <20230425090524.3027-1-dun.tan@intel.com> <20230425090524.3027-2-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|IA0PR11MB7403:EE_ x-ms-office365-filtering-correlation-id: 66091f54-d7e5-40f5-de02-08db45f57e51 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: biQ9ctXlfaMIwPSJzUU1M6SKp4oxBPpxkViRzGONmCnlD1znzLt4fl8eBelivE5hP0rO9vy76RqpFtq9QUOBMI/hNvpN7jJ3UwjEhTMdgF1dazNP+9+zpdxsa7lRScV6FNtRd5A1Ie16Dn7wAUmwK5kNFGzO+6mh6xh/psss8P6dQpzVNnRQ6I1qoA0COqW4wxRt/TDrGU3/UkxoIaVvOX9mC/uzPYDLD0/wcY9g4SaA/o0qmdbHr5R/JCsXlAgum8bHF0iox5G2rgqyic2Aqx+KtEtYIb0aDDtH1anw+UgATvGCW13lcvLvUD5nuipM0/iiko3ZiMq8XYEFA6fErZHV5P1R5xdsTz7lIvnIm330Kp8VwinPk7xGSW2jJubFeSZs9l+mSWvOQO1Pn6/hAxxRJpAKjDhtPNaVTkCK+52lRUXJ8IDjuFmklDEonPAVtMFOy5ir1DvChWxCTNCc6Y7/SHPh8MtfyIEUXpW6QkU1zgddyUf7UrnwChICYOQ4ShPA7s3kPk3S2tQnVLqWzX8eIDTmm6p2JpbdEte86zj0wZx1eaAiBzF3uKolCREOjh43GJC9N1z30UcP7Bsdv8MyiBwqLq0QvPJasNrij0PIspGjHNWxwX1D9NKrLrBF x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(376002)(346002)(396003)(366004)(451199021)(83380400001)(76116006)(7696005)(71200400001)(478600001)(110136005)(54906003)(6506007)(26005)(107886003)(186003)(9686003)(53546011)(4744005)(52536014)(15650500001)(5660300002)(33656002)(122000001)(82960400001)(38100700002)(66556008)(66946007)(4326008)(64756008)(66446008)(66476007)(86362001)(41300700001)(8936002)(55016003)(38070700005)(316002)(2906002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gUju3NozxnjPBFosuAn6Pv551uVX8UjmqjJGvaO/sDD1iBvSVq1yfxpGbtfT?= =?us-ascii?Q?cPj06n0drUFxWXzIYRi1dkmzxIkl9ucj78iKNjEwGeIgdM7N5RdTIE4vIlZw?= =?us-ascii?Q?sJo+GfZg7PeLxrMo0PltHmxLiqbNUFyWeRoN57c6K2zSJMbBds3JBg6efjdD?= =?us-ascii?Q?CUrhHK+qlcE7YftNBPiINLD+m9/B3Gi3qrflZJhMvcuHPprsKYqYiUzBSObA?= =?us-ascii?Q?29NnyyMUCcVfM6QjcX6KQVt4OeJ1H1LBWKHWm4r45wyyqWpp51Avci4uh++6?= =?us-ascii?Q?84Y26UsDConxHiBOvUb+6pm7oWlrh3gII0nzS17dw97FEHFxZT/52rVbQepL?= =?us-ascii?Q?zmXnjQixAPOFm5uSpE/yGjx3xEFF3CpKw7leL0SqcsbdTWaDBF6zYNn1MZEt?= =?us-ascii?Q?sY24km2eIzFhhZi9Tor1TQCc3NeauTC/F+hBsqIpLiYzw37H9exvTUjGzBuA?= =?us-ascii?Q?nliMkG48XULd/TJ3dOY77PTe025E5VlIbU2g3VkAEc1aIpJigme7t9QAM/yy?= =?us-ascii?Q?o8unAr8llQmug9Ov5X2XS/8yx4ID81q9aWSy3DaDPFx1nueO0mQS0X1RHRmH?= =?us-ascii?Q?G1TtR6Cj4K7bPt5sKt1IQ+N3/+YA3mAcCN4FG0SInN35waOewuweuoLTrJCs?= =?us-ascii?Q?EE7vvTTBrMBulWmY1qeGUKxE770BctzlYnOdNZCsgayMhIMZahgHGNlFH81R?= =?us-ascii?Q?X7klbuBdgiR+UOXqn1rLAvH4Lcd9A0C2WcAsid9a2lmR765ZWbmp2h4Geyku?= =?us-ascii?Q?O+lOPLoCl3/QZFV+C7VPqUbM1zbBPdYjujYUDqQvYxxra2rX5HJFuG+Ntz12?= =?us-ascii?Q?igN3Z6BOmFkQBuHgPyHgXLb1ADrCLtpRadOR0GRAau9+z1QdZZ43IEZEgvyR?= =?us-ascii?Q?oo8TZIjl6V3MZUEt6hFpYu+KZE0tJ6pvM18yHLtv6nr/20X97eWy/bN+CvUD?= =?us-ascii?Q?PeKE+/GOtuMek+s2Urz0FDHIXAgmExFZTJ0MGU4U1bntzFbj4OJu+rXEdUOm?= =?us-ascii?Q?Tuc7Gs1xL0NWMXBy6VgQk/BJ7uMYMYEBZik4NHyNmns5dRpn1G4cJrQ6bmfZ?= =?us-ascii?Q?G1HB5WvVahtp5w4jwar+UuDbnGa4nI5v7fajmXMXkxhqiELKiHUpQM5btuIX?= =?us-ascii?Q?B6J21gRCZEndk+AbXla533hFBUQAEG1tFPDWOZ3iBJ3+3yxCygel++f07bBL?= =?us-ascii?Q?MPehDe3BOqOPJUNVHTLsqX0YE24rvQPKbfKRHGOU6bRQBwphVSOVw6HZwhem?= =?us-ascii?Q?hcelkSpdtIudPIYXc/W5ci3cCZJpf2t2EQ6XbzWqRU94uBZTw1ly5eyYHlmS?= =?us-ascii?Q?r84V+zlBiFJwsY/vUdEHPAMN0OYDTvr/3H7hbx9rf/z7KiUIyqhpowCJx/+r?= =?us-ascii?Q?gwi0/+fJ9y2hOdqv3fmCP/g4x8DYGyCtn1ivn5ai9BanmTWSFl3e2Ug0OhB8?= =?us-ascii?Q?nW/VT6tqXbZT64JvAvngtrZFIW2yJDdR8w+iGStBrLcaKwV5Ccw/DIsvAniF?= =?us-ascii?Q?yw7EluIzsXeebpkkAlkpykeV+qJ0D4VIFhiVjETsH0OF0gt3jmzM6OF/S/bD?= =?us-ascii?Q?0YnUthWhkeuwIVY5bVc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66091f54-d7e5-40f5-de02-08db45f57e51 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2023 01:28:09.1309 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PbNK8jdyuBKbSN0cXf55yHyS1TOjcFg4XWpXR160TnPtL+XdYGrYWbQlXXSScxV2dd3ml8Be93G/RfK1rcUFAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7403 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the comments. I'll add comments to explain it. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Tuesday, April 25, 2023 10:10 PM To: devel@edk2.groups.io; Tan, Dun Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann ; Chen, Xiao X Subject: RE: [edk2-devel] [Patch V2 1/2] UefiCpuPkg: Update code to support= enable ProcTrace only on BSP > + if (ProcTraceData->EnableOnBspOnly) { 1. can you please add comments here to remind reader that this is also the first and only time ProcTraceInitialize() runs? Similar comments in the next chunk code. > + MemRegionBaseAddr =3D (UINTN)AllocateAlignedReservedPages (Pages, > Alignment); > + if (MemRegionBaseAddr =3D=3D 0) { > + // > + // Could not allocate for BSP even > + // > + DEBUG ((DEBUG_ERROR, "ProcTrace: Out of mem, failed to allocate > buffer for BSP\n")); > + return RETURN_OUT_OF_RESOURCES; > + }=20