[edk2-devel] remove <LegacyBiosMpTable.h> and <Mps.h>, including references

[edk2-devel] remove <LegacyBiosMpTable.h> and <Mps.h>, including references

[Laszlo Ersek]

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754

I'm sending this as a common anchor message for

  [edk2-platforms PATCH 0/2] remove <LegacyBiosMpTable.h> and <Mps.h> refs
                 [PATCH 0/3] remove <LegacyBiosMpTable.h> and <Mps.h>, including refs

Thanks,
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110969): https://edk2.groups.io/g/devel/message/110969
Mute This Topic: https://groups.io/mt/102483845/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH 0/2] remove <LegacyBiosMpTable.h> and <Mps.h> refs

[Laszlo Ersek]

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754

Remove references to two old headers that play no role in modern UEFI.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>

Laszlo Ersek (2):
  WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references
  SimicsOpenBoardPkg: remove <Mps.h> reference

 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h                          | 1 -
 Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h | 1 -
 Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c       | 1 -
 3 files changed, 3 deletions(-)


base-commit: 3c2f11d19e02a71c87ada8513bcbb0f0c504eebc


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110971): https://edk2.groups.io/g/devel/message/110971
Mute This Topic: https://groups.io/mt/102483851/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

[Laszlo Ersek]

For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from
edk2, first remove the edk2-platforms references to that header file.

I can't build-test this change. As far as I can tell, building the
CooperCityRvp and WilsonCityRvp platforms with "build_bios.py" should
build these changes; however, both platforms fail to build without FSP
blobs.

I think there's a fair chance that this patch should work nonetheless;
<LegacyBiosMpTable.h> introduces names prefixed with EFI_LEGACY_MP_TABLE_,
and edk2-platforms doesn't contain that string. (The one exception is
FEATUREBYTE2_5, which is also absent from edk2-platforms.)

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h | 1 -
 Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c       | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h
index 32c16ff9110a..d8c209a57f75 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h
@@ -27,7 +27,6 @@
 #include <Platform.h>
 #include <Ppi/PchPolicy.h>
 
-#include <IndustryStandard/LegacyBiosMpTable.h>
 #include <UncoreCommonIncludes.h>
 
 #endif  //_SYSTEM_BOARD_INFO_DXE_H_
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c
index ed9f80734cd7..b69ae1736bb8 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c
@@ -8,7 +8,6 @@
 
 #include <PlatPirqData.h>
 #include <PlatDevData.h>
-#include <IndustryStandard/LegacyBiosMpTable.h>
 
 #ifndef V_INTEL_VID
 #define V_INTEL_VID               0x8086



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110970): https://edk2.groups.io/g/devel/message/110970
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

[Chiu, Chasel]

Hi Laszlo,

I verified and encountered build failure as some files still consuming definitions from LegacyBiosMpTable.h, for example:
https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22

Any suggestion that we can reduce impact to existing platforms?

Thanks,
Chasel



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Thursday, November 9, 2023 4:06 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from
> edk2, first remove the edk2-platforms references to that header file.
> 
> I can't build-test this change. As far as I can tell, building the CooperCityRvp and
> WilsonCityRvp platforms with "build_bios.py" should build these changes;
> however, both platforms fail to build without FSP blobs.
> 
> I think there's a fair chance that this patch should work nonetheless;
> <LegacyBiosMpTable.h> introduces names prefixed with
> EFI_LEGACY_MP_TABLE_, and edk2-platforms doesn't contain that string. (The
> one exception is FEATUREBYTE2_5, which is also absent from edk2-platforms.)
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoar
> dInfoDxe/SystemBoardInfoDxe.h | 1 -
> 
> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platform
> DeviceDataSRP10nm.c       | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> ardInfoDxe/SystemBoardInfoDxe.h
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> ardInfoDxe/SystemBoardInfoDxe.h
> index 32c16ff9110a..d8c209a57f75 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> ardInfoDxe/SystemBoardInfoDxe.h
> +++
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> +++ ardInfoDxe/SystemBoardInfoDxe.h
> @@ -27,7 +27,6 @@
>  #include <Platform.h>
>  #include <Ppi/PchPolicy.h>
> 
> -#include <IndustryStandard/LegacyBiosMpTable.h>
>  #include <UncoreCommonIncludes.h>
> 
>  #endif  //_SYSTEM_BOARD_INFO_DXE_H_
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
> mDeviceDataSRP10nm.c
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
> mDeviceDataSRP10nm.c
> index ed9f80734cd7..b69ae1736bb8 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
> mDeviceDataSRP10nm.c
> +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Pl
> +++ atformDeviceDataSRP10nm.c
> @@ -8,7 +8,6 @@
> 
>  #include <PlatPirqData.h>
>  #include <PlatDevData.h>
> -#include <IndustryStandard/LegacyBiosMpTable.h>
> 
>  #ifndef V_INTEL_VID
>  #define V_INTEL_VID               0x8086
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111005): https://edk2.groups.io/g/devel/message/111005
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

[Laszlo Ersek]

Hi Chasel,

On 11/10/23 02:13, Chiu, Chasel wrote:
> 
> Hi Laszlo,
> 
> I verified and encountered build failure as some files still consuming definitions from LegacyBiosMpTable.h, for example:
> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
> 
> Any suggestion that we can reduce impact to existing platforms?

thanks for testing the build!

Here's my problem: this information seems to be exposed
firmware-globally, ultimately. We have a UbaConfigProtocol->AddData()
call, which exposes SystemBoardInfoData. SystemBoardInfoData exposes
SystemBoardInfoCallback(). That one in turn exposes SystemBoardInfoTable
(of type DXE_SYSTEM_BOARD_INFO).

And so on and so on, and ultimately we publicly expose
DEVICE_DATA_HW_LOCAL_INT.

That structure type is defined in
"Platform/Intel/WhitleyOpenBoardPkg/Include/PlatDevData.h", and it only
has the following comment:

"Platform hardwired data describing connection of interrupt sources to
local APICs"

So I can't tell if this structure type officially and explicitly defers
to the MP Table specification, or just ad-hoc reuses the same values.

In the former case, we cannot remove LegacyBiosMpTable.h from edk2 (or
perhaps we need to move it over to edk2-platforms).

In the latter case, we should just replace the enum constants with their
integer values (or perhaps replace them with some different macros, like
ACPI spec macros or similar), and then we can delete LegacyBiosMpTable.h.

That is, we need to figure out where the DEVICE_DATA_HW_LOCAL_INT type
definition originates from.

The particular "DeviceDataHwLocalInt1" array comes from edk2-platforms
commit 3584efd25110 ("WhitleyOpenBoardPkg: Add UBA Modules",
2021-07-14). The commit message is empty -- so it's a dead-end.

The type definition comes from edk2-platforms commit 41bfa85f527a
("WhitleyOpenBoardPkg: Add Includes and Libraries", 2021-07-14). The
commit message is similarly empty.

Laszlo

> 
> Thanks,
> Chasel
> 
> 
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
>> Sent: Thursday, November 9, 2023 4:06 AM
>> To: devel@edk2.groups.io
>> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
>> L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
>> Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
>> remove <LegacyBiosMpTable.h> references
>>
>> For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from
>> edk2, first remove the edk2-platforms references to that header file.
>>
>> I can't build-test this change. As far as I can tell, building the CooperCityRvp and
>> WilsonCityRvp platforms with "build_bios.py" should build these changes;
>> however, both platforms fail to build without FSP blobs.
>>
>> I think there's a fair chance that this patch should work nonetheless;
>> <LegacyBiosMpTable.h> introduces names prefixed with
>> EFI_LEGACY_MP_TABLE_, and edk2-platforms doesn't contain that string. (The
>> one exception is FEATUREBYTE2_5, which is also absent from edk2-platforms.)
>>
>> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoar
>> dInfoDxe/SystemBoardInfoDxe.h | 1 -
>>
>> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platform
>> DeviceDataSRP10nm.c       | 1 -
>>  2 files changed, 2 deletions(-)
>>
>> diff --git
>> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
>> ardInfoDxe/SystemBoardInfoDxe.h
>> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
>> ardInfoDxe/SystemBoardInfoDxe.h
>> index 32c16ff9110a..d8c209a57f75 100644
>> ---
>> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
>> ardInfoDxe/SystemBoardInfoDxe.h
>> +++
>> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
>> +++ ardInfoDxe/SystemBoardInfoDxe.h
>> @@ -27,7 +27,6 @@
>>  #include <Platform.h>
>>  #include <Ppi/PchPolicy.h>
>>
>> -#include <IndustryStandard/LegacyBiosMpTable.h>
>>  #include <UncoreCommonIncludes.h>
>>
>>  #endif  //_SYSTEM_BOARD_INFO_DXE_H_
>> diff --git
>> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
>> mDeviceDataSRP10nm.c
>> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
>> mDeviceDataSRP10nm.c
>> index ed9f80734cd7..b69ae1736bb8 100644
>> ---
>> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
>> mDeviceDataSRP10nm.c
>> +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Pl
>> +++ atformDeviceDataSRP10nm.c
>> @@ -8,7 +8,6 @@
>>
>>  #include <PlatPirqData.h>
>>  #include <PlatDevData.h>
>> -#include <IndustryStandard/LegacyBiosMpTable.h>
>>
>>  #ifndef V_INTEL_VID
>>  #define V_INTEL_VID               0x8086
>>
>>
>>
>>
>>
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111132): https://edk2.groups.io/g/devel/message/111132
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

[Laszlo Ersek]

Hi Chasel,

On 11/10/23 02:13, Chiu, Chasel wrote:
> 
> Hi Laszlo,
> 
> I verified and encountered build failure as some files still consuming definitions from LegacyBiosMpTable.h, for example:
> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
> 
> Any suggestion that we can reduce impact to existing platforms?

I've been hoping to get comments from Nate on the expected contents of
DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my proposal:
I'd like to just replace the enum constants in question with their
numerical values.

However, even for that, I'd really like to be able to build-test the
platform locally. Do you have build instructions? How can I satisfy the
FSP blob requirement?

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111261): https://edk2.groups.io/g/devel/message/111261
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

[Chiu, Chasel]

Hi Laszlo,

I think you have to clone all the required repos.
edk2 repository
git clone https://github.com/tianocore/edk2.git

edk2-platforms repository
git clone https://github.com/tianocore/edk2-platforms.git

edk2-non-osi repository
git clone https://github.com/tianocore/edk2-non-osi.git

FSP repository
git clone https://github.com/IntelFsp/FSP.git

check if you got all repos like below:
edk2
edk2-non-osi
edk2-platforms
FSP

Then switch to edk2-platforms/Platform/Intel/build_bios.py -p WilsonCityRvp to start the build

Detail information is in readme: https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/Readme.md

Please let me know if any question.

Thanks,
Chasel





> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Wednesday, November 15, 2023 3:51 AM
> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> Hi Chasel,
> 
> On 11/10/23 02:13, Chiu, Chasel wrote:
> >
> > Hi Laszlo,
> >
> > I verified and encountered build failure as some files still consuming definitions
> from LegacyBiosMpTable.h, for example:
> > https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd5469051338
> >
> 0ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Co
> m
> > mon/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
> >
> > Any suggestion that we can reduce impact to existing platforms?
> 
> I've been hoping to get comments from Nate on the expected contents of
> DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my proposal:
> I'd like to just replace the enum constants in question with their numerical values.
> 
> However, even for that, I'd really like to be able to build-test the platform locally.
> Do you have build instructions? How can I satisfy the FSP blob requirement?
> 
> Thanks!
> Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111499): https://edk2.groups.io/g/devel/message/111499
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

[Laszlo Ersek]

Hi Chasel,

On 11/21/23 03:17, Chiu, Chasel wrote:
> 
> Hi Laszlo,
> 
> I think you have to clone all the required repos.
> edk2 repository
> git clone https://github.com/tianocore/edk2.git
> 
> edk2-platforms repository
> git clone https://github.com/tianocore/edk2-platforms.git
> 
> edk2-non-osi repository
> git clone https://github.com/tianocore/edk2-non-osi.git
> 
> FSP repository
> git clone https://github.com/IntelFsp/FSP.git

But that's the thing exactly: this repository is not public, and I'm not
a member of the IntelFsp organization. When I log in to GitHub, and open

  https://github.com/IntelFsp/

the page says

  This organization has no public repositories.

This is basically what I meant earlier, when I asked: "How can I satisfy
the FSP blob requirement?".

Anyway... this is taking too long; I don't want to waste your time with
it. We can't reasonably expect any contributor to send patches for a
subsystem they can't even build due to not being permitted access to
various proprietary blobs. I'm dropping this patch set now (for edk2 as
well), and removing myself from the BZ.

Thanks for the help thus far!
Laszlo

> 
> check if you got all repos like below:
> edk2
> edk2-non-osi
> edk2-platforms
> FSP
> 
> Then switch to edk2-platforms/Platform/Intel/build_bios.py -p WilsonCityRvp to start the build
> 
> Detail information is in readme: https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/Readme.md
> 
> Please let me know if any question.
> 
> Thanks,
> Chasel
> 
> 
> 
> 
> 
>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Wednesday, November 15, 2023 3:51 AM
>> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
>> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
>> L <nathaniel.l.desimone@intel.com>
>> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
>> remove <LegacyBiosMpTable.h> references
>>
>> Hi Chasel,
>>
>> On 11/10/23 02:13, Chiu, Chasel wrote:
>>>
>>> Hi Laszlo,
>>>
>>> I verified and encountered build failure as some files still consuming definitions
>> from LegacyBiosMpTable.h, for example:
>>> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd5469051338
>>>
>> 0ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Co
>> m
>>> mon/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
>>>
>>> Any suggestion that we can reduce impact to existing platforms?
>>
>> I've been hoping to get comments from Nate on the expected contents of
>> DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my proposal:
>> I'd like to just replace the enum constants in question with their numerical values.
>>
>> However, even for that, I'd really like to be able to build-test the platform locally.
>> Do you have build instructions? How can I satisfy the FSP blob requirement?
>>
>> Thanks!
>> Laszlo
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111666): https://edk2.groups.io/g/devel/message/111666
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

[Chiu, Chasel]

Hi Laszlo,

Thanks for your support too!
By the way, do we still plan to remove LgacyBiosMpTable.h? We can follow up with relevant OpenBoardPkg fixes if that's the goal.

Thanks,
Chasel



> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Thursday, November 23, 2023 2:05 AM
> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> Hi Chasel,
> 
> On 11/21/23 03:17, Chiu, Chasel wrote:
> >
> > Hi Laszlo,
> >
> > I think you have to clone all the required repos.
> > edk2 repository
> > git clone https://github.com/tianocore/edk2.git
> >
> > edk2-platforms repository
> > git clone https://github.com/tianocore/edk2-platforms.git
> >
> > edk2-non-osi repository
> > git clone https://github.com/tianocore/edk2-non-osi.git
> >
> > FSP repository
> > git clone https://github.com/IntelFsp/FSP.git
> 
> But that's the thing exactly: this repository is not public, and I'm not a member of
> the IntelFsp organization. When I log in to GitHub, and open
> 
>   https://github.com/IntelFsp/
> 
> the page says
> 
>   This organization has no public repositories.
> 
> This is basically what I meant earlier, when I asked: "How can I satisfy the FSP
> blob requirement?".
> 
> Anyway... this is taking too long; I don't want to waste your time with it. We can't
> reasonably expect any contributor to send patches for a subsystem they can't
> even build due to not being permitted access to various proprietary blobs. I'm
> dropping this patch set now (for edk2 as well), and removing myself from the BZ.
> 
> Thanks for the help thus far!
> Laszlo
> 
> >
> > check if you got all repos like below:
> > edk2
> > edk2-non-osi
> > edk2-platforms
> > FSP
> >
> > Then switch to edk2-platforms/Platform/Intel/build_bios.py -p
> > WilsonCityRvp to start the build
> >
> > Detail information is in readme:
> > https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel
> > /Readme.md
> >
> > Please let me know if any question.
> >
> > Thanks,
> > Chasel
> >
> >
> >
> >
> >
> >> -----Original Message-----
> >> From: Laszlo Ersek <lersek@redhat.com>
> >> Sent: Wednesday, November 15, 2023 3:51 AM
> >> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> >> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone,
> >> Nathaniel L <nathaniel.l.desimone@intel.com>
> >> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> >> remove <LegacyBiosMpTable.h> references
> >>
> >> Hi Chasel,
> >>
> >> On 11/10/23 02:13, Chiu, Chasel wrote:
> >>>
> >>> Hi Laszlo,
> >>>
> >>> I verified and encountered build failure as some files still
> >>> consuming definitions
> >> from LegacyBiosMpTable.h, for example:
> >>> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513
> >>> 38
> >>>
> >>
> 0ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Co
> >> m
> >>> mon/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
> >>>
> >>> Any suggestion that we can reduce impact to existing platforms?
> >>
> >> I've been hoping to get comments from Nate on the expected contents
> >> of DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my
> proposal:
> >> I'd like to just replace the enum constants in question with their numerical
> values.
> >>
> >> However, even for that, I'd really like to be able to build-test the platform
> locally.
> >> Do you have build instructions? How can I satisfy the FSP blob requirement?
> >>
> >> Thanks!
> >> Laszlo
> >
> >
> >
> > 
> >
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111754): https://edk2.groups.io/g/devel/message/111754
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

[Pedro Falcato]

On Tue, Nov 21, 2023 at 2:17 AM Chiu, Chasel <chasel.chiu@intel.com> wrote:
>
>
> Hi Laszlo,
>
> I think you have to clone all the required repos.
> edk2 repository
> git clone https://github.com/tianocore/edk2.git
>
> edk2-platforms repository
> git clone https://github.com/tianocore/edk2-platforms.git
>
> edk2-non-osi repository
> git clone https://github.com/tianocore/edk2-non-osi.git
>
> FSP repository
> git clone https://github.com/IntelFsp/FSP.git

I wonder if the docs are outdated? I had heard of
https://github.com/Intel/FSP, not IntelFsp/FSP.
Does https://github.com/Intel/FSP work?

-- 
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111763): https://edk2.groups.io/g/devel/message/111763
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references

[Chiu, Chasel]

> -----Original Message-----
> From: Pedro Falcato <pedro.falcato@gmail.com>
> Sent: Monday, November 27, 2023 3:14 PM
> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> On Tue, Nov 21, 2023 at 2:17 AM Chiu, Chasel <chasel.chiu@intel.com> wrote:
> >
> >
> > Hi Laszlo,
> >
> > I think you have to clone all the required repos.
> > edk2 repository
> > git clone https://github.com/tianocore/edk2.git
> >
> > edk2-platforms repository
> > git clone https://github.com/tianocore/edk2-platforms.git
> >
> > edk2-non-osi repository
> > git clone https://github.com/tianocore/edk2-non-osi.git
> >
> > FSP repository
> > git clone https://github.com/IntelFsp/FSP.git
> 
> I wonder if the docs are outdated? I had heard of https://github.com/Intel/FSP,
> not IntelFsp/FSP.
> Does https://github.com/Intel/FSP work?


Yes, https://github.com/intel/FSP.git is the one, however, In my case both links work the same and I can clone successfully by either one.


> 
> --
> Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111790): https://edk2.groups.io/g/devel/message/111790
Mute This Topic: https://groups.io/mt/102483850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH 2/2] SimicsOpenBoardPkg: remove <Mps.h> reference

[Laszlo Ersek]

For removing "MdePkg/Include/Guid/Mps.h" from edk2, first remove the
edk2-platforms references to that header file.

I can't build-test this change. As far as I can tell, building the
BoardX58Ich10 platform with "build_bios.py" should build the change;
however, that platform fails to build without an FSP blob.

I think there's a fair chance that this patch should work nonetheless;
<Mps.h> introduces EFI_MPS_TABLE_GUID, MPS_TABLE_GUID, and
gEfiMpsTableGuid, and edk2-platforms doesn't contain those strings.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h b/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h
index 566b6a48c65d..62c6dfe9b52d 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h
+++ b/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h
@@ -46,7 +46,6 @@
 
 #include <Guid/Acpi.h>
 #include <Guid/SmBios.h>
-#include <Guid/Mps.h>
 #include <Guid/HobList.h>
 #include <Guid/GlobalVariable.h>
 #include <Guid/EventGroup.h>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110972): https://edk2.groups.io/g/devel/message/110972
Mute This Topic: https://groups.io/mt/102483855/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 0/3] remove <LegacyBiosMpTable.h> and <Mps.h>, including refs

[Laszlo Ersek]

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754

Remove two old headers that play no role in modern UEFI.

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>

Laszlo Ersek (3):
  MdePkg: remove <LegacyBiosMpTable.h>
  ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from
    DMEM
  MdePkg: remove <Mps.h>

 MdePkg/Include/Guid/Mps.h                                                  |  29 --
 MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h                        | 288 --------------------
 MdePkg/MdePkg.dec                                                          |   3 -
 ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c                         |   9 -
 ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf |   1 -
 ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni |   1 -
 6 files changed, 331 deletions(-)
 delete mode 100644 MdePkg/Include/Guid/Mps.h
 delete mode 100644 MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h


base-commit: bb18fb80abb9d35d01be5d693086a9ed4b9d65b5


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110973): https://edk2.groups.io/g/devel/message/110973
Mute This Topic: https://groups.io/mt/102483864/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/3] MdePkg: remove <LegacyBiosMpTable.h>

[Laszlo Ersek]

Nothing in edk2 (or edk2-platforms, at this point) references
"LegacyBiosMpTable.h", or the names it introduces (EFI_LEGACY_MP_TABLE_*
and FEATUREBYTE2_5). Remove the header.

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h | 288 --------------------
 1 file changed, 288 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h b/MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h
deleted file mode 100644
index fa57f1ca10ce..000000000000
--- a/MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h
+++ /dev/null
@@ -1,288 +0,0 @@
-/** @file
-  Defives data structures per MultiProcessor Specification Ver 1.4.
-
-  The MultiProcessor Specification defines an enhancement to the standard
-  to which PC manufacturers design DOS-compatible systems.
-
-Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
-SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-
-#ifndef _LEGACY_BIOS_MPTABLE_H_
-#define _LEGACY_BIOS_MPTABLE_H_
-
-#define EFI_LEGACY_MP_TABLE_REV_1_4  0x04
-
-//
-// Define MP table structures. All are packed.
-//
-#pragma pack(1)
-
-#define EFI_LEGACY_MP_TABLE_FLOATING_POINTER_SIGNATURE  SIGNATURE_32 ('_', 'M', 'P', '_')
-typedef struct {
-  UINT32    Reserved1  : 6;
-  UINT32    MutipleClk : 1;
-  UINT32    Imcr       : 1;
-  UINT32    Reserved2  : 24;
-} FEATUREBYTE2_5;
-
-typedef struct {
-  UINT32            Signature;
-  UINT32            PhysicalAddress;
-  UINT8             Length;
-  UINT8             SpecRev;
-  UINT8             Checksum;
-  UINT8             FeatureByte1;
-  FEATUREBYTE2_5    FeatureByte2_5;
-} EFI_LEGACY_MP_TABLE_FLOATING_POINTER;
-
-#define EFI_LEGACY_MP_TABLE_HEADER_SIGNATURE  SIGNATURE_32 ('P', 'C', 'M', 'P')
-typedef struct {
-  UINT32    Signature;
-  UINT16    BaseTableLength;
-  UINT8     SpecRev;
-  UINT8     Checksum;
-  CHAR8     OemId[8];
-  CHAR8     OemProductId[12];
-  UINT32    OemTablePointer;
-  UINT16    OemTableSize;
-  UINT16    EntryCount;
-  UINT32    LocalApicAddress;
-  UINT16    ExtendedTableLength;
-  UINT8     ExtendedChecksum;
-  UINT8     Reserved;
-} EFI_LEGACY_MP_TABLE_HEADER;
-
-typedef struct {
-  UINT8    EntryType;
-} EFI_LEGACY_MP_TABLE_ENTRY_TYPE;
-
-//
-// Entry Type 0: Processor.
-//
-#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_PROCESSOR  0x00
-typedef struct {
-  UINT8    Enabled  : 1;
-  UINT8    Bsp      : 1;
-  UINT8    Reserved : 6;
-} EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_FLAGS;
-
-typedef struct {
-  UINT32    Stepping : 4;
-  UINT32    Model    : 4;
-  UINT32    Family   : 4;
-  UINT32    Reserved : 20;
-} EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_SIGNATURE;
-
-typedef struct {
-  UINT32    Fpu       : 1;
-  UINT32    Reserved1 : 6;
-  UINT32    Mce       : 1;
-  UINT32    Cx8       : 1;
-  UINT32    Apic      : 1;
-  UINT32    Reserved2 : 22;
-} EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_FEATURES;
-
-typedef struct {
-  UINT8                                            EntryType;
-  UINT8                                            Id;
-  UINT8                                            Ver;
-  EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_FLAGS        Flags;
-  EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_SIGNATURE    Signature;
-  EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_FEATURES     Features;
-  UINT32                                           Reserved1;
-  UINT32                                           Reserved2;
-} EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR;
-
-//
-// Entry Type 1: Bus.
-//
-#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_BUS  0x01
-typedef struct {
-  UINT8    EntryType;
-  UINT8    Id;
-  CHAR8    TypeString[6];
-} EFI_LEGACY_MP_TABLE_ENTRY_BUS;
-
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_CBUS    "CBUS  " // Corollary CBus
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_CBUSII  "CBUSII" // Corollary CBUS II
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_EISA    "EISA  " // Extended ISA
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_FUTURE  "FUTURE" // IEEE FutureBus
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_INTERN  "INTERN" // Internal bus
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_ISA     "ISA   " // Industry Standard Architecture
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MBI     "MBI   " // Multibus I
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MBII    "MBII  " // Multibus II
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MCA     "MCA   " // Micro Channel Architecture
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MPI     "MPI   " // MPI
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MPSA    "MPSA  " // MPSA
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_NUBUS   "NUBUS " // Apple Macintosh NuBus
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_PCI     "PCI   " // Peripheral Component Interconnect
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_PCMCIA  "PCMCIA" // PC Memory Card International Assoc.
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_TC      "TC    " // DEC TurboChannel
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_VL      "VL    " // VESA Local Bus
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_VME     "VME   " // VMEbus
-#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_XPRESS  "XPRESS" // Express System Bus
-//
-// Entry Type 2: I/O APIC.
-//
-#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_IOAPIC  0x02
-typedef struct {
-  UINT8    Enabled  : 1;
-  UINT8    Reserved : 7;
-} EFI_LEGACY_MP_TABLE_ENTRY_IOAPIC_FLAGS;
-
-typedef struct {
-  UINT8                                     EntryType;
-  UINT8                                     Id;
-  UINT8                                     Ver;
-  EFI_LEGACY_MP_TABLE_ENTRY_IOAPIC_FLAGS    Flags;
-  UINT32                                    Address;
-} EFI_LEGACY_MP_TABLE_ENTRY_IOAPIC;
-
-//
-// Entry Type 3: I/O Interrupt Assignment.
-//
-#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_IO_INT  0x03
-typedef struct {
-  UINT16    Polarity : 2;
-  UINT16    Trigger  : 2;
-  UINT16    Reserved : 12;
-} EFI_LEGACY_MP_TABLE_ENTRY_INT_FLAGS;
-
-typedef struct {
-  UINT8    IntNo    : 2;
-  UINT8    Dev      : 5;
-  UINT8    Reserved : 1;
-} EFI_LEGACY_MP_TABLE_ENTRY_INT_FIELDS;
-
-typedef union {
-  EFI_LEGACY_MP_TABLE_ENTRY_INT_FIELDS    fields;
-  UINT8                                   byte;
-} EFI_LEGACY_MP_TABLE_ENTRY_INT_SOURCE_BUS_IRQ;
-
-typedef struct {
-  UINT8                                           EntryType;
-  UINT8                                           IntType;
-  EFI_LEGACY_MP_TABLE_ENTRY_INT_FLAGS             Flags;
-  UINT8                                           SourceBusId;
-  EFI_LEGACY_MP_TABLE_ENTRY_INT_SOURCE_BUS_IRQ    SourceBusIrq;
-  UINT8                                           DestApicId;
-  UINT8                                           DestApicIntIn;
-} EFI_LEGACY_MP_TABLE_ENTRY_IO_INT;
-
-typedef enum {
-  EfiLegacyMpTableEntryIoIntTypeInt    = 0,
-  EfiLegacyMpTableEntryIoIntTypeNmi    = 1,
-  EfiLegacyMpTableEntryIoIntTypeSmi    = 2,
-  EfiLegacyMpTableEntryIoIntTypeExtInt = 3,
-} EFI_LEGACY_MP_TABLE_ENTRY_IO_INT_TYPE;
-
-typedef enum {
-  EfiLegacyMpTableEntryIoIntFlagsPolaritySpec       = 0x0,
-  EfiLegacyMpTableEntryIoIntFlagsPolarityActiveHigh = 0x1,
-  EfiLegacyMpTableEntryIoIntFlagsPolarityReserved   = 0x2,
-  EfiLegacyMpTableEntryIoIntFlagsPolarityActiveLow  = 0x3,
-} EFI_LEGACY_MP_TABLE_ENTRY_IO_INT_FLAGS_POLARITY;
-
-typedef enum {
-  EfiLegacyMpTableEntryIoIntFlagsTriggerSpec     = 0x0,
-  EfiLegacyMpTableEntryIoIntFlagsTriggerEdge     = 0x1,
-  EfiLegacyMpTableEntryIoIntFlagsTriggerReserved = 0x2,
-  EfiLegacyMpTableEntryIoIntFlagsTriggerLevel    = 0x3,
-} EFI_LEGACY_MP_TABLE_ENTRY_IO_INT_FLAGS_TRIGGER;
-
-//
-// Entry Type 4: Local Interrupt Assignment.
-//
-#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_LOCAL_INT  0x04
-typedef struct {
-  UINT8                                           EntryType;
-  UINT8                                           IntType;
-  EFI_LEGACY_MP_TABLE_ENTRY_INT_FLAGS             Flags;
-  UINT8                                           SourceBusId;
-  EFI_LEGACY_MP_TABLE_ENTRY_INT_SOURCE_BUS_IRQ    SourceBusIrq;
-  UINT8                                           DestApicId;
-  UINT8                                           DestApicIntIn;
-} EFI_LEGACY_MP_TABLE_ENTRY_LOCAL_INT;
-
-typedef enum {
-  EfiLegacyMpTableEntryLocalIntTypeInt    = 0,
-  EfiLegacyMpTableEntryLocalIntTypeNmi    = 1,
-  EfiLegacyMpTableEntryLocalIntTypeSmi    = 2,
-  EfiLegacyMpTableEntryLocalIntTypeExtInt = 3,
-} EFI_LEGACY_MP_TABLE_ENTRY_LOCAL_INT_TYPE;
-
-typedef enum {
-  EfiLegacyMpTableEntryLocalIntFlagsPolaritySpec       = 0x0,
-  EfiLegacyMpTableEntryLocalIntFlagsPolarityActiveHigh = 0x1,
-  EfiLegacyMpTableEntryLocalIntFlagsPolarityReserved   = 0x2,
-  EfiLegacyMpTableEntryLocalIntFlagsPolarityActiveLow  = 0x3,
-} EFI_LEGACY_MP_TABLE_ENTRY_LOCAL_INT_FLAGS_POLARITY;
-
-typedef enum {
-  EfiLegacyMpTableEntryLocalIntFlagsTriggerSpec     = 0x0,
-  EfiLegacyMpTableEntryLocalIntFlagsTriggerEdge     = 0x1,
-  EfiLegacyMpTableEntryLocalIntFlagsTriggerReserved = 0x2,
-  EfiLegacyMpTableEntryLocalIntFlagsTriggerLevel    = 0x3,
-} EFI_LEGACY_MP_TABLE_ENTRY_LOCAL_INT_FLAGS_TRIGGER;
-
-//
-// Entry Type 128: System Address Space Mapping.
-//
-#define EFI_LEGACY_MP_TABLE_ENTRY_EXT_TYPE_SYS_ADDR_SPACE_MAPPING  0x80
-typedef struct {
-  UINT8     EntryType;
-  UINT8     Length;
-  UINT8     BusId;
-  UINT8     AddressType;
-  UINT64    AddressBase;
-  UINT64    AddressLength;
-} EFI_LEGACY_MP_TABLE_ENTRY_EXT_SYS_ADDR_SPACE_MAPPING;
-
-typedef enum {
-  EfiLegacyMpTableEntryExtSysAddrSpaceMappingIo       = 0,
-  EfiLegacyMpTableEntryExtSysAddrSpaceMappingMemory   = 1,
-  EfiLegacyMpTableEntryExtSysAddrSpaceMappingPrefetch = 2,
-} EFI_LEGACY_MP_TABLE_ENTRY_EXT_SYS_ADDR_SPACE_MAPPING_TYPE;
-
-//
-// Entry Type 129: Bus Hierarchy.
-//
-#define EFI_LEGACY_MP_TABLE_ENTRY_EXT_TYPE_BUS_HIERARCHY  0x81
-typedef struct {
-  UINT8    SubtractiveDecode : 1;
-  UINT8    Reserved          : 7;
-} EFI_LEGACY_MP_TABLE_ENTRY_EXT_BUS_HIERARCHY_BUSINFO;
-
-typedef struct {
-  UINT8                                                  EntryType;
-  UINT8                                                  Length;
-  UINT8                                                  BusId;
-  EFI_LEGACY_MP_TABLE_ENTRY_EXT_BUS_HIERARCHY_BUSINFO    BusInfo;
-  UINT8                                                  ParentBus;
-  UINT8                                                  Reserved1;
-  UINT8                                                  Reserved2;
-  UINT8                                                  Reserved3;
-} EFI_LEGACY_MP_TABLE_ENTRY_EXT_BUS_HIERARCHY;
-
-//
-// Entry Type 130: Compatibility Bus Address Space Modifier.
-//
-#define EFI_LEGACY_MP_TABLE_ENTRY_EXT_TYPE_COMPAT_BUS_ADDR_SPACE_MODIFIER  0x82
-typedef struct {
-  UINT8    RangeMode : 1;
-  UINT8    Reserved  : 7;
-} EFI_LEGACY_MP_TABLE_ENTRY_EXT_COMPAT_BUS_ADDR_SPACE_MODIFIER_ADDR_MODE;
-
-typedef struct {
-  UINT8                                                                     EntryType;
-  UINT8                                                                     Length;
-  UINT8                                                                     BusId;
-  EFI_LEGACY_MP_TABLE_ENTRY_EXT_COMPAT_BUS_ADDR_SPACE_MODIFIER_ADDR_MODE    AddrMode;
-  UINT32                                                                    PredefinedRangeList;
-} EFI_LEGACY_MP_TABLE_ENTRY_EXT_COMPAT_BUS_ADDR_SPACE_MODIFIER;
-
-#pragma pack()
-
-#endif



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110975): https://edk2.groups.io/g/devel/message/110975
Mute This Topic: https://groups.io/mt/102483866/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM

[Laszlo Ersek]

We're removing <MdePkg/Include/Guid/Mps.h>. First, remove the
gEfiMpsTableGuid system config table reference from the UEFI Shell's DMEM
debug command.

Cc: Zhichao Gao <zhichao.gao@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni | 1 -
 ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 1 -
 ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c                         | 9 ---------
 3 files changed, 11 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
index 4041f0cd483e..155efc1a82f1 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
@@ -112,7 +112,6 @@
                                                   "SAL System Table              %016LX\r\n"
                                                   "ACPI Table                    %016LX\r\n"
                                                   "ACPI 2.0 Table                %016LX\r\n"
-                                                  "MPS Table                     %016LX\r\n"
                                                   "SMBIOS Table                  %016LX\r\n"
                                                   "DTB Table                     %016LX\r\n"
                                                   "Memory Attribute Table        %016LX\r\n"
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
index 3741dac5d94c..2074cb7d96da 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
@@ -127,7 +127,6 @@ [Guids]
   gEfiGlobalVariableGuid          ## SOMETIMES_CONSUMES ## GUID
   gEfiSmbiosTableGuid             ## SOMETIMES_CONSUMES ## SystemTable
   gEfiSmbios3TableGuid            ## SOMETIMES_CONSUMES ## SystemTable
-  gEfiMpsTableGuid                ## SOMETIMES_CONSUMES ## SystemTable
   gEfiAcpi10TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
   gEfiAcpi20TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
   gShellDebug1HiiGuid             ## SOMETIMES_CONSUMES ## HII
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
index a609971f345e..39a59c195512 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
@@ -12,7 +12,6 @@
 #include <Protocol/PciRootBridgeIo.h>
 #include <Protocol/HiiDatabase.h>
 #include <Guid/Acpi.h>
-#include <Guid/Mps.h>
 #include <Guid/SmBios.h>
 #include <Guid/MemoryAttributesTable.h>
 #include <Guid/RtPropertiesTable.h>
@@ -113,7 +112,6 @@ ShellCommandRunDmem (
   UINT64        Acpi20TableAddress;
   UINT64        SalTableAddress;
   UINT64        SmbiosTableAddress;
-  UINT64        MpsTableAddress;
   UINT64        DtbTableAddress;
   UINT64        MemoryAttributesTableAddress;
   UINT64        RtPropertiesTableAddress;
@@ -190,7 +188,6 @@ ShellCommandRunDmem (
           AcpiTableAddress               = 0;
           SalTableAddress                = 0;
           SmbiosTableAddress             = 0;
-          MpsTableAddress                = 0;
           DtbTableAddress                = 0;
           MemoryAttributesTableAddress   = 0;
           RtPropertiesTableAddress       = 0;
@@ -224,11 +221,6 @@ ShellCommandRunDmem (
               continue;
             }
 
-            if (CompareGuid (&gST->ConfigurationTable[TableWalker].VendorGuid, &gEfiMpsTableGuid)) {
-              MpsTableAddress = (UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
-              continue;
-            }
-
             if (CompareGuid (&gST->ConfigurationTable[TableWalker].VendorGuid, &gEfiMemoryAttributesTableGuid)) {
               MemoryAttributesTableAddress = (UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
               continue;
@@ -292,7 +284,6 @@ ShellCommandRunDmem (
             SalTableAddress,
             AcpiTableAddress,
             Acpi20TableAddress,
-            MpsTableAddress,
             SmbiosTableAddress,
             DtbTableAddress,
             MemoryAttributesTableAddress,



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110974): https://edk2.groups.io/g/devel/message/110974
Mute This Topic: https://groups.io/mt/102483865/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM

[Gao, Zhichao]

I would leave the decision to the right owner of LegacyBiosMpTable.h in MdePkg. Once pass review on MdePkg, I am fine with this patch.

Thanks,
Zhichao

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Thursday, November 9, 2023 8:06 PM
> To: devel@edk2.groups.io
> Cc: Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove
> gEfiMpsTableGuid ref from DMEM
> 
> We're removing <MdePkg/Include/Guid/Mps.h>. First, remove the
> gEfiMpsTableGuid system config table reference from the UEFI Shell's DMEM
> debug command.
> 
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands
> Lib.uni | 1 -
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands
> Lib.inf | 1 -
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c                         | 9 ----
> -----
>  3 files changed, 11 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.uni
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.uni
> index 4041f0cd483e..155efc1a82f1 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.uni
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> d
> +++ sLib.uni
> @@ -112,7 +112,6 @@
>                                                    "SAL System Table              %016LX\r\n"
>                                                    "ACPI Table                    %016LX\r\n"
>                                                    "ACPI 2.0 Table                %016LX\r\n"
> -                                                  "MPS Table                     %016LX\r\n"
>                                                    "SMBIOS Table                  %016LX\r\n"
>                                                    "DTB Table                     %016LX\r\n"
>                                                    "Memory Attribute Table        %016LX\r\n"
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.inf
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.inf
> index 3741dac5d94c..2074cb7d96da 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.inf
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> d
> +++ sLib.inf
> @@ -127,7 +127,6 @@ [Guids]
>    gEfiGlobalVariableGuid          ## SOMETIMES_CONSUMES ## GUID
>    gEfiSmbiosTableGuid             ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiSmbios3TableGuid            ## SOMETIMES_CONSUMES ## SystemTable
> -  gEfiMpsTableGuid                ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiAcpi10TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiAcpi20TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
>    gShellDebug1HiiGuid             ## SOMETIMES_CONSUMES ## HII
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> index a609971f345e..39a59c195512 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> @@ -12,7 +12,6 @@
>  #include <Protocol/PciRootBridgeIo.h>
>  #include <Protocol/HiiDatabase.h>
>  #include <Guid/Acpi.h>
> -#include <Guid/Mps.h>
>  #include <Guid/SmBios.h>
>  #include <Guid/MemoryAttributesTable.h>  #include
> <Guid/RtPropertiesTable.h> @@ -113,7 +112,6 @@
> ShellCommandRunDmem (
>    UINT64        Acpi20TableAddress;
>    UINT64        SalTableAddress;
>    UINT64        SmbiosTableAddress;
> -  UINT64        MpsTableAddress;
>    UINT64        DtbTableAddress;
>    UINT64        MemoryAttributesTableAddress;
>    UINT64        RtPropertiesTableAddress;
> @@ -190,7 +188,6 @@ ShellCommandRunDmem (
>            AcpiTableAddress               = 0;
>            SalTableAddress                = 0;
>            SmbiosTableAddress             = 0;
> -          MpsTableAddress                = 0;
>            DtbTableAddress                = 0;
>            MemoryAttributesTableAddress   = 0;
>            RtPropertiesTableAddress       = 0;
> @@ -224,11 +221,6 @@ ShellCommandRunDmem (
>                continue;
>              }
> 
> -            if (CompareGuid (&gST-
> >ConfigurationTable[TableWalker].VendorGuid, &gEfiMpsTableGuid)) {
> -              MpsTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
> -              continue;
> -            }
> -
>              if (CompareGuid (&gST-
> >ConfigurationTable[TableWalker].VendorGuid,
> &gEfiMemoryAttributesTableGuid)) {
>                MemoryAttributesTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
>                continue;
> @@ -292,7 +284,6 @@ ShellCommandRunDmem (
>              SalTableAddress,
>              AcpiTableAddress,
>              Acpi20TableAddress,
> -            MpsTableAddress,
>              SmbiosTableAddress,
>              DtbTableAddress,
>              MemoryAttributesTableAddress,



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111541): https://edk2.groups.io/g/devel/message/111541
Mute This Topic: https://groups.io/mt/102483865/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 3/3] MdePkg: remove <Mps.h>

[Laszlo Ersek]

The MPS table is legacy from the traditional BIOS era. According to the
file-top comment in the header, it was only included in UEFI (and so in
edk2) for Itanium's sake (and Itanium is also gone from edk2).

Remove the header, and the MPS table GUID definition. There are no
references left in edk2 or edk2-platforms.

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 MdePkg/MdePkg.dec         |  3 --
 MdePkg/Include/Guid/Mps.h | 29 --------------------
 2 files changed, 32 deletions(-)

diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index ac54338089e8..bac96ffd9896 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -388,9 +388,6 @@ [Guids]
   ## Include/Guid/SmBios.h
   gEfiSmbiosTableGuid            = { 0xEB9D2D31, 0x2D88, 0x11D3, { 0x9A, 0x16, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
 
-  ## Include/Guid/Mps.h
-  gEfiMpsTableGuid               = { 0xEB9D2D2F, 0x2D88, 0x11D3, { 0x9A, 0x16, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }}
-
   ## Include/Protocol/AuthenticationInfo.h
   gEfiAuthenticationChapLocalGuid = { 0xC280C73E, 0x15CA, 0x11DA, { 0xB0, 0xCA, 0x00, 0x10, 0x83, 0xFF, 0xCA, 0x4D }}
 
diff --git a/MdePkg/Include/Guid/Mps.h b/MdePkg/Include/Guid/Mps.h
deleted file mode 100644
index 0edcdbf2b9e8..000000000000
--- a/MdePkg/Include/Guid/Mps.h
+++ /dev/null
@@ -1,29 +0,0 @@
-/** @file
-  GUIDs used for MPS entries in the UEFI 2.0 system table
-  ACPI is the primary means of exporting MPS information to the OS. MPS only was
-  included to support Itanium-based platform power on. So don't use it if you don't have too.
-
-  Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
-  SPDX-License-Identifier: BSD-2-Clause-Patent
-
-  @par Revision Reference:
-  GUIDs defined in UEFI 2.0 spec.
-
-**/
-
-#ifndef __MPS_GUID_H__
-#define __MPS_GUID_H__
-
-#define EFI_MPS_TABLE_GUID \
-  { \
-    0xeb9d2d2f, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d } \
-  }
-
-//
-// GUID name defined in spec.
-//
-#define MPS_TABLE_GUID  EFI_MPS_TABLE_GUID
-
-extern EFI_GUID  gEfiMpsTableGuid;
-
-#endif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110976): https://edk2.groups.io/g/devel/message/110976
Mute This Topic: https://groups.io/mt/102483867/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-