[Patch V2 0/2] Modify defination for MpWakeupStructure

[Patch V2 0/2] Modify defination for MpWakeupStructure

[duntan]

In the V2 patch set:
Change macro name for mailbox version to EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_MAILBOX_STRUCTURE_VERSION

Dun Tan (2):
  MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure
  MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

 MdePkg/Include/IndustryStandard/Acpi64.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
2.31.1.windows.1

[Patch V2 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure

[duntan]

modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination
in Acpi64.h.

Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
 MdePkg/Include/IndustryStandard/Acpi64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
index fe5ebfac2b..bfd022b6b6 100644
--- a/MdePkg/Include/IndustryStandard/Acpi64.h
+++ b/MdePkg/Include/IndustryStandard/Acpi64.h
@@ -607,7 +607,7 @@ typedef struct {
 typedef struct {
   UINT16    Command;
   UINT16    Reserved;
-  UINT32    AcpiId;
+  UINT32    ApicId;
   UINT64    WakeupVector;
   UINT8     ReservedForOs[2032];
   UINT8     ReservedForFirmware[2048];
-- 
2.31.1.windows.1

[Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

[duntan]

Add define for MMultiprocessorWakeupMailboxStructure Version. The
version for Mailbox Structure in Spec6.4 is 0.

Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
index bfd022b6b6..379ab02a72 100644
--- a/MdePkg/Include/IndustryStandard/Acpi64.h
+++ b/MdePkg/Include/IndustryStandard/Acpi64.h
@@ -601,6 +601,11 @@ typedef struct {
   UINT64    MailBoxAddress;
 } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE;
 
+///
+/// Multiprocessor Wakeup Mailbox Structure Version (as defined in ACPI 6.4 spec.)
+///
+#define EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_MAILBOX_STRUCTURE_VERSION  0x0
+
 ///
 /// Multiprocessor Wakeup Mailbox Structure
 ///
-- 
2.31.1.windows.1

Re: [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

[Zhiguang Liu]

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Thursday, March 9, 2023 11:12 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: [Patch V2 2/2] MdePkg: Add define for
> MultiprocessorWakeupMailboxStructure Version
> 
> Add define for MMultiprocessorWakeupMailboxStructure Version. The
> version for Mailbox Structure in Spec6.4 is 0.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index bfd022b6b6..379ab02a72 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -601,6 +601,11 @@ typedef struct {
>    UINT64    MailBoxAddress;
>  } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE;
> 
> +///
> +/// Multiprocessor Wakeup Mailbox Structure Version (as defined in ACPI
> +6.4 spec.) /// #define
> +EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_MAILBOX_STRUCTURE_VERSI
> ON  0x0
> +
>  ///
>  /// Multiprocessor Wakeup Mailbox Structure  ///
> --
> 2.31.1.windows.1

Re: [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

[Ni, Ray]

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Thursday, March 9, 2023 11:12 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: [Patch V2 2/2] MdePkg: Add define for
> MultiprocessorWakeupMailboxStructure Version
> 
> Add define for MMultiprocessorWakeupMailboxStructure Version. The

Double "M".

Re: [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

[duntan]

Thanks Ray. Updated in V3 patch set.

Thanks,
Dun

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Thursday, March 9, 2023 11:19 AM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
Subject: RE: [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version


> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Thursday, March 9, 2023 11:12 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming 
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; 
> Ni, Ray <ray.ni@intel.com>
> Subject: [Patch V2 2/2] MdePkg: Add define for 
> MultiprocessorWakeupMailboxStructure Version
> 
> Add define for MMultiprocessorWakeupMailboxStructure Version. The

Double "M".