From: "duntan" <dun.tan@intel.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>,
'Bret Barkelew' <Bret.Barkelew@microsoft.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Date: Thu, 2 Sep 2021 02:24:21 +0000 [thread overview]
Message-ID: <BN9PR11MB548363590F1F596D8D81A8EAE5CE9@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <00b701d79f9f$972611f0$c57235d0$@byosoft.com.cn>
Thanks a lot!
Thanks,
Dun
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Thursday, September 2, 2021 10:10 AM
To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
I upload it again. Now, it has been merged.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> 发送时间: 2021年9月2日 9:24
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> in gate-build-job.yml and CISetting.py
>
> Hi Liming,
>
> I have seen the link to push my commits to master of edk2. The result
> shows that the Ci test failed in ArmPlatformPkg. But I think my
> commits will not affect the ArmPlatformPkg. Here is the link.
> https://github.com/tianocore/edk2/pull/1940the
> So is there anything I need to do?
>
> Thanks,
> Dun
> -----Original Message-----
> From: Tan, Dun
> Sent: Wednesday, September 1, 2021 11:32 AM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add
> UefiPayloadPkg in gate-build-job.yml and CISetting.py
>
> Hi Liming,
>
> The patch to fix the build issue has been merged this morning.
> Would you please help to merge the two patches to enable core CI for
> UefiPayloadPkg?
>
> Thanks,
> Dun
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, August 31, 2021 9:05 AM
> To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add
> UefiPayloadPkg in gate-build-job.yml and CISetting.py
>
> Dun:
> This PR also includes one additional commit to fix the build issue.
> Have you send the patch for it?
>
> For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>.
> It will be merged after the build issue has been fixed.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Tan, Dun <dun.tan@intel.com>
> > 发送时间: 2021年8月30日 16:31
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> > in gate-build-job.yml and CISetting.py
> >
> > Hi Liming,
> >
> > Here is the link of the PR to verify the change in Tiano EDKII. It
> > passed the CI by GCC and VS both.
> > https://github.com/tianocore/edk2/pull/1931
> >
> > Thanks,
> > Dun
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Monday, August 30, 2021 11:26 AM
> > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
> > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add
> > UefiPayloadPkg in gate-build-job.yml and CISetting.py
> >
> > Dun:
> > I don't see the issues to enable UefiPayloadPkg in CI. Have you
> > created the private PR to verify this change?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> > > 发送时间: 2021年8月24日 17:24
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>
> > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add
> > > UefiPayloadPkg in gate-build-job.yml and CISetting.py
> > >
> > > Hi all,
> > > Since the CI for UefiPayloadPkg is important to our develop
> > > progress, would you please speed up the review process? Thanks a lot!
> > >
> > > Thanks,
> > > Dun Tan
> > > -----Original Message-----
> > > From: Tan, Dun <dun.tan@intel.com>
> > > Sent: Friday, August 20, 2021 2:44 PM
> > > To: devel@edk2.groups.io
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>; Tan, Dun <dun.tan@intel.com>
> > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> > > gate-build-job.yml and CISetting.py
> > >
> > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for
> > > UefiPayloadPkg.
> > > Add UefiPayloadPkg to supported Packages in CISettings.
> > >
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Signed-off-by: DunTan <dun.tan@intel.com>
> > > ---
> > > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> > > .pytool/CISettings.py | 3 ++-
> > > 2 files changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > > b/.azurepipelines/templates/pr-gate-build-job.yml
> > > index 207acc7631..d5b16c127f 100644
> > > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > > @@ -48,6 +48,9 @@ jobs:
> > > TARGET_SECURITY:
> > > Build.Pkgs: 'SecurityPkg'
> > > Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > + TARGET_UEFIPAYLOAD:
> > > + Build.Pkgs: 'UefiPayloadPkg'
> > > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > TARGET_PLATFORMS:
> > > # For Platforms only check code. Leave it to Platform CI
> > > # to build them.
> > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> > > 96e6baa519..ce330e2c73 100644
> > > --- a/.pytool/CISettings.py
> > > +++ b/.pytool/CISettings.py
> > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager,
> > > UpdateSettingsManager, SetupSettingsManag
> > > "CryptoPkg",
> > > "UnitTestFrameworkPkg",
> > > "OvmfPkg",
> > > - "RedfishPkg"
> > > + "RedfishPkg",
> > > + "UefiPayloadPkg"
> > > )
> > >
> > > def GetArchitecturesSupported(self):
> > > --
> > > 2.31.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
>
>
>
>
>
>
>
prev parent reply other threads:[~2021-09-02 2:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 6:43 [PATCH 0/2] Enable Core ci for UefiPayloadPkg duntan
2021-08-20 6:43 ` [PATCH 1/2] UefiPayloadPkg: Create .yaml file in UefiPayloadPkg duntan
2021-08-20 8:12 ` Ni, Ray
2021-08-20 6:43 ` [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py duntan
2021-08-24 9:23 ` duntan
2021-08-30 3:26 ` 回复: [edk2-devel] " gaoliming
2021-08-30 8:31 ` duntan
2021-08-31 1:04 ` 回复: " gaoliming
2021-09-01 3:32 ` duntan
2021-09-01 6:05 ` 回复: " gaoliming
2021-09-02 1:24 ` duntan
2021-09-02 2:09 ` 回复: " gaoliming
2021-09-02 2:24 ` duntan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB548363590F1F596D8D81A8EAE5CE9@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox