public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "duntan" <dun.tan@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev
Date: Fri, 27 Oct 2023 06:31:49 +0000	[thread overview]
Message-ID: <BN9PR11MB54836C669778D339742A9C07E5DCA@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW4PR11MB5872FCE791B34A84D54740A58CDCA@MW4PR11MB5872.namprd11.prod.outlook.com>

Hi Jiewen,

Currently I'm working on the Tdx test. Since the patch set doesn't change the code logic when Tdx or SEV is enabled, so I want to send out the patch as soon as possible to see if there is any comments from community. 

I will include AMD SEV reviewer in this patch series. Thanks for reminding.

Thanks,
Dun

-----Original Message-----
From: Yao, Jiewen <jiewen.yao@intel.com> 
Sent: Friday, October 27, 2023 1:49 PM
To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

HI
Since this impact TDX and SEV, would you please let me know what kind of test you have done?
Have you validated TDX and SEV before you submit the patch? Please describe that clearly in your patch description.

Also please include AMD SEV reviewer in this patch series.

Thank you
Yao, Jiewen

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of duntan
> Sent: Friday, October 27, 2023 1:43 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 0/7] Support Tdx and sev in 
> BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev
> 
> The goal is to have single BaseIoLibIntrinsic instance that can also 
> used for sev and Tdx.
> In this patch set, string I/O instructions are deleted in IoRead/WriteFifo API.
> Then change the source file of BaseIoLibIntrinsic to also support Tdx 
> and sev feature. So BaseIoLibIntrinsicSev and related assembly code can be removed.
> 
> Dun Tan (7):
>   MdePkg: Create TdxLibNull.inf instance
>   MdePkg: Add CcProbeLibNull and TdxLibNull implement
>   MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c
>   MdePkg:support Tdx and sev in BaseIoLibIntrinsic
>   OvmfPkg: Add CcProbeLib in PlatformInitLib.inf
>   OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files
>   MdePkg:remove BaseIoLibIntrinsicSev related code
> 
>  MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf    |  14 ++++++++++----
>  MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf |  61 
> ------------------
> -------------------------------------------
>  MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm          | 131 --------------------
> ----------------------------------------------------------------------
> ----------------------------
> -------------
>  MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm       | 293 ------------------
> ----------------------------------------------------------------------
> ----------------------------
> ----------------------------------------------------------------------
> ----------------------------
> -------------------------------------------------------------------------------
>  MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c               |  45
> +++++++++++++++++++++++++++++++++++++--------
>  MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h                | 166 ------------------------
> ----------------------------------------------------------------------
> ----------------------------
> --------------------------------------------
>  MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm           | 120 --------------------
> ----------------------------------------------------------------------
> ----------------------------
> --
>  MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm        | 282 ------------------
> ----------------------------------------------------------------------
> ----------------------------
> ----------------------------------------------------------------------
> ----------------------------
> --------------------------------------------------------------------
>  MdePkg/Library/TdxLib/TdxLibNull.inf                        |  21
> +++++++++++++++++++++
>  MdePkg/MdeLibs.dsc.inc                                      |   4 +++-
>  MdePkg/MdePkg.dsc                                           |   2 +-
>  OvmfPkg/AmdSev/AmdSevX64.dsc                                |   2 +-
>  OvmfPkg/Bhyve/BhyveX64.dsc                                  |   2 +-
>  OvmfPkg/CloudHv/CloudHvX64.dsc                              |   2 +-
>  OvmfPkg/IntelTdx/IntelTdxX64.dsc                            |   2 +-
>  OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf         |   3 ++-
>  OvmfPkg/Microvm/MicrovmX64.dsc                              |   2 +-
>  OvmfPkg/OvmfPkgIa32.dsc                                     |   2 +-
>  OvmfPkg/OvmfPkgIa32X64.dsc                                  |   2 +-
>  OvmfPkg/OvmfPkgX64.dsc                                      |   2 +-
>  OvmfPkg/OvmfXen.dsc                                         |   2 +-
>  21 files changed, 83 insertions(+), 1077 deletions(-)  delete mode 
> 100644 MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf
>  delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm
>  delete mode 100644 
> MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm
>  delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h
>  delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm
>  delete mode 100644 
> MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm
>  create mode 100644 MdePkg/Library/TdxLib/TdxLibNull.inf
> 
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110194): https://edk2.groups.io/g/devel/message/110194
Mute This Topic: https://groups.io/mt/102215661/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-10-27  6:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27  5:42 [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev duntan
2023-10-27  5:42 ` [edk2-devel] [PATCH 1/7] MdePkg: Create TdxLibNull.inf instance duntan
2023-10-27  5:54   ` Ni, Ray
2023-10-27  5:56     ` Ni, Ray
2023-10-27  6:32       ` duntan
2023-10-27  5:42 ` [edk2-devel] [PATCH 2/7] MdePkg: Add CcProbeLibNull and TdxLibNull implement duntan
2023-10-27  5:42 ` [edk2-devel] [PATCH 3/7] MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c duntan
2023-10-27  5:42 ` [edk2-devel] [PATCH 4/7] MdePkg:support Tdx and sev in BaseIoLibIntrinsic duntan
2023-10-27  5:42 ` [edk2-devel] [PATCH 5/7] OvmfPkg: Add CcProbeLib in PlatformInitLib.inf duntan
2023-10-30 14:37   ` Ard Biesheuvel
2023-10-27  5:42 ` [edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files duntan
2023-10-30 14:36   ` Ard Biesheuvel
2023-10-31 12:30     ` Laszlo Ersek
2023-10-31 13:19       ` Ard Biesheuvel
2023-10-27  5:43 ` [edk2-devel] [PATCH 7/7] MdePkg:remove BaseIoLibIntrinsicSev related code duntan
2023-10-27  5:49 ` [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Yao, Jiewen
2023-10-27  6:31   ` duntan [this message]
2023-10-27  7:06     ` Yao, Jiewen
2023-10-27  7:34       ` duntan
2023-10-27  8:05         ` duntan
2023-10-27 21:31           ` Lendacky, Thomas via groups.io
2023-10-28 11:40             ` Laszlo Ersek
2023-10-31  9:56               ` duntan
2023-10-31 17:06                 ` Laszlo Ersek
2023-10-31 22:36                   ` Laszlo Ersek
2023-11-02  8:49                     ` duntan
2023-11-02 10:42                       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB54836C669778D339742A9C07E5DCA@BN9PR11MB5483.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox