From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5E6627803EA for ; Fri, 27 Oct 2023 06:32:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lJQirFr5xDZNo5KPziUg/ec8GtY713LFd2aabVoNOkA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698388320; v=1; b=c+DFGE2iUV60191ihr+vjOcXEQ0UFm3mgO4Cv4feuw27FxUxw2CKMJwMcoJeftjgGvaTB+FK k0IQwKeL2uYjZVyZo22nTWLmSUBOlYSN8tuediPThCgsDBcIm7cywPjKFdPzDDvJ8Tip7tTRlHN mZo79LDNHZQP5ztoW/pXd2wE= X-Received: by 127.0.0.2 with SMTP id 2dhqYY7687511xbTomBm08PU; Thu, 26 Oct 2023 23:32:00 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.1297.1698388319065798745 for ; Thu, 26 Oct 2023 23:32:00 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="384925150" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="384925150" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 23:31:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="763101365" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="763101365" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Oct 2023 23:31:58 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 26 Oct 2023 23:31:58 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 26 Oct 2023 23:31:58 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 26 Oct 2023 23:31:58 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 26 Oct 2023 23:31:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cmMK1TBszxwmfT1rj0qdMo8x3IctrsmLDBRN6D9h6ZrtSiDQfvezADHDQD+P/rJt1VyiPizp/lLIijwG3fw/DYEszPMgA7QVJ51T3WoIb7dL8PJRkfjrO/vEB2R6WKh8PudVkw1Xh+al0N6NW9+1MUYjlP6EXjX9mRmL5UxZNCLSNrn5ezzK0YiKa5UkUvKZV3GY8QR4HiU+HRFHBD5UwlnWWi7hYeCKMC5X1OEsZIb5Yc6tnCH/ZKaZJqT2EbsQZB3/u3hkaKjLJrSkY8POLb6KIOj4AXq3LUq+NIvtx3V/SZ8uFOChjGbbtWcq4ATA1baQC/kXP7y0AlYveaEJwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HLLnptipcZDcRQp7Mgvzcn+GYfvUkZEWv6IZYB78vwk=; b=LWs6joqFGfZ5A0rl0wBA3eATO7b9DSTYwOPXZrSY0QbS8ZVMIvlv32XrktWifGwq+E9CWW6cY/XFiG/mQnfSmeWnO6wZ/42lI+PgW6UX10EvcDYsard/KN1gjkAO6sOULDnZx98NQ0pxzee0Wj++RusyGxO4rZ713uyO92kqwc0U8aUlDe9k1H6vcPJNwiz4sQ9LTIbWzHWgm7f5aEGwNF37o3xOKBQIGFnvnhRJJiFGrLay1/5dVm40n7qOrM800dviCtvy1ymVRrSfTJZuZUUBCgkQfWiE5/X+G3sfOkockoWh8pGt0GLY+f4gVtxVz1YUmJ98itObKQloCunHwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM8PR11MB5639.namprd11.prod.outlook.com (2603:10b6:8:24::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.21; Fri, 27 Oct 2023 06:31:50 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::83d:af7b:9ba0:64d2]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::83d:af7b:9ba0:64d2%4]) with mapi id 15.20.6933.024; Fri, 27 Oct 2023 06:31:50 +0000 From: "duntan" To: "Yao, Jiewen" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Thread-Topic: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Thread-Index: AQHaCJiEbq0hqvyGs0+1Tmniw3oYDbBdIKuggAADw7A= Date: Fri, 27 Oct 2023 06:31:49 +0000 Message-ID: References: <20231027054300.1382-1-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DM8PR11MB5639:EE_ x-ms-office365-filtering-correlation-id: e9d9debb-269d-455e-8ecf-08dbd6b666a0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: KgzHuj20LZpwIH3m10cjLcxvBEuF+bjNsSz/u/yoJtqdRM8ylf9UzvGKeUpps6uTf/q7Wci9dGpy9LRCjWJJQtSapfPB00Xa2bIj4ookJbTSzDMRWaTHHFnArZhnJZD/Fh03XaiyXdXohroJUZ+A7TmkxaYsIR3XicjHDf5NqY2+kn3J3C8R4po2g7sPqXY9IO6zmpcdp1Skn4qxqieb2CeNAYCp38xmJpwNP3MLDNKTVzz6fbkzJrI+G/Ky+unaz/sc10TtKMcCqBM7ObNpQNFqnvuZgojibQqpapMPz7xbtNy04tEMdmC0A9SRg2QKAcoTI3D9ua96JWjeO11w/sTzj6nr6r4MPrbDfn8UO1qEV4qB0ioOSYHhp2froaYixJ0vRcx0QLQsA4dyRUPktiHv7m8idsAYyyQzuNX6DAAdm4e1t1rieFFuKBB4ql6NjxIJdSawmf0mtwd7Q2D025agBIF4b15p/FmhifXp57rgG61r/lD5pP2zc2zoUxz0H7Cz2zcglEviocHWBeA6XuiWD3zl7r0Y5RdmuK6PLSB77gfQTEYgVb/gv6yFt3wmwCjoey5MWWVhMR2PsqOv/X9ZbrOIkbx0pvli75T4rmvSzSZSDSsr5OgCo91lIJ8QIdrxGo6xP9ZJY13mn0APSg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mxvmrr2tSujojpeNGcUNV+vbSu05um0uUSzAZumEGoBuGU+lSZcDJaGviA9U?= =?us-ascii?Q?QFjqeE57+bf7sgI5gbReZaVoMqVGy30+XRUxfIqgLnrv2K01DNOFLfi9M89T?= =?us-ascii?Q?Tm+hDJjB70d7Segz9+hanjVXOjCjKFqUd+EmXBlKWJAOHgdSyJAWwFvu2pom?= =?us-ascii?Q?BIhNZC8fD0LW39nGkit7zQevFeOJB09Y7vyWPZ+GgftAGQPPBGSXWjTMSFTb?= =?us-ascii?Q?uTXUj3AjGOqK+KixgrvOGFpj7vKcUR0sqKqjy1xrLHSmVWBFPtYcDPeBfBcb?= =?us-ascii?Q?okHaFmLdB/w7POUYvbf4LIpW9uVv+tqfNXGJMkNQXQ1N6JA97J/7GupzHct+?= =?us-ascii?Q?Kyj3X2+Q6QJ16TS3poEHMi3/fu4gKONLi0MuiGCoGmI5nSpGS9fcaCFKG3pl?= =?us-ascii?Q?RmB1/o20V3k8kfwcU1Tmf2FdgzJQ4CVDQi2TYJOFeCiTllr6zxIACQDs32DL?= =?us-ascii?Q?wwjZPEiPiBNvn/LqNzL9i9M8hpIi2LTIuwe3NDVW0jBylglgNYzF3UGYoC6F?= =?us-ascii?Q?wK3MVAo9iPvPaCjfPXBjyTVSdlR80dYd7mogsubAieSsfkkcsMdhm8pqutKf?= =?us-ascii?Q?huF8eaoNBaRWrINYcU4EDxrLZZqv+Qz9DLcpl+cDdldFqZNuP0t7GyVok01/?= =?us-ascii?Q?2IfB4+M1UcnxWoDVcbwEYKDFwi2ytp+JHEi3vcsh5T61pkJyJg3PKKd3brUi?= =?us-ascii?Q?Oz/5W+M6iZPgJhIZ5pBiXNFkFyHbYX1zJ0DGWbybQtMVIddEhRQQ1jkgYLfr?= =?us-ascii?Q?t40a26sDpsDGdGZqWAA8QYm9F/0B0SEXNbBaaQImANVTp2YbMbHvsudoIq95?= =?us-ascii?Q?QVXZNjVY8pdcSu/ljpla0fPtvl+bItJxDs1+e2Dpho8BpYiwbTGHLIBh+HYS?= =?us-ascii?Q?CgL2cjm+wUWGceu7kGskAnEZtrqnRNiNYa7Gku37gE+QsH3SKI2C4E4J1cgC?= =?us-ascii?Q?fA31JCi5863r16OOwfo4sWXDo5xZVqfxBr9heu4LRYOI2Pa7Y37YalKbFMPI?= =?us-ascii?Q?IhcNzKJIE/lI9QE7SKBmUfztH+54XEuAoSp/sF2jMK5p4BSJvFnGsfvvynCJ?= =?us-ascii?Q?fSdh0D9nyHoCQcRmq4PapppJmbG19Jt2XhIePnWk6b4EmbMhcniNLQKJF4gr?= =?us-ascii?Q?IbPSJa3x5cBlWN/F+snZPY8VDT8XtzWjHcOJKHlKcletsKjDYBnUh26hwts5?= =?us-ascii?Q?4M+tmi7dgADxLVzYaea/0yNZlDovLD56NFJE3G3F7h9aYMzTGo8y8OzYKXVP?= =?us-ascii?Q?jl/FlfF6soaxyNisz8wIxmj84kXd2ds6gEA2qUM/lMPbMfUiyfQVldSAybyX?= =?us-ascii?Q?8mexUVvcBHWjcAOCoapL3jq+Yh1xn3Pqwaj7na0ez0fFJ4p/ASwQ4T6xlOtQ?= =?us-ascii?Q?/OyVUMvfa3Xkx2OWvXfX4coiFfL+qCqYARwCYQorN2sA2quSeIyACjgQzkjy?= =?us-ascii?Q?0K9oCd4eB4PfUx4LcvRnRG0F9DkB/Z5fT1ZOiA0yiE+mJ1d7nlwwfJkqaFoX?= =?us-ascii?Q?KtEUS3fq4sj833lQIXzKI72JR0W5vMNdzXg2SiK6h7RRH4nubhX2KkQSA0N8?= =?us-ascii?Q?R69oHN13V9SUlT/AtrE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9d9debb-269d-455e-8ecf-08dbd6b666a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2023 06:31:49.7160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rwXSTi2pf3FdDxIW9biAHscwiV7UYWSlshTPNdM7HEKveoE4RawWfy5mnL4/TwK3KGdTkLmPqKm6tLORUo0CSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5639 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RLae6Z5rRiJFk4Qqo01dRUDgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=c+DFGE2i; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Jiewen, Currently I'm working on the Tdx test. Since the patch set doesn't change t= he code logic when Tdx or SEV is enabled, so I want to send out the patch a= s soon as possible to see if there is any comments from community.=20 I will include AMD SEV reviewer in this patch series. Thanks for reminding. Thanks, Dun -----Original Message----- From: Yao, Jiewen =20 Sent: Friday, October 27, 2023 1:49 PM To: devel@edk2.groups.io; Tan, Dun Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntri= nsic and remove BaseIoLibIntrinsicSev HI Since this impact TDX and SEV, would you please let me know what kind of te= st you have done? Have you validated TDX and SEV before you submit the patch? Please describe= that clearly in your patch description. Also please include AMD SEV reviewer in this patch series. Thank you Yao, Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Friday, October 27, 2023 1:43 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/7] Support Tdx and sev in=20 > BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev >=20 > The goal is to have single BaseIoLibIntrinsic instance that can also=20 > used for sev and Tdx. > In this patch set, string I/O instructions are deleted in IoRead/WriteFif= o API. > Then change the source file of BaseIoLibIntrinsic to also support Tdx=20 > and sev feature. So BaseIoLibIntrinsicSev and related assembly code can b= e removed. >=20 > Dun Tan (7): > MdePkg: Create TdxLibNull.inf instance > MdePkg: Add CcProbeLibNull and TdxLibNull implement > MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c > MdePkg:support Tdx and sev in BaseIoLibIntrinsic > OvmfPkg: Add CcProbeLib in PlatformInitLib.inf > OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files > MdePkg:remove BaseIoLibIntrinsicSev related code >=20 > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 14 ++++++= ++++---- > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf | 61=20 > ------------------ > ------------------------------------------- > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm | 131 ------= -------------- > ---------------------------------------------------------------------- > ---------------------------- > ------------- > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm | 293 ------= ------------ > ---------------------------------------------------------------------- > ---------------------------- > ---------------------------------------------------------------------- > ---------------------------- > -------------------------------------------------------------------------= ------ > MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c | 45 > +++++++++++++++++++++++++++++++++++++-------- > MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h | 166 ------= ------------------ > ---------------------------------------------------------------------- > ---------------------------- > -------------------------------------------- > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm | 120 ------= -------------- > ---------------------------------------------------------------------- > ---------------------------- > -- > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm | 282 ------= ------------ > ---------------------------------------------------------------------- > ---------------------------- > ---------------------------------------------------------------------- > ---------------------------- > -------------------------------------------------------------------- > MdePkg/Library/TdxLib/TdxLibNull.inf | 21 > +++++++++++++++++++++ > MdePkg/MdeLibs.dsc.inc | 4 +++- > MdePkg/MdePkg.dsc | 2 +- > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 3 ++- > OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > OvmfPkg/OvmfXen.dsc | 2 +- > 21 files changed, 83 insertions(+), 1077 deletions(-) delete mode=20 > 100644 MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm > delete mode 100644=20 > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm > delete mode 100644=20 > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm > create mode 100644 MdePkg/Library/TdxLib/TdxLibNull.inf >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110194): https://edk2.groups.io/g/devel/message/110194 Mute This Topic: https://groups.io/mt/102215661/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-