From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.1299.1676052662648784794 for ; Fri, 10 Feb 2023 10:11:02 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=I2e+bgEI; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676052662; x=1707588662; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FzHX7oslExr0kiFtrgxn9BjQrIaeVXOzqy+S5HnFodA=; b=I2e+bgEIN1WcrCSqrPVpdtZXaZyM1Byf/jp2GkyDYvRSY8SIhCrxwhHP VaWz1XN2hkjx3mIWECx2uyc/pZY9YyMoPOYyn5TF/zjEL+Y5M3qKiv+wM 6XePG5XoOZzsPk6EnsISHG9iJsMXylMnOV+++5b7++VQKQRmAc59vvCFS xntxrHXKHy3n/OxSkChrhJADQfrN+niV9ZCglYbSbsRzJ9pgZrp96R2Ji +eQi/Qb7l+Q5fzmsTSgCEBU68Wx+ujxWqMVTJxvjzucEGagYNVclOO6Ak q5dRK5KpW1EbseTUZLPWPYVW8cPVo/ZeySJeFrdvZPsGzMXIAN9j0+4WM w==; X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="310849743" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="310849743" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 10:11:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="792068154" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="792068154" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 10 Feb 2023 10:10:57 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 10 Feb 2023 10:10:57 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 10 Feb 2023 10:10:56 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 10 Feb 2023 10:10:56 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 10 Feb 2023 10:10:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O0hOQvZedfb+9YkIe7wCbCaVNgxSDNo+v+X/DESbOaKHGbwyJLb/rUhMh4nqeEZu6+r5AL6mZhQ2tSd1m2Q4n0/N/zi9wSdVY/CHnXQuDmxKSbueCzN8A5qGSBux+ypaoON2LxwsAEDh7DTddsUQZOpE+GsZljfQJoAnqgEuRCHqw7/QlbZu6Ugv6QjTUgPF9aJ4j3cZZmqRsHrQKiaZzceD5xeh6CmvYY/79NM1g9PMnS1U3tOWaJP8vtp+MekCBxpfi14KrpQAwrpz7YXtFQV+2moUTD2sDr1CGHIMmdDL0/O0GHVz+CpGWZuI55e9dNLmPEarj7zkEAnKFuhZHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x1Sg0Xstt/DVjaIR9uOVFK6yZONyUvUOBIOWXtsbtiw=; b=TALUhY7yxdLhJ2nZ9UK9SVLOHMdwW1NM2/JheAeMyb9udvv0HL4l/wNDz2H/OUAF83JPN9Lt4n4F+AsH6bdlThU8osmEXsBrpddK6pKP+s47kZITVWBupapc9LyiGLsluS2xFqhltQOuygydaIJbDycSJmyDyKiPNwsGPRfDGKggKArXoztlNK/6pPSRq6pBFBqQDaymckhLYq7cb0kQB68juU2NlBqmc36FXkPq0VFj6YElaVRcS9lQFmXDiWbJsOwJR6bEsEdVw4kGbHtG64EmUFX+n95TcGnQmDe8CK3vkrKv3Pxbn1/WCNyxpdzMOLmI7i8vgs3qny/aVT4pPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DS0PR11MB7530.namprd11.prod.outlook.com (2603:10b6:8:146::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Fri, 10 Feb 2023 18:10:54 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::ee18:f0d6:8983:5a24]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::ee18:f0d6:8983:5a24%3]) with mapi id 15.20.6086.021; Fri, 10 Feb 2023 18:10:54 +0000 From: "Chiu, Chasel" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "S, Ashraf Ali" , "Oram, Isaac W" , "Chaganty, Rangasai V" , "Ni, Ray" Subject: Re: [edk2-platforms][PATCH v1 1/1] SpiFvbServiceStandaloneMm: Add changes for rewrite varstore header Thread-Topic: [edk2-platforms][PATCH v1 1/1] SpiFvbServiceStandaloneMm: Add changes for rewrite varstore header Thread-Index: AQHZPOnlvLnA5x7WPUm83lf1Rp2IUK7IfAmw Date: Fri, 10 Feb 2023 18:10:54 +0000 Message-ID: References: <20230210005130.1021-1-mikuback@linux.microsoft.com> In-Reply-To: <20230210005130.1021-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DS0PR11MB7530:EE_ x-ms-office365-filtering-correlation-id: 4d761283-dcd3-4a16-1b72-08db0b92267a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KwAEkRVSv/2ZNP63C+UMP/BVtTcYEoBlOcbq1yxnYrsvwsTqykqh+db+G+dL+ZOxNEvU0Sejt1CXUIEZOVxcFSMeEDS3gvHTC/StYpiHgGDGWr4EvfyPEzIDGKRyG527qnAL1rvVg61j0zMH23W3bioZvts5AceyCnTy34S+zP7wS5i2+VMwG3lC8uLFtMAawmapfg+IbosIvuT8Oc5+eI3lfQnMNF+cEA2l1K65ok5rmyMaAPQZgsGN/HW30onb/T1yn8tp02KDvN02m/fejgwBCTAo2yrecKdw17z3rh4Z0mKq+f2MtG8J3Vxpxh50igaM/Wv/4Ln/wkZsuczS+nnRXT+aGFUfDJrYIyxuFhRXtwnsBpyahgNmT2p9zvacd5B/3zvx0M0X9oy8jpZoXnYK4nU3MvP/NQTPF6XpI0FDCCYO8jVZ/hYpHBDK8spln8IZcT6/2ZWfTfB9gwQpR/iDiRbef7tySA4itClBT4Ut4ZkWRMkKTuyfzeRa6UpBQWWV9TYUTH0rHxLtgPMVaSPkWB+nnF09B7UUvnGFqLbco+O0XF6p8NrdHF1f94cv0KoLLkZbp0R2L9/0zWlW4LUF+fKSx2zcaZggcjN27pLokJQB/Ny1k41EGlN1HYmuIMQe8+MDLrhP8EfD4BFv8Ucn7uRITBwtUpWYKAB4c5nP6M+fRJcTanw+zSxrn/lpVJ3MI9D4QZKe+/5CWgrX7kjeSf5k0jY7anrm3Y+63x8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(376002)(136003)(396003)(39860400002)(451199018)(2906002)(4326008)(8936002)(52536014)(55016003)(71200400001)(66476007)(5660300002)(66446008)(86362001)(66556008)(76116006)(64756008)(8676002)(66946007)(54906003)(41300700001)(33656002)(83380400001)(110136005)(316002)(19627235002)(478600001)(38070700005)(7696005)(122000001)(26005)(82960400001)(186003)(53546011)(6506007)(38100700002)(9686003)(107886003)(14943795004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?toIfDB/Wu6OVrEz8U3TZBUfL4LnIpeYDGak0K6I3QeyQzbgDrR/+DPRlVSUx?= =?us-ascii?Q?nBOjr5JrxK22F3AUmSfUeEB/zudWU/O6I0lAjMQpYedH5YZpsbJWwx4BKjf4?= =?us-ascii?Q?mEqd2MIR4lbuVcrHrb3nvTiXYNUmcpy95e6ZJp4ZlZmhY6AN7J5unCPjC7OA?= =?us-ascii?Q?El1Ucxb+/M/4m7aeSrufJebOwQU/42s6SCYHEcajNrSXm3nzg3r75ufLJOk2?= =?us-ascii?Q?1xytmjhyF3syD8HW+f355wMlQVAvL9iKBIDINP46o+HfsbcNSh9bPCWv6iJi?= =?us-ascii?Q?h66JKtQG4tDRjmEfN+f+Vv+25zdPdXk43gfzrpxt+gpgvZdjZMIoOIIgmtib?= =?us-ascii?Q?JG7ovnWlrPmcCAlKOEdXsEYd5wTwyExVGaaNtz/t0+K2PlqPNBg87tnck3TI?= =?us-ascii?Q?43esCj1JWFkBzvDK55JvSnHsoSo08EeN7FYYx4/AEpQsFfNTu31orqC9pYmd?= =?us-ascii?Q?OxJzcTf8/7CQzIOjIoYjr6xWEIHH0T5tBmqg5f0JJOCfTLuUJLSPuQUHaSLh?= =?us-ascii?Q?EBjHSXKPShG+Mlh4o9x08YrDEdGgKcsXwoECE6YujprNiu20SPytrC2/7Rt6?= =?us-ascii?Q?WB9Ki+Ku8tgNyOIYaewrPLOZHdZPHJRxIa1oGDhpNYDEfF8bE6aBjBP01fsJ?= =?us-ascii?Q?ZMKpj9LKRmi40QoMxWCq8b8edt0rMil2u/zfdlhmM9KY7rgkhuCFoPejO1eh?= =?us-ascii?Q?QIgHUg137Ex7EnDcpJ3laeC3KoCbhX979Sn6o6XXlXQTUJKLO8Itvci3PLm8?= =?us-ascii?Q?4SFa+gc7wgiLCH5dOFloihiaivJiFap1kAJZYMXi5lKeb7POIXarAg+Brwrs?= =?us-ascii?Q?R1zGODZ0GsqXt3AnG1d1flPOXdU9BNAcsK+mrWlm0oCUzr71wl/vW/IjPuV7?= =?us-ascii?Q?DNNOX/FU5AgPb011RdBRTQKDlo1oKnn+0OwH/QAebxNFr6TTFXZgLw62bjO4?= =?us-ascii?Q?F3jK/7GfxL9lts0gPb8D1pTLBSNO3KsEbcGTKpAAMkYjjUqnhtM25kl1YRNE?= =?us-ascii?Q?i680dqDIqmjxudGZYEbdwe25w2B34VLv/pzn4+CMXSFh6I0ABQOR/noJQnoW?= =?us-ascii?Q?Hlrf/f0KkM/NKoS0X4GWA7HHYxVAnN8kjJ70EaSrv2PWwy/Wx97+a22lglj0?= =?us-ascii?Q?57ww6/VOoQCYOvZlJj+FEk22eiggssYgfX5tYEH08MKrWjIccFQtVuBMe2cr?= =?us-ascii?Q?eWcyzS9BeHFS91XJZJGdzLNgbmYVmQGrvvFK8PN8bN93vnMmG31VbSvSi+UI?= =?us-ascii?Q?8XlrklUZcAvRKyFr5PKAn7WGb8GJkiTKXWknShGFRhD3s9U/cAhOsyP9JQCk?= =?us-ascii?Q?FBg3F+3gpTxnWOCBJGhvaTd4SFAh+eIxMJZRDxFsab9bFYlzhKWgTGZrR/YE?= =?us-ascii?Q?Y8/aft/9t4g+T/lvAoeNe6pP5PMirulkGUOs8nyOIoKqpc3kgYtkqhfCVCdc?= =?us-ascii?Q?q2Tq8Jn93Bx6KAQXtXTwF4v8pYHB/MKgv8vxHd5bQlo3WhPnUMEU5EyH+ta7?= =?us-ascii?Q?TXrjP3KzyQ8Yskm0StgISu8uaOgLaPEkxrHfCw748Mn+y603+Hxns2RXDIHa?= =?us-ascii?Q?XEHKJH0RKomWL6DDZgWVwPtpqZ0PFm9WMNE+RlEO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d761283-dcd3-4a16-1b72-08db0b92267a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2023 18:10:54.1412 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +HWPmRXBHesChc7hjOn390ajl20f3HtN/1s18ANeO5E7XLm2TTe1EYI+sSXudWzxUq2aQB1TmFeiXP274bJ+dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7530 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, February 9, 2023 4:52 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Oram, Isaac W > ; Chaganty, Rangasai V > ; Ni, Ray ; Chiu, Chasel > > Subject: [edk2-platforms][PATCH v1 1/1] SpiFvbServiceStandaloneMm: Add > changes for rewrite varstore header >=20 > From: Michael Kubacki >=20 > Updates the Standalone MM module to have the necessary INF changes to bui= ld > with the following two recent commits made to rewrite the the variable st= ore > header in the MM SPI FVB service. >=20 > - e95c798 > - 88d44c5 >=20 > Cc: Ashraf Ali S > Cc: Isaac Oram > Cc: Rangasai V Chaganty > Cc: Ray Ni > Cc: Chasel Chiu > Signed-off-by: Michael Kubacki > --- >=20 > Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSt= andalo > neMm.inf | 4 ++++ > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = | 4 +++- > 2 files changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git > a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbService= Standal > oneMm.inf > b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbService= Standal > oneMm.inf > index 152cf0036fdb..717b6fc00cc6 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbService= Standal > oneMm.inf > +++ b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbSe > +++ rviceStandaloneMm.inf > @@ -44,6 +44,8 @@ [Packages] > [Pcd] > gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase ## > CONSUMES > gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize ## CONS= UMES > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashVariableStoreType ## > SOMETIMES_CONSUMES > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashNvStorageAdditionalSize ## > + CONSUMES >=20 > [Sources] > FvbInfo.c > @@ -60,6 +62,8 @@ [Protocols] > [Guids] > gEfiFirmwareFileSystem2Guid ## CONSUMES > gEfiSystemNvDataFvGuid ## CONSUMES > + gEfiVariableGuid ## SOMETIMES_CONSUMES > + gEfiAuthenticatedVariableGuid ## SOMETIMES_CONSUMES >=20 > [Depex] > TRUE > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > index d73a51ca5235..cad22acda496 100644 > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > @@ -188,7 +188,8 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, > PcdsDynamic, PcdsDynamicEx] >=20 > ## Define Flash Variable Store type.

> # When Flash Variable Store corruption happened, the SpiFvbService wi= ll > recreate Variable Store > - # with valid header information provided by this PCD value.
> + # with valid header information provided by this PCD value. > + # Note: This PCD must be FixedAtBuild when using Standalone MM. > # 0: Variable Store is gEfiVariableGuid type.
> # 1: Variable Store is gEfiAuthenticatedVariableGuid type.
> # Other value: reserved for future use.
@@ -199,6 +200,7 @@ > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > # Platform may implement a Regular variable region and an additional = region, > which will require this PCD > # to tell SpiFvbService to include both regions. > # Note: This PCD is for compatible with legacy usages that should be > deprecated. > + # Note: This PCD must be FixedAtBuild when using Standalone MM. > # The new usage model should define separate regions without implicit > connections to UEFI Variable or FTW regions.
> # Example legacy usage is to set this PCD equal to platform > PcdFlashFvNvStorageEventLogSize. > # 0: No additional NVS region.
> -- > 2.28.0.windows.1