From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.3063.1632877897804044232 for ; Tue, 28 Sep 2021 18:11:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=niEeCWMP; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10121"; a="204986152" X-IronPort-AV: E=Sophos;i="5.85,330,1624345200"; d="scan'208";a="204986152" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 18:11:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,330,1624345200"; d="scan'208";a="708125854" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 28 Sep 2021 18:11:36 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 18:11:36 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 18:11:35 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 28 Sep 2021 18:11:35 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 28 Sep 2021 18:11:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kLhKlRpWnZlqTqbzWEO5VPUyrt7t6Kmmt83FR+MOsDFUjCuQ3KEiO1qUMOO7QAi7auBowTphdueMNDbFwg1hxgljBGPubi2IDVnNPEhsrDBIdEEkBK2ddL/m9GvGvWJ0TFqLD3pUp4zL2i9iZ8G7x0XRGCbsyj06M6uXA8nCFob0WPFgPJGfQiICf6Bp/g2hNC63e8E/7UNBr6mvPYg1Pqh+rLwyQ5bVuWjl+EltA1lEnMaJI/kumODcOjPfXF/IFVbb6QOemdL14GaVKrMnEqJmCo5PGtq2ixmRKkTBxJzHYxhBT7eqphbwzPEnEwlQMpqBKLshfhaMVSyzU3fPAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eD25wzklTv8urnGZcM9yZ/Difer1qNS8j6ZeTc1Igsk=; b=dkHMbpFtGgewXH2IYZzCzKjYsoEbpCJI94BNK9MhTpez/luimscVXBk9lbiqKmiMZMJ6F3fTdZKoKijI4j+3d894Haa0z8MKORb1CE9j6Vnq20HygyvTUzcyftKDd6O40lxzYH1ee/tiILs5mjSuCE8G5vo4eikpjzd8Stw9iOVF+kM8rviL+07oZDmYZvQXr2UQnYUrQ6SzQE6eac32ZagCH81EViqsUMlVGUY3uZaKlfKrdEFFNlWSy5MhXkA8iOEclp8mgnyCAuq0+fmL4fcDHcl9WRc4UjI0DA2G9DnwZuWzQaNt814OfX5dW9nqQN6Jc3fFzFmkVTWdoYW3/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eD25wzklTv8urnGZcM9yZ/Difer1qNS8j6ZeTc1Igsk=; b=niEeCWMPzpz4RK9Jfa9KmvvPuf6iENx2hCPft2i89ww5XdQaigBjnUQ34O2iEuL3hIt2B9rknHKhiXfqe5STqlGw5GpWCqXJ/lH6l/hsRA0/SSL2UOLDJgMnWdByDRFNq75/rusFsk7pHpySIeWqRO9IZPP2KoeEBg7bIFfCd5c= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN8PR11MB3649.namprd11.prod.outlook.com (2603:10b6:408:84::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Wed, 29 Sep 2021 01:11:10 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e%7]) with mapi id 15.20.4544.022; Wed, 29 Sep 2021 01:11:10 +0000 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: Benjamin Doron Subject: Re: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build Thread-Topic: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build Thread-Index: AQHXtM3Wlhf6ArGJj0eJnE2vUmTT2au6NAIw Date: Wed, 29 Sep 2021 01:11:10 +0000 Message-ID: References: <20210929010323.2653-1-nathaniel.l.desimone@intel.com> In-Reply-To: <20210929010323.2653-1-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 73cd1f94-ef38-4c4f-d2ac-08d982e605dd x-ms-traffictypediagnostic: BN8PR11MB3649: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sJT+xu1XYwdtG5xhADQDZNHHGE4rxWNCaRA8h4gxMIK3MN+HYaBvyWXe09TKO4IsASl55KJttcPnId+sIEUwHP5DecKpq8Ki+BTh5BqvqHp6+5ww14YIwEOgDWd9D56GXek+GgQh34FUk8P3nJxlUhSF+eqw76LdRPv/Fg+EhgeeqF8JtUxW/1Y8NmIS7e+o/5sSkIlyzDndVMOs4tRD0NJO5Jo/3faBU3jAHfy+dCv2tQWAXoSz3jDIUtOo+8aVOMmp1xMjFXQDYiUvM7XifSyYWroKL7xLk3KCCJdb+TB2Mja1vnEx8MO9/m83qH0swX0FUZJE9LJk1oLloe9uBTdsjjNL4aNaMMDe2jrnrkGbIrI6opOxgK5gWD6qkziQKfJb43rfHCsu8Eaejsa8Ee3ggWJcqWzJrFfkwWiH3lHvQNgARfALWmJqfuxThpLCgm6lqKC86qOeM1ClG+rzu5b7jsbX2k05DLUhyrs+X0QKXAtyi26wv25jS647SlIMy4un5o1jr29HKAV3WctFVOXYLN6bOUkgRYE9yhlGANUvMzNnJIjwEjRI++DRG8ZNKQpcCy24fEHmG48dvRw4q88G7cq2e4PP5O+fAlYYAt9NspirUjvy/BTKkvZUFdQ8sgXTu3y1c1gXAT/ms1j4H/cIcNi214XxVFNmc7Q8IT0a+5VKLXlQdPw3D/B4P/YTYOyVWUbVKehk4cMvP60ZEA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(71200400001)(9686003)(4326008)(33656002)(8676002)(26005)(8936002)(55016002)(186003)(19627235002)(5660300002)(7696005)(508600001)(53546011)(52536014)(110136005)(76116006)(66946007)(83380400001)(122000001)(66476007)(66556008)(38100700002)(38070700005)(316002)(86362001)(2906002)(66446008)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?guA1ehcKbd/wIDE2cqu3L4fXtHkWihH9c49nu9RWeIRCXcw6Z7IoC6r1zvn0?= =?us-ascii?Q?Q89B4gYxZzErQ13L11KNL+8tY58PfjjpkoaBxMHtkLHL3kUUseUUAWKM91AS?= =?us-ascii?Q?7IDjMI4axNJdmrr5gFPl0BHzqIpaMxMZd8aXActQ3j7hdnYOnPvtf/km336T?= =?us-ascii?Q?xWyY8NxUXsoQkeQh5bkAuzAxusBZxLrQcaaGlEM3iGSENg5CaxQWkOlro2CI?= =?us-ascii?Q?JuD+//n/+oTLUOTeNbavk4dvPaWQMBvlj7FQdTz2QFzZyPD5RQChUCn/tjac?= =?us-ascii?Q?/6IIUNqY3s+Ti9iU7Ddc5I2XK77hQ18Lp5RSLEU4/nK4BQcDPjgCHz4egAuQ?= =?us-ascii?Q?6RAIFhABv1GluozRyOEfsDZV+nfQpzPNjhFUW3dOXseSedAJddqETIONN3Uw?= =?us-ascii?Q?2nnoWbxVeyUDl9Gy9cGLwf5A7/osLqnIVu+gUKp7ZzMUL5NCUs/E/cHAprVg?= =?us-ascii?Q?lsnYN0GHJG3I0/lo14iHlaSBsBXBwq7BfYdzGhwd0AgOSEl54/3smEp+iE1h?= =?us-ascii?Q?BGfNb7DwUIZhmMSkeMDJwy90MU+jqmFHXeOwSr37akR/xFPm4l5peSrJ6hTc?= =?us-ascii?Q?snyY+RloThfNpr+ugPZ0PSOlAfJ9AtqZ87ixPF+LoRkr9g+CD/HyK7qcRR3O?= =?us-ascii?Q?hjRTXGrRfxrwStrKxEz3tvxeVq/ytIv0BhywcY1K4+m2HZBeba0L5FnMXrSZ?= =?us-ascii?Q?spKYit0qngNLll0qNKQru4dkNxUIZ8K7gYru7ble5gK9IkSbspxMCe0CqQck?= =?us-ascii?Q?1bQ4qeQgoSli2Xe3CHc5q5i9pi4sgWtf6q23gVAnCGeMv+AzF/Y3J3sJD1ql?= =?us-ascii?Q?HsHIpgh7uP++V2xmB/cw0mEzsYNTprfcAI7XHkhukpxGE6dNjgMzfgmCHMRA?= =?us-ascii?Q?wy56Y1njidMktZIA7G0wlmBkM6Eu3GAHT7345mGyYg0yv60fi/jt0STuRMJd?= =?us-ascii?Q?xQCCKYIMbXQK0GpaDlC41egAyYEmOMPChwJt6X0ZaedNB/svECcFbWxL/hjr?= =?us-ascii?Q?P0Cs3r8Gvu6mR2veQAcLCP40Yf/UxPPaB0KZ1LbDFpvg17wYOj9l+lX7inK8?= =?us-ascii?Q?w2VXikPCg6FClEzUhpLgRcrCWmDy+R1bVhTjv45IgmlVG3N49f5OkFtXr/9I?= =?us-ascii?Q?9gEU2Aqf9s7OUJHYVCYxvRG7RFdcbC13y8LWimnAqetWRFD8ofIs0NkLNeW1?= =?us-ascii?Q?r+tUsEpcrg9hT69dTzN8+1LqyM1nAMnCbD979kZrhXj8u6b4dEZf2oMl6dpZ?= =?us-ascii?Q?gX71vsukjRn3f4gzishjCFR4AYHEJv2ggQFupj62z1/7FM3OmNeryDNoJYs3?= =?us-ascii?Q?iAErrM+P1+FH/apB2c+SGNHK?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73cd1f94-ef38-4c4f-d2ac-08d982e605dd X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2021 01:11:10.1033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KZrj9O9kQ1Qb4VEurqd1II4zZI5g9pFRN5oOng0GvykdI3f6MX6e9d6x/LKOKXeFdlAEPh9NhtKYk945XtCvgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3649 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, September 29, 2021 9:03 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Benjamin Doron > > Subject: [edk2-platforms] [PATCH V1] > KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build >=20 > AspireVn7Dash572G currently does not build with Visual Studio. > This is due to the Visual C++ compiler generating warnings with the GCC > compiler does not. The two classes of issues are unused local variables a= nd > implicit integer casts that could result in truncation. Visual C++ requir= es an > explicit cast in cases where integer truncation is possible. >=20 > Cc: Chasel Chiu > Cc: Benjamin Doron > Signed-off-by: Nate DeSimone > --- > .../AspireVn7Dash572G/Library/BoardEcLib/EcCommands.c | 9 +++++---- > .../Library/BoardInitLib/DxeBoardInitLib.c | 3 ++- > .../Library/BoardInitLib/PeiAspireVn7Dash572GDetect.c | 3 +-- > .../BoardInitLib/PeiAspireVn7Dash572GInitPostMemLib.c | 7 +++---- > .../PeiSiliconPolicyUpdateLib.inf | 2 ++ > 5 files changed, 13 insertions(+), 11 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcL > ib/EcCommands.c > b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcL > ib/EcCommands.c > index ea8a8ae11e..6e752b4e22 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcL > ib/EcCommands.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar > +++ dEcLib/EcCommands.c > @@ -2,6 +2,7 @@ > Board-specific EC commands. >=20 > Copyright (c) 2021, Baruch Binyamin Doron > + Copyright (c) 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -167,8 +168,8 @@ EcIdxRead ( > return; > } >=20 > - IoWrite8 (EC_INDEX_IO_HIGH_ADDR_PORT, Address >> 8); > - IoWrite8 (EC_INDEX_IO_LOW_ADDR_PORT, Address); > + IoWrite8 (EC_INDEX_IO_HIGH_ADDR_PORT, (UINT8) (Address >> 8)); > + IoWrite8 (EC_INDEX_IO_LOW_ADDR_PORT, (UINT8) Address); > *Data =3D IoRead8 (EC_INDEX_IO_DATA_PORT); } >=20 > @@ -184,8 +185,8 @@ EcIdxWrite ( > IN UINT8 Data > ) > { > - IoWrite8 (EC_INDEX_IO_HIGH_ADDR_PORT, Address >> 8); > - IoWrite8 (EC_INDEX_IO_LOW_ADDR_PORT, Address); > + IoWrite8 (EC_INDEX_IO_HIGH_ADDR_PORT, (UINT8) (Address >> 8)); > + IoWrite8 (EC_INDEX_IO_LOW_ADDR_PORT, (UINT8) Address); > IoWrite8 (EC_INDEX_IO_DATA_PORT, Data); } >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/DxeBoardInitLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/DxeBoardInitLib.c > index 4bce51886e..5c5c26d85c 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/DxeBoardInitLib.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar > +++ dInitLib/DxeBoardInitLib.c > @@ -2,6 +2,7 @@ > Aspire VN7-572G Board Initialization DXE library >=20 > Copyright (c) 2021, Baruch Binyamin Doron > + Copyright (c) 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -46,7 +47,7 @@ EcSendTime ( > SendEcCommand (0xE0); > for (Index =3D 0; Index < 4; Index++) { > // Shift bytes > - EcTimeByte =3D EcTime >> Index*8; > + EcTimeByte =3D (UINT8) (EcTime >> (Index * 8)); > DEBUG ((DEBUG_INFO, "EC: Sending 0x%x (iteration %d)\n", EcTimeByte, > Index)); > SendEcData (EcTimeByte); > } > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/PeiAspireVn7Dash572GDetect.c > b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/PeiAspireVn7Dash572GDetect.c > index d379fdb0d4..344e06859e 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/PeiAspireVn7Dash572GDetect.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar > +++ dInitLib/PeiAspireVn7Dash572GDetect.c > @@ -1,6 +1,6 @@ > /** @file >=20 > -Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -29,7 +29,6 @@ GetAspireVn7Dash572GBoardId ( > OUT UINT8 *BoardId > ) > { > - EFI_STATUS Status; > UINT16 DataBuffer; >=20 > ReadEcAdcConverter (MODEL_ID_AD, &DataBuffer); diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/PeiAspireVn7Dash572GInitPostMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/PeiAspireVn7Dash572GInitPostMemLib.c > index 2946e174ca..77722f5d60 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInit > Lib/PeiAspireVn7Dash572GInitPostMemLib.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar > +++ dInitLib/PeiAspireVn7Dash572GInitPostMemLib.c > @@ -1,6 +1,6 @@ > /** @file >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -40,7 +40,6 @@ EcInit ( > UINT16 ABase; > UINT16 Pm1Sts; > UINT32 GpeSts; > - UINT16 XhciPmCs; >=20 > /* This is called via a "$FNC" in a PeiOemModule pointer table, with "= $DPX" on > SiInit */ > IoWrite8 (0x6C, 0x5A); // 6Ch is the EC sideband port @@ -66,13 +65,1= 3 @@ > EcInit ( > IoWrite32 (ABase + R_PCH_ACPI_GPE0_STS_127_96, GpeSts); > /* Clear xHCI PM_CS[PME_Status] - RW/1C - and disable xHCI > PM_CS[PME_En] */ > PciAndThenOr16 (PCI_LIB_ADDRESS(PCI_BUS_NUMBER_PCH_XHCI, > PCI_DEVICE_NUMBER_PCH_XHCI, PCI_FUNCTION_NUMBER_PCH_XHCI, > R_PCH_XHCI_PWR_CNTL_STS), > - ~B_PCH_XHCI_PWR_CNTL_STS_PME_EN, > + (UINT16) ~B_PCH_XHCI_PWR_CNTL_STS_PME_EN, > B_PCH_XHCI_PWR_CNTL_STS_PME_STS > ); >=20 > /* Enter S3 sleep */ > IoAndThenOr32 (ABase + R_PCH_ACPI_PM1_CNT, > - ~(B_PCH_ACPI_PM1_CNT_SLP_TYP | > B_PCH_ACPI_PM1_CNT_SLP_EN), > + (UINT32) ~(B_PCH_ACPI_PM1_CNT_SLP_TYP | > + B_PCH_ACPI_PM1_CNT_SLP_EN), > V_PCH_ACPI_PM1_CNT_S3 > ); > IoWrite32 (ABase + R_PCH_ACPI_PM1_CNT, > B_PCH_ACPI_PM1_CNT_SLP_EN); diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/Pe > iSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/Pe > iSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf > index ad85326bf9..0a8cf91b07 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/Pe > iSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Libra > +++ ry/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf > @@ -53,6 +53,8 @@ > gHsioSataPreMemConfigGuid ## CONSUMES > gSaMiscPeiPreMemConfigGuid ## CONSUMES > gFspNonVolatileStorageHobGuid ## CONSUMES > + gIoApicConfigGuid ## CONSUMES > + gHpetPreMemConfigGuid ## CONSUMES > gLockDownConfigGuid > gPchGeneralConfigGuid > gCpuPowerMgmtBasicConfigGuid > -- > 2.27.0.windows.1