From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.8407.1625820455698610359 for ; Fri, 09 Jul 2021 01:47:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=T7rIRv46; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="270786456" X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="270786456" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2021 01:47:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="411718571" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga003.jf.intel.com with ESMTP; 09 Jul 2021 01:47:31 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 9 Jul 2021 01:47:31 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 9 Jul 2021 01:47:30 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 9 Jul 2021 01:47:29 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 9 Jul 2021 01:47:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHq3tL1uXUts2LgZkQA4Ai88YjIljVka0nM+silHvo2P3O2QNmL/cAWt/r0vk8vtEUcH22YPfYG37pkjiba3Dh6GAFg0nIetQ1X7BOyVuPhlPkRYCIQHFSGONYP619gTLRnOofvRcsVYBnMbw+cowaDTSiZQ++Dbe0ECnGSO3VRhNkLzVrRjXELPYBuEvfQROt/LLiL5pC2fBvS7LruFk7GfbJaAhsedfQ0I3UKGWbK1hV9AWtjUNSoTllObGmLoQVv00lKG+N6vfo6A/c2u9FvauwmsjLaz8ux3Nc8F1K+beX7cCi3ER/BF4VoVR6LAdM6GmXQA1669hNDlZENBJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xTXvw/F6sZiQMBJU6c275rld8l2EO+LPHXEUOXqC3fY=; b=SwC7KneFQpdsJaiW3ZTvw7u1VxnNnHfozEZDLf9YhbLeTTgZIRlckfdJZ/NkfK/aCFg6hjmzQBTH1FMGQ9VTCK1RuVqq+LtdDS5pVplBSloKLKi2Ct3F9c5zWgpuprluFGq77BCyxhku23PJ5J6GaUQwyv+zks6+9mKo0oIoLgg0dKC2lMsz5Izg8O3nnsogRJ6xVeV6THVDT2Dc+bVZOyeKbZ06RxTgka9oBmKmPidlZs5iY1/w0NdTFoAsDgCGaGe0SZROMTdm9TLszlV316GIs7aY4rUGu1JpoNpjfo32ZtS/2OAEOkLLOPz7FEHPYZ6gtWSwUDnAIOwyZKI+lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xTXvw/F6sZiQMBJU6c275rld8l2EO+LPHXEUOXqC3fY=; b=T7rIRv46pONx/WFPaZ4G2wtIjODPSso3pESC2pb2ID3ZcQbxXocDXHxPwl/Hg98P9VginKXc/s7ZmtVs+Q8HFbHyowGzf8YXQEUnkj1EklIHrfFJhG4IpBtoi3P10FFPhMMM5Zzmvj2Stk1KawbDTEqjHNitb0/DsFRAATXlq0E= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB1314.namprd11.prod.outlook.com (2603:10b6:404:47::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20; Fri, 9 Jul 2021 08:47:27 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2%7]) with mapi id 15.20.4308.023; Fri, 9 Jul 2021 08:47:27 +0000 From: "Chiu, Chasel" To: "S, Ashraf Ali" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Desimone, Nathaniel L" , "Zeng, Star" , "Solanki, Digant H" , "V, Sangeetha" Subject: Re: [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber Should be UINT32 Thread-Topic: [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber Should be UINT32 Thread-Index: AQHXdJTBk39I94MTukWmjbGA3a5a0Ks6VJNg Date: Fri, 9 Jul 2021 08:47:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5cc620f6-3cb3-4c9c-ea79-08d942b62e5c x-ms-traffictypediagnostic: BN6PR11MB1314: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:546; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r8ZTY1U40Q/A5o30yOSDtwqC5nrN/wtCytv4MwOnv7HqEXiTD/Gpvd+N4zDuMqs9TDgiTuTmUrBoVOamDHSmW3TfjuJcCtfq8IE0tAcnC/XWd2oV2PFjeqwjJOuoz7zSOHwkCnS2kQ4meW/dkiLhi1E1oqEmkWRjSdRjRq+ORHx3muXdj8HCdW/e/cFaah/pnDxqkYfrsweA/wfGSel0YtahvkV84JLgZDcMgC767Idyg2fyQBN7sxyNQp93NT3HYvqvEBwCSUovdg7yIA8WAxo5rx/k4Hady66URu7cvzOfipQL6qrCOLNpY/NBcBGoL6/jCqV0+zVnErn1r60qFXuJtDUgrnJelmDn2hJS9Jsoks6UCOCvRNLq/9OGln16hc+jF0+mPaKIHUlbVVCpSP6XKloooQwDX9hoiflH0rUZh72iCOIxDoPgxYX+0JVswSL8dody1+mJOa3diPzAvLDuWLjbujI7teiVgAIwSA0WjgnwO4hLMAtnwuNwWCpD1817F9Vrv3SBRqB/Rr/8w+SSmR+a7DNX3pc0NlC3D2KQNwgmeRy4Ndxxx+rmWksFOZ5rPD4Yi4oeGhjDEwKF1/QQfnO1oX9Xma8a4IgPf6MjOzwmlDlY8/hGBfLhUo6Ms9V+39PxTv22Ruhu+2EIo2NsGHKJu7r0YtDPW8GrHZlJuR1YvTQp42P+rS5c2sCbLR8aMIMRwLzuHeZRO722qPp1p9cuuU370UZtlLU9PFghGSl7Mb1dQhE20pdZN7xqHcMKzzMZF/bQW3HwXwUJkpHhwK4qWgEir3wea9ZC02I= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(366004)(346002)(376002)(186003)(66556008)(64756008)(66446008)(110136005)(54906003)(8676002)(7696005)(53546011)(6506007)(8936002)(26005)(55016002)(9686003)(107886003)(5660300002)(66476007)(52536014)(66946007)(4326008)(76116006)(33656002)(71200400001)(316002)(19627235002)(2906002)(38100700002)(122000001)(478600001)(86362001)(83380400001)(11716005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OKyY234Vr8DilfVIIV6jn6LLtR6uE8RKzaklvqCPGCZDvdqWHjdCXiUZq9dH?= =?us-ascii?Q?FYmdDgIhyUo6l+F6+Li3j2JH9CSCsSFcoFDWqAm51UG5HYG61Kxc9O1z4+SS?= =?us-ascii?Q?G6fSDBWoLD0Z/Op2u2wWd/0/9rbDvFyA43dKGdC/uKZl7o2nh609Zbmc15gK?= =?us-ascii?Q?TOPzuTaVvCZkomquTkQRCUHSH7AALCjwNLiMzefvXsy2Gt9q5c94chlHxEPJ?= =?us-ascii?Q?Pgjw51ZjOD8ExZHc9tHhDudd2pd5Lqxt77sZa+OL4iQZ8s9+MCSK+6JaA3h+?= =?us-ascii?Q?GW76k+GxLFpbe0W7i5C/L7QQnOQs6BE73vngKVLXFuehIaizDLz/gXJccBre?= =?us-ascii?Q?tLQgFWp1ItACjj5yDQZ6Xj0y/YIwloKlgTduPjxJ5JJnLMQjTpihw66zl0Dj?= =?us-ascii?Q?TZZewq9+95w7KJxNjcDZri5LhEAG0oYDlKno9Vv+1tJfreWWpBxzvx2KywTZ?= =?us-ascii?Q?U6WjsT9t101VxcG1v7U8rluQDoKV7eIaGdk672jX8etGrsGciSgRa5i6r03w?= =?us-ascii?Q?dnHmX+/5UggbF8i8y3d/qPVEH9ooLl+HfJoFa+leYG0zj4L4zhZEQBo7Df8a?= =?us-ascii?Q?YPbZYDwteJVeNE6QMVhAqymOAVwjmsLYx7pzfPoSjXa2mklTbkDCy3yFJqzp?= =?us-ascii?Q?oQCLUftu6NSIHbNt5oJirZp0pUU8STtmR97VcJ1CnhB6deb5FotHBCpVP/91?= =?us-ascii?Q?5uI2XMFZaV6hHLq/yo/MA7EZgPQVZo9293oxjfyokTsvN+xo85MHZ90mxQFw?= =?us-ascii?Q?sqa9IthJEJq0CmN8iLdkPNd7PbqXWMylwlA5NTvF5lvG6SWtNDJq1GYh9sIq?= =?us-ascii?Q?Ki1QSJZpGW+6jPf3jT9RqTQTYIt/koEyq0PFHs1uGEk/NL/mYcgRRemr7igj?= =?us-ascii?Q?jybZzIlwZ7m1nOQ76D9KhO6QdD+h0vuWyf6Qs659sxVBLi7pg1EJBnKgYBjT?= =?us-ascii?Q?WpZVV7hiN9tolpNK0Qe9m0kI9U0qMFTuu/1UrXf6/H0WoyH65+0kdVXJsINU?= =?us-ascii?Q?AaVMbR8aUpAIRpqCU2xy/Cc7MkYwEWjG9zuWYAfmls5uo8u0OYUqJTg3PWWT?= =?us-ascii?Q?z1MR0UQ7FCrHhWkg/xCaYR3duORrWDqJvGmPPHJjnluZRK7xgkjWlumkOFW+?= =?us-ascii?Q?1Neb4sLaSFEXSJJ9pGJ3k7rj3VHHBM08xT+fKMKhJkDWBW9RHhXN2bqQ7vWH?= =?us-ascii?Q?skIfIccqOTRgqCGXdzL77DbUfWg2VcUZ1pCS+h5KHdkOW+pmFWSOTO1nglS5?= =?us-ascii?Q?uAJ4I12KENMnaGl7hj3rM60Ha9V5FVcO+iaHmlu9RejxG0Utz5hXvQau9jaP?= =?us-ascii?Q?4k90KFt1t5CCu+Vu+wRRYUUT?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cc620f6-3cb3-4c9c-ea79-08d942b62e5c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 08:47:27.6678 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: koupKF31dWQ9Aj0QTxmi9ckIXAoZLbUnYiSHRkrcBnisQbPL/ibADM7J1jDcXoGmors0thlmZOjxp5Oz3ratEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1314 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: S, Ashraf Ali > Sent: Friday, July 9, 2021 3:33 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; C= hiu, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; > Solanki, Digant H ; V, Sangeetha > > Subject: [PATCH] IntelFsp2Pkg: BaseCacheLib EfiProgramMtrr MtrrNumber > Should be UINT32 >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3485 >=20 > CacheLib EfiProgramMtrr Function takes MTRR number as a input parameter, > in the function the parameter is defined as UINTN were as the caller call= ing > MTTR number in UINT32. >=20 > Signed-off-by: Ashraf Ali S > Cc: Ray Ni > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Digant H Solanki > Cc: Sangeetha V > --- > IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf | 4 ++-- > IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf > b/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf > index d9034bcbaf..9a513fb6df 100644 > --- a/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf > +++ b/IntelFsp2Pkg/Library/BaseCacheLib/BaseCacheLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Instance of BaseCache. > # > -# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2014 - 2021, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -15,7 +15,7 @@ > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D CacheLib >=20 > -[Sources.IA32] > +[Sources] > CacheLib.c > CacheLibInternal.h >=20 > diff --git a/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c > b/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c > index 17e895c345..2365f7514e 100644 > --- a/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c > +++ b/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2021, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -164,7 +164,7 @@ EfiRecoverCacheMtrr ( **/ VOID EfiProgramMtrr ( > - IN UINTN MtrrNumber, > + IN UINT32 MtrrNumber, > IN EFI_PHYSICAL_ADDRESS MemoryAddress, > IN UINT64 MemoryLength, > IN EFI_MEMORY_CACHE_TYPE MemoryCacheType, > -- > 2.30.2.windows.1