From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.7601.1625812315518447106 for ; Thu, 08 Jul 2021 23:31:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=fxRlSZkB; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="273490924" X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="273490924" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 23:31:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="646199073" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 08 Jul 2021 23:31:51 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 8 Jul 2021 23:31:51 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 8 Jul 2021 23:31:51 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 8 Jul 2021 23:31:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eotAroIkSZ2C8eym83LVejAkg6aGjp18YWgh13Jvbq2lL1qDR8XJ8FWH0jROwgOtC+JtHks4Jk+CD0/AE9SJl7gRWon8KbX4a2oIbj7pZdJs/Znwq6Rbw3kqrRBF9qUZTTEq5ERszUW4RDn2BMTaqwzHbdu6SxoMsOT0idbcLbp/UYVUfTjeoMxlt9FPXOOBFmUDtnfRf7jf8rNiItHQgyewfZsOsupQG4BMyYi5iPosp9VMtCg8rly2jvTuW1qIuzt1EmlK7BtZGEzVPe0uZXxSZvpq5jAUR8A5RIVp21X2jKu+zxvW8ZtT3WEBBkXuXO+SMlhyPERKYqMf4x+pjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DK4JnHd7J3of145MZ5xGvAEXOy1FxqkqvRBNvq5GXtU=; b=CvcqiayyueyQvWOWEVfmpk485bI2oDMjUB59HiX+KN6gOnyk4gkCaMKBiXz4lru2QoQBQMzRcLfyQFFrwl3boihDPme9UVl3oTET8i+qovbejEUf5x/gujkEeH1RissuHBnLTyCR8QlQhmftTgdq5evmwr0duiramvSCHKfpBB+xPQ71KDzw0iSFyxJIodN4meHdRg7hN7iZWXrJ8pRUmTi19sK7PT/9nvb4fQb7iHHxP0XB8ZT2S1Co5rVd8YOJShxyln7l5QJq8VmncPWoLdPQ2QyTAFdwZfjjiiq877fn0AwGPFfzYH3UNTLJAS2i1wlouaWLdgb7ZSRQ+3b84A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DK4JnHd7J3of145MZ5xGvAEXOy1FxqkqvRBNvq5GXtU=; b=fxRlSZkBukw27wjPKPWutJBqRll3Yr6dEL0W/7qoK6+F3MN+23fLiELMtvyephjIis4BJJXF4Ji/N6ybHC+SQ/rTsttflwZYIoQzCk6ZWnCpaSJdoR0vNOoGBgPKTs90gPc3KO1nHakaeWw2UXdsBG46WoW95jgeXNyc1cbfodg= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Fri, 9 Jul 2021 06:31:45 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2%7]) with mapi id 15.20.4308.023; Fri, 9 Jul 2021 06:31:45 +0000 From: "Chiu, Chasel" To: "Chaganty, Rangasai V" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Liming Gao , "Oram, Isaac W" Subject: Re: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Thread-Topic: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Thread-Index: AQHXdAdg5BmZdXnwk0eMue9OhwSo66s56yoAgABEg/A= Date: Fri, 9 Jul 2021 06:31:45 +0000 Message-ID: References: <20210708144056.1740-1-chasel.chiu@intel.com> <20210708144056.1740-2-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f29325b9-3a3d-4f82-170e-08d942a338eb x-ms-traffictypediagnostic: BN9PR11MB5276: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:27; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: veWcxMGFimtSlZP/foIQpPF7GGwTF3P4GPd1eT597blCPbb4Nz4IecREqFP+FwJuGNXZqNZk2hD5QSXtshC1xubWH5lGDIpB5kc+WOQ6qgKiRbDBFCT1Rebza8mQ3VW4ySvficj8gUWgofGPN2leMzntarXN8J0vC7cd6+/pIJ2tzWr629Q353YNHA8o77dw3MF92c57Ov7KkUaw2j8uJ7ebfSETKfXDaz3dhchbc5mAWZuun+7SSl4/sG8+7auyHxMQwkGqP7X9GznLp5aE9oQdj16yaTr/sI8d0hUyY9YVCWo+uTjaZzFVOQkoLzvng7BRJqP28utIfQ9nCitaDlu0vg7pbzmCiM+MmKwWMDpC1ERVRFsrKdVA+v6noLzhqHsRypsh7DLtOcGoghc1KWFf6zwuLEjfM3Yk3ZdJy7OHgcLoA1AcXOuI14ONmGN1RdQwV0PSFUE+upO/ElVCafplD7AEzxmNVQdgdWUFD1H8GssSljiN+nlC7jnvHBWyyhmJz5zIviRqUTwIhAts8kPsDNq9WBYx3dz1JwK/A7PysYLruMqkpFPO4Jj2kZSCgelNakq5ZvkfeM9kQyQL1oX1hlkm3QuxgjCEKar+d2nZ3EdStcMSR2hONhrwEhq4PGb+T4Om85rLcHfdsKeQbLtnIH3zaZpW/HuKt6WGsExPjyEPZo5u97NyNLK9cEOwvKEZBxme7hQgBHGWod925ww8gSHIfG7hru0c35yW0AIhyC6iFA7jMCXz8Jwag74QrbC4YgP7naDhdy9vYOUIkcmycdD/a0J+VZfJUui+CFg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(376002)(366004)(136003)(396003)(186003)(33656002)(64756008)(71200400001)(66476007)(66446008)(8676002)(8936002)(83380400001)(53546011)(6506007)(66946007)(2906002)(86362001)(5660300002)(66556008)(478600001)(4326008)(110136005)(9686003)(107886003)(54906003)(55016002)(52536014)(26005)(966005)(122000001)(7696005)(76116006)(38100700002)(316002)(11716005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ccDzeRSPe6YcEsdrECIuxiKOfCxNpmIrH0ll/mkshuRjvHtD+I5Il9W3pgir?= =?us-ascii?Q?HJjK+vS4D59UPbqtZbUm+TZFiIxSsZAYu4hNPpKNcMqaI41cEa/4gZRWXx/x?= =?us-ascii?Q?1iVr/3pmJbnFHigAA5LUS6/rYLDrTiIAYuU61dNi9R1+J+qo3Z82uhP9Vnx+?= =?us-ascii?Q?3OLFDFqsdhHpfDtqh0w4DPxHyDQKC3lOUK25O2nRxfmwkbysqS9cAka+LUpN?= =?us-ascii?Q?CZsr6VWbZK4gkM/8gLiNXsnRATu4jZfeBzwFUUnMZGGDKQ7kEX057Q3n+7L9?= =?us-ascii?Q?6AhG9NUFmuAC3TPOZ2eQCL+Bnymir/L57ubZzKhmvZYVNHrh3fRrw1pzjvd6?= =?us-ascii?Q?T7EV2gBdZPxTEL24PofFzLbA8zjajxCSweApLvTtPpZMtCzaKDQV5j96FCiI?= =?us-ascii?Q?nzfXsP5Z1Fc9Crcv5lK4SZuiJHahT6ryN7trEiQvB23zW3036ATeaoGhqtEN?= =?us-ascii?Q?KLkx9inRAARoNDjfFkzA8bXIbWLZJPgCKg22hWp2W4FDfEbRBRcsZ2Gj2Z3R?= =?us-ascii?Q?5K9UpPHWdk/Lg31zo8OCF8yZ6H9fACLw6nB7ba4Shmi87MoKFeC+jcA6E6Rh?= =?us-ascii?Q?NOvOjOzTOWGCZIsj3goSgf4QnbCKPBFCiO5v2fgbxUtRYDGNCm5pAw08Tqzm?= =?us-ascii?Q?U0TYMJ3yL3/FekBmHwOEq4F4T4aMWAzdUnS9Zl+J3TF/PMoNI4G5f6Btmix+?= =?us-ascii?Q?VM0rcc8F/3CwkKnw7XWQ3nt2Q53r8FdWH1SnHz+ROpqr7hEpgKjsujY48yp/?= =?us-ascii?Q?nOl4t2LEtPA6zJwZoxjcYP28Pi6yd6SjAPJxclxzp/Xl+EMyRcEguZeI4Uj6?= =?us-ascii?Q?MRR2RpDx+5ITK/Sy/Lznado5Dw0zkzF7EKJ9JnfYoBVEbXl+pEg1KU4RbfpC?= =?us-ascii?Q?Gzo+4JzAYtJKZc6QeJjG2C/uv5Sd26Uq6MzbnBhJDi5AdO5rMtqYGaAQHNij?= =?us-ascii?Q?tPNaTofTUxKAwSFj6AuvXpj18KIQB7BeQAOd8xJtLP/ASrrYJ4KRSqcdv8iM?= =?us-ascii?Q?CygCdGR1f52iMxd8kByh9Kv6saItVnctBFk78dnq8rXSQ2jLC5zwP5rHLaFO?= =?us-ascii?Q?AOdwoO/2eM7IFUD61H6ajEDsRqWXaHD/xAeeX1sdzwfqz42cTOjY+OytKmu8?= =?us-ascii?Q?lh0wdHsIQ6u43Cq3zaU4pJZHuWf+5fmIli0cTOOulFGVwinIbiaWsVA1UM5j?= =?us-ascii?Q?IJGc21tEEPvB8YWWGa17ly8S6PP9LMG6Sy7tt3G4c1zkQfY/hLY+6DPd/1Dy?= =?us-ascii?Q?Sa94s7OMgLfMAo1dLvhTBdypshZm7+Lm5WVhyYJOFzEYt7B81iYn5qICVtFK?= =?us-ascii?Q?v6toiVZsq1ox29DNajDPYO9y?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f29325b9-3a3d-4f82-170e-08d942a338eb X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 06:31:45.0434 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CSZIrCf/GEHPK/bOS3mb04h3WwjhwnIdDmQ2ehS+/7nsltKT7cT8jhlm1aonpYAwmquazq34U7wxxkjwNmHEFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5276 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sai, We will fix the build failure first and macro naming convention will be che= cked separately later. Thanks, Chasel > -----Original Message----- > From: Chaganty, Rangasai V > Sent: Friday, July 9, 2021 10:25 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Liming Gao > ; Oram, Isaac W > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build th= is > package. >=20 > In ServerManagment.h, please make sure the newly added macros and > structure names are EFI/PI spec defined. > If they are not, please remove "EFI_" prefix from the names. > With that: > Reviewed-by: Sai Chaganty >=20 > -----Original Message----- > From: Chiu, Chasel > Sent: Thursday, July 08, 2021 7:41 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Liming Gao ; > Oram, Isaac W > Subject: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this > package. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3484 >=20 > Fixed the build failure of this package. >=20 > Cc: Nate DeSimone > Cc: Sai Chaganty > Cc: Liming Gao > Cc: Isaac Oram > Signed-off-by: Chasel Chiu > --- >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/P > eiGenericIpmi.inf | 1 + >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeatu > re.dsc | 11 +++++++++++ >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerMa > nagement.h | 17 +++++++++++++++++ > 3 files changed, 29 insertions(+) >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > index 0ef2c18116..bd995ef25f 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > @@ -42,6 +42,7 @@ > DebugLib >=20 > IoLib >=20 > TimerLib >=20 > + ReportStatusCodeLib >=20 >=20 >=20 > [Guids] >=20 >=20 >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > index a1fcefad70..05a7d4f0af 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > @@ -59,6 +59,12 @@ > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf >=20 > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf >=20 >=20 > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/P > eiServicesTablePointerLibIdt.inf >=20 > + > ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiR > eportStatusCodeLib.inf >=20 > + >=20 > + ##################################### >=20 > + # IPMI Feature Package >=20 > + ##################################### >=20 > + > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseL > ib/PeiIpmiBaseLib.inf >=20 >=20 >=20 > [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] >=20 > ####################################### >=20 > @@ -72,6 +78,11 @@ > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf >=20 >=20 > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf >=20 >=20 >=20 > + ##################################### >=20 > + # IPMI Feature Package >=20 > + ##################################### >=20 > + > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/ > IpmiBaseLib.inf >=20 > + >=20 >=20 > ########################################################## > ###################### >=20 > # >=20 > # Component section - list of all components that need built for this fe= ature. >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > index 244b86e91a..7591f33aba 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > @@ -149,6 +149,15 @@ typedef enum { > #define UPPER_NON_RECOVER_GOING_LOW 0x400 >=20 > #define UPPER_NON_RECOVER_GOING_HI 0x800 >=20 >=20 >=20 > +// >=20 > +// Definitions for Get BMC Execution Context >=20 > +// >=20 > +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 >=20 > +// >=20 > +// Current Execution Context responses >=20 > +// >=20 > +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 >=20 > + >=20 > // >=20 > // Server Management COM Addressing types >=20 > // >=20 > @@ -318,6 +327,14 @@ typedef struct { > UINT16 IoBasePort; >=20 > } IPMI_HOB_DATA; >=20 >=20 >=20 > +// >=20 > +// Constants and Structure definitions for "Get Device ID" command to > follow here >=20 > +// >=20 > +typedef struct { >=20 > + UINT8 CurrentExecutionContext; >=20 > + UINT8 PartitionPointer; >=20 > +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; >=20 > + >=20 > // >=20 > // COM Layer Callback >=20 > // >=20 > -- > 2.28.0.windows.1