From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.7692.1625812864391342122 for ; Thu, 08 Jul 2021 23:41:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=d5Iw8Q7l; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="209619581" X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="209619581" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 23:41:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="458178628" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 08 Jul 2021 23:41:02 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 8 Jul 2021 23:41:02 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 8 Jul 2021 23:41:01 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 8 Jul 2021 23:41:01 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 8 Jul 2021 23:41:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=INNdGhuEYkOxWCoYX55iZnjmoyB0e1/DvQqeCEzERXVVRQHvmCdGYyMmL8v4Jvc02YxDBB1DbNO92aM72xkSn2UnlnKKwosxOLhA3xsSXPdzgsDfQ4Y3HDUKFbe7uNd7d/1MrbARJmAXLbX9LDwok2cft2JdXF8mVkLcsmBN9O0Lu0FTKOgjkb0xMGsn5BvPebHXydhSEU8GhTDkRZBsVeWdYozkTxoMZ9VdD7y1lNbi5fI+8UOJLybmoTM83yl3tU4auQKw+KNYbh5KUKRHqQoUhAa9BC1TPymPCrmmODhU5KK1obXse3cVVEPlTOSU7ChUdszroAiH42Q+4VxKXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OVswB2JbS6HzfljmwZX03jZbpJRszdZ+BMOp5B2pvKI=; b=alq1vJV5o6Jqmmu0F3ljWMowd8gCcGa8poDwHidtRNYVfuVsHZq+Mwmdr1Jt/utbcLs8aYrIr2w18d19x4B5+Xh/CfYAqamh2JXba5qYrZhb6p5IYO+EhLW0ImiKyR7a47q08idB/IKTWxtuch1rpOwBx8XfP3CUOUB69XfJbK+sYq7fa6i3E5GfdfkyGGEDiVMTBrXHcRwHyVjQs6DXmOzvcuRCX+fG13Fi2iIU7yARcqHeqKAxyf9tjEIk9/XfSIrs2iN94GzN+Aks8S2y0p48bQ50965gZcB5zODhO01VbwyP6PGVM3r1UtbePaSARqXROkrRTFLWmRnzsmnqdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OVswB2JbS6HzfljmwZX03jZbpJRszdZ+BMOp5B2pvKI=; b=d5Iw8Q7l7VYPgoD18LSiqAdCRQoLb3FZIZZmg4saiLP8IN+W/ki7NDtgNf8YTEvtsMJUtlxwDS62fEmRuXtTX+tn/g41J4XCauMC7i3VND+UU2d3YMIM2g4mNr0ExIH2rVuzg6Y4RyRlWOBSUy6QaTdq8Lnf2WHvSKE+nZRfqOg= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB1571.namprd11.prod.outlook.com (2603:10b6:405:d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20; Fri, 9 Jul 2021 06:41:00 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2%7]) with mapi id 15.20.4308.023; Fri, 9 Jul 2021 06:41:00 +0000 From: "Chiu, Chasel" To: "Chaganty, Rangasai V" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Liming Gao , "Oram, Isaac W" Subject: Re: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Thread-Topic: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Thread-Index: AQHXdAdg5BmZdXnwk0eMue9OhwSo66s56yoAgABEg/CAAACqgIAAAf6A Date: Fri, 9 Jul 2021 06:41:00 +0000 Message-ID: References: <20210708144056.1740-1-chasel.chiu@intel.com> <20210708144056.1740-2-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7eeb76a8-b5a3-4894-1150-08d942a483f4 x-ms-traffictypediagnostic: BN6PR11MB1571: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:27; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k/sWNJZCEpNqNXT9Z3jWt9SfyF20aw9xmaw4+c80vdRRDYngb9pgrJL7ICBVWSoq1EpNuFuITp/mKj38kTYvDiLpmCxYsn1B2IjQJhSUoy/UfZPA4wtu+ZLVwVTd368pAFNqJr7fUd9uDDp8HcmRKG4qD3Je+1Lxq7xRvJ9HUZAz4ANhhyCOcmSAWBXqC0mBx+xM7TU6OQRxNP6fvu7nO5rgd7NxT49foePyuTTMgbXmX4FmrwgObsuth+a7AD3tx+K+t6NDT0U93uCsk3My4kZT3wVgcSaVqYiex1VpITpBDLWWT3xsuA6xzfS9RnIwSednJRmUnsPG1NA7o1Yyot+2/WmE77QBbfeM+ohQ/Hj93QJVVBb+beGJD2lVhfX+nqolmgwUiqZK7LR/wbSt/YGgFjAUlK1g1umhpIsBc/LiBfeeDr6ZHsTUobAfVf3r/dYR08xFlAb6rWQBgHvqt9wkz/BHwEdOn5AxgOSnW3Y0kTs6Ey2mbESqAHYUFrbwFSGAF1QmaIQ+xb8pj1WIPJFnUpmOKGHCVrRboOzzrqX5PiNGisy8BHsXLvCmCl5duwchrCd67hQzgOJQwXMTT7R5+azT1uLw8q9yyQOwDBq5eRSUtSlZVWWSUDDnq1Gp7L/3fywf1YUbbM++v1uAtS9C4CvERopBVuWWykk716g5jHCh5ExgBYcZQ4EOBrkeLmvHuDWgLZeN3yssPzmsDFtwkaHfU+lh8TonG8xE6W0l6FzYkMmWkjz3hnddwd2M1+veCGbv551bwCi5jOBlgdzYgqEmSojdFQ1f7z3HXHA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(366004)(136003)(39860400002)(376002)(4326008)(66476007)(8676002)(966005)(478600001)(83380400001)(66446008)(5660300002)(66946007)(64756008)(76116006)(107886003)(66556008)(86362001)(7696005)(9686003)(2906002)(33656002)(316002)(6506007)(8936002)(38100700002)(52536014)(53546011)(54906003)(122000001)(55016002)(71200400001)(186003)(110136005)(26005)(11716005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kd1LWkO6pCc+a2/9bDZNkFQ6e1X9PqltaSyEVNNTYDQ5xvdO4XoUGY7wNB8X?= =?us-ascii?Q?CACD+LlnsJFX/vQO4ORMXiRG5B60v3VOMlYJGbNaoUZJvbR31UM6hyffaa4V?= =?us-ascii?Q?zLVrxz+ZGb0ZTQuWsxpnIwxw0Tpp5Q7gpLo5f6Hn8aK+WeHfTTnkAHgKt2Ep?= =?us-ascii?Q?mX7lTftQvM60Y4GEyTnH4QDxMV5b9GIZmalksnYIrUigJam+vdzaEnH7mtjw?= =?us-ascii?Q?CiGaNI32D+TdxSLaH4MZXVxFn3Jx7WZ6V02Fl1CkZHrWzsBKr1NwopTcc7Bh?= =?us-ascii?Q?xigxMyRfUT4QDjIEAkCvyTKa6IwRHnBtSouZcqLC3OZmG52MeMTZr3d3Y+bW?= =?us-ascii?Q?+fLYC7mnTylmuMlE6JLHrq/aYkBtrhynLWI0R79a4xMnHZAbxaA0BKvgf5oS?= =?us-ascii?Q?eNbDH+vl8B0wCfDy/VlH52qYh9jjq9LyJjmX0U8PSx6oZLI6SUkNm0HM1tav?= =?us-ascii?Q?EdrNduRXvypqe6nBkOurmE3vyVVhG2p0/I+pUj+HeD4m8eTlpIIWzx/GshnE?= =?us-ascii?Q?hG5yzhqBL6ZsFwsQYqQG2dgmuW/lFANZilHovcyEdUfO9kUaUUvo8imHINMl?= =?us-ascii?Q?5lqMiD9+SRq4Hwr7DqQxvQYWAfHKq/ZGEvf4lQF3n2FQsqYfJLd+s3eaYui6?= =?us-ascii?Q?CPHdhjhHfPpqw/GVGNn4yUA3yc/yVXnd525lVx7ew7bpegnPbQeWlp99dJDN?= =?us-ascii?Q?kUsqOcMLHacTRQkjOw/BNJ5RcZaCgUk/MsZveAdYujUZGyjcnogNrWE26iYo?= =?us-ascii?Q?7BLv7JmNJj3Yq2s7wqUEiHriXJ0331C9mcSMovHlsp6EhUnh3JvtlhDQaZ/f?= =?us-ascii?Q?7qup5bHRCXH2R6StJqSVye+eoWReMZRbgbPbmD+pDwfhvnQb6ul2flMilvMv?= =?us-ascii?Q?L0LzdoNy3slAShngCR2RZbUFNQovbLKyEzqAu38HNCn/vQtVXKFevN35k6kp?= =?us-ascii?Q?F7r9F32rYUk+Hj0dBMSaWqgUrN3PHd1+dSvqkr4E5lGBrQT5OcOLnKLQPODk?= =?us-ascii?Q?XuKoZJ2n13zA93dE8VL/8l8nsH3rvsZtN/VWpBuKTl7SI0x1cVot2CYtUPe+?= =?us-ascii?Q?cfQrvLsDNNvP/uZeY16qv3XDBqj/1Bww9BFd1GxYObl4y+DtcMtEFG2XJNjd?= =?us-ascii?Q?WZQPldY40rSV8SwbQl6XR6C8VwSlqEj3xBUSBWV7P8E3G1k9ytC8fC4iE0qT?= =?us-ascii?Q?OOMl1tii1U0a9d+q0kTSupZEBwdqWNQh46iQA/yyrouzkKDlds7DfvTPghNr?= =?us-ascii?Q?0CXGYpXorzEYP+iwpuEGHliUBBAEzhqJygwAuocf3LpH0mqct8KWXiGCttpq?= =?us-ascii?Q?S90vYjAAO7JqBREI9i7HsOX0?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7eeb76a8-b5a3-4894-1150-08d942a483f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 06:41:00.4122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Oy4IMUd5M1eRh8/OPfWc5pwFHchhS7AUZ1rDYZdMSEOWefLpK27z+eIa+dfQHZR24nQPXZJqY0xvgCGnAmAMjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1571 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Change pushed:=20 8cb431b46a0888a8ee8e442dc3ea50d7de79e473 107af998afe1a34c7b6aff5240abd9918e51b073 Thanks, Chasel > -----Original Message----- > From: Chaganty, Rangasai V > Sent: Friday, July 9, 2021 2:33 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Liming Gao > ; Oram, Isaac W > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build th= is > package. >=20 > Sounds good. >=20 > -----Original Message----- > From: Chiu, Chasel > Sent: Thursday, July 08, 2021 11:32 PM > To: Chaganty, Rangasai V ; > devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Liming Gao > ; Oram, Isaac W > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build th= is > package. >=20 >=20 > Hi Sai, >=20 > We will fix the build failure first and macro naming convention will be > checked separately later. >=20 > Thanks, > Chasel >=20 >=20 > > -----Original Message----- > > From: Chaganty, Rangasai V > > Sent: Friday, July 9, 2021 10:25 AM > > To: Chiu, Chasel ; devel@edk2.groups.io > > Cc: Desimone, Nathaniel L ; Liming Gao > > ; Oram, Isaac W > > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build > > this package. > > > > In ServerManagment.h, please make sure the newly added macros and > > structure names are EFI/PI spec defined. > > If they are not, please remove "EFI_" prefix from the names. > > With that: > > Reviewed-by: Sai Chaganty > > > > -----Original Message----- > > From: Chiu, Chasel > > Sent: Thursday, July 08, 2021 7:41 AM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Chaganty, Rangasai V > > ; Liming Gao > > ; Oram, Isaac W > > Subject: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build > > this package. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3484 > > > > Fixed the build failure of this package. > > > > Cc: Nate DeSimone > > Cc: Sai Chaganty > > Cc: Liming Gao > > Cc: Isaac Oram > > Signed-off-by: Chasel Chiu > > --- > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/P > > eiGenericIpmi.inf | 1 + > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeatu > > re.dsc | 11 +++++++++++ > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerMa > > nagement.h | 17 +++++++++++++++++ > > 3 files changed, 29 insertions(+) > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > > /PeiGenericIpmi.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > > /PeiGenericIpmi.inf > > index 0ef2c18116..bd995ef25f 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > > /PeiGenericIpmi.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > > /PeiGenericIpmi.inf > > @@ -42,6 +42,7 @@ > > DebugLib > > > > IoLib > > > > TimerLib > > > > + ReportStatusCodeLib > > > > > > > > [Guids] > > > > > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > > ture.dsc > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > > ture.dsc > > index a1fcefad70..05a7d4f0af 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > > ture.dsc > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > > ture.dsc > > @@ -59,6 +59,12 @@ > > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > > > > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > > > > > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibId > > PeiServicesTablePointerLib|t/P > > eiServicesTablePointerLibIdt.inf > > > > + > > > ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiR > > eportStatusCodeLib.inf > > > > + > > > > + ##################################### > > > > + # IPMI Feature Package > > > > + ##################################### > > > > + > > > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseL > > ib/PeiIpmiBaseLib.inf > > > > > > > > > [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] > > > > ####################################### > > > > @@ -72,6 +78,11 @@ > > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > > > > > > > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > > /UefiRuntimeServicesTableLib.inf > > > > > > > > + ##################################### > > > > + # IPMI Feature Package > > > > + ##################################### > > > > + > > > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/ > > IpmiBaseLib.inf > > > > + > > > > > > > ########################################################## > > ###################### > > > > # > > > > # Component section - list of all components that need built for this > feature. > > > > diff --git > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > > Management.h > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > > Management.h > > index 244b86e91a..7591f33aba 100644 > > --- > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > > Management.h > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > > Management.h > > @@ -149,6 +149,15 @@ typedef enum { > > #define UPPER_NON_RECOVER_GOING_LOW 0x400 > > > > #define UPPER_NON_RECOVER_GOING_HI 0x800 > > > > > > > > +// > > > > +// Definitions for Get BMC Execution Context > > > > +// > > > > +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 > > > > +// > > > > +// Current Execution Context responses > > > > +// > > > > +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 > > > > + > > > > // > > > > // Server Management COM Addressing types > > > > // > > > > @@ -318,6 +327,14 @@ typedef struct { > > UINT16 IoBasePort; > > > > } IPMI_HOB_DATA; > > > > > > > > +// > > > > +// Constants and Structure definitions for "Get Device ID" command > > +to > > follow here > > > > +// > > > > +typedef struct { > > > > + UINT8 CurrentExecutionContext; > > > > + UINT8 PartitionPointer; > > > > +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; > > > > + > > > > // > > > > // COM Layer Callback > > > > // > > > > -- > > 2.28.0.windows.1