From: "duntan" <dun.tan@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib
Date: Fri, 31 Mar 2023 07:09:59 +0000 [thread overview]
Message-ID: <BN9PR11MB54837CA1328893B2423D005CE58F9@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN6PR11MB8244B6B4B1CEADC8E93526B18C8F9@MN6PR11MB8244.namprd11.prod.outlook.com>
Ray,
Thanks for the comments. I'll modify the code in next version patch set.
Thanks,
Dun
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Friday, March 31, 2023 3:01 PM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Wang, Jian J <jian.j.wang@intel.com>
Subject: RE: [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib
Thanks for the cleanup: 166(+) 679(-).
2 minor comments:
> UINTN
> CreateIdentityMappingPageTables (
> + IN BOOLEAN Is32BitPageTable,
[Ray] Can you change the parameter name as Is64bitPageTable? Because 64bit is the trend, I don't like to say future is "FALSE".
> + MapAttribute.Uint64 = 0;
[Ray] Can you add explicitly "MapAttribute.Bits.Present = 0"?
> + MapMask.Uint64 = 0;
> + MapMask.Bits.Present = 1;
> + if (IsNullDetectionEnabled ()) {
> + CreateOrUpdatePageTable (&PageTable, PagingMode, 0, SIZE_4KB,
> + &MapAttribute, &MapMask); }
>
next prev parent reply other threads:[~2023-03-31 7:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 2:42 [PATCH 0/9] Create page table by CpuPageTableLib in DxeIpl duntan
2023-03-28 2:42 ` [PATCH 1/9] ArmVirtPkg: Add CpuPageTableLib required by DxeIpl in DSC duntan
2023-03-28 6:53 ` Gerd Hoffmann
2023-03-28 11:30 ` duntan
2023-03-28 2:42 ` [PATCH 2/9] EmulatorPkg: " duntan
2023-03-28 2:42 ` [PATCH 3/9] IntelFsp2Pkg: " duntan
2023-03-28 2:56 ` Chiu, Chasel
2023-03-28 2:42 ` [PATCH 4/9] MdeModulePkg: " duntan
2023-03-28 2:42 ` [PATCH 5/9] OvmfPkg: Add CpuPageTableLib required by DxeIpl in DSC file duntan
2023-03-28 2:42 ` [PATCH 6/9] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck duntan
2023-03-31 7:08 ` Ni, Ray
2023-03-28 2:43 ` [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib duntan
2023-03-31 7:01 ` Ni, Ray
2023-03-31 7:09 ` duntan [this message]
2023-03-28 2:43 ` [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX duntan
2023-03-31 7:02 ` Ni, Ray
2023-03-28 2:43 ` [PATCH 9/9] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO duntan
2023-03-31 7:05 ` Ni, Ray
2023-03-31 7:10 ` duntan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB54837CA1328893B2423D005CE58F9@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox