From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.2145.1623371631804041556 for ; Thu, 10 Jun 2021 17:33:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=V92tON5T; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: chasel.chiu@intel.com) IronPort-SDR: YouajlbeFrNv8RPdUQw8yN26pDfYnUFgEAq0IgWM7EvBkJhLM40pMA7NC3jW0WB/b4XH28zKFr lDL+snntEQbA== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="226850996" X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="226850996" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 17:33:49 -0700 IronPort-SDR: GSt8YZv53gBvRlMC6PdtPd8LLOejNL/0w6bt0YEk7x12nh67bP05o9PtxNT39R+PkMAqpxwB8h 2stk0L9Wbzog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="448931704" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 10 Jun 2021 17:33:47 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 10 Jun 2021 17:33:47 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 10 Jun 2021 17:33:47 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 10 Jun 2021 17:33:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DlR78B4XVCAj1PxXX5YMvLKtMW8HC2CclHyZRoCq89CW2k99p9HPCigOnHdnZAoQofFSi5mzaSrUSqmeStZbFr5IjN+ibZOA9gPHVob/5tRrFmqchbuY8ritkzdY0d71C2KvsjFBHaqDq1w3Mt1y3TXkKyVBwryzFKKXLPrMCG9WKADViurkwmH9OgDhovMndFDcKa/PLayR0B1/z8Zcwv8atMOETdh3tSMSS4qE32LOOcE5thv7CrIjyVCfhIZFH0K23d7bU2ZofeA4/JDmV2FXu/WzJqbAQHkDHXnJKYV4eAImBfND9WdcjINC4S5tfwnxBtXeAwODCq396fXz9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xxOC9lliEsB1TDQUo2uRB1qf3yo6gx9AXQqan11e8Tc=; b=W6HY8EYYJC3hK7Mq/9ujf1NYbOfGDn7qnlCYAhb34DLlQE4Z5MxddlUa4AuYn4VG5uqm7sUAejwI2yhCAQxQELndvn1gl849g13ZCEi5SMS6vkbe1pC/woCI+aCYvYGn6QFnwxQ+1+UegO68p6qNXHZzebmGrYkXBwPivcraqVTq4I7EcQIhBRXWIVFvk27RjEZeB08WWRSE2ii5t1isM7p8xN14CVf0N91v+ZES0/IN27KJLU60gvpqODLJ+Nq9T5x/MOEOKI3DkqMIButjBimsX+n5V2d5cZnlRAoyYJGd6qne+DCIuRP+BJwYcwXtcDT7Zk6SKPV07Rclz3Zm1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xxOC9lliEsB1TDQUo2uRB1qf3yo6gx9AXQqan11e8Tc=; b=V92tON5TbBhboEBsxUCevFIVWb/zoL7acO32PSvtc26BMBAoJSkN6WEBh0q8W5WkmdZD1e9rW0CeIF3FuISv0oR9HLb/CCzHlzQhqcU041KUFNJ+2E2kyIKJo2qxrsY64iy4u7xtGsOhZqMa3lMvvuRs2Vdp8eejbPiU/XG6fK0= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB1393.namprd11.prod.outlook.com (2603:10b6:404:3c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 00:33:03 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2162:be61:a479:4168]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2162:be61:a479:4168%9]) with mapi id 15.20.4219.023; Fri, 11 Jun 2021 00:33:03 +0000 From: "Chiu, Chasel" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value Thread-Topic: [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value Thread-Index: AQHXXkptu07mvu6S5EyN59O9cdisdqsN9geg Date: Fri, 11 Jun 2021 00:33:03 +0000 Message-ID: References: <20210610224550.855-1-michael.d.kinney@intel.com> <20210610224550.855-3-michael.d.kinney@intel.com> In-Reply-To: <20210610224550.855-3-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [111.240.64.175] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 12337839-37ff-4dce-5e5e-08d92c707974 x-ms-traffictypediagnostic: BN6PR11MB1393: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: riAaLMgba1qYgnRuUkgVGFSwGCQFy5ihbUtFsL+1gCUSMpHwCQW488WUAZ6S3NDYyQZioD3iyPTqyo6D0DEsDS73g82Ddapv072vDRTf/VLwiCR3p1P0Ckg1PKjmdor8yiZ73+/KO6G5r4eiSgRHa3dJxlZTIEaiLX5zVQpsWN2lBkHLxgd3B97nljRvs01KHfsFL+QyDtKMJ8kloxmSJsMVBcMnyffqnr/FMKph9mWIoZbGCYOJ9BD/75p7NXpbY/vw9O6VI8mxafzDOZ418eFABlZURgpK6xjEZ6pBvr470wmeIEF/cQDtf/7dc1cPMWBtWYZbm5xSa2wTuTuezh7me16QnV76NPsdeeobBsP89p8GatCNp+Cnm3IKEhtGFPp66mBDuHdt/BUhWKpmw6N4zLDx+T79XvAn9yMZk03ZW8gmYEIMXVc5EqJwcCT4bWJBXsoTZeiW7ipoB8I/f7JJTud3zKbdruzF2WVsS+wM8BBijgaS6q5YwqMZA2VLjj8teez2aixpyVPJkavD/yl6FSJNu5BlciPkDkgdl/XRw5rgvITCn20j0EfujhNgP2y7+rYYux5+m7UHGKZJrfBTQr9nW+m8GSz2xRYeIJaPRO9RnP4XsHcuYbb82p8TqfjCfHb9uDtKyVgr2aLIwRvG+6BnjBUGhMvo2zw+LIloHH/ilRTziO6d0B8n/iJ/ESymhpR7TMTRYlnXOk798g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(396003)(136003)(376002)(39860400002)(346002)(55016002)(122000001)(71200400001)(83380400001)(7696005)(38100700002)(52536014)(6506007)(33656002)(4326008)(107886003)(26005)(2906002)(110136005)(86362001)(9686003)(66476007)(53546011)(8676002)(478600001)(316002)(76116006)(966005)(5660300002)(186003)(64756008)(66556008)(66446008)(66946007)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?54v6IuDd54L9B1gDCWK+M2tW5X8DD7f2AmnVnaWa7/9jMsElHpL3eaubSb+8?= =?us-ascii?Q?4w9OUbmwUKvAVZYtcDSgsPNtoAIa74NPrLfeoTRbC/AOE9AEYQoHh8ICB/bv?= =?us-ascii?Q?3cuvXNF5FJesaH2RCoOtxsZb55uebNCb6Qvn3DErlk5Nxy3oqoRjzsL2IUz7?= =?us-ascii?Q?JnkIXfPesjn9KUGUpTC6zreXiRgevJgfDMWf+eEYsIT1fFps9XcxA6pnCw/l?= =?us-ascii?Q?VaE56g1POYq7Pf0UsxjI9US9zuagJrVfGXWngMCoiQMxU4JKHvSgPdstGEXy?= =?us-ascii?Q?mHXIlsDFJBs8sWvzLYDiA+2U5OG7X7yM6UkDSkUZjh0qbWRaF7SGmxQsdmGK?= =?us-ascii?Q?x4i9XCS3NW3nOznRqM00tjrFwhuIryRXBESJh6Hz4wFlvDqqMAl2nIM7MU6b?= =?us-ascii?Q?SUi1ofV3VH8EiWfEAUiK12NdDDbJ19SG2sHrjN6/FCQVxts4tavoRR/R15VG?= =?us-ascii?Q?IdYznv2eE4ejnFC1OqqlAYsv3dmX7pmE/ZEJXQkkiSyem6218M7F9NRpGE5o?= =?us-ascii?Q?VQttiShudLSGwrm3qqcLwpgOL5c5apKnZ6EBjZPw9jB8tXsSjIR3gXVjOGyV?= =?us-ascii?Q?HJ3r/mnPlGVCq7HW5p7BySQADJwNBOZMbMUvlkUVXHc9PyemUpt7qCuBwXG/?= =?us-ascii?Q?UnsJd2RqtfMi46Mh9ygw86263PI1rZCbwJAeeY3tU4djiZXX15JOG6tlkPL7?= =?us-ascii?Q?H6cUY+MmJe0V6Ww/6ZszGWiJgmkr2XEXbFkUvZVEO2M8Tu48SEC/oDp7iA+K?= =?us-ascii?Q?o8Wm/J7rx9X4CSkQdQyDNbGl3Xj/5zQ5YYNm4sp38sY1eUe/Q1kafQ4Q3TN9?= =?us-ascii?Q?HrL7gi8jmZ1Z9J0zHvgFs8HI+NqArQ/+CnpA8Qdop8+hhrfC+Qbh4yHeiGBr?= =?us-ascii?Q?NyUeYkHxMk/FkZOs/6SbBeIhP7/m6ER+45ECAYzvL3CiyZG7EmZBTkRrCNgi?= =?us-ascii?Q?PhUKmMrb7pO5yMm35bKpFXo0/NH+L1wKW8Aa7kF0IS+FORUyF0HDpX5dKxYp?= =?us-ascii?Q?VdmKffoSJpqnaDI7sot3aIPs12tGjiYCt5ZnzqdQ+FHxbNN+sZC2bacZQz4S?= =?us-ascii?Q?HVGBWIPw7FdoC4S2TjmV4ilKGMpJjdcbX9+M0KUgprZkg7+JAGAIawVFtPcc?= =?us-ascii?Q?0K6XP8eUXPlhSnUKYbAnuR/CZNmCZQqU0+i12tO1N/ehJJEIO85pTJ2D8Aem?= =?us-ascii?Q?HZMrYcKFDX1RWg8Q5ue8V4TaFTYBsFlNAJg0FxvVwZQbX++lzj52vW1QzDEz?= =?us-ascii?Q?5mci8Q58F3D+149gzkWlv+Om0o9V00F7PWyn5O30KhQPwIJLWvOnXYMfbe7V?= =?us-ascii?Q?mFyO4l7xwvWZUROrOgvcIOkW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12337839-37ff-4dce-5e5e-08d92c707974 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2021 00:33:03.3303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sy/DUZ+lR0Yj6LjsVIXtHx/KRWQ9igFk5QgdZ1Liz5+NX3hGxU15QUfxuo1RZtLoTrInfitvZpEBCW5LiYaY5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1393 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, June 11, 2021 6:46 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: Fix > SmBusSendByte value >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3451 >=20 > Update SmBusSendByte() to write value to Command Register instead of Host > Data registers. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Michael D Kinney > --- > .../Pch/Library/BaseSmbusLib/BaseSmbusLib.c | 24 +++++++++++++------ > 1 file changed, 17 insertions(+), 7 deletions(-) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSmbusLib.= c > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSmbusLib.= c > index 5d09e18613..68dc698aaf 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSmbusLib.= c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseSmbusLib/BaseSmbu > +++ sLib.c > @@ -201,14 +201,24 @@ InternalSmBusNonBlock ( > HostControl |=3D B_PCH_SMBUS_PEC_EN; > } > // > - // Set Host Commond Register. > + // We do not need Data Register for SendByte Command > // > - IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HCMD, (UINT8) > SMBUS_LIB_COMMAND (SmBusAddress)); > - // > - // Write value to Host Data 0 and Host Data 1 Registers. > - // > - IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HD0, (UINT8) Value); > - IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HD1, (UINT8) (Value >> 8)); > + if ((HostControl =3D=3D V_PCH_SMBUS_SMB_CMD_BYTE) && ((SmBusAddress & > BIT0) =3D=3D B_PCH_SMBUS_WRITE)) { > + // > + // Set Host Command Register. > + // > + IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HCMD, (UINT8)Value); } > + else { > + // > + // Set Host Command Register. > + // > + IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HCMD, (UINT8) > SMBUS_LIB_COMMAND (SmBusAddress)); > + // > + // Write value to Host Data 0 and Host Data 1 Registers. > + // > + IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HD0, (UINT8) Value); > + IoWrite8 (IoPortBaseAddress + R_PCH_SMBUS_HD1, (UINT8) (Value >> > + 8)); } > // > // Set Auxiliary Control Regiester. > // > -- > 2.31.1.windows.1