From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.7314.1670569281965097477 for ; Thu, 08 Dec 2022 23:01:22 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Dy1fLqnu; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670569282; x=1702105282; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=GiqIDBGV1CNoONcIz38YrBBgwQpKFL9U/0bfvypCtiU=; b=Dy1fLqnu67S+1WixSShncPaUBunMYAeDtVMDwlCysWGrR+GXfFMSbjN4 KHzh3CI92KKlho7pvmv9fg9nYDB3ssQi5Lab1LQks3YVtMmPY8fLdqooR S2wFV40nw1/hVqn0Xx724dNfecD7s7+xnmlRSFuLqYM7L6PgMZABiIQRn PVe4FJELjz+xpzd2+xCsrS2a7PWp+gO9sMMrZ2SrSy7URhTAiOPr95Onv gar+JagxaQ7rJeCimkAF/VB7AKhj3+WukjzNU+CzzZeqFQ7TGQSYjii3S pOv4fzB6Bw+tzdtrEaNxSOSmN5g2F8cVCSOm09TLaYkB0cc79+7O7VBit Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="315033625" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208,217";a="315033625" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 23:01:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10555"; a="821638830" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208,217";a="821638830" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 08 Dec 2022 23:01:13 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 8 Dec 2022 23:01:13 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 8 Dec 2022 23:01:13 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 8 Dec 2022 23:01:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nflx6AFLifyY4P7KCLIDa4T3q06XJwUBw/NMYLzlq+zuiGZ1em2EurktHnWYL2ldkBx5rCHdL1jbtIk0d/jbaJPR4mgRvee8tdCZ6K98rCHPT78LTfQKD6ldjvoJnEJvSqdnUFb1jR17CjgpHUYhmnXoHCzye40jKPDrOCI4BVKquxbwz4PzuQq7mLVWXmSBqs1JSjdKQxLFBWmY6R+f0rwgdta/2Ie/4uozUKL9+eTzXzjzKgyPr7xAl8VialnSFl1aHUn/pMFgwVlvvHJxarDUDa6eDP1glT+FxCCqmxFU+0n/jF5Jrs8vC439o2oCRyzaqh5KiP25R2qWO6wFrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zB/Yguk5l4FyuxyGFdaxUHcR5BXw+1Kill2uYVVRumk=; b=WBnZbL+PCKXr8NrVC+BaUvSeiWodjqtEcuXRpMqoW4OiCDOjvyaJDdMnf0Sijhz7e7BlY252YZb93gFzWV10bwqgRzO47sR5oPwqRGUAEhglIfc1oS4JwMDMxZ4Lr60Tf/GmlMzutc6cyAgTNdqnGn3Zn68NavqQX64c5t299P2o2zlxs7aj7rZ+nF3Gf5zHb7OlgfuvxGbYfsAKFBDocme7iLR7u3TV5SKnzemnOx8fotm0hk7YALeFl5GOLnnIYzvt7c8sTHAxN54NrEKI62nKHDfLQakIlX6QnEzN8lch/o1BCX+sDyvD7fAMI7wTAIhmgL/xOhaww6w7ANldBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SA3PR11MB7535.namprd11.prod.outlook.com (2603:10b6:806:307::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Fri, 9 Dec 2022 07:01:10 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c945:6fc3:ca84:dd9b]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c945:6fc3:ca84:dd9b%9]) with mapi id 15.20.5880.018; Fri, 9 Dec 2022 07:01:10 +0000 From: "duntan" To: Sean Brogan , Michael Kubacki , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI template for Shell UnitTest Thread-Topic: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI template for Shell UnitTest Thread-Index: AQHY/mhQafQCh/tB5USXUEAXEUkBHq5UG2DAgAqgsFCAAWnagIAALTOggAMRpICAAFcRkIAA8gzBgACKUVA= Date: Fri, 9 Dec 2022 07:01:10 +0000 Message-ID: References: <20221122114737.393-1-dun.tan@intel.com> <1729E5B1AD6A86B6.31464@groups.io> <5ef65ca6-886d-7be2-6b5c-07432788b9d0@linux.microsoft.com> <6220396f-5602-d23a-ad74-4e455ebf28a8@linux.microsoft.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-12-08T22:37:00.735Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SA3PR11MB7535:EE_ x-ms-office365-filtering-correlation-id: 814dac2b-9dbc-420e-4fd4-08dad9b32709 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T9Nd2BRCE0GUCnWUZEOpQr1CuRL/wB84BWfXAHSSdFvd1PaQqRjDNMeQ8J1MhkXYOIVh9d5aJfwK12LJdOKxxoGvDFrcH99qWeTw617gsOySJ61sY8+11P8UuLA51sgfV+8ByonEEfdCWEIpsyYOJJa9R157E1A91k66oXISBewgFHFQCAWcZQT97KiO1Ft/8I5FnLGGa5TepjYOtOFj/6xopXX9bS3iyG1VSZUpB925/IDD7OP0IMUzYkGJXJ6NsJuByeLZUDrGUmLx2MLoPxipgDiBMZGAoAQ3INsmsxzPWm0Zq/0LtMgFGog0/D29gnEGfguBOxPWW0etAznOLe7+iU3p46qHapWhAnBNsu3FKm1ksG3jY/ZC2vtsS/aVSrt4b3xSHBrX57p11gpIVlxJAXgAyKW2OplRgrWTP2c9ZWNlPVt9I9bVzDW5uOemgajQ8cGhnMN7Cq7LSigLLztrBpe3qiMd7QwDLEoeGu2XCtBekeoQe9bZVwNN//xvkm+iyv70zdmK7bGXP36ggEibreB/L6Wme6NUqTCS0spUy72yOjeGr42VvkU6AQL5nUjKh4P/TLuEXLbPeXePo7TAetnRFOT8Y0ldcjSmiN30qXl2IkOmJd5SQ90jW9Ik8gAtpln4VYzH5AcTP6/5998+05wvnvvHT813c1JWJ81eI8A2gK6g4tGr/lVrXf9W84rgOyOHtQVz12DRU2LbYcwLewXIZ2yPyPxd2MIK1ya0jo/aLtEtXlOwQaJN4Wj1qVXNrMDantqA+bKSvRP95A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199015)(1690799008)(71200400001)(966005)(45080400002)(107886003)(316002)(7696005)(83380400001)(66556008)(53546011)(6506007)(66899015)(8676002)(478600001)(52536014)(66946007)(76116006)(41300700001)(4326008)(9326002)(186003)(8936002)(30864003)(2906002)(66476007)(64756008)(5660300002)(66446008)(38100700002)(55016003)(33656002)(82960400001)(122000001)(54906003)(26005)(9686003)(19627235002)(110136005)(166002)(38070700005)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?snEZ2nFw5BY4GP+ZoaSvUjwb1annGMQ8gZ7+iM2u7xNqhvesG+qC4A3Csu8t?= =?us-ascii?Q?ZLBoxuSAHTtZ0TfwLN7TFR1GuKW8XueUUrjEkkg1H6642rv3EAtq60LBvBKn?= =?us-ascii?Q?BOc/UF1/qL5o6GD62JES+3OZWu3BvzoKvTXeDcI9/9qL+s4UQLtVRVzjT0jj?= =?us-ascii?Q?bDrFJyCtCnWiBxbKfwpdoAPbQYyZ48/N/bbs+CjGXqGKawbt5NONzRB8crLS?= =?us-ascii?Q?YD9dvDkqUix+nYc8fMCiRJPTjeeG7ACvkaGK4x7GC0P3eQzR41BTtTljCByG?= =?us-ascii?Q?NgXvoMwAlQXEi8Jbqd5pyD3A/OaJnyyeM3za2ToCw0p7RzJq+/07u+O8PCen?= =?us-ascii?Q?sTeZruFend/VjPuPDA0TLQQFrR/THbBSvRAZ7zSUMeqqIf0NGc4Y9c94zVne?= =?us-ascii?Q?LqiK/kr/JbE/GtKibj37Ln22Aeb3+eveSRIfWzDI4WwuUSQoBdNLrFHr8Loh?= =?us-ascii?Q?Q25TukORXkU51e3OKm96FulG0lIIecr0TN2EHppIldWHMsg/w9osuppSXTrW?= =?us-ascii?Q?iBfpEDPl2z/Qje2G32Mho8WWKHI7jo5DciD/BcMXMcWq0ggvEemQQcw+8RsP?= =?us-ascii?Q?sDUEnCffkjlDDQUB/k3eIFNzBl6fmjBic3MB0mEDSkSPUNfReMldK/1hpvbv?= =?us-ascii?Q?u30XIRN2rvXMYS4BFhFF8q8ezY1ExHfy9+uvX/T8B+QBA/mVdz5FvE6jiQg1?= =?us-ascii?Q?4IoxqmFbwcglI5cpWL7a0K3sr9L+7UltGEg7PWd+vKvWGDW/E1Ti1ZfY0Tmn?= =?us-ascii?Q?Mn4KOXelQAr2SYdbW1+N4xr2ZAzYC2Kg8k2HS4PqzBrvMXCI3/2kV3SyyyrL?= =?us-ascii?Q?Jy7dy56jg2KYP7LFrD4o5VbrYDdGEp6+QwhE/Y17vPxEPsi8dTW856Lv1A5W?= =?us-ascii?Q?/pc+B5zIdHY+tARYCo3Dw5y+7Pn6um01tApjdzY98p8AWyR1vLjvfCa0gi8Y?= =?us-ascii?Q?Dgf8nBzeqvXS9mpjOlvDM+PYwkq2m+IVXG4TqQUhh+xS4YZgdqteirqp2Rcz?= =?us-ascii?Q?1W1Qly/H0OUyPak04s2zFvcefYt9h/5q/aVyoXv/M7fTqPpA6l70vdr9XWn5?= =?us-ascii?Q?HmqGuJ/Iw5eNXLyt85JrX0N3h0FBoMiE/BnrATMZ6KsXWN2o955GECTmCA3K?= =?us-ascii?Q?H33U7Kvr9kACwDl8D+CMP1dck923eFBlXGR6+5Kt4igRpjjTFwZIlkudGZ0Z?= =?us-ascii?Q?frrNDmd+CbcZiE9PtTX7eNcKt4iQEf5JNPUclQ6CrH4+yr/OnglBvDYYRnM4?= =?us-ascii?Q?//yI72aCLwLjF80kt6VIA3NCYDUyTjx0KAjbb2MZ4yiECu7SA9rIoCeiWv1O?= =?us-ascii?Q?W5KpVKmcDupGrwglEsE2/JMbdbJJHnnN8G7Hp3zRdWAVkY38AFmooDQ7W+wl?= =?us-ascii?Q?bHXuKfCCCGuzj9tEVdPI1cKq954V3iJumhe9+PqupYjpjEekN4LPQoz7qeF8?= =?us-ascii?Q?Wr+dAEXuPp/C9CFCK9IWGAQu3OtCeM0GE4OY2zhyfRRVVTAO22BEffWrSYLi?= =?us-ascii?Q?Lu+BNljQNix4AEW8KoyXcmjG+DCDTk1ROjU/ZdmHH6uXsWmxNVHji5HNzi9X?= =?us-ascii?Q?9fubNdeQ3J9xXECCBBU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 814dac2b-9dbc-420e-4fd4-08dad9b32709 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2022 07:01:10.3329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jjdLh982BX8mG3m/Y/JhCZ1g7oFVMmreOBfTEzVsKNnXZeTMYvKK0u5/RE/3QyyE73mQpCy/yKL4vvqLg4ymaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7535 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN9PR11MB54837FAF1583F07F864E085CE51C9BN9PR11MB5483namp_" --_000_BN9PR11MB54837FAF1583F07F864E085CE51C9BN9PR11MB5483namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sean, Thank you for creating this discussion. Looking forward to more feedback fr= om community. Thanks, Dun From: Sean Brogan Sent: Friday, December 9, 2022 6:37 AM To: Tan, Dun ; Michael Kubacki ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Ni, Ray Subject: Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI te= mplate for Shell UnitTest Dun, I created this discussion on github hoping that others might have ideas/fee= dback. Integrate target-based testing into Platform CI for Edk2 using OVMF * Discu= ssion #3739 * tianocore/edk2 (github.com) Lets use that to discuss and then on monday we can talk more if needed. Thanks Sean [https://opengraph.githubassets.com/1743f87e9d9139f88783fef5e0cdeb31d956f01= 6a4ea69c0c5489778f4834eb7/tianocore/edk2/discussions/3739] Integrate target-based testing into Platform CI for Edk2 using OVMF * Discu= ssion #3739 * tianocore/edk2 Starting a discussion here to see if more individuals in the community have= opinions on how best to integrate target-based testing into edk2 CI. There= is a current proposed patch on the mailing lis... github.com ________________________________ From: Tan, Dun > Sent: Thursday, December 8, 2022 12:17 AM To: Michael Kubacki >; devel@edk2.groups.io > Cc: Sean Brogan >; Kinney, Michael D >; Gao, Liming >; Ni, Ray > Subject: [EXTERNAL] RE: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand Pl= atformCI template for Shell UnitTest Thank you and Sean a lot! I'll attend the CI meeting if there is any open. Thanks, Dun -----Original Message----- From: Michael Kubacki > Sent: Thursday, December 8, 2022 10:57 AM To: devel@edk2.groups.io; Tan, Dun > Cc: Sean Brogan >; Kinney, Michael D >; Gao, Liming >; Ni, Ray > Subject: Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI te= mplate for Shell UnitTest Hi Dun, Sean Brogan and I have some feedback we'll send soon after we sync on it. I= f anything is still open as of the upcoming TianoCore tools & CI meeting an= d you're able to attend, we can talk there as well. Thanks, Michael On 12/5/2022 11:46 PM, duntan wrote: > Hi Michael, > Thanks for the reply! In the following PR, I added an unit test list in t= he new OvmfPkg platform CI JOB. In PlatformCI_OvmfPkg_Ubuntu_GCC5_PR and P= latformCI_OvmfPkg_Windows_VS2019_PR, the CI for specific unit test list was= triggered. > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.com%2Ftianocore%2Fedk2%2Fpull%2F3651&data=3D05%7C01%7Csean.brogan%40micro= soft.com%7C884211b3375b4f0618de08dad8f4bdea%7C72f988bf86f141af91ab2d7cd011d= b47%7C1%7C0%7C638060842928005678%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD= AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D%2= FPbU3fGHlHv5%2FlKn8tvUdEO6%2Ff2SjCAzc7u2KVRxyK0%3D&reserved=3D0 > > Thanks, > Dun > > -----Original Message----- > From: Michael Kubacki > > Sent: Tuesday, December 6, 2022 9:24 AM > To: devel@edk2.groups.io; Tan, Dun > > Cc: Sean Brogan >; Kinney, Michael D > >; Gao, Lim= ing >; > Ni, Ray > > Subject: Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand > PlatformCI template for Shell UnitTest > > Sorry for the delay Dun. Can you please share an edk2 pull request with t= his change? > > Thanks, > Michael > > On 12/4/2022 10:57 PM, duntan wrote: >> Hi all, >> Is there anything else I can do to speed up the review process for this = patch set? Looking forward to your reply. >> >> Thanks, >> Dun >> -----Original Message----- >> From: Tan, Dun >> Sent: Monday, November 28, 2022 5:34 PM >> To: devel@edk2.groups.io; Tan, Dun > >> Cc: Sean Brogan >; Michael Kubacki >> >; Kin= ney, Michael D >> >; Gao, Li= ming >; >> Ni, Ray > >> Subject: RE: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand >> PlatformCI template for Shell UnitTest >> >> Hi all, >> Could you please help to review this patch? Thanks a lot! >> >> Thanks, >> Dun >> >> -----Original Message----- >> From: devel@edk2.groups.io > On Behalf Of duntan >> Sent: Tuesday, November 22, 2022 7:48 PM >> To: devel@edk2.groups.io >> Cc: Sean Brogan >; Michael Kubacki >> >; Kin= ney, Michael D >> >; Gao, Li= ming >; >> Ni, Ray > >> Subject: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI >> template for Shell UnitTest >> >> Expand PlatformCI build and run steps template for Shell UnitTest. Add a= new parameter unit_test_list to support building and running specific Shel= l UnitTest modules. >> >> In stuart_pr_eval step, if the unit_test_list passed from platform yml f= ile is not null, it will select some packages from the packages which conta= in the module in unit_test_list and set them into a new variable pkgs_to_bu= ild base on its evaluation rule. >> In stuart_build step, if unit_test_list is not null, '${{ parameters.uni= t_test_list}} -p $(pkgs_to_build)' will be added into the arguments to buil= d specific UnitTest modules in pkgs_to_build. >> In 'Run to shell' step, if unit_test_list is not null, all the UnitTest = modules built in stuart_build step will runs in shell. >> >> Signed-off-by: Dun Tan > >> Cc: Sean Brogan > >> Cc: Michael Kubacki > >> Cc: Michael D Kinney > >> Cc: Liming Gao > >> Cc: Ray Ni > >> --- >> .azurepipelines/templates/platform-build-run-steps.yml | 21 +++++++++= ++++++++---- >> 1 file changed, 17 insertions(+), 4 deletions(-) >> >> diff --git a/.azurepipelines/templates/platform-build-run-steps.yml >> b/.azurepipelines/templates/platform-build-run-steps.yml >> index 40a31a509f..51503287c4 100644 >> --- a/.azurepipelines/templates/platform-build-run-steps.yml >> +++ b/.azurepipelines/templates/platform-build-run-steps.yml >> @@ -30,6 +30,9 @@ parameters: >> - name: run_flags >> type: string >> default: '' >> +- name: unit_test_list >> + type: string >> + default: '' >> >> - name: extra_install_step >> type: stepList >> @@ -49,7 +52,9 @@ steps: >> displayName: 'Install/Upgrade pip modules' >> >> # Set default >> -- bash: echo "##vso[task.setvariable variable=3Dpkg_count]${{ 1 }}" >> +- bash: | >> + echo "##vso[task.setvariable variable=3Dpkg_count]${{ 1 }}" >> + echo "##vso[task.setvariable variable=3Dpkgs_to_build]${{ 'all' }}" >> >> # Fetch the target branch so that pr_eval can diff them. >> # Seems like azure pipelines/github changed checkout process in nov 2= 020. >> @@ -62,7 +67,7 @@ steps: >> displayName: Check if ${{ parameters.build_pkg }} need testing >> inputs: >> filename: stuart_pr_eval >> - arguments: -c ${{ parameters.build_file }} -t ${{ parameters.build_= target}} -a ${{ parameters.build_arch}} --pr-target origin/$(System.PullReq= uest.targetBranch) --output-count-format-string "##vso[task.setvariable var= iable=3Dpkg_count;isOutpout=3Dtrue]{pkgcount}" >> + arguments: -c ${{ parameters.build_file }} -t ${{ >> + parameters.build_target}} -a ${{ parameters.build_arch}} >> + --pr-target >> + origin/$(System.PullRequest.targetBranch) >> + --output-count-format-string "##vso[task.setvariable variable=3Dpkg_co= unt;isOutpout=3Dtrue]{pkgcount}" >> + --output-csv-format-string "##vso[task.setvariable >> + variable=3Dpkgs_to_build]{pkgcsv}" ${{ parameters.unit_test_list}} >> condition: eq(variables['Build.Reason'], 'PullRequest') >> >> # Setup repo >> @@ -97,14 +102,22 @@ steps: >> inputs: >> filename: stuart_build >> arguments: -c ${{ parameters.build_file }} TOOL_CHAIN_TAG=3D${{ >> parameters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}} -a >> ${{ parameters.build_arch}} ${{ parameters.build_flags}} >> - condition: and(gt(variables.pkg_count, 0), succeeded()) >> + condition: and(and(gt(variables.pkg_count, 0), succeeded()), >> + eq(variables.unit_test_list, '')) >> + >> +# Build specific pkg for UnitTest >> +- task: CmdLine@1 >> + displayName: Build UnitTest >> + inputs: >> + filename: stuart_build >> + arguments: ${{ parameters.unit_test_list}} -p $(pkgs_to_build) >> +-c ${{ parameters.build_file }} TOOL_CHAIN_TAG=3D${{ >> +parameters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}} -a >> +${{ parameters.build_arch}} ${{ parameters.build_flags}} >> + condition: and(and(gt(variables.pkg_count, 0), succeeded()), >> +not(eq(variables.unit_test_list, ''))) >> >> # Run >> - task: CmdLine@1 >> displayName: Run to shell >> inputs: >> filename: stuart_build >> - arguments: -c ${{ parameters.build_file }} TOOL_CHAIN_TAG=3D${{ par= ameters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}} -a ${{ para= meters.build_arch}} ${{ parameters.build_flags}} ${{ parameters.run_flags }= } --FlashOnly >> + arguments: -c ${{ parameters.build_file }} TOOL_CHAIN_TAG=3D${{ >> + parameters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}} -a >> + ${{ parameters.build_arch}} ${{ parameters.build_flags}} ${{ >> + parameters.run_flags }} --FlashOnly ${{ parameters.unit_test_list}} >> condition: and(and(gt(variables.pkg_count, 0), succeeded()), eq(var= iables['Run'], true)) >> timeoutInMinutes: 1 >> >> -- >> 2.31.1.windows.1 >> >> >> >> >> >> >> >> >> >> > > >=20 > > --_000_BN9PR11MB54837FAF1583F07F864E085CE51C9BN9PR11MB5483namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Sean,

Thank you for creating this discussion. Looking for= ward to more feedback from community.

 

Thanks,

Dun

 

From: Sean Brogan <sean.brogan@microsoft.c= om>
Sent: Friday, December 9, 2022 6:37 AM
To: Tan, Dun <dun.tan@intel.com>; Michael Kubacki <mikuback= @linux.microsoft.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Limin= g <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand Platfo= rmCI template for Shell UnitTest

 

Dun,

 

I created this discussion on github hoping that oth= ers might have ideas/feedback.  

 

Lets use that to discuss and then on monday we can talk more if needed.&= nbsp;

 

Thanks

Sean

 

 

Starting a discussion here to see if= more individuals in the community have opinions on how best to integrate t= arget-based testing into edk2 CI. There is a current proposed patch on the mailing lis...

github.com

 

From: Tan, Dun <d= un.tan@intel.com>
Sent: Thursday, December 8, 2022 12:17 AM
To: Michael Kubacki <mikuback@linux.microsoft.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sea= n.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming &l= t;gaoliming@byosoft.com.cn&= gt;; Ni, Ray <ray.ni@intel.com> Subject: [EXTERNAL] RE: [edk2-devel] [PATCH 3/3] .azurepipelines: Ex= pand PlatformCI template for Shell UnitTest

 

Thank you and Sean a lot! I'll attend the CI meeting= if there is any open.

Thanks,
Dun
-----Original Message-----
From: Michael Kubacki <m= ikuback@linux.microsoft.com>
Sent: Thursday, December 8, 2022 10:57 AM
To: devel@edk2.groups.io; Tan, = Dun <dun.tan@intel.com>
Cc: Sean Brogan <sean.broga= n@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com> Subject: Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI te= mplate for Shell UnitTest

Hi Dun,

Sean Brogan and I have some feedback we'll send soon after we sync on it. I= f anything is still open as of the upcoming TianoCore tools & CI meetin= g and you're able to attend, we can talk there as well.

Thanks,
Michael

On 12/5/2022 11:46 PM, duntan wrote:
> Hi Michael,
> Thanks for the reply! In the following PR, I added an unit test list i= n the new OvmfPkg platform CI JOB. In  PlatformCI_OvmfPkg_Ubuntu_GCC5_= PR and PlatformCI_OvmfPkg_Windows_VS2019_PR, the CI for specific unit test = list was triggered.
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Ftianocore%2Fedk2%2Fpull%2F3651&data=3D05%7C01%7Csean.brogan%40mic= rosoft.com%7C884211b3375b4f0618de08dad8f4bdea%7C72f988bf86f141af91ab2d7cd01= 1db47%7C1%7C0%7C638060842928005678%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw= MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdat= a=3D%2FPbU3fGHlHv5%2FlKn8tvUdEO6%2Ff2SjCAzc7u2KVRxyK0%3D&reserved=3D0
>
> Thanks,
> Dun
>
> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com>
> Sent: Tuesday, December 6, 2022 9:24 AM
> To: devel@edk2.groups.io; = Tan, Dun <dun.tan@intel.com>=
> Cc: Sean Brogan <sean.= brogan@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@int= el.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Ni, Ray <ray.ni@intel.com&g= t;
> Subject: Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand
> PlatformCI template for Shell UnitTest
>
> Sorry for the delay Dun. Can you please share an edk2 pull request wit= h this change?
>
> Thanks,
> Michael
>
> On 12/4/2022 10:57 PM, duntan wrote:
>> Hi all,
>> Is there anything else I can do to speed up the review process for= this patch set? Looking forward to your reply.
>>
>> Thanks,
>> Dun
>> -----Original Message-----
>> From: Tan, Dun
>> Sent: Monday, November 28, 2022 5:34 PM
>> To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com= >
>> Cc: Sean Brogan <s= ean.brogan@microsoft.com>; Michael Kubacki
>> <mikuback@linux= .microsoft.com>; Kinney, Michael D
>> <michael.d.kinney= @intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
>> Ni, Ray <ray.ni@intel.com>
>> Subject: RE: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand
>> PlatformCI template for Shell UnitTest
>>
>> Hi all,
>> Could you please help to review this patch? Thanks a lot!
>>
>> Thanks,
>> Dun
>>
>> -----Original Message-----
>> From: devel@edk2.groups.io= <devel@edk2.groups.io&g= t; On Behalf Of duntan
>> Sent: Tuesday, November 22, 2022 7:48 PM
>> To: devel@edk2.groups.io
>> Cc: Sean Brogan <s= ean.brogan@microsoft.com>; Michael Kubacki
>> <mikuback@linux= .microsoft.com>; Kinney, Michael D
>> <michael.d.kinney= @intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
>> Ni, Ray <ray.ni@intel.com>
>> Subject: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand Platform= CI
>> template for Shell UnitTest
>>
>> Expand PlatformCI build and run steps template for Shell UnitTest.= Add a new parameter unit_test_list to support building and running specifi= c Shell UnitTest modules.
>>
>> In stuart_pr_eval step, if the unit_test_list passed from platform= yml file is not null, it will select some packages from the packages which= contain the module in unit_test_list and set them into a new variable pkgs= _to_build base on its evaluation rule.
>> In stuart_build step, if unit_test_list is not null, '${{ paramete= rs.unit_test_list}} -p $(pkgs_to_build)' will be added into the arguments t= o build specific UnitTest modules in pkgs_to_build.
>> In 'Run to shell' step, if unit_test_list is not null, all the Uni= tTest modules built in stuart_build step will runs in shell.
>>
>> Signed-off-by: Dun Tan <du= n.tan@intel.com>
>> Cc: Sean Brogan <s= ean.brogan@microsoft.com>
>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <gao= liming@byosoft.com.cn>
>> Cc: Ray Ni <ray.ni@intel.co= m>
>> ---
>>    .azurepipelines/templates/platform-build-run-ste= ps.yml | 21 +++++++++++++++++----
>>    1 file changed, 17 insertions(+), 4 deletions(-)=
>>
>> diff --git a/.azurepipelines/templates/platform-build-run-steps.ym= l
>> b/.azurepipelines/templates/platform-build-run-steps.yml
>> index 40a31a509f..51503287c4 100644
>> --- a/.azurepipelines/templates/platform-build-run-steps.yml
>> +++ b/.azurepipelines/templates/platform-build-run-steps.yml
>> @@ -30,6 +30,9 @@ parameters:
>>    - name: run_flags
>>      type: string
>>      default: ''
>> +- name: unit_test_list
>> +  type: string
>> +  default: ''
>>   
>>    - name: extra_install_step
>>      type: stepList
>> @@ -49,7 +52,9 @@ steps:
>>      displayName: 'Install/Upgrade pip mo= dules'
>>   
>>    # Set default
>> -- bash: echo "##vso[task.setvariable variable=3Dpkg_count]${= { 1 }}"
>> +- bash: |
>> +    echo "##vso[task.setvariable variable=3Dp= kg_count]${{ 1 }}"
>> +    echo "##vso[task.setvariable variable=3Dp= kgs_to_build]${{ 'all' }}"
>>   
>>    # Fetch the target branch so that pr_eval can di= ff them.
>>    # Seems like azure pipelines/github changed chec= kout process in nov 2020.
>> @@ -62,7 +67,7 @@ steps:
>>      displayName: Check if ${{ parameters= .build_pkg }} need testing
>>      inputs:
>>        filename: stuart_pr_eval=
>> -    arguments: -c ${{ parameters.build_file }} -t = ${{ parameters.build_target}} -a ${{ parameters.build_arch}} --pr-target or= igin/$(System.PullRequest.targetBranch) --output-count-format-string "= ##vso[task.setvariable variable=3Dpkg_count;isOutpout=3Dtrue]{pkgcount}&quo= t;
>> +    arguments: -c ${{ parameters.build_file }} -t = ${{
>> + parameters.build_target}} -a ${{ parameters.build_arch}}
>> + --pr-target
>> + origin/$(System.PullRequest.targetBranch)
>> + --output-count-format-string "##vso[task.setvariable variab= le=3Dpkg_count;isOutpout=3Dtrue]{pkgcount}"
>> + --output-csv-format-string "##vso[task.setvariable
>> + variable=3Dpkgs_to_build]{pkgcsv}" ${{ parameters.unit_test= _list}}
>>      condition: eq(variables['Build.Reaso= n'], 'PullRequest')
>>   
>>     # Setup repo
>> @@ -97,14 +102,22 @@ steps:
>>      inputs:
>>        filename: stuart_build >>        arguments: -c ${{ parame= ters.build_file }} TOOL_CHAIN_TAG=3D${{
>> parameters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}}= -a
>> ${{ parameters.build_arch}} ${{ parameters.build_flags}}
>> -  condition: and(gt(variables.pkg_count, 0), succeeded()) >> +  condition: and(and(gt(variables.pkg_count, 0), succeeded()= ),
>> + eq(variables.unit_test_list, ''))
>> +
>> +# Build specific pkg for UnitTest
>> +- task: CmdLine@1
>> +  displayName: Build UnitTest
>> +  inputs:
>> +    filename: stuart_build
>> +    arguments: ${{ parameters.unit_test_list}} -p = $(pkgs_to_build)
>> +-c ${{ parameters.build_file }} TOOL_CHAIN_TAG=3D${{
>> +parameters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}= } -a
>> +${{ parameters.build_arch}} ${{ parameters.build_flags}}
>> +  condition: and(and(gt(variables.pkg_count, 0), succeeded()= ),
>> +not(eq(variables.unit_test_list, '')))
>>   
>>    # Run
>>    - task: CmdLine@1
>>      displayName: Run to shell
>>      inputs:
>>        filename: stuart_build >> -    arguments: -c ${{ parameters.build_file }} TOO= L_CHAIN_TAG=3D${{ parameters.tool_chain_tag}} TARGET=3D${{ parameters.build= _target}} -a ${{ parameters.build_arch}} ${{ parameters.build_flags}} ${{ p= arameters.run_flags }} --FlashOnly
>> +    arguments: -c ${{ parameters.build_file }} TOO= L_CHAIN_TAG=3D${{
>> + parameters.tool_chain_tag}} TARGET=3D${{ parameters.build_target= }} -a
>> + ${{ parameters.build_arch}} ${{ parameters.build_flags}} ${{ >> + parameters.run_flags }} --FlashOnly ${{ parameters.unit_test_lis= t}}
>>      condition: and(and(gt(variables.pkg_= count, 0), succeeded()), eq(variables['Run'], true))
>>      timeoutInMinutes: 1
>>   
>> --
>> 2.31.1.windows.1
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
>
>
>
>

--_000_BN9PR11MB54837FAF1583F07F864E085CE51C9BN9PR11MB5483namp_--