Re: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version

["duntan" <dun.tan@intel.com>]

Thanks for the comments Zhiguang. Will update the macro name in V2 patch.

Thanks,
Dun

-----Original Message-----
From: Liu, Zhiguang <zhiguang.liu@intel.com> 
Sent: Thursday, March 9, 2023 10:24 AM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>
Subject: RE: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version

Hi Dun,
Do you mean the mailbox version?
Here is from spec
	MailBox Version | Version of the mailbox. 0 for this version of the spec.
If so, I suggest the macro name should be EFI_ACPI_6_4_MULTIPROCESSOR _WAKEUP_MAILBOX _STRUCTURE_VERSION 

Thanks
Zhiguang

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, March 3, 2023 3:26 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming 
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; 
> Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup 
> Structure Version
> 
> Add define for Multiprocessor Wakeup Structure Version. The version 
> for MpWakeupStructure in Spec6.4 is 0.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 16c2faaaf2..4920939bdc 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -601,6 +601,11 @@ typedef struct {
>    UINT64    MailBoxAddress;
>  } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE;
> 
> +///
> +/// Multiprocessor Wakeup Structure Version (as defined in ACPI 6.4
> +spec.) /// #define
> +EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE_REVISION  0x0
> +
>  ///
>  /// Multiprocessor Wakeup Mailbox Structure  ///
> --
> 2.31.1.windows.1