* Re: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly
[not found] <20210916034447.771-1-xiaoqiang.zhang@intel.com>
@ 2021-09-16 3:51 ` Chiu, Chasel
2021-09-22 8:39 ` Chiu, Chasel
1 sibling, 0 replies; 3+ messages in thread
From: Chiu, Chasel @ 2021-09-16 3:51 UTC (permalink / raw)
To: Zhang, Xiaoqiang, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L, Zeng, Star
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>
> Sent: Thursday, September 16, 2021 11:45 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic
> and set it accordingly
>
> From: Zhang Xiaoqiang <xiaoqiang.zhang@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3632
>
> PcdFspModeSelection will be used to set FSP mode.
> Make PcdFspModeSelection dynamic and set it accordingly.
>
> Signed-off-by: Zhang Xiaoqiang <xiaoqiang.zhang@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> index a3b9363779..b8dac1b574 100644
> --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> @@ -82,12 +82,6 @@
> # @Prompt Skip FSP API from FSP wrapper.
>
>
> gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi|0x00000000|UINT32|0x400
> 00009
>
>
>
> - ## This PCD decides how Wrapper code utilizes FSP
>
> - # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without calling
> FSP API)
>
> - # 1: API mode (FSP Wrapper will call FSP API)
>
> - #
>
> -
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UINT8|
> 0x4000000A
>
> -
>
> ## This PCD decides how FSP is measured
>
> # 1) The BootGuard ACM may already measured the FSP component, such as
> FSPT/FSPM.
>
> # We need a flag (PCD) to indicate if there is need to do such FSP measurement
> or NOT.
>
> @@ -106,6 +100,12 @@
>
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x00000000|UI
> NT32|0x4000000B
>
>
>
> [PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
>
> + ## This PCD decides how Wrapper code utilizes FSP
>
> + # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without calling
> FSP API)
>
> + # 1: API mode (FSP Wrapper will call FSP API)
>
> + #
>
> +
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UINT8|
> 0x4000000A
>
> +
>
> #
>
> ## These are the base address of FSP-M/S
>
> #
>
> --
> 2.32.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly
[not found] <20210916034447.771-1-xiaoqiang.zhang@intel.com>
2021-09-16 3:51 ` [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly Chiu, Chasel
@ 2021-09-22 8:39 ` Chiu, Chasel
2021-09-22 8:49 ` Zhang, Xiaoqiang
1 sibling, 1 reply; 3+ messages in thread
From: Chiu, Chasel @ 2021-09-22 8:39 UTC (permalink / raw)
To: Zhang, Xiaoqiang, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L, Zeng, Star
Patch pushed: https://github.com/tianocore/edk2/commit/f334c5a41dc4702b1c767c6614025aa2f802f9a4
Thanks,
Chasel
> -----Original Message-----
> From: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>
> Sent: Thursday, September 16, 2021 11:45 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection
> dynamic and set it accordingly
>
> From: Zhang Xiaoqiang <xiaoqiang.zhang@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3632
>
> PcdFspModeSelection will be used to set FSP mode.
> Make PcdFspModeSelection dynamic and set it accordingly.
>
> Signed-off-by: Zhang Xiaoqiang <xiaoqiang.zhang@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> index a3b9363779..b8dac1b574 100644
> --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> @@ -82,12 +82,6 @@
> # @Prompt Skip FSP API from FSP wrapper.
>
>
> gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi|0x00000000|UINT32|0x4
> 0000009
>
>
>
> - ## This PCD decides how Wrapper code utilizes FSP
>
> - # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without
> calling FSP API)
>
> - # 1: API mode (FSP Wrapper will call FSP API)
>
> - #
>
> -
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN
> T8|0x4000000A
>
> -
>
> ## This PCD decides how FSP is measured
>
> # 1) The BootGuard ACM may already measured the FSP component, such
> as FSPT/FSPM.
>
> # We need a flag (PCD) to indicate if there is need to do such FSP
> measurement or NOT.
>
> @@ -106,6 +100,12 @@
>
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x0000000
> 0|UINT32|0x4000000B
>
>
>
> [PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
>
> + ## This PCD decides how Wrapper code utilizes FSP
>
> + # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without
> calling FSP API)
>
> + # 1: API mode (FSP Wrapper will call FSP API)
>
> + #
>
> +
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN
> T8|0x4000000A
>
> +
>
> #
>
> ## These are the base address of FSP-M/S
>
> #
>
> --
> 2.32.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly
2021-09-22 8:39 ` Chiu, Chasel
@ 2021-09-22 8:49 ` Zhang, Xiaoqiang
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Xiaoqiang @ 2021-09-22 8:49 UTC (permalink / raw)
To: Chiu, Chasel, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L, Zeng, Star
Thanks Chasel!
Best Regards,
Xiaoqiang Zhang
-----Original Message-----
From: Chiu, Chasel <chasel.chiu@intel.com>
Sent: Wednesday, September 22, 2021 4:39 PM
To: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly
Patch pushed: https://github.com/tianocore/edk2/commit/f334c5a41dc4702b1c767c6614025aa2f802f9a4
Thanks,
Chasel
> -----Original Message-----
> From: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>
> Sent: Thursday, September 16, 2021 11:45 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection
> dynamic and set it accordingly
>
> From: Zhang Xiaoqiang <xiaoqiang.zhang@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3632
>
> PcdFspModeSelection will be used to set FSP mode.
> Make PcdFspModeSelection dynamic and set it accordingly.
>
> Signed-off-by: Zhang Xiaoqiang <xiaoqiang.zhang@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> index a3b9363779..b8dac1b574 100644
> --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> @@ -82,12 +82,6 @@
> # @Prompt Skip FSP API from FSP wrapper.
>
>
> gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi|0x00000000|UINT32|0x4
> 0000009
>
>
>
> - ## This PCD decides how Wrapper code utilizes FSP
>
> - # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without
> calling FSP API)
>
> - # 1: API mode (FSP Wrapper will call FSP API)
>
> - #
>
> -
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN
> T8|0x4000000A
>
> -
>
> ## This PCD decides how FSP is measured
>
> # 1) The BootGuard ACM may already measured the FSP component, such
> as FSPT/FSPM.
>
> # We need a flag (PCD) to indicate if there is need to do such FSP
> measurement or NOT.
>
> @@ -106,6 +100,12 @@
>
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x0000000
> 0|UINT32|0x4000000B
>
>
>
> [PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
>
> + ## This PCD decides how Wrapper code utilizes FSP
>
> + # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without
> calling FSP API)
>
> + # 1: API mode (FSP Wrapper will call FSP API)
>
> + #
>
> +
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN
> T8|0x4000000A
>
> +
>
> #
>
> ## These are the base address of FSP-M/S
>
> #
>
> --
> 2.32.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-22 8:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210916034447.771-1-xiaoqiang.zhang@intel.com>
2021-09-16 3:51 ` [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly Chiu, Chasel
2021-09-22 8:39 ` Chiu, Chasel
2021-09-22 8:49 ` Zhang, Xiaoqiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox