From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7F74094133C for ; Fri, 27 Oct 2023 07:34:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1q+jBy+ZkICyYqYz/G9Y3xqw8pw+Z+xKtkRIKSKoIN4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698392096; v=1; b=eADPM2ncJJ0V1CmeLFZ2whLyceIbzzY2Ey0byeoolj9cSI3RUnVQbZpt7KiE5LzlWlkxaa31 vVlQ0QxSnShE1vuJPR1gldB+RaLDOZyFoAZOW5+OB290nwCPv/KEOfjaxtRAx2vV0TYhWRDgnt7 xEyhhPxp1h1ICFodsXHKnw+k= X-Received: by 127.0.0.2 with SMTP id bHAMYY7687511xrOztujDrXI; Fri, 27 Oct 2023 00:34:56 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.1913.1698392095401293527 for ; Fri, 27 Oct 2023 00:34:55 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="367071583" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="367071583" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 00:34:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="709340757" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208";a="709340757" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Oct 2023 00:34:54 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 27 Oct 2023 00:34:54 -0700 X-Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 27 Oct 2023 00:34:54 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 27 Oct 2023 00:34:54 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 27 Oct 2023 00:34:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bT8OT9ncGwsvS5grMWpCtqArN1BIdPgldcCV9Z3yjlhzv+bzDauOlsbdaQe3O4WQl5HDGHx6dplGT6L9PT/r5sxYzzOoI1xa+iCCmXg8yvEwOkENyLknE+5OsWVWG0LHJeILUwkWNnkvmvgCsqqThU61LOF6cJvnX9AksXUbq0Huri4u82PxdjL2/7AedBe0qhX4juzPjJ9bbHWF6p8md4g9kZ6MDBCuq6+VwB769/JayC36xUpRQJzBii0+Ro/y8559YVgaiVcE3XdTESjoLe+WfZrzbu3lIDUzklF4OwwhgdHlPb3WuPgHjGDYR/jCDZmp+28gVBYU03zuMPx81g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EbyV02aZHKxEg+Wa+GuSwSoy6US78qyOXivwn4oUuQg=; b=ENZ3zOiZZTeARzhb7L5ICLIX3QIkdL2J0xddaLQVJd6dJ/Nr22QJxcjgO1KUlsuXYuDgMsvX7YLFE01QiXYMNEdE9UJ2jgPUbMJzjEknmBq90o4yZ5N3OXl0BhWQ3YUi5uTflWHZ3QgbAMPmB6fXOKEwdvOBEyMyrU9CwjGX6YTkF8IXVQNEDEQKJp57TGEjd1jsGePunsNbaTnCyYuNoV+GXSQCm7l1TYMyC6eqEV5ygC+6R89f+J12S4pF8Z3KxGX/dz+AjoB7xtBpi0KQRP9Q/zNwlz7haZIJndDUsheFchywiuQo+PBlAhe01rp1K6i+tZjupexya8CqCmDJNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SA3PR11MB7626.namprd11.prod.outlook.com (2603:10b6:806:307::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31; Fri, 27 Oct 2023 07:34:52 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::83d:af7b:9ba0:64d2]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::83d:af7b:9ba0:64d2%4]) with mapi id 15.20.6933.024; Fri, 27 Oct 2023 07:34:52 +0000 From: "duntan" To: "Yao, Jiewen" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Thread-Topic: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev Thread-Index: AQHaCJiEbq0hqvyGs0+1Tmniw3oYDbBdIKuggAADw7CAABCdIIAAAmGQ Date: Fri, 27 Oct 2023 07:34:52 +0000 Message-ID: References: <20231027054300.1382-1-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SA3PR11MB7626:EE_ x-ms-office365-filtering-correlation-id: 4b88c8b2-90ee-4777-b38e-08dbd6bf351e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: LScY4rGbR4XL174d+eqaMt9E4uw45eZZy4pUgvkCTmEmLrG9NSf4R5f/UgdeWa3wAX+zwakHiOWnZazit5hfM98aYuVAz7HunUjOfAH0gFpM8+8lGEQIBj7st2wSJhhNYX04sTR6RaLdeIs+cymTFhVq1/4mbY20RXIKnSKtH0OM564IH5l2Y7G4yYKXy3iGFqzaUVHA6z+5KbzcLfnbdcRyd7EpcX0RWJ3zqAnpVRShGaQILrwkqhRzbrZKXMITYn1qNul+CEHeMUkpXWIc+oesWhikciD/PKzssR55p5G62ZWQRGluSaXr3f52VBxwmSH9BqsFYOLq7f2uTiKQR77X8zUdFN4qapcHGXyNqHV84aK/2pPEYBKAkqc6+A3Cr0qFCMZkvCnBlTTpHIJQsjZ8s02igXZIfTiYf5/yVPZirlcws1h7V+hVS7e56lh2tiIC1Xy8NNYN01oC9p3FcSDlp7RyNwFNv6W0GIrhVUHCX2wf5a5zLhrF+VgZeSruh/i6lM2v65Lk7gPGj6xpTCgySKPIGQO+MyZXOqsof7xsY1b+0nXTmwrG7myls+qNPGoK5glTOpQyinIqFcY3PAUJE3IEi8X8XpG+xswm93z4a+EC1BB7A0hw5UmY9g7q6WFFRo2nYQ1Scbp/A2TMgQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dOr/x9QHaJH5r2zXiZzeLX0XI2htYHvIGhkYqk4D4HVgetveHqTl9sDjLR6S?= =?us-ascii?Q?f0AiqtGZV9wvpg07hKN2RGEfASx8goOaylBvdsFXFqspBphMvixNMx3ZrV5e?= =?us-ascii?Q?gemBhDYzkTE0EY4LXhPjpouL3hs/+UXp7o3vY4R1b979uIq1627rxRbqS73o?= =?us-ascii?Q?lWW8d9pCRiwv3DrxJusUJfbqw2uIfp+AHAZbqAuJwMfniQ7bxiIWpoHyAHkf?= =?us-ascii?Q?hDpW7lBiDuUycNuiOtQzttkPk6sPbrhwwDWrfv7wEYgVchtYGeutTaQXtC16?= =?us-ascii?Q?jSB0R5VCXiYfGfK+5/DlEZS4PuxMh2zhPJWSUjYZLokBwP1JbcjdrRk88o0e?= =?us-ascii?Q?+a6ynsshb0rHI58mH7nVN4qolAlbNdlCiICs0LhP9Orc1cZijyrVT80OwXEZ?= =?us-ascii?Q?Cnglvm98CJLwb0h+AF6fL5bdf9c45oxuUYex+BHo0XbKEQ4/reTBnhlPu+C9?= =?us-ascii?Q?EfVLeIqj5KatFOY1+anwvmzcTJP084zFu8oVgJZ0ZtWQZVYZfraFpwHLVFHG?= =?us-ascii?Q?mNwCe5bpESbenkRFDXZxWYMBkaJkH428OVeaIfTe0KkTA8GGAkbKMTThcfSA?= =?us-ascii?Q?UtT9CI5epHolCtqum8/NE0c4X6uF+fW0DNcW/idKjZhpc9dG5PSIYQdT6ewi?= =?us-ascii?Q?s6wR+Q6lwVm+L3irWON+szmHX/E6aCDfWJCnPGGqPm+BDOdT5TPbjFOByaGT?= =?us-ascii?Q?2fkQq4caNiqSUdDVVit9lMmAmoWn2M9i3lf9ARb7GFAceQZR/10wi3ThD9xx?= =?us-ascii?Q?ON5kFz59ci7e/r1hM7NQ3k6eRNRNaxpzthVXYuVVCPD+FOXT1LxbBfO/Wi69?= =?us-ascii?Q?woDGHCAGIFykFlDipvOIlSGzFW5tBq8Z0u6DCwPgCBMofkR/XTMjbBylm2Mg?= =?us-ascii?Q?7XGlo1rpIL2NFGQZihA+/kUuDKj051GWAXFE8/zM7EHper9GUq11fgsix64M?= =?us-ascii?Q?N21y0wCa+OWz2g3R8bIjsyzKsINo6zneuDLGjyqD4iQkyv91fCQq5zyLVDrt?= =?us-ascii?Q?ukhtywTJChpF5/mLUEsQIIEtS4MHH0WyfvD4THtJZqZY7/tSft34EOBRyLny?= =?us-ascii?Q?4OctM98b8S7aQtYhDgWvG+nRIQMfY4x+FHBFkC7NVpU2qhYhkSiWYqK8giDO?= =?us-ascii?Q?NfkHsbFmKtSH50fXV6i81ekbcRcv0rX6cZT3xTqeAPP0Lk+m0vz0mLDLi9bx?= =?us-ascii?Q?lug+FRsvG1NlcMVbSWpGFs3IKTtk9RLLXiYKPY0hMtsMDUVxajBvXVrP8rIm?= =?us-ascii?Q?kxRhZGvo8KEcie2dV6uRYHSOUotUBL+NSybrZP1rleZoQOVYEVMGWbY0BwAk?= =?us-ascii?Q?1Apum6h+2Djq+0ExlTRGH5jfajz1fge6qR2pmShZTstvLF5yJc4U9+g7VatT?= =?us-ascii?Q?GLSIm8Vup/9zSS2hQiUvvonKtTSvgp9Aq09I8nwF7RDRreSP5vcKxn5E/A9i?= =?us-ascii?Q?wWcBpKP4CzVQb678lnUsweBv8IBuNgA6w4HNoRFK30rxf58F/tYN9Y6YKbTv?= =?us-ascii?Q?iezEAAxd+Bn2oc+FNgS4+iF4ejne6ptqBj5NikRscierzztub8mW6f77NupB?= =?us-ascii?Q?arTWVGM8m5RnD6Gx05A=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b88c8b2-90ee-4777-b38e-08dbd6bf351e X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2023 07:34:52.0944 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pNqmO1rsNTwswl3LVuoiXnmmS0KMqzBLq85LcaZHd7wde6lbQVuCybXXKgjWJzTEysN1r5B+4ncXwLlLOpBjWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7626 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kVWKEMQ4fZoBwWND3q55GELux7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eADPM2nc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for the suggestion.=20 I'll update the test result once I finished the test. Also the abstract mes= sage in this patch has been modified to mention that this patch should not = be merged now. Thanks, Dun -----Original Message----- From: Yao, Jiewen =20 Sent: Friday, October 27, 2023 3:07 PM To: Tan, Dun ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntri= nsic and remove BaseIoLibIntrinsicSev Here is my suggestion: 1) Please perform the test to ensure the functional part is correct. Without that, how can people know you are doing things right? 2) If you do not run any test, before you send out patch, please call out t= hat clearly. That is important to reminder the maintainer: Don't merge, even if it pass = review. Otherwise, once the review passed, the maintainer may merge it. I don't think that is the intention. Thank you Yao, Jiewen =20 > -----Original Message----- > From: Tan, Dun > Sent: Friday, October 27, 2023 2:32 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in=20 > BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev >=20 > Hi Jiewen, >=20 > Currently I'm working on the Tdx test. Since the patch set doesn't=20 > change the code logic when Tdx or SEV is enabled, so I want to send=20 > out the patch as soon as possible to see if there is any comments from co= mmunity. >=20 > I will include AMD SEV reviewer in this patch series. Thanks for remindin= g. >=20 > Thanks, > Dun >=20 > -----Original Message----- > From: Yao, Jiewen > Sent: Friday, October 27, 2023 1:49 PM > To: devel@edk2.groups.io; Tan, Dun > Subject: RE: [edk2-devel] [PATCH 0/7] Support Tdx and sev in=20 > BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev >=20 > HI > Since this impact TDX and SEV, would you please let me know what kind=20 > of test you have done? > Have you validated TDX and SEV before you submit the patch? Please=20 > describe that clearly in your patch description. >=20 > Also please include AMD SEV reviewer in this patch series. >=20 > Thank you > Yao, Jiewen >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of=20 > > duntan > > Sent: Friday, October 27, 2023 1:43 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH 0/7] Support Tdx and sev in=20 > > BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev (Don't merge becaus= e the test hasn't been completed yet.) > > > > The goal is to have single BaseIoLibIntrinsic instance that can also=20 > > used for sev and Tdx. > > In this patch set, string I/O instructions are deleted in IoRead/WriteF= ifo API. > > Then change the source file of BaseIoLibIntrinsic to also support=20 > > Tdx and sev feature. So BaseIoLibIntrinsicSev and related assembly=20 > > code can be > removed. > > > > Dun Tan (7): > > MdePkg: Create TdxLibNull.inf instance > > MdePkg: Add CcProbeLibNull and TdxLibNull implement > > MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c > > MdePkg:support Tdx and sev in BaseIoLibIntrinsic > > OvmfPkg: Add CcProbeLib in PlatformInitLib.inf > > OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files > > MdePkg:remove BaseIoLibIntrinsicSev related code > > > > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 14 ++++= ++++++--- > - > > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf | 61 > > ------------------ > > ------------------------------------------- > > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm | 131 ----= ------------- > --- > > -------------------------------------------------------------------- > > -- > > ---------------------------- > > ------------- > > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm | 293 ----= ----------- > --- > > -------------------------------------------------------------------- > > -- > > ---------------------------- > > -------------------------------------------------------------------- > > -- > > ---------------------------- > > -----------------------------------------------------------------------= -------- > > MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c | 45 > > +++++++++++++++++++++++++++++++++++++-------- > > MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h | 166 ----= ------------------ > -- > > -------------------------------------------------------------------- > > -- > > ---------------------------- > > -------------------------------------------- > > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm | 120 ----= -------------- > -- > > -------------------------------------------------------------------- > > -- > > ---------------------------- > > -- > > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm | 282 ----= ------------ > -- > > -------------------------------------------------------------------- > > -- > > ---------------------------- > > -------------------------------------------------------------------- > > -- > > ---------------------------- > > -------------------------------------------------------------------- > > MdePkg/Library/TdxLib/TdxLibNull.inf | 21 > > +++++++++++++++++++++ > > MdePkg/MdeLibs.dsc.inc | 4 +++- > > MdePkg/MdePkg.dsc | 2 +- > > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- > > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- > > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > > OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 3 ++- > > OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- > > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > > OvmfPkg/OvmfPkgX64.dsc | 2 +- > > OvmfPkg/OvmfXen.dsc | 2 +- > > 21 files changed, 83 insertions(+), 1077 deletions(-) delete mode > > 100644 MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf > > delete mode 100644=20 > > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm > > delete mode 100644 > > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm > > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h > > delete mode 100644=20 > > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm > > delete mode 100644 > > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm > > create mode 100644 MdePkg/Library/TdxLib/TdxLibNull.inf > > > > -- > > 2.31.1.windows.1 > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110198): https://edk2.groups.io/g/devel/message/110198 Mute This Topic: https://groups.io/mt/102215661/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-